Alvaro FuentesandChristophe Simonis
c18b9f44be
When we use the `|` (or) version of this rule the ORM generates two
sub-queries when checking the company. This causes sub-optimal and in
some cases really bad planning for the queries and thus PG takes hours
to complete them.
Example (formatted):
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE ("mrp_bom"."company_id" in (1))
)
)
OR ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE "mrp_bom"."company_id" IS NULL
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
If we use the single term version the generated query has only one
sub-query:
```sql
SELECT "mrp_routing_workcenter".id
FROM "mrp_routing_workcenter"
LEFT JOIN "mrp_bom" AS "mrp_routing_workcenter__bom_id"
ON "mrp_routing_workcenter"."bom_id" = "mrp_routing_workcenter__bom_id"."id"
WHERE "mrp_routing_workcenter"."workcenter_id" in (1)
AND ( ("mrp_routing_workcenter"."bom_id" in (
SELECT "mrp_bom".id
FROM "mrp_bom"
WHERE (("mrp_bom"."company_id" in (1))
OR ("mrp_bom"."company_id" IS NULL))
)
)
)
ORDER BY "mrp_routing_workcenter__bom_id"."sequence",
"mrp_routing_workcenter__bom_id"."id",
"mrp_routing_workcenter"."sequence",
"mrp_routing_workcenter"."id"
```
In this version PG is able to produce a better query plan resulting in
better execution times.
Also, the `company_id` field is required on some models, so the "= False" comparison is useless.
closes odoo/odoo#159123
X-original-commit: 1b5c41f36801fb886ec591f29dba42787d698526
Related: odoo/enterprise#59378
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Co-authored-by: Christophe Simonis <chs@odoo.com>
80 lines
3.4 KiB
XML
80 lines
3.4 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
|
|
<odoo>
|
|
|
|
<record id="group_use_lead" model="res.groups">
|
|
<field name="name">Show Lead Menu</field>
|
|
<field name="category_id" ref="base.module_category_hidden"/>
|
|
</record>
|
|
|
|
<record id="group_use_recurring_revenues" model="res.groups">
|
|
<field name="name">Show Recurring Revenues Menu</field>
|
|
<field name="category_id" ref="base.module_category_hidden"/>
|
|
</record>
|
|
|
|
<record id="contacts.res_partner_menu_config" model="ir.ui.menu">
|
|
<field name="groups_id" eval="[(4, ref('sales_team.group_sale_manager'))]"/>
|
|
</record>
|
|
|
|
<data noupdate="1">
|
|
|
|
<record id="crm_rule_personal_lead" model="ir.rule">
|
|
<field name="name">Personal Leads</field>
|
|
<field ref="model_crm_lead" name="model_id"/>
|
|
<field name="domain_force">['|',('user_id','=',user.id),('user_id','=',False)]</field>
|
|
<field name="groups" eval="[(4, ref('sales_team.group_sale_salesman'))]"/>
|
|
</record>
|
|
|
|
<record id="crm_lead_company_rule" model="ir.rule">
|
|
<field name="name">CRM Lead Multi-Company</field>
|
|
<field name="model_id" ref="model_crm_lead"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="crm_rule_all_lead" model="ir.rule">
|
|
<field name="name">All Leads</field>
|
|
<field ref="model_crm_lead" name="model_id"/>
|
|
<field name="domain_force">[(1,'=',1)]</field>
|
|
<field name="groups" eval="[(4, ref('sales_team.group_sale_salesman_all_leads'))]"/>
|
|
</record>
|
|
|
|
<record id="crm_activity_report_rule_all_activities" model="ir.rule">
|
|
<field name="name">All Activities</field>
|
|
<field ref="model_crm_activity_report" name="model_id"/>
|
|
<field name="domain_force">[(1,'=',1)]</field>
|
|
<field name="groups" eval="[(4, ref('sales_team.group_sale_salesman_all_leads'))]"/>
|
|
</record>
|
|
|
|
<record id="crm_activity_report_rule_personal_activities" model="ir.rule">
|
|
<field name="name">Personal Activities</field>
|
|
<field ref="model_crm_activity_report" name="model_id"/>
|
|
<field name="domain_force">['|',('user_id','=',user.id),('user_id','=',False)]</field>
|
|
<field name="groups" eval="[(4, ref('sales_team.group_sale_salesman'))]"/>
|
|
</record>
|
|
|
|
<record id="crm_activity_report_rule_multi_company" model="ir.rule">
|
|
<field name="name">CRM Lead Multi-Company</field>
|
|
<field name="model_id" ref="model_crm_activity_report"/>
|
|
<field name="domain_force">[('company_id', 'in', company_ids + [False])]</field>
|
|
</record>
|
|
|
|
<record id="mail_plan_rule_group_sale_manager_lead" model="ir.rule">
|
|
<field name="name">Manager can manage lead plans</field>
|
|
<field name="groups" eval="[(4, ref('sales_team.group_sale_manager'))]"/>
|
|
<field name="model_id" ref="mail.model_mail_activity_plan"/>
|
|
<field name="domain_force">[('res_model', '=', 'crm.lead')]</field>
|
|
<field name="perm_read" eval="False"/>
|
|
</record>
|
|
|
|
<record id="mail_plan_templates_rule_group_sale_manager_lead" model="ir.rule">
|
|
<field name="name">Manager can manage lead plan templates</field>
|
|
<field name="groups" eval="[(4, ref('sales_team.group_sale_manager'))]"/>
|
|
<field name="model_id" ref="mail.model_mail_activity_plan_template"/>
|
|
<field name="domain_force">[('plan_id.res_model', '=', 'crm.lead')]</field>
|
|
<field name="perm_read" eval="False"/>
|
|
</record>
|
|
|
|
</data>
|
|
|
|
</odoo>
|