Thomas Lefebvre (thle)
a64bd4ba52
Steps to reproduce:
- install sale_management module;
- go to settings of sale_management and check "Automatic invoice" parameter;
- in debug mode, we can see the template selected (do not change it);
- save the settings;
(This is just one example)
Issue:
The parameter is not added to the "ir_config_parameter" table.
Cause:
The improvement which consists in comparing the settings which one wishes to record with those which already exist in order to set the parameters which are different creates a problem.
Indeed, the current settings are retrieved directly from the model with their default value if there is one.
These are the values that will be used for the comparison.
Because of this, when we want to save a parameter which is set to its default value (on first save), the logic will not notice a difference.
Therefore, the parameter will not be saved in the "ir_config_parameter" table.
Consequence:
In the code, when we wanted to look up the value of a parameter, if it is not saved, we use its default value instead of saving it with its default value.
Example:
```
field_example = fields.Integer(string='Example', default=1000, config_parameter='model.field_example')
value_field_example = params.get_param('model.field_example', default=1000)
```
The default value is repeated.
Solution:
To know whether or not we add a new parameter in the "ir_config_parameter" table, we must look at what already exists in the table and not in the settings defined in the model.
opw-3057306
closes odoo/odoo#106188
X-original-commit: d881dfaaa163b409a94494e35afa2cbda7cf2aa2
Related: odoo/enterprise#34258
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
3.3 KiB
3.3 KiB
| 1 | id | name | model_id:id | group_id:id | perm_read | perm_write | perm_create | perm_unlink |
|---|---|---|---|---|---|---|---|---|
| 2 | access_test_testing_utilities_a | access_test_testing_utilities_a | model_test_testing_utilities_a | 1 | 0 | 0 | 0 | |
| 3 | access_test_testing_utilities_readonly | access_test_testing_utilities_readonly | model_test_testing_utilities_readonly | 1 | 0 | 0 | 0 | |
| 4 | access_test_testing_utilities_c | access_test_testing_utilities_c | model_test_testing_utilities_c | 1 | 0 | 0 | 0 | |
| 5 | access_test_testing_utilities_d | access_test_testing_utilities_d | model_test_testing_utilities_d | 1 | 0 | 0 | 0 | |
| 6 | access_test_testing_utilities_e | access_test_testing_utilities_e | model_test_testing_utilities_e | 1 | 0 | 0 | 0 | |
| 7 | access_test_testing_utilities_f | access_test_testing_utilities_f | model_test_testing_utilities_f | 1 | 0 | 0 | 0 | |
| 8 | access_test_testing_utilities_g | access_test_testing_utilities_g | model_test_testing_utilities_g | 1 | 0 | 0 | 0 | |
| 9 | access_test_testing_utilities_m2o | access_test_testing_utilities_m2o | model_test_testing_utilities_m2o | 1 | 0 | 0 | 0 | |
| 10 | access_test_testing_utilities_default | access_test_testing_utilities_default | model_test_testing_utilities_default | 1 | 0 | 0 | 0 | |
| 11 | access_test_testing_utilities_parent | access_test_testing_utilities_parent | model_test_testing_utilities_parent | 1 | 0 | 0 | 0 | |
| 12 | access_test_testing_utilities_sub | access_test_testing_utilities_sub | model_test_testing_utilities_sub | 1 | 0 | 0 | 0 | |
| 13 | access_test_testing_utilities_sub2 | access_test_testing_utilities_sub2 | model_test_testing_utilities_sub2 | 1 | 0 | 0 | 0 | |
| 14 | access_test_testing_utilities_sub3 | access_test_testing_utilities_sub3 | model_test_testing_utilities_sub3 | 1 | 0 | 0 | 0 | |
| 15 | access_test_testing_utilities_recursive | access_test_testing_utilities_recursive | model_test_testing_utilities_recursive | 1 | 0 | 0 | 0 | |
| 16 | access_test_testing_utilities_onchange_parent | access_test_testing_utilities_onchange_parent | model_test_testing_utilities_onchange_parent | 1 | 0 | 0 | 0 | |
| 17 | access_test_testing_utilities_onchange_line | access_test_testing_utilities_onchange_line | model_test_testing_utilities_onchange_line | 1 | 0 | 0 | 0 | |
| 18 | access_model_test_testing_utilities_onchange_count | access_model_test_testing_utilities_onchange_count | model_test_testing_utilities_onchange_count | 1 | 1 | 1 | 1 | |
| 19 | access_test_testing_utilities_onchange_count_sub | access_test_testing_utilities_onchange_count_sub | model_test_testing_utilities_onchange_count_sub | 1 | 1 | 1 | 1 | |
| 20 | access_o2m_readonly_subfield_parent | access_o2m_readonly_subfield_parent | model_o2m_readonly_subfield_parent | 1 | 1 | 1 | 1 | |
| 21 | access_o2m_readonly_subfield_child | access_o2m_readonly_subfield_child | model_o2m_readonly_subfield_child | 1 | 1 | 1 | 1 | |
| 22 | access_test_testing_utilities_req_bool | access_test_testing_utilities_req_bool | model_test_testing_utilities_req_bool | 1 | 0 | 0 | 0 | |
| 23 | access_o2m_changes_parent | access_o2m_changes_parent | model_o2m_changes_parent | base.group_user | 1 | 0 | 0 | 0 |
| 24 | access_o2m_changes_children | access_o2m_changes_children | model_o2m_changes_children | base.group_user | 1 | 0 | 0 | 0 |
| 25 | access_o2m_changes_children_lines | access_o2m_changes_children_lines | model_o2m_changes_children_lines | base.group_user | 1 | 0 | 0 | 0 |
| 26 | access_ttu_product | access_ttu_product | model_ttu_product | base.group_user | 1 | 0 | 0 | 0 |
| 27 | access_ttu_root | access_ttu_root | model_ttu_root | base.group_user | 1 | 0 | 0 | 0 |
| 28 | access_ttu_child | access_ttu_child | model_ttu_child | base.group_user | 1 | 0 | 0 | 0 |
| 29 | access_ttu_grandchild | access_ttu_grandchild | model_ttu_grandchild | base.group_user | 1 | 0 | 0 | 0 |
| 30 | access_res_config_test | access_res_config_test | test_testing_utilities.model_res_config_test | base.group_user | 1 | 0 | 0 | 0 |