Commit Graph
6 Commits
Author SHA1 Message Date
Atul Patel 9f649f3e40 [FIX] pad: Use a post instead of a get on the request
The old code used Request(data=)]( https://github.com/odoo-dev/odoo/blob/723b083cf5e51beec166059350466e5504db46c9/addons/pad/py_etherpad/__init__.py#L39)

Which however means it did a POST:

> the HTTP request will be a POST instead of a GET when the data parameter is provided

yet the code currently uses `requests.get`, so [it looks very much like a mistake when converting from urllib to requests](https://github.com/odoo-dev/odoo/commit/01e35141479b8dfc4a390518f89fc52e7cec5396#diff-3303eb022ac36e1ef7258c28f24f6de6).
2017-07-17 13:18:37 +02:00
Xavier Morel 01e3514147 [FIX] P3: urllib, urllib2 and urlparse
In Python 3, all of these were "consolidated" under urllib(.request,
.parse, .errors) which is inconvenient.

Since we already have hard dependencies on requests and
werkzeug(.urls, which is a backport of Python 3's unicode-aware
urllib.parse) migrate *everything* to that.

A sticking point is urllib2.URLError, those were (mostly) replaced by
the slightly more general IOError which URLError extends.
2017-05-15 12:26:30 +02:00
Olivier Dony 723b083cf5 [FIX] pad: partial revert of global replace of urllib.urlencode() by werkzeug's version, this one was useful to handle sequences
The API of werkzeug's version does not accept a boolean
as the second argument, so this crashes.

bzr revid: odo@openerp.com-20140218182643-a13mvcmsav195dfx
2014-02-18 19:26:43 +01:00
Denis Ledoux 0306adbfe3 [FIX] *: using werkzeug.url_encode instead of urllib.urlencode because urliblib.encode does not accept unicode
bzr revid: dle@openerp.com-20140129121316-b5f5e4r6fz9l80kq
2014-01-29 13:13:16 +01:00
Martin Trigaux c8c298c83c [IMP] clean permissions and shebang in files
bzr revid: mat@openerp.com-20130514103113-8idhvhokt0e8jzea
2013-05-14 12:31:13 +02:00
Christophe Matthieu e57ae347a0 [IMP] pad : message insert into pad
bzr revid: chm@openerp.com-20120920105713-meckyb4pnlxbapzk
2012-09-20 12:57:13 +02:00