Commit Graph
4 Commits
Author SHA1 Message Date
Vincent Schippefilt 05fc9a6733 [IMP] *: use _read_group instead of read_group
This commit modifies most of the usages of read_group and uses
_read_group instead. _read_group doesn't join automatically on the
many2one fields when no order_by is specified, making it more performant
when the "name" of the many2one is not relevant, which is the case for
most back-end cases

closes odoo/odoo#84908

Task-id: 2479334
Related: odoo/enterprise#24877
Signed-off-by: Raphael Collet <rco@odoo.com>
2022-03-02 17:10:48 +00:00
Thibault Delavallée d1edc9e6a7 [REF] crm: correctly name lost_reason field on lead
As this is a many2one, it should end with an ``_id`` suffix. Otherwise we
may think this is a char field, which was probably the case at one point.

Task-2671709

Part-of: odoo/odoo#78648
2021-11-23 09:39:51 +00:00
Dharmraj Jhala 6f95973484 [IMP] crm: better access leads linked to a lost reason
This commit improves overall usability for lost reason wizard in CRM with
following improvements

  * prevent deletion of reason if any lead is still referencing it;
  * remove obsolete filter 'Include archived' for lost reason;
  * add new stat button for lost reason, to see the leads that were lost
    due to that particular reason;
  * add margin on the reason title to avoid ribbon glitch;

TaskID 2176323
PR #43541

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-01-27 09:57:03 +00:00
Thibault Delavallée 9219944a5a [REF] crm: quickly reorganize crm_lead file
In this commit we perform some small code move in order to better understand
the huge crm_lead.py file. Notably

  * add some code sections headers (actions, PLS, opp/leads merge);
  * move crm.lead.tag and crm.lost.reason in their own file;
  * reorganize fields by main category because it is a mess;
  * remove some unnecessary help messages on fields;
  * merge two _auto_init methods definitions;

No functional change occur with this commit as it contains only some code
move.

It prepares some further technical cleaning in CRM application, notably
onchange -> compute move.

LINKS

Related to Task ID 2092799 (not really spec, spotted while working on it)
PR odoo/odoo#42015

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-12-17 12:50:46 +00:00