Commit Graph
126133 Commits
Author SHA1 Message Date
Yannick Tivisse 8fa8ffdf27 [FIX] hr: Add a multi company ir.rule on hr.employee model 2019-02-18 15:28:15 +00:00
Yannick Tivisse 980cbb2516 [FIX] hr_payroll: Refine access to benefit types for officers/managers 2019-02-18 15:28:15 +00:00
Yannick Tivisse 4cb33cee16 [FIX] hr_payroll: Allow Leaves Officers to validate/refuse leaves
Currently payroll officers access rights are required to validate/refuse leaves.

Fix this undesired behavior.
2019-02-18 15:28:15 +00:00
Lucas Lefèvre 40436f5f67 [FIX] hr_payroll: use js framework datetime_to_str 2019-02-18 15:28:15 +00:00
Lucas Lefèvre c02222085b [FIX] hr_payroll: clean datetime parsing and formatting
Use ORM Datetime and Date methods instead of `strftime`
and `strptime`.
2019-02-18 15:28:15 +00:00
Yannick Tivisse 624a1fc56b [FIX] resource: Make get_leave_days_data private 2019-02-18 15:28:15 +00:00
Yannick Tivisse 9cbc68b8ab [FIX] resource: Make get_work_days_data private 2019-02-18 15:28:15 +00:00
Yannick Tivisse 8a9c9bb10f [FIX] hr_payroll: Remove duplicated import 2019-02-18 15:28:15 +00:00
Yannick Tivisse 8b2cd25878 [FIX] hr_payroll: Use ref only once in a for loop 2019-02-18 15:28:15 +00:00
Yannick Tivisse 219c19f5f7 [FIX] hr_payroll: Batch some calls to create and methods 2019-02-18 15:28:15 +00:00
Yannick Tivisse 507e098d5a [FIX] hr_payroll: Unlink all benefits at once
unlink() invalidates the whole cache, it's an anti-pattern
to use it in a loop! Accumulate the records to unlink and
do it at the very end.
2019-02-18 15:28:15 +00:00
Yannick Tivisse cffe008351 [FIX] hr_payroll: Make method api.model 2019-02-18 15:28:15 +00:00
Yannick Tivisse 1f39611fcc [FIX] hr_payroll: Generate all benefits at once without SQL
It's easier, shorter, more logical to verify that a conflict will happen,
rather than combining multiple hacks to hide errors.

On the other hand, the method will now be called only once when generating
benefits on leaves/attendances for several employees
2019-02-18 15:28:15 +00:00
Yannick Tivisse 4ea60907f1 [FIX] hr_payroll: Fix linting issues 2019-02-18 15:28:15 +00:00
Yannick Tivisse 2a4b883b17 [FIX] hr_payroll: Make some methods private 2019-02-18 15:28:15 +00:00
Yannick Tivisse 3af4e24721 [FIX] hr_payroll: Replace constraints methods by sql constraints
It's a one-liner instead of 6 lines of Python with extra ORM overhead
2019-02-18 15:28:15 +00:00
Julien (juc) Castiaux 6b7f1ef091 [FIX] digest: remove unnecessary context
The `company` context is explicitly set by `action_send` while the
template previewer doesn't set it. This inconsistency leads to
error when previewing the digest template.

opw-1939007

closes odoo/odoo#31195
2019-02-18 14:42:32 +00:00
Alexandre Kühn e3714eeea6 [FIX] im_livechat: instantly receive messages from new livechat
Before this commit, when new messages were posted in a new
livechat, the operator received them after a delay. This
may take up to a minute before receiving the notification.

This behaviour was causing a bigger issue: those notifications
may never be received by the operator. This case happened when
the operator was receiving more recent notifications while
notifications from new livechats were pending.

The delay was caused by the operator not yet subscribed to
notifications on the newly created livechat. It is only on
the next poll of longpolling that the subscription occurred,
then followed by dispatching the notifications to the operator.

This commit fixes the issue by dispatching new messages of new
livechats directly to the operator. This is done by enforcing
the operator to make another polling when a new livechat is created,
so that he is always subscribed to those livechats. As a result,
new messages are received instantaneously.

opw-1933951

closes odoo/odoo#31199
2019-02-18 13:16:04 +00:00
Christophe Matthieu 6739a5c1d4 [FIX] website: don't not edit not editable contents or branded hr, br... 2019-02-18 09:45:38 +00:00
mgh-odoo 9b169f8805 [IMP] mail : autofocus items in autocomplete inputs
With this commit, when using autocomplete inputs in Discuss
or chat windows, the 1st item is automatically auto-focused.

Example of autocomplete inputs:
- Discuss: "Add or join a channel" in sidebar
- Chat window: when clicking on "New Message" from systray
    messaging menu.

As a result, we can use keyboard keys to navigate and select
the desired item.

Task-ID 1894447

closes odoo/odoo#30207
2019-02-19 09:56:26 +00:00
Vandan Shah 3cbae36557 [IMP] *: Add progress bar on kanban views based on activities
Purpose
=======

If the activities are available on a model (i.e. inherits mail.activity.mixin),
add a progress bar based on the activities if nothing is defined yet.

closes odoo/odoo#24777
2019-02-19 11:01:40 +00:00
Vandan Shah a44e4ac6c4 [IMP] web: improve kanban tooltip
1) Remove the total record tooltip from kanban group.
2) Remove progressbar help from kanban view.
3) Improvements in testcase since we have removed total record tooltip.
2019-02-19 11:01:40 +00:00
Nicolas Lempereur 5062a26d18 [FIX] website_crm_partner_assign: deadline->expected closing
In the backend interface, lead/opportunity date_deadline is named
"Expected Closing" or sometime "Expected Closing Date" but on the
frontend it was named "Deadline" for opportunity.

opw-1941273
closes #31244
2019-02-19 12:19:31 +00:00
Christophe Matthieu 859ce50903 [FIX] web_editor: clean or hide image handle data according to image size
closes odoo/odoo#31183
2019-02-19 09:37:25 +00:00
Christophe Matthieu 41b470456c [FIX] website: avoid double start edition
issue: 'enable_editor' and click on 'edit' before loading edition, or
double click on 'edit'
2019-02-19 08:43:51 +00:00
Christophe Matthieu 9fff365d4a [FIX] website: hide edit menu when the user click on save an wait reload 2019-02-19 08:43:51 +00:00
Christophe Matthieu e3ad11d972 [FIX] website: remove 'enable_editor' from the URL before edition 2019-02-19 08:43:51 +00:00
Christophe Matthieu 832357f0b7 [FIX] web_editor: use website color for popover edition 2019-02-19 08:43:51 +00:00
Christophe Matthieu 60c013749e [FIX] web_editor: speeder edition of field char on website_blog
Before this fix, the customize button was updated with each character,
which slowed down the fast insertion of characters and used resources
unnecessarily.
2019-02-19 08:43:51 +00:00
Christophe Matthieu b7818fe036 [FIX] website: don't not edit not editable contents or branded hr, br... 2019-02-18 09:45:38 +00:00
mgh-odoo e096dc9b66 [IMP] mail : autofocus items in autocomplete inputs
With this commit, when using autocomplete inputs in Discuss
or chat windows, the 1st item is automatically auto-focused.

Example of autocomplete inputs:
- Discuss: "Add or join a channel" in sidebar
- Chat window: when clicking on "New Message" from systray
    messaging menu.

As a result, we can use keyboard keys to navigate and select
the desired item.

Task-ID 1894447

closes odoo/odoo#30207
2019-02-19 09:56:26 +00:00
qmo-odoo c564ae6c87 [IMP] website_slides: Add elearning feature to slides
Purpose of this commit is to introduce a new way of displaying and managing
slides in eLearning module. Its purpose is to give a better experience to
users when going through a course. Notably a fullscreen mode allows to take
lessons one by one without going out of the elearning display. Integration
of all slide types eases taking the course step by step.

Quiz are introduced in this commit. Those are an addition to slides with
some question / answers (multiple choice). It allows customer to gain karma
and improves gamification. Certifications are still done using the survey
application. Quiz targets only small tests at the end of a given slide.

A new widget is added to display and control slide display in fullscreen
mode. Old display is still available for documentation channels or when
going out of fullscreen mode, to see details on comments / review / statistics
and have access to share options.

This commit is linked to task ID 1902304 and PR #29876. It closes the main
work on refactoring website slides into eLearning, with other tasks already
merged in current community [1][2][3][4][5].

[1] Task ID 1940360 landed at b2149bc7a2: certification inclusion
[2] Task ID 1936153 landed at 6c6179e57c: homepage inclusion
[3] Task ID 1937160 landed at 8b7605c9e5: selling courses
[4] Task ID 1922159 and 1940516 landed at 5fa651cb01 and 6a64c3ce82:
    new user profile and gamification of slides / forum
[5] Task ID 1938643 landed at 77b5673a0d: upload channel/slide
2019-02-19 13:11:15 +00:00
Vandan Shah 7a80ebe35e [IMP] *: Add progress bar on kanban views based on activities
Purpose
=======

If the activities are available on a model (i.e. inherits mail.activity.mixin),
add a progress bar based on the activities if nothing is defined yet.

closes odoo/odoo#24777
2019-02-19 11:01:40 +00:00
Vandan Shah d09ecc8b18 [IMP] web: improve kanban tooltip
1) Remove the total record tooltip from kanban group.
2) Remove progressbar help from kanban view.
3) Improvements in testcase since we have removed total record tooltip.
2019-02-19 11:01:40 +00:00
Antoine Guenet f5c269db12 [FIX] web_editor: properly position image handle in product configurator
The image handle (grey overlay over the image) was not properly
repositioning on scroll in the product configurator (a side effect of
not having a popover).

closes odoo/odoo#31226
2019-02-19 09:06:49 +00:00
Antoine Guenet d9a77bd846 [FIX] web_editor: stop wrapping text in p on delete in anchor
This notably fixes a bug with the accordion snippet (website) where
selecting a title and typing seemed to add a newline.

closes odoo/odoo#31222
2019-02-19 09:46:28 +00:00
David Monjoie addeae990f [IMP] base,doc: add scales attribute to gantt view
closes odoo/odoo#31210
2019-02-19 08:28:29 +00:00
David Monjoie 7c48315d7a [IMP] base,doc: add offset attribute
Depending on the scale, the number of units to add to today to
compute the default period. Examples: An offset of +1 in default_scale
week will open the gantt view for next week, and an offset of -2 in
default_scale month will open the gantt view of 2 months ago.
2019-02-19 08:27:53 +00:00
Antoine Guenet 1f4b606ad0 [FIX] web_editor: remove invisible space on insert media where forbidden
The web editor inserts zero-width characters (unicode 200B) around media
when inserting them in the DOM so as to be able to edit before and after
said media (contenteditable caveat). It should however not do so in fake
not-editable nodes - such as the navbar - given that we do not expect to
edit in them but only to replace the media. This ensures that behaviour.

closes odoo/odoo#31200
2019-02-18 13:06:17 +00:00
Christophe Monniez fec86404e7 [IMP] tests: replace browser_js success and failure strings
When evaluating js tests using the browser_js method, they are
considered a success when 'ok' is found in the console log and a failure
if 'error' is found instead.

This is not very robust and recently failed with this commit : 7410de111f
It adds a filter named 'Error' in a view, when the 'click_all' test
clicks on this filter, a message with the name of the filter is written
in the console, wrongly leading to a test failure.

With this commit, the browser_js method expects a log message in the
browser console with the explicit text "test successful".
On the other hand, any error in the console log will lead to a test
failure but a test can be forced to fail with the explicit error message
in the browser console "test failed".

As a bonus, the python logger should now also log browser js trace messages.

closes odoo/odoo#31158
2019-02-19 08:06:07 +00:00
Robot Odoo 83e6faf9a2 [FIX] website_slides: hide publish widget if user cannot publish
Purpose
=======

The "publish/unpublish" widget is always shown on slide.channel/slide.slide for
a website_publisher user even if he's not allowed to manage the publishing of
the channel (see slide.channel.can_publish field).

This commit will hide the widget on both the slide.channel and the slide.slide frontend
pages if the user doesn't have the right to publish/unpublish. A generic solution
implemented directly in the publish mixin has been chosen to ease understanding
and allow easy reuse in other applications.

Commit linked to task ID 1902304 (main elearning task).

closes odoo/odoo#31187
2019-02-19 10:20:00 +01:00
Robot Odoo d56402a547 [FIX] doc: build errors & some warnings
closes odoo/odoo#30835
2019-02-19 08:09:28 +01:00
Aurélien Warnon 3c88e75c86 [FIX] website_slides: handle publishing rights of channel/slide
Purpose
=======

Handle publishing of the slide.slide/slide.channel accordingly to the new
'can_publish' field in the website published mixin.
2019-02-19 07:08:03 +00:00
Aurélien Warnon 916968058d [IMP] website: add a field to handle publish rights for publish mixin
Purpose
=======

The "publish/unpublish" widget is always shown on the frontend as long as the user
is a website_publisher and the object has a "website_published" field.

In some modules (namely website_slides) we need to handle a more refined level of access.

This commit adds a "can_publish" computed field that can be overridden to add some additional
access rules to the object and hide the widget if the user doesn't have the rights to
publish/unpublish.
2019-02-19 07:07:02 +00:00
Yannick Tivisse 7cd45840fc [IMP] hr_payroll: Set structure on generated payslips from benefits
closes odoo/odoo#30432
2019-02-18 16:16:20 +00:00
RomainLibert 1e12ce3430 [IMP] hr_payroll: add multi company rules on benefit and payslip run
Task 1913733
2019-02-18 16:16:20 +00:00
RomainLibert afde04dd54 [IMP] point_of_sale: make pos_session multi company aware
When creating a pos session we try to link the session to
the first cash journal we find.

The problem is that we cannot link a journal comming from another
company this is strictly forbidden by a constraint.

This is why we should make sure that we search only for journals in the
same company as the config.

Task 1913733
2019-02-18 16:16:20 +00:00
Yannick Tivisse ef048c24de [IMP] l10n_in_hr_payroll: Remove useless reports
They don't show anything that is of interest.

Task 1913733
2019-02-18 16:16:20 +00:00
qsm-odoo 9d5fa81ba3 [REF] website_theme_install: update theme install screen design
task-1907934

closes odoo/odoo#31114
2019-02-18 09:50:03 +00:00
Robot Odoo 6a64c3ce82 [MERGE][IMP] website{_profile, _slide,_forum,*} : improve slides integration in user profile and add karma generation
Purpose of the merge is to continue the work done from PR #30988.
This completes the website profile page,  gamifies the under development eLearning [1][2]
and continues integration between eLearning and the forum.

This merge contains notably:
- Complete profile page with course progression detail and eLearning certifications
- Apply Karma gains on various action on the eLearning
- Allow to set the communication type on eLearning course at creation (frontend)
- Redesign website users page

See sub commits for more details.

Merge linked to task ID 1922159 (elearning gamification / website_profile)
and task ID 1940516 (forum comments) PR #31097.

[1] see task ID 1902304 (main eLearning task) PR #29876.
[2] see task ID 1936153 (new homepage for slides) PR #30770.

closes odoo/odoo#31109
2019-02-18 17:15:58 +01:00