Commit Graph
126133 Commits
Author SHA1 Message Date
qsm-odoo 217ba16809 [IMP] website_blog, *: improve social links visual
* website

Use real social colors which makes the blogs look more modern.
Introduce the colors for github, instagram and youtube.

Part of https://github.com/odoo/odoo/pull/31749
task-1948882
2019-03-29 16:37:37 +00:00
Andrea Ulliana 1967ea89e6 [IMP] website_blog: review blog layouts
Review our blog layouts to follow the design we added for forum and
event (usings cards for records but not for menu + colored cards for
the right column). Also fixes some DOM/Bootstrap structures.

Part of https://github.com/odoo/odoo/pull/31749
task-1948882
2019-03-29 16:37:37 +00:00
Andrea Ullianaandqsm-odoo ce1da231b9 [IMP] website_sale, *: add products searchbar snippet
* website

When the e-commerce is installed, you can now add a new snippet that can
be dropped anywhere: a search bar to search for products with an
autocomplete feature.
That snippet is also used as default "/shop" search bar. Finally,
you have the possibility to customize the snippet via snippet options.

task-1866973

closes odoo/odoo#30366

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>


Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-03-29 16:33:15 +00:00
Nans Lefebvre c26eb41f9e [FIX] *: put all mail.message.subtype as noupdate
The mail.message.subtype model contains a field internal,
which decides if the messages are visible to external users or not.
Such a value should not be overriden at module update,
so all subtypes should be in noupdate.

opw 1946043

closes odoo/odoo#32214

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-03-28 13:40:41 +00:00
svs-odoo 63d2a1675b [IMP] stock_account: cost field editable on FIFO + AUTO
Before this commit, when 'Inventory Valuation' was on 'Automated' and
'Costing Method' was on FIFO, the product cost field wasn't editable
anymore.
Now, it still editable in this configuration (other configuration aren't
affected).

Task #1937164

closes odoo/odoo#31145

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-03-29 14:54:45 +00:00
Yannick Tivisse 62c9dedafd [IMP] base: Remove useless ACL rules
Now that portal users don't have access to the backend, it doesn't make
sense to give the read access on attachments, as this is the role of
the specific controllers to provide this access according to the business
logic.

For the record, these rules have been introduced at:
https://github.com/odoo/odoo/commit/61065b6d04248aa496765e1035c4c90cbdc38de7
https://github.com/odoo/odoo/commit/f3fa266d115ac9d4723164af10f8dee40821b290

closes odoo/odoo#32134

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-03-29 12:00:25 +00:00
Robot Odoo 97315af946 [MERGE][IMP] (website)_sale_(product_configurator): improve p. configurator & exclusions
Task #1891970
Original p. configurator commit d3530eb

Main purpose
------------------

The main purpose of this merge is to improve the product configurator usability by removing the "Configure a product" link to make it dynamic based on the selected product.
It also cleans the (website_)sale modules by moving the configurator specific code into its own modules: (website)_sale_product_configurator.

Detailed changes
-----------------------

Here is a more detailed list of the things done in this merge:

- Moved the product_configurator into its own module now that we have a specific option for it.
  The option only enables the p. configurator in the SO form.
  The e-commerce should always allow customer to configure their products, even if the option is not
  checked.

  This allows moving some of the code specific to the p. configurator into its own module.
  However, a lot of the code has to remain in "sale" module since the e-commerce does not require the
  option checked and needs the "configure product" feature in the shop by default.

  (This is why the fields "product_custom_attribute_value_ids" and
  "product_no_variant_attribute_value_ids" are still in the "sale" module)

- Since we now have the product_configurator in its own module, we can add a bridge module for the
  website_sale to override the necessary controller routes in a cleaner way.
  This commit adds the bridge module and move files and code around.

- The sale order lines will now always be editable directly from the tree view.
  Installing some modules would force a popup form, which leads to a significant drop
  in productivity when filling in multiple sale order lines.

- This commit will add an event configurator widget that will open a wizard when the selected product is
  'event_ok'.
  The widget will allow configuring the 'event_id' and the 'event_ticket_id' fields so that they can be safely
  removed from the sale order line tree view.
  The user can also edit the event configuration by using a button next to the product_id dropdown field
  if the product is configured as 'event_ok'.

- The p. configurator now comes with a widget that is "o2m" like in the SO lines view.
  The widget is only used on the added "product_template_id" field on the SO line.

  This widget controls the opening of the configuration window and removes the need of a "Configure a
  product" button.
  The "SectionAndNoteListRenderer" is now cleaned from p. configurator specific code.

  The widget is also responsible for handling the configuration provided by the p. configurator form
  and applying it on the SO line with a 'field_changed' event that updates all the necessary fields.

- Added support for 'MULTI' and 'DELETE_ALL' operations on X2Many fields in basic_model.js
  - 'MULTI' allows to batch multiple operations at once
  - 'DELETE_ALL' behaves like 'DELETE' with all the current data of the field

- A message will be displayed when hovering a disabled attribute value's input to explain why it's
  disabled.
  e.g: Not available with Color: Black

  This works for both exclusions within the product and exclusions from a reference product.

- The exclusions will work in both sides, if "black" excludes "metal", "metal" will also exclude "black".

- The "Customizable Desk" and "Conference chair" products now have some stock in the initial inventory
  to avoid the stock warning when adding these products in a SO through the product configurator.

- The _name_search of product.template fallbacks by default on product.product
  In case there are no product.products yet (dynamic product variants configuration), we need to
  include the base product.template _name_search in the results

- The "ProductConfiguratorMixin" was named like that for historical reasons.
  It had no direct link to the product configurator anymore since the latter was moved in its own module.
  The ProductConfiguratorMixin was renamed to VariantMixin to avoid confusion.
  This commit just move files around, there should not be any functional change.

Spec
=======
- remove "configure a product" from sale order lines
  When the product configurator is active, replace the product_product_id by a product_template_id
  in the sale order line. When we select a template without variants, it sets the variant automatically,
  but when we select a product template having variants, it opens the configurator dialog.
- add a widget to modify the product configuration in the sale order line (next to product template field)
- UX improvements:
    - Invert image and configuration in the main screen
    - If the product doesn't have an image, hide it instead of showing the placeholder (only for first
      screen?)
- new independent option in sales settings to activate product configurator.
  (same in e-commerce)
- demo data: Change demo data to set Customizable Desk & Conference Chair as make to order
- If only one attribute value that is Custom, don't display radio, selection or even color box
- show exclusions in both sides in the configurator
  -> SOLUTION: auto populate other way around (Black not for XL -> XL not for Black)
- don't allow to select an excluded value in the configurator (frustrating).
  Replace with an uncomaptibility message on hover (e.g. Not available for Color: Black, Size: XL)
- apply the same mechanism for optional & suggested products: e.g. Not available for Customizable
  Table (Color: Black)
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#28310

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-03-29 14:23:17 +01:00
Olivier Colson 5091bc1df7 [FIX] account: avoid traceback when using the 'with tax' filter of reconciliation models
Field tax_id has been replaced by tax_ids by commit https://github.com/odoo/odoo/commit/4d7f0526122084e7be08212bd5ef9935603605ff . The filter had not been adapted properly and raised a traceback, as tax_id did not exist anymore.

closes odoo/odoo#32231

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-03-29 08:53:27 +00:00
Aurélien Warnon 7c4b99fec2 [IMP] (w_)sale_product_configurator: improve single custom value layout
Purpose
=======

When a single custom value is configured in an attribute, use the 'value' label
as a placeholder to have a full width input.
2019-03-28 14:55:02 +00:00
Aurélien Warnon d59830d864 [IMP] *_product_configurator: improve optional products naming
Task #1891970

Purpose
=======

The name of the optional products displayed in the modal now change dynamically based on the selected
variants configuration.
You do not have to wait until the product is in the cart to see the full name anymore.

Ex: Conference Chair -> Conference Chair (Steel)
2019-03-28 14:55:01 +00:00
Aurélien Warnon eff1f45767 [REF] *_product_configurator,website_sale: remove deprecated methods/params
Task #1891970

Purpose
=======

This commit cleans up the deprecated methods introduced during the product configurator
post v12 fix (ref: f8dad1bb4b).
2019-03-28 14:55:01 +00:00
Aurélien Warnon ab621e524f [REF] (website_)sale,*_product_configurator: rename p_c_mixin to variant_mixin
Task #1891970

Purpose
=======

The "ProductConfiguratorMixin" was named like that for historical reasons.
It had no direct link to the product configurator anymore since the latter was moved in its own module.

The ProductConfiguratorMixin was renamed to VariantMixin to avoid confusion.
This commit just move files around, there should not be any functional change.
2019-03-28 14:55:00 +00:00
Aurélien Warnon 220f5ae53f [IMP] sale_product_configurator: improve p. configurator
Task #1891970
Original p. configurator commit d3530eb

Purpose
=======
- The p. configurator now comes with a widget that is "o2m" like in the SO lines view.
  The widget is only used on the added "product_template_id" field on the SO line.

  This widget controls the opening of the configuration window and removes the need of a "Configure a product" button.
  The "SectionAndNoteListRenderer" is now cleaned from p. configurator specific code.

  The widget is also responsible for handling the configuration provided by the p. configurator form
  and applying it on the SO line with a 'field_changed' event that updates all the necessary fields.

- Added support for 'MULTI' and 'DELETE_ALL' operations on X2Many fields in basic_model.js
  - 'MULTI' allows to batch multiple operations at once
  - 'DELETE_ALL' behaves like 'DELETE' with all the current data of the field

Spec
=======
- remove "configure a product" from sale order lines
  When the product configurator is active, replace the product_product_id by a product_template_id
  in the sale order line. When we select a template without variants, it sets the variant automatically,
  but when we select a product template having variants, it opens the configurator dialog.
- add a widget to modify the product configuration in the sale order line (next to product template field)
- UX improvements:
    - Invert image and configuration in the main screen
    - If the product doesn't have an image, hide it instead of showing the placeholder (only for first screen?)
- new independent option in sales settings to activate product configurator.
  (same in e-commerce)
- demo data: Change demo data to set Customizable Desk & Conference Chair as make to order
- If only one attribute value that is Custom, don't display radio, selection or even color box
2019-03-28 14:55:00 +00:00
svs-odoo 3c3b9c0696 [FIX] stock: don't allow putaway for services
Before this commit, you could specify putaway rules for service type
products, but as putaway is useless for services, we don't want that.

Task #1961021

closes odoo/odoo#32199

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-03-28 09:48:31 +00:00
wan 0f8be0d75c [IMP] base: warn when duplicating VAT number
Task 1942984
Add a warning to alert for partner duplicates based on VAT number
When we create a new partner with an existing vat number, on change from vat number -->  trigger a warning,

closes odoo/odoo#31597

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-03-28 15:25:41 +00:00
Robot Odoo 460e96c887 [IMP] mail, test_mail, *: add new email.cc.mixin on main models
*: crm, project, maintenance, hr_recruitment

When a record is created from an email, cc can be lost. This commit
proposes a new mixin to keep cc on the record and allows to create
partner for each of them when sending a message from the chatter.

The mixin is added on the mail recors that can be created from mail.alias:

document
helpdesk.ticket
mrp.eco
quality.alert
hr.applicant
crm.lead
project.task
mail.channel
maintenance.equipment

A new show more/ show less mechanism is also added to the partner suggestions in chatter.

Task: 1925001
Linked PR: odoo/enterprise#3689

closes odoo/odoo#31275

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-03-28 17:36:53 +01:00
XavierDo fbafbf2230 [IMP] mail, test_mail, *: add new email.cc.mixin on main models
*: crm, project, maintenance, hr_recruitment

When a record is created from an email, cc can be lost. This commit
proposes a new mixin to keep cc on the record and allows to create
partner for each of them when sending a message from the chatter.

The mixin is added on the mail recors that can be created from mail.alias:

document
helpdesk.ticket
mrp.eco
quality.alert
hr.applicant
crm.lead
project.task
mail.channel
maintenance.equipment

Task: 1925001
2019-03-28 09:34:11 +00:00
XavierDo e1cd5bbede [IMP] mail: add show more button on partner suggestion.
When sending a message from chatter, a list of suggested partners appears
on the top of the text area. With the previous commit,
cc will be added to this list. This commit adds a show more/show less
button in case there is more than 3 suggested recipients to display.

Task: 1925001
2019-03-28 09:34:11 +00:00
wan c160c73602 [IMP] account: disable quick create on account.account
Task 1958439

Purpose: prevent the erroneous account creation

closes odoo/odoo#32177

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-03-28 08:25:05 +00:00
William Henrotin b3b8f6357f [FIX] mrp: update test_order.py
- Add docstrings
- Use Form views in all tests
- Add some missing assets

closes odoo/odoo#31473

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-03-27 15:16:55 +00:00
William Henrotin 291eb73ce1 [IMP] mrp: flexible component consumption
Purpose: The quantities to consume on Bill of Material lines should be
either strictly used or be taken as a reference more or less adjustable.

This commit adds a setting on BoM to specify if the consumption is 'strict'
or 'flexible'. This new option has the following impacts:

   On produce wizard: if consumption is set to 'strict', the done quantities
   are prefilled and checked when saving the wizard. If set to 'flexible',
   the production flow remains the same as present one.

   On workorders: if consumption is set to 'strict', the Validate button
   will save the consumed data, and propose to fill the remaining ones until
   the total is registered. If set to 'flexible', two button are displayed.
   'Validate' to register the current component and pass to next step either
   the quantity to consume is complete or not, and 'Continue Consumption'
   to registered the current component quantity but leaving the user the
   possibility to add more quantity (and possibly another lot number) for
   the current component

This commit also revert partially d3617fd852
as the warning become some sort of an error

Task: 1889393
2019-03-27 15:16:55 +00:00
Martin Geubelle 32ab3422f0 [FIX] web: tests: correct pass hasSelectors
The attribute is true by default, but when it is set to `false`
in a test, it was not correctly passed in the view.

Note that it has no impact currently in the tests.

closes odoo/odoo#32175

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-03-27 15:36:59 +00:00
Christophe Simonis da711b9c0b [MERGE] forward port branch saas-12.2 up to 27e9c9e011 2019-03-27 19:17:30 +01:00
Aurélien Warnon 55ed70f405 [ADD/MOV] website_sale_product_configurator: new module and files move
Purpose
=======
Since we now have the product_configurator in its own module, we can add a bridge module for the website_sale
to override the necessary controller routes in a cleaner way.

This commit just adds the bridge module and move files and code around, there should not be any functional change.
2019-03-27 15:12:51 +00:00
Aurélien Warnon 3cb46ec74c [ADD/MOV] sale_product_configurator: new module and files move
Purpose
=======
- Moved the product_configurator into its own module now that we have a specific option for it.
  The option only enables the p. configurator in the SO form.
  The e-commerce should always allow customer to configure their products, even if the option is not checked.

  This allows moving some of the code specific to the p. configurator into its own module.
  However, a lot of the code has to remain in "sale" module since the e-commerce does not require the option
  checked and needs the "configure product" feature in the shop by default.
  (This is why the fields "product_custom_attribute_value_ids" and "product_no_variant_attribute_value_ids"
  are still in the "sale" module)
2019-03-27 15:12:50 +00:00
Aurélien Warnon 14f0e81e20 [IMP] event_sale: add an event configurator on SO lines
Purpose
=======

Commit 92b9e3684607fbb0c9a7d3f2331292eac51ebdea removed the SO line popup form and added all the event
information fields directly in the sale order line tree view.

The event information should be hidden by default because they are only relevant for 'event_ok' products.

This commit will add an event configurator widget that will open a wizard when the selected product is 'event_ok'.
The widget will allow configuring the 'event_id' and the 'event_ticket_id' fields so that they can be safely removed
from the sale order line tree view.

The user can also edit the event configuration by using a button next to the product_id dropdown field
if the product is configured as 'event_ok'.
2019-03-27 15:12:49 +00:00
Aurélien Warnon e813487e75 [REM] sale: remove the SO line popup form
Purpose
=======

The sale order lines will now always be editable directly from the tree view.

Why?

- Installing some modules would force a popup form, which leads to a significant drop
  in productivity when filling in multiple sale order lines ;
- The next version of the product configurator will only be compatible with inline tree view editing.
2019-03-27 15:12:49 +00:00
Aurélien Warnon d9423656ce [IMP] (website_)sale: improve the exclusion mechanism in p.configurator
Targets commit d3530eb07e
References task id 1891970

Purpose
=======
- A message will be displayed when hovering a disabled attribute value's input to explain why it's disabled.
  e.g: Not available with Color: Black

  This works for both exclusions within the product and exclusions from a reference product.

- The exclusions will work in both sides, if "black" excludes "metal", "metal" will also exclude "black".
2019-03-27 15:12:48 +00:00
Alexandre Kühn 05e480acb1 [FIX] im_livechat: open website livechat window
Before this commit, when opening a website livechat window,
it crashed with the following error message in the dev tools:

```
Cannot read property 'html' of `undefined`
```

The problem was caused by the rendering of the chat window header
before the chat window widget is even mounted in the DOM. This error
has been introduced by the migration from jQuery 1.12 to 3, in which
most occurrences of `$.Deferred` have been turned into `Promise` [1].

`Widget.appendTo()` returns a `Promise` (was `$.Deferred` before).
A `Promise` is always asynchronous, whereas a `$.Deferred` with
jQuery 1.12 may be either synchronous or asynchronous. In the case
of the website livechat window, the implementation with `$.Deferred`
was always synchronous, which is no longer the case now.

[1] https://github.com/odoo/odoo/commit/126fb33f6a74916c808c8e988f55faf82f0b5759

closes odoo/odoo#32168

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-03-27 14:27:11 +00:00
Aurélien Warnon f860128159 [IMP] stock: add stock for demo data: customizable desk & conf. chair
Targets commit d3530eb07e

Purpose
=======
- The "Customizable Desk" and "Conference chair" products now have some stock in the initial inventory
  to avoid the stock warning when adding these products in a SO through the product configurator.
2019-03-27 13:46:09 +00:00
Sarah Van Bogaert ce4713cd0e [IMP] web: allow multiple fields in form views
This feature was already working in the actual version of Odoo but it is now tested. The following
features are supported:
- When the value of one widget is modified, the other ones change accordingly
- The modifiers 'invisible' and 'readonly' are applied correctly if they differ between widgets.
However, the modifiers 'required' must be equal for the several fields, otherwise the behavior
is not guaranteed.

closes odoo/odoo#32158

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-03-27 13:32:53 +00:00
Christophe Simonis 6b4758cd9a [MERGE] forward port branch saas-12.2 up to 7c1a9a8204 2019-03-27 14:29:01 +01:00
wan 29ef024b51 [IMP] account: display sample data on dashboard if empty
Task: 1893104

closes odoo/odoo#28131

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-03-25 10:23:49 +00:00
eco-odoo 3d6aa1db14 [IMP] account: improve dashboard design
Replace "Balance in General Ledger" by "Balance in GL" or simply "Balance" when both balances are equal.
Rename Import Bills > Upload bills.
Remove space between labels and values.

Task: 1893104
2019-03-25 10:23:49 +00:00
eco-odoo 7dfae39db4 [IMP] web: improve attachment files design
Task: 1893104
2019-03-25 10:23:49 +00:00
Antoine Prieels aed52bb39e [ADD] helpdesk_sale_coupon: Generate coupons from tickets
Add button to tickets to open a wizard to offer a selected coupon to a customer.

TaskID: 1909413
2019-03-21 12:30:57 +00:00
Cedric Snauwaert 4d7f052612 [FIX] account: change reconciliation widget m2o tax_id to a m2m tax_ids
closes odoo/odoo#26990

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-03-12 09:25:15 +00:00
Martin Geubelle 3b9483f170 [REF] web: correctly reuse read_group old datapoint
Rev. odoo/odoo@5c6a7c9 made a change to reuse an old group datapoint when
performing a read_group, instead of restoring *some* properties of the old
group (so basically a `_.omit` instead of a `_.pick`).

This is a bad idea as some properties were bound to the new datapoint
(`evaluateModifiers` for example) so it doesn't make any sense to update
the old datapoint with theses properties.

closes odoo/odoo#31956

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-03-20 09:06:25 +00:00
Christophe Monniez 8bb46e8b96 [FIX] hr_holidays: use api model instead of multi for dashboard
Before 1ced3bfca, the get_days_all_request method was called with the
context as an argument. As a consequence, because of the api.multi, the
first arg is used as the ids of the record. As the id is not used in
this method, it was not harmful. With the above mentioned fix, there is
no more argument. This causes a traceback when clicking on menu "My Time
Off/Dashboard".

With this commit, the api.model is used instead, that way, the first arg
is not considered as ids.

closes odoo/odoo#32119

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-03-26 09:12:33 +00:00
Robot Odoo e64ed7cece [MERGE][IMP] sale_crm : create partner from lead to new quotation
When creating a quotation from a opportunity that does not have any
customer set, we ended up on a quotation without any customer or any of
the contact information entered on the crm.lead.

With this commit, if no customer is set on the opportunity, when hitting New
Quotation button,  a modal is displayed to ask the user what to do to fill in the
customer field.

- Create a new customer : Use the information from the opportunity to create
automatically a res.partner. Set the res.partner on the quotation
and on the opportunity.
- Use an existing customer : Set this customer on the quotation
and on the opportunity.

Extra
For consistency, in the 'convert to opportunity' modal,
move the 'create a new customer' at the top of the selection values
+ change the group title to 'Customer' instead of 'Customers'

Task-1917332

closes odoo/odoo#30475

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-03-26 10:58:23 +01:00
David Beguin c092d8fc6d [IMP] crm : align partner action in lead to opportunity modal on New quotation modal
For consistency, in the 'convert to opportunity' modal,
move the 'create a new customer' at the top of the selection values
to be align with the New quotation - set partner modal
(crm.quotation.partner)
+ change the group title to 'Customer' instead of 'Customers'

Task ID : 1917332
Closes PR #30475
2019-03-25 14:50:55 +00:00
David Beguin 4c9c249cc3 [IMP] sale_crm : create partner on new quotation if no customer set on opportunity
When creating a quotation from a opportunity that does not have any
customer set, we ended up on a quotation without any customer or any of
the contact information entered on the crm.lead.

If no customer is set on the opportunity, when hitting New Quotation button,
a modal is displayed to ask the user what to do to fill in the customer field.

- Create a new customer : Use the information from the opportunity to create
automatically a res.partner. Set the res.partner on the quotation
and on the opportunity.
- Use an existing customer : Set this customer on the quotation
and on the opportunity.

Task ID : 1917332
Closes PR #30475
2019-03-25 14:50:55 +00:00
Christophe Monniez 9ea4fefed2 [FIX] web: avoid click on home menu in community
A fix attempt for the clickEveryWhere test was made in 39e71353c5.
Unfortunately, the last modification of the fix were not tested on the
runbot and introduced two new issues.

1) The click method on the home menu has been changed to use an enhanced
   _click function. This function crash when the jquery element is empty.
   As this menu does not exists in community, the test miserably fails.

2) A "focus" event was added in the _click function that simulates a real click.
   But the "focus" event is not a mouse event and as nothing to do there.

With this commit, the _click function returns immediatly when the
element is empty.

Also, the "focus" event is removed from the _click
simulation but a focus method is used to give focus to the close button.

Giving the focus to the cancel button is itself a fix for the
DateTimePicker field (see 39e7135).

closes odoo/odoo#32082

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-03-25 08:16:24 +00:00
Raphael Collet d87443a213 [FIX] convert: enable kwargs in tag <function>
closes odoo/odoo#31417

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-03-22 16:42:14 +00:00
Raphael Collet 1ced3bfca4 [FIX] *: pass context in kwargs in rpc calls 2019-03-22 16:42:08 +00:00
Raphael Collet 579965adc5 [IMP] api: RPC calls must always pass context as a keyword argument 2019-03-22 16:36:06 +00:00
Christophe Simonis 5df4746c9a [MERGE] forward port branch saas-12.2 up to 230ad8c381
closes odoo/odoo#32088

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-03-25 11:13:41 +00:00
Christophe Monniez 39e71353c5 [FIX] web: focus on close button when before closing a modal
During the clickEverywhere test, when a modal is opened, the hide method
is called to bypass it. This is not realistic and does not work in some
cases.

For example in Point of sale, menu "Reporting/Sales Details", a modal is
opened with a DateTimePicker (tempus dominus) already opened.
When hiding or closing the modal, the DateTimePicker needs to perform
some cleanup. If the modal is simply hidden, the DateTimePicker is not
cleanly destroyed.

With this commit, a modal is closed by clicking on its close button and
before that, the focus is set on the close button to let the
datepicker widget do its stuff on losing focus.

Also, a more realistic click is done by trigerring more events (code
adapted from tour helper).

closes odoo/odoo#32038

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-03-22 10:28:15 +00:00
Swapnesh Shah 3a56e34169 [IMP] mail: highlight re-send alert in BS style
closes odoo/odoo#31890

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2019-03-22 09:18:01 +00:00
Arnold Moyaux eff31f5336 [IMP] account: allow to override _get_reason
Do not pass the function reference instead call it
on self in order to be able to override it.

task_id: 1909413

closes odoo/odoo#30993

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-03-21 08:59:36 +00:00