Commit Graph
126133 Commits
Author SHA1 Message Date
Olivier Dony fb31330451 [FIX] auth_signup: correct leftover from 6d16915d39
The /web/signup controller was also supposed to get the special frame
header, like all sign-in/up pages.
2018-07-26 23:48:58 +02:00
Laurent Smet 3cee86e149 [IMP] account: replace old manual reconciliation wizard
The old manual reconciliation wizard gets deprecated (soon to be removed) while we push forward the 'payment matching' widget. Better, faster, stronger.

Was task: 1847703
Was part of PR #25921
2018-07-26 22:45:41 +02:00
Laurent Smet b5bb5bd421 [IMP] account: automatic communication management on out_invoices
On the accounting config, you can select an automatic way to compute the
reference on invoice and then, improve the reconciliation in a later task:
- free communication: set what you want as reference (default)
- based on partner: find the partner more easily
- based on number: retrieve the invoice directly

Was task: 1847703
Was part of PR #25921
2018-07-26 22:45:41 +02:00
Christophe Simonis e1585c1a75 [MERGE] forward port branch 11.0 up to adc97120c9 2018-07-26 19:16:14 +02:00
Thibault Delavallée 71200fdc9b [MERGE][IMP] mail: improve propagation of model through activity type configuration
Activity types can be either generic, either related to a given model.
This task aims at improving the model propagation through several commits

 * prefill model when configuring application activity types;
 * limit previous / next activity types to generic or same model;
 * propagate model when creating new activity types through recommended
   activity m2m;

See sub commits for more details.

This merge is linked to task ID 1844644 and closes PR #25843.
2018-07-26 17:22:26 +02:00
Thibault Delavallée ec16901c76 [IMP] mail: propagate model when creating next activity types
If you create new activity types through the "create and edit" of the
recommended activity type it is a good idea to propagate the model in order
to avoid having inconsistent results.

This commit is linked to task ID 1844644 and PR #25843.
2018-07-26 17:16:50 +02:00
Thibault Delavallée 17e0d52319 [IMP] mail: limit next / previous activities to same kind
When creating an activity type flow using recommended next activities we
should limit the available activity types by model. They should be either
generic either of the same kind. Otherwise you could have inconsistent
results.

This commit is linked to task ID 1844644 and PR #25843.
2018-07-26 17:16:03 +02:00
Thibault Delavallée ec2b6d5b63 [IMP] crm, hr_recruitment: add default model when creating activity types
Purpose is to help managers in their daily use of activities. When creating
a new activity type through an app-dedicated menu we should pre-fill the
model with the main app model. This is already done in several applications.
This commit fixes some applications where it was not done.

This commit is linked to task ID 1844644 and PR #25843.
2018-07-26 17:14:46 +02:00
Richard Mathot adc97120c9 [FIX] hr_timesheet: missing compute_sudo
opw-1862271
2018-07-26 17:13:11 +02:00
Martin Trigaux 424e50121b [FIX] purchase_stock: use correct external id
The external id is purchase_stock.route_warehouse0_buy

Simplify the code to make it more readable

Fixes #25942
2018-07-26 16:33:28 +02:00
Anshuman Sharma 0bf4986cf6 [FIX] hr_attendance: fix attendance check in/out layout issue when having no employee
When user is not linked to any employee and get try to check in/out then user
gets white screen. Instead correctly displays a warning message telling
the user should have an employee.

Screeshot: https://drive.google.com/file/d/1cX1NtCcELeTYgr0kK5cW4i5etyHtezAV/view

This commit is related to task ID 1841522. Closes PR #25230.
2018-07-26 16:20:42 +02:00
Xavier Morel d5dc1536dd [IMP] auth_ldap: make methods non-RPC-accessible
There really is no reason for these methods to be called over RPC.
2018-07-26 15:53:26 +02:00
Xavier Morel aac21e4125 [CHG] Change login/auth internal protocol
* Make Users._login and session.authenticate always raise AccessDenied
  on authentication failure instead of only sometimes (cf
  Session.authenticate calling security.check() which raises and not
  catching the exception)
* Alter AccessDenied such that it's possible to add a custom access
  message, for use with login rate limiting instead of smuggling the
  information via the session
* Alter the RPC endpoints to catch and convert AccessDenied back to
  a boolean sentinel
2018-07-26 15:53:26 +02:00
Xavier Morel a8d868e287 [ADD] Rate limiting to (failed) login attempts
Task 31122 section 4.

Implement per-IP rate limiting of login attempts after some number
of failures.

* check_credentials has no reason to be public, make it private
* add hooks to check for login cooldown on a source IP (remote_addr:
  http://werkzeug.pocoo.org/docs/0.14/wrappers/#werkzeug.wrappers.BaseRequest.remote_addr)
  basis
* add baseline/default configuration of 60s cooldown
* add baseline threshold of 10 login failures, after checking odoo.com
  logs it looks like we have short runs of up to 7 failures (assumed
  to be legitimate) before the user either gets it right or goes and
  looks it up

Depends on #24187
2018-07-26 15:53:26 +02:00
Shubham Johar 48c058112f [IMP] project: Improve the onboarding tour
- improve tips text
- project task quicky create "Title" changed to "Task Title"
- Add steps to open task to add more information on task(edit task and then save task)
- Remove step on "Assigned to"
- Finish tour on Invite users in Settings
- Add rainbow man on tour finish

Related to task: #1825214
2018-07-26 15:50:55 +02:00
Nicolas Lempereur 07023137cd [FIX] models.py: onchange creating m2m => no NewId
Since 2054b59 if we created a record in a many2many relationship of an
onchange, we would also possibly erreneously return the NewId.

The logic of convert_to_onchange of _RelationalMulti doesn't send back
the ID field (if the ID is needed, it is part of the command, not the
update/create dictionary values of a command) and this commit does the
same for the code changed in 2054b59.

This commit also adds a test for this fix, and a test for the regression
corrected with cd2ccc4110 reported in #25969

fix for https://github.com/odoo/odoo/commit/2054b5928#commitcomment-29837226
closes #25984
2018-07-26 15:26:27 +02:00
Prakash Prajapati 045b409349 [IMP] mrp, mrp_byproduct: hide field for kit BoM
This commit hides the field 'Routing' and column "Consumed" in manufactoring
order if the product to make is of type 'kit'. Those field are specific
to manufacturing products

PR:22085
TASK:38933
2018-07-26 15:22:34 +02:00
Prakash Prajapati 1c6aad274d [IMP] mrp: wording improvement
This commit adds a tooltip on field 'manufacturing readiness'
and improve the wording of the selectable values.

PR:22085
TASK:38933
2018-07-26 15:22:34 +02:00
William Henrotin 4a9e392376 [IMP] mrp: done unbuild order locked
This commit doesn't allow to cancel an unbuild order if the state is
'done'

PR:22085
TASK:38933
2018-07-26 15:22:33 +02:00
Prakash Prajapati 996c881ce3 [IMP] mrp: manufacturing order layout improvement
this commit hides the 'Miscellaneous' tab in MO form view if its content
is empty in order to improve the user interface.

PR:22085
TASK:38933
2018-07-26 15:22:33 +02:00
Prakash Prajapati 578427114b [IMP] mrp: filter and group by improvement
This commit hide 'Planned' filter and 'Routing' group by if work order
feature is not actived As they only make sense in that case.

PR:22085
TASK:38933
2018-07-26 15:22:33 +02:00
Prakash Prajapati 6fd5c5a8ea [ADD] stock_account: search view improvement
inventory valuation search view was the product's one. This commit add new filters
to the inventory valuation search view and removes the ones specific to products.

It also rename the search view title to the same label as the menu action

PR:22085
TASK:38933
2018-07-26 15:22:30 +02:00
Prakash Prajapati 16e9f8d46f [IMP] stock: simplify warehouse resupply
The default resupply feature can be configured by going on the route and activating
it for the warehouse. This field is therefore useless and this commit remove it.

The field 'resupply warehouses' is reworded an hidden when there is only one active warehouse

PR:22085
TASK:38933
2018-07-26 15:21:32 +02:00
William Henrotin c0794649f3 [IMP] stock: stockable term rename
"Stockable" term is not a proper english word. We change it
to"Storable"This commit is related to task ID 38933

PR:22085
TASK:38933
2018-07-26 15:21:32 +02:00
Prakash Prajapati 5c1f2126f7 [IMP] stock: picking title renaming
Rename Stock Operarion title in picking list view to a clearer
word for the final user.

PR:22085
TASK:38933
2018-07-26 15:21:32 +02:00
Cedric Snauwaert 82da221b1f [FIX] l10n_de: DATEV export compatiblity
When invoicing a line with an account that has a tax, ensure that line has the same tax of accounts. This is required by DATEV and is common usage in Germany

Was task 35289
Was PR #25202
2018-07-26 15:15:12 +02:00
Thorsten Vocks a3bc08d9d8 [IMP] 10.0 improvement of german account charts
I. modification and extension of SKR03 account chart
========================================

* improvment and mapping of Odoo standard account types (usage of all
available account types and fixing of wrong mapping)
* fixing of reconcile setting on several accounts
* update of account chart (to SKR03 2017)
* fixing of account chart by ascending order of accounts for easier
maintenance in the future and probably easier preparation of accounting reports
* backport of new account tags from V11 for better reporting
* shorter tags
* introduction of new taxes for all theoretically possible tax cases
needed to declare the VAT
* automatic mapping of taxes to accounts to auto detect the right tax
by selection of income / expense account on invoice lines
* assignation of tax groups to taxes
* introduction of reconcile templates (to allow booking of cash discount
cases)

II. modification and extension of SKR04 account chart
=========================================

* improved mapping of Odoo standard account types (usage of all
available account types and fixing of wrong mapping)
* fixed reconcile settings for all accounts
* update of account chart (to latest SKR04 2017)
* better source code by ascending order of accounts. Finally it will be
easier to maintain the chart in the future and also it will be easier
to identify and group records to to develop missing or new accounting
reports.
* backport of new account tags from V11 for better reporting
* shorter tags
* assignation of tax groups to taxes
* introduction of further taxes to cover most possible tax
cases needed to declare the german VAT
* automatic mapping of taxes to accounts to auto detect the right tax
by selection of income / expense account on invoice lines
* introduction of reconcile templates for cash discount deduction on
payments or low payment variances.
2018-07-26 15:14:17 +02:00
Lucas Perais (lpe) 2e5dc495bb [FIX] sale: portal SO view no image if public
Access a SO with the access token, without being logged

Before this commit, the images of the so lines were the no image placeholder
This was because the route of the image was so.line/product_image
Since the token applies on SO, and not on its lines, nothing simple would work

After this commit, we hide the image if the user is the public one

OPW 1868916
closes #25973
2018-07-26 14:20:15 +02:00
Lucas Perais (lpe) f05b10ce49 [FIX] website_payment: display acquirer's messages in case of wire transfer
Connect as portal, go to my account > invoices and click pay now
select wire transfer as the acquirer and then pay now

Before this commit, the messages displayed to the user was misleading and wrong

After this commit, we take the relevant acquirer's message

OPW 1867670
closes #17508
closes #25946
2018-07-26 14:17:32 +02:00
Hiral Bhavsar b7e2d47596 [FIX] web: Make progress bar work with selection fields
Purpose
=======

The progress bar on a kanban column doesn't work with selection fields

Specification
=============

In kanban view, subgroupCounts of progressbar should work if columns are grouped with a selection field

Currently, progressbar's subgroupCounts only worked if column is grouped by a 'Many2one' field. If column
is grouped by a 'selection' field then its not working.

For example,

If column is grouped by a 'Many2one' field then we've tuple,
     {'state': (2, 'Signatures in Progress')}
So, here for preparing progressBar values for subgroupCounts we'll get
     {Signatures in Progress: {overdue: 0, planned: 0, today: 1}}
But for a selection field, we'll have a string 'sent' i.e a technical value,
     {'state': 'sent'}
So here 'group_by_value' as a 'key' will never be matched as we have 'sent' instead
of 'Signatures in Progress'. We've a technical value instead of its UI value and
dict of subgroupCounts would be based on UI values that's why it'll never find values.

To fix this issue we need to set proper 'group_by_value'.

That's why added one condition for 'selection' field to gets its value of specific
state inside 'read_progress_bar' method.

Related to Task: 1862371
2018-07-26 13:43:22 +02:00
Martin Trigaux f4cb239fa8 [FIX] stock: fix previous fix
Typo in 5c44f205a2

Courtesy of Miquel Raïch, Eficient

Closes #25935
2018-07-26 13:40:38 +02:00
Christophe Simonis 5c3660cf0c [FIX] base_vat_autocomplete: correct typo introduced by previous forward-port 2018-07-26 13:15:44 +02:00
Christophe Simonis 93e689d1c2 [MERGE] forward port branch 11.0 up to 1353abecbe 2018-07-26 12:58:46 +02:00
Christophe Simonis 1353abecbe [MERGE] forward port branch saas-15 up to ee09d11738 2018-07-26 12:40:54 +02:00
Christophe Simonis ee09d11738 [MERGE] forward port branch saas-14 up to b8ab55319b 2018-07-26 12:38:55 +02:00
Christophe Simonis b8ab55319b [FIX] web: avoid traceback in case of failed login 2018-07-26 12:21:44 +02:00
Hetashree Chauhan a4d6bff197 [IMP] sale, pos_sale: merge sale report
In Sales, we want to merge the `All Channels Sale Orders` report with
the `Sales` report in order to avoid having information scattered
accross two different reports.

Related to task #58961
Closes #23324
2018-07-26 11:47:18 +02:00
Kirti Choudhary 0932863bb9 [FIX] account: fix crash on post() action of journal entry
This commits defines a new method 'action_post()' for 'account.move' object to call instead of 'post()' from the account.move form view.
Indeed, additional parameter ‘invoice’ of post() is considered as ‘context’ by webclient when called from button action and it is crashing badly.

TASK ID - 1860817
2018-07-26 11:17:37 +02:00
Kirti Choudhary bbec66b6a0 [FIX] account: fix crash on post() action of journal entry
This commits defines a new method 'action_post()' for 'account.move' object to call instead of 'post()' from the account.move form view.
Indeed, additional parameter ‘invoice’ of post() is considered as ‘context’ by webclient when called from button action and it is crashing badly.

TASK ID - 1860817
2018-07-26 11:09:35 +02:00
Goffin Simon 418e146054 [FIX] sale_timesheet: Leaves manager Access error
When validating a leaves request with a user which is
in group group_hr_holidays_manager(Leaves Manager) and
group_account_invoice (Accounting & Finance Billing), it raised an
access error because the function _validate_leave_request
tried to create an analytic line with a project_id.

Without the rule account_analytic_line_rule_billing_user added by this
commit: https://github.com/odoo/odoo/commit/81218a8, a user which was
in group group_hr_holidays_manager and group_account_invoice had the rights
to validate a leaves request.

opw:1866243
2018-07-26 10:34:06 +02:00
Priyanka Kakadiya c315d9ffc8 [FIX] purchase_stock: correctly set dropshipping settings
Currently settings for purchase stock dropshipping are added by
classname 'app_settings_block'. But there are so many classes with this name
that by default it takes first class. First found application receives this
settings.

This commit fixes that by correctly putting the settings in the purchase
settings.

Related to task: 1858217
Closes PR #25267.
2018-07-26 10:32:06 +02:00
Thibaud Ducasse 8198fb6473 [IMP] doc: add logrotate warning in cmdline doc
Fixes #24542
2018-07-26 10:20:04 +02:00
Nikunj Ladava e167f63dba [FIX] survey: fix group by partner filter
While clicking on the answer in appraisal, it gives traceback because of this
context filter. This commit is related to task ID 1866476 and closes PR #25749.
2018-07-26 09:59:00 +02:00
Can Tecim 5e58ac16c3 [FIX] models.py: onchange in python2 with 2054b59
Without the call to `super`, with at least two level off expected
onchange return data (eg. `invoice_lines.name`) we have an error in
python2, python3 python implementation of OrderedDict and possibly other
python implementation.

So this worked most often (with python3 CPython C implementation of
OrderedDict) by chance.

closes #25960
2018-07-26 09:58:29 +02:00
Adrian Torres a800e7f5ec [FIX] tests: remove duplicate tests
The tests introduced in commit 4265026ee2
are replaced and optimized by the tests introduced in commit
cb4266787b
2018-07-26 07:45:34 +02:00
qdp-odoo d519082137 [FIX] stock: fix module installation
In case there are multiple companies that need to call create_transit_location() at the installation of module, orm was crashing because expecting a singleton when doing self.partner_id or self.id
2018-07-26 02:18:37 +02:00
Laurent Smet c75f3a007c [REF] account,stock,account_intrastat: Intrastat report moved in interprise
This will allow to use the same core for all intrastat reports and benefit from the dynamic financial reports engine.
Incoterms have been move to account, as we want to provide a light intrastat report for people not having the stock app installed

Was task: 35850
Was PR #23805
2018-07-26 02:18:37 +02:00
jpr-odoo ad3e567dc6 [IMP] mail: draft activity feedback popup from the Chatter
Before this commit, when we were writing a feedback on an activity marked as
done, and then clicked somewhere else by mistake, the popup would disappear
and the content was lost.

With this commit, we do not lost what we have written in the feedback popover
in the case above: a temporary draft is made, so that reopening the feedback
popup restores its previous content.

Note that the draft is kept in JS, so it will be lost on new page or page
reload. Also, there is no test, because of `$.popover`. In particular,
animations cannot be disabled with `$.support.transition=false`, and there
is not way to detect when transitions end (delays in test is a very bad idea
for obvious reasons).

Task-ID 1832491
2018-07-25 22:23:26 +02:00
Christophe Simonis 4b9d6387b8 [MERGE] forward port branch saas-15 up to e80a0d4aa9 2018-07-25 18:11:41 +02:00
Yannick Tivisse 58fc4e4409 [IMP] base: Improve partners/employees demo data
- Update all the pictures
- Rename the partners with a name that is easy to say for an English speaker (No more 'Agwoleight')
- Update all the addresses/phone numbers in the american format
- Unify the demo data with the new theme (Wood shop/manufacture,...)
2018-07-25 17:34:06 +02:00