Commit Graph
126133 Commits
Author SHA1 Message Date
Nikunj Ladava 8be798375e [FIX] payment: fix rpc.fail in payment form
Parameters of the rpc.fail is changed because of this commit : https://github.com/odoo/odoo/commit/fc5d030ef2695f7d2daeb87db9697240be4b99d4#diff-c52e0c611c3001980c7a7be0f6395e60R80

This commit is related to Task ID: 1869500
Closes #26052
2018-07-31 16:45:03 +02:00
Holger Brunn 65ad60665e [FIX] base: fix users' groups assignation
Avoid sharing of users'groups when writing on multiple users.

When changing groups of multiple users, all implied groups were shared
between written users.

Oversight of new-api rewrite.

Fixes #26036
2018-07-31 16:22:26 +02:00
len-odoo e57a1a8e6f [FIX] web: fix 'drag and drop' test function to work in both directions
The 'drag and drop' function defined in test_utils should be aware of four
different cases, moving up or down, above or below another row.
We need an offset of one pixel for the function to work when moving down
(this is a case of broken symmetry because of <=)

Related to opw 1867049 regarding sequences of resequence moves.
2018-07-31 16:18:26 +02:00
Goffin Simon c75f4fbcd1 [FIX] stock: Source and Destination on pickings
Steps to reproduce the bug:

- Go on a picking with an operation type of type "vendor" (e.g. a receipt) :
the field source location appears while it should be the destination location.

- Go on a picking with an operation type of type "customer " (e.g. a delivery) :
the field destination location appears while it should be the source location.

opw:1869145
2018-07-31 15:07:53 +02:00
Olivier Colson 81a206fa38 [IMP] account: bank journal open in regular journal form view: don't show 'partner_id' field in account creation popup, and fill it with company partner by default. 2018-07-31 15:06:15 +02:00
Goffin Simon e1da65841a [FIX] stock: Display issue on product categ
This text is not written at the right place and it's useless.
So it's confusing for the users.

opw:1870443
2018-07-31 15:04:03 +02:00
RomainLibert 4a99d63615 [IMP] website_sale: change sale_report search view 2018-07-31 14:56:40 +02:00
RomainLibert 89c37b6e35 [IMP] sale: change date order into order date 2018-07-31 14:56:40 +02:00
RomainLibert 42aa0b16e3 [IMP] website_sale_link_tracker: add utm fields to sale.report
We need to be able to filter and group by campaign_id, source_id and
medium_id in the sale_report those fields are defined in utm mixin which
is installed with website_sale_link_tracker.
2018-07-31 14:56:40 +02:00
qsm-odoo e10a4303c2 [FIX] web: BS4, review selected dropdown item style
With BS4, I had to change the dropdown structure and with it the messy
way we handled "selected" items. Sub-filters items were still not
adapted correctly: use the "selected" class on dropdown-item elements,
not one of its parent.
2018-07-31 13:56:50 +02:00
qsm-odoo 160a17b4bd [FIX] *: BS4, restore modal headers 2018-07-31 13:30:09 +02:00
RomainLibert 0520e0b51d [IMP] crm,website_crm_partner_assign: change some labels
In crm,website_crm_partner_assign and website_crm_score there were fields with
almost the same label, which was confusing, we change those names so it
reflects better what the field is used for.

|    field    |           module           |     old label    |         new label        |
------------------------------------------------------------------------------------------
| date_open   | crm                        | Assigned         | Assignation Date         |
| date_assign | website_crm_partner_assign | Assignation Date | Partner Assignation Date |
| assign_date | website_crm_score          | Assign Date      | Auto Assign Date         |
------------------------------------------------------------------------------------------
2018-07-31 13:23:38 +02:00
RomainLibert 629577ac86 [IMP] crm: clean crm lead actions and search view
In order to be able to add some enterprise views to crm, we need to
define the views as act_window.view, we also want to define a graph and
a pivot view for the leads.

We also want to have a more powerful search view associated with these.

Task: #1831168
Closes #25400
2018-07-31 13:23:38 +02:00
qsm-odoo 37b746c6cf [FIX] *: BS4, restore modal headers
Close icon should now be put after the modal title in the DOM.
Completes commit https://github.com/odoo/odoo/commit/d9801c1abe06b4c20702c0e94c56eea6a3ed8327
2018-07-31 13:07:48 +02:00
Shubham Johar 51ef4b8ea3 [IMP] auth_signup: Set activation_scope at 'B2C' by default
Purpose
=======

More and more features redirect to the portal (see & pay
quotations, invoices, etc.) with anonymous access by default
you can't sign up to the customer portal, while you see
a Sign in button. It's frustrating.

The ability to create a customer account is a nice service,
useful in any business willing to engage with returning
customers. This should be the default value

Specification
=============

Activate B2C portal by default. We have to create an
ir.config.parameter for the change to be immediate after
the installation. Otherwise the admin has to go and save
its res.config.settings one time before it's effective.

Task ID: 1841514
2018-07-31 12:37:50 +02:00
Yannick Tivisse a701031c92 [REM] account_invoicing: Merge module into account
Purpose
=======

The only module that was supposed to work without the accounting menuitems was
the ecommerce. Now that the ecommerce wants the accounting menuitems to be
visible, this module makes no sense anymore.

Specification
=============

Remove the account_invoicing module and move the code to account.
2018-07-31 12:34:18 +02:00
mgh-odoo 1fd9ebcdf8 [IMP] website_sale: Add a dependency to account_invoicing
Purpose
=======

Add account invoicing dependency and remove some duplicate options

Purpose of this commit is when ecommerce installed lots of invoicing
stuff still show up while account_invoicing is not yet installed
(like  (invoice button in sales order, invoicing policy of products etc..)
and most of customers not using ecommerce without invoicing so the split is
useless for now

Specification
=============

Add account_invoicing as a dependency of website_sale and remove
the duplicated options from settings

Related Task ID: 1866823
2018-07-31 12:34:18 +02:00
RomainLibert 14676c5aa1 [DOC] web_cohort: add context keys 2018-07-31 11:33:17 +02:00
qsm-odoo bcf61bdcab [FIX] mass_mailing: BS4, restore bg-color snippet option style 2018-07-31 11:08:11 +02:00
qsm-odoo 15af66ce3f [FIX] web: BS4, restore database manager
The database manager was broken with BS4, this commit restores it. The
old BS3 layout was not perfect either, so this commit redesigns the
forms with BS4 too.
2018-07-31 11:08:11 +02:00
Can Tecim bf332e2e08 [FIX] purchase: P3-style super call
3869cdf7d8 merged a fix which used a
P3-style super call, which is not compatible with Python 2.

While 11.0 is not really exactly officially supported on Python 2,
we originally decided not to break compatibility unless there were
very good reasons to do so.
2018-07-31 10:05:30 +02:00
Goffin Simon 47acea1523 [FIX] website_sale_wishlist: Wrong displayed currency in the wishlist
Steps to reproduce:

1. Activate multi-currency and associate a price list "Other list" with secondary currency as an alternative for "Public Price List".

2. Enable the price list to be selectable on the website.

3. Enable wishlist functionality on Website module

4. Navigate to website without logging in

5. Add a product to the wishlist (with the default price list)

6. Switch price lists.

Bug:

The wrong currency was displayed in the wishlist for the new price.

PS: In function "compute_new_price", price_new = website_price

opw:1867314
2018-07-31 09:44:03 +02:00
Romain Derie e11908d429 [FIX] website_sale: _get_pl_partner_order
With 60300fc, people can use promo code on website.
But the condition leads to a side effect, if a partner has a pricelist set for
him, he will never be able to see the dropdown list of pricelist since he will
enter the else condition with show_visible set to true.

Now, user is able to see selectable pricelists.

opw-1869371
2018-07-31 09:25:26 +02:00
Lucas Perais (lpe) 93e71d181e [FIX] account: reconciliation widget: Don't loose pager on adding last line
Have a statement line with multiple pages of propositions
Go to the last page
Add everything

Before this commit, after clicking on the last item of the list,
a write-off creation was displayed, without any means to come back to the other
propositions

After this commit, we display the page before
2018-07-31 09:18:31 +02:00
Lucas Perais (lpe) aa7bc410f0 [FIX] account: reconciliation widget: empty line should open write off
In manual reconciliation, have an accound with no direct proposal.
An empty line should be present

Click on it

Before this commit, there was a traceback

After this commit, a write-off creation appears
2018-07-31 09:18:31 +02:00
Lucas Perais (lpe) ebca7c3d37 [FIX] account: reconciliation widget: remove prop to attain balance
In manual reconciliation (but probably automatic too)

Have 3 lines for one account
2 of them are balanced
the third is of an amount X

Add the three lines to the reconciliation
A write-off proposal of -X should appear

Now, remove the third line by clicking on it
Click on Reconcile

Before this commit, the values sent to the server were wrong, as the write-off
was still included

After this commit, we make sure we don't send lines that are not displayed
2018-07-31 09:18:31 +02:00
Lucas Perais (lpe) 862c245576 [FIX] account: default_get aml compute balance
Create an account.move, create a line, then add an item to start to add a second aml
The current balance of the move is put in debit (or credit) to help automatically making the second line

Save the move.
Edit the move
Delete a line
Add a new line

Before this commit, the balance was not correctly computed because the default_get did not compute
the balance on deleted lines
The move ended up with wrong unbalanced new lines

After this commit, the balance is computed with deleted lines taken into account
2018-07-31 09:18:31 +02:00
Katherine Zaoral 5dd10f57ab [IMP] sale_crm: Source Document is set when a Quotation has been created from an Opportunity
opw-1867965
2018-07-31 08:02:05 +02:00
Fabien Pinckaers 0ee0fe5570 [FIX] crm: no filter on creation date this month 2018-07-30 21:48:09 +02:00
qsm-odoo 6f577ab280 [FIX] web: BS4, adapt caret position for sub-filters 2018-07-30 18:10:45 +02:00
qsm-odoo 6a80ddecfc [FIX] web: BS4, form sheet should clear floating elements
Before most were cleared by .tab-content elements, which is not the case
anymore with BS4.
2018-07-30 18:10:45 +02:00
Nicolas Lempereur 5dc180a3ea [FIX] im_livechat: double click on :) => 1 message
Prevent sending multiple messages when multiple clicks on one feedback
icon.

opw-1863312
closes #26047
2018-07-30 17:03:57 +02:00
Christophe Simonis a719cf2563 [MERGE] forward port branch saas-11.3 up to b4555df336 2018-07-30 17:02:28 +02:00
Arnold Moyaux 2a4451d5b4 [FIX] stock: missing action's routing on delivery ressuply
Since commit a35df8d371 action has been
added on routing however it was forget in delivery ressuply case.
2018-07-30 16:02:17 +02:00
Christophe Simonis b4555df336 [MERGE] forward port branch saas-11.2 up to 3376bad191 2018-07-30 15:51:38 +02:00
Christophe Simonis 3376bad191 [FIX] event: remove duplicated method
Oversight of previous forward-port
2018-07-30 15:46:52 +02:00
qsm-odoo 203296e8a9 [FIX] web: BS4, fix custom radio button style
This is a standard BS4 bug: radio buttons's dot is not properly centered
as soon as the html font-size is not a multiple of 4 (and our backend
uses 13px). As a quick fix, I change that to 12px and use a font-size base
of 13/12rem so that the body font-size does not change. Bootstrap will
probably fix this in a future update.
2018-07-30 15:08:16 +02:00
Goffin Simon 6e69de6707 [FIX] website_sale: Billing address in Authorize.net transaction
Let's consider the partner P1 with the address A1 and its invoice partner P2
with the address A2.

When creating a transaction in the shop for P1 with billing address = A1:

- if option Payment Flow =  Redirection to the acquirer website
   => the billing address of the transaction is A1

- if if option Payment Flow = Payment from Odoo
   => the billing address of the transaction was A2

Now with this patch, the billing address is A1 in each case.

opw:1867188
2018-07-30 15:02:06 +02:00
Yannick Tivisse 0ea443e943 [MERGE] sale, delivery: Improve the invoicing status followup
Purpose
=======

Improve some common usability issues coming from the invoicing followup.

Specification
=============

1. Sale: Rename 'Check/Set Price' buttons for more clarify
    relabel "Check price" -> "Get rate"
    relabel "Set Price" -> "Add to order"

2. Sale: Change the default invoicing method if there are downpayments
    Purpose
    -------
    Currently the default invoicing method is not very clear.

    Specification
    -------------
    Currently the result is not really correct. We can propose to deduct
    the down payment even if there are no down payments on the sales order.

    Now the option to deduct down payments will be selected if there
    is a downpayment line on the sales order and if there exists at
    least one invoice linked to the sales order that is not cancelled.

3. Delivery: Improve the SO invoice status
    Purpose
    -------
    If a SO is only containing lines for which the product is invoiced on
    the delivered quantity, the sales order is marked as 'Nothing to Invoice'.

    If I add a delivery line, the SO becomes 'To Invoice'. There is not really
    a use case in the real life where you will invoice the delivery fees before
    invoicing what has been really delivered.

    Specification
    -------------
    If an order:
    - contains delivery lines or downpayment lines
    - If the product on the other lines are invoiced on the delivered quantity
    - Nothing has been delivery or can be invoiced for theses lines

    Set the invoice status of the sales order to 'Nothing to invoice' instead
    of 'To Invoice'

4. Sale: Unlink the down payment on a SO if the invoice is unlinked
    Purpose
    -------
    When we create a downpayment line of SO and when we delete Invoice of downpayment then so line for downpayment is not deleted.

    Specification
    -------------
    Remove the downpayment line in the SO if the related invoice is deleted

Task ID :33126
2018-07-30 14:58:06 +02:00
Kirti Choudhary eebeb39da5 [IMP] sale: Unlink the down payment on a SO if the invoice is unlinked
Purpose
=======

When we create a downpayment line of SO and when we delete Invoice of downpayment then so line for downpayment is not deleted.

Specification
=============

Remove the downpayment line in the SO if the related invoice is deleted

Task ID :33126
2018-07-30 14:57:04 +02:00
Mitali Patel 752a6843d1 [IMP] delivery: Improve the SO invoice status
Purpose
=======

If a SO is only containing lines for which the product is invoiced on
the delivered quantity, the sales order is marked as 'Nothing to Invoice'.

If I add a delivery line, the SO becomes 'To Invoice'. There is not really
a use case in the real life where you will invoice the delivery fees before
invoicing what has been really delivered.

Specification
=============

If an order:
- contains delivery lines or downpayment lines
- If the product on the other lines are invoiced on the delivered quantity
- Nothing has been delivery or can be invoiced for theses lines

Set the invoice status of the sales order to 'Nothing to invoice' instead
of 'To Invoice'

Task ID : 33126
2018-07-30 14:57:04 +02:00
Kirti Choudhary 3d46887d38 [IMP] sale: Change the default invoicing method if there are downpayments
Purpose
=======

Currently the default invoicing method is not very clear.

Specification
=============

Currently the result is not really correct. We can propose to deduct
the down payment even if there are no down payments on the sales order.

Now the option to deduct down payments will be selected if there
is a downpayment line on the sales order and if there exists at
least one invoice linked to the sales order that is not cancelled.

Task ID : 33126
2018-07-30 14:57:04 +02:00
Kirti Choudhary d24b7503cd [IMP] sale: Rename 'Check/Set Price' buttons for more clarify
relabel "Check price" -> "Get rate"
relabel "Set Price" -> "Add to order"

Task ID : 33126
2018-07-30 14:57:04 +02:00
Christophe Simonis a6e401a2ee [MERGE] forward port branch 11.0 up to 44ea58234e 2018-07-30 14:08:56 +02:00
Lucas Perais (lpe) 44ea58234e [FIX] base, hr_timesheet: display negative float_time values
Before this commit, negative values in a float field interpreted as time
(i.e. unit_amount on analytic lines) were wrongly formatted

After this commit, not only we correct the hr_timesheet qweb templates
but we also correct the qweb widget to handle the case

OPW 1869986
closes #26024
2018-07-30 13:18:04 +02:00
qsm-odoo a842f6b3ee [FIX] web: BS4, left-align buttons in modal footers
Modal footers now use flex to vertically center buttons. So our
left-align style overridde had to be adapted. Also, we sometimes
use footer buttons as non-direct children of the modal-footer, which
is not a supported BS4 case, so we had to adapt that too.
2018-07-30 12:57:27 +02:00
Christophe Simonis 91d647ecf7 [FIX] website_sale_delivery: use -U+FEFF instead of U+2011 for negative numbers
See cb2a3afa7e and 7a519520f2
2018-07-30 12:57:26 +02:00
Christophe Simonis 248a59553d [MERGE] forward port branch saas-15 up to 535d50afbd 2018-07-30 12:53:34 +02:00
Christophe Simonis 535d50afbd [MERGE] forward port branch saas-14 up to 5a57892b05 2018-07-30 12:48:15 +02:00
Christophe Simonis 5a57892b05 [MERGE] forward port branch 10.0 up to 7a519520f2 2018-07-30 12:46:20 +02:00