Commit Graph
126133 Commits
Author SHA1 Message Date
Christophe Monniez c6fa1796af [FIX] tests: clean the browser even on failure
When a Chrome headless test fails the browser is not cleaned and could
lead to a mix with other tests when the same method is called.

Also, the multiline assertions gives an unreadable message when the
assertion fails.
Finally, it happens that a thread does not have an 'url' attribute and lead to a crash when the logger tries to show the thread url.

With this commit, the browser is cleaned, even on failure and the
assertions are now one line.

Closes:  #26432
2018-08-17 14:49:53 +02:00
Alexandre Kühn 0eab8f6e0b [FIX] mail: correct meaning for ASC/DESC thread ordering
Revision on https://github.com/odoo/odoo/commit/f2302dfb27dd7f6a0dee7c65ab75b62a01706264

The commit above improved the rendering of thread.
However, it wrongly defined ASC and DESC.

This commit fixes this issue by re-arranging so that their
definitions match the meaning of 'ascending' and
'descending'.

Orders are defined from top to bottom. Visually:

                _____________            _____________
               |             |          |             |
               |  message 1  |          |  message n  |
               |  message 2  |          |  ...        |
               |  ...        |          |  message 2  |
               |  message n  |          |  message 1  |
               |_____________|          |_____________|

    ORDER:           ASC                     DESC
2018-08-17 14:10:46 +02:00
Alexandre Kühn 1337465c51 [REF] mail: reorder Discuss handler function alphabetically 2018-08-17 14:10:32 +02:00
Yannick Tivisse b10841d615 [IMP] auth_signup: Set self created users as customers
Since https://github.com/odoo/odoo/commit/9aaa32b6f62a95f58d11c17aefb4da4027371223
newly created users are not customers anymore.

But users created from frontend (like in the ecommerce) should be customers.

Specification
=============

Portal users created from auth_signup should be customers.
2018-08-17 14:05:59 +02:00
Martin Trigaux d97e69ff02 [FIX] mail: schedule activity with user's today
The activity was incorrectly scheduled with a deadline as the now in UTC while
the state was computed using "today" in the user's timezone.
This made the nightly test fail (run at 23:30 UTC with the user in UTC+2).

Use context_today instead of today for all activity_schedule calls
To make it easier, use on the context_today default value instead of setting
context_today everywhere (which is more error prone in the future)

Never use datetime, only date objects
add a warning to detect potential errors when passing a datetime

Closes #26411
2018-08-17 13:46:39 +02:00
Nicolas Martinelli b4cbf0bb61 [FIX] calendar: date start
When creating and editing a new calendar.event record from the calendar
view, the start_datetime field does not prefill from the day that was
selected on the calendar.

Introduced in e08f999468

opw-1875276
2018-08-17 13:38:32 +02:00
Nicolas MartinelliandArnold Moyaux f0028bc837 [FIX] mrp: raw materials and multi-location
- Create a BOM for Product P with the following component:
  Product C, 5.0 units
- Make some stock for C:
  2 units in location 1
  3 units in location 2
- Create a MO for P, reserve.

When trying to produce an error arise:

> Cannot set the done quantity from this stock move, work directly with
> the move lines.

If the user tries to unlock the MO in order to set the done quantity on
the move lines, the same error will arise when trying to produce.

In the specific scope of the production, we set the quantity done on the
move line instead of directly on the move, to avoid this limitation.

opw-1871241

Co-authored-by: Arnold Moyaux <arm@odoo.com>
2018-08-17 13:21:28 +02:00
Martin Trigaux c51cfbc58b [FIX] purchase: use date everywhere in report
account_invoice.date is a date field
purchase_order.date_order is a datetime field
2018-08-17 13:14:51 +02:00
XavierDo f83c313631 [IMP] mail_bot: improve answers, initialisation and others
1. Odoobot shouldn't talk to admin when demo data are installed
Odoobot will talk to a user on it's first connection, meaning that
a dev will see this chat window a lot. The state disabled is not a
real state but is explicit, the odoobot wont be initialized in this
case. It is still possible to test odoobot flow with demo user.

2. remove old odoobot image and update link

3. small improvements in odoobot answers
2018-08-17 13:06:43 +02:00
Lucas Perais (lpe) 412c471e78 [FIX] tools: sanitize allow white-space style
OPW 1870847
2018-08-17 12:58:21 +02:00
Mehul Patel dc5462db51 [FIX] web, google_spreadsheet: BS4, fix arrow issue in search filters 2018-08-17 12:46:14 +02:00
Hiral Bhavsar b0c4245df7 [FIX] web: BS4, restore calendar view's sidebar filters checkbox
Currently cross sign not appearing inline to checkbox while hovering
sidebar filters and checkbox tick/untick not working properly.
2018-08-17 12:46:14 +02:00
qsm-odoo 4895b542e4 [FIX] website_links: restore filter buttons (useless breaking rules)
Revealed with BS4.
2018-08-17 12:46:14 +02:00
mgh-odoo d187f37563 [FIX] base: use proper info alert for new team member message
Bug revealed with BS4.
2018-08-17 12:46:14 +02:00
Anshuman Sharma 13ebe69747 [FIX] website_forum: BS4, set a spacing between cards 2018-08-17 12:46:14 +02:00
Kishan Gajjar 9056e5a3cb [FIX] web_editor: BS4, mark proper active img-padding option 2018-08-17 12:46:14 +02:00
Deep Patel 0bcd71a54a [FIX] web: BS4, fix stat button color issue 2018-08-17 12:46:14 +02:00
Vandan Shah e31048f6a4 [FIX] mrp: BS4, restore report's links design 2018-08-17 12:46:14 +02:00
qsm-odoo 9d30113356 [FIX] web: BS4, restore dropdown active colors 2018-08-17 12:46:14 +02:00
qsm-odoo ed031d9085 [FIX] mail: BS4, restore discuss badge design 2018-08-17 12:46:14 +02:00
qsm-odoo 3bf3a40606 [FIX] website: BS4, restore facebook snippet UI
+ solve JS error introduced by a recent commit

Thanks to @kig-odoo for original fix
2018-08-17 12:46:14 +02:00
Alexandre Kühn ff4901e429 [DOC] web:tests: add docstring for testUtils.patchDate 2018-08-17 12:37:36 +02:00
Alexandre Kühn 75aef0106e [FIX] mail: misplaced translatable string
`_t()` must surround a static string in order to become a
translatable string.
2018-08-17 12:37:25 +02:00
RomainLibert 2d738f8563 [FIX] product_form: remove hs code and duplicate internal note
The hs code was only used in a single view, hence it was decided that we
wouldn't keep it
2018-08-17 11:47:28 +02:00
Simon Lejeune 3fa2ca0779 [FIX] web: no_open in field options no longer working
example: <field name="product_id" options="{'no_open': True}" readonly="1"/>

This has been broken by rev. 43d21dd9c due to misplaced parentheses
(an empty object in javascript being truthy).
2018-08-17 11:24:27 +02:00
Sébastien Theys 82a46db2de [FIX] portal,sale,sale_management: raise if no document
Before this commit, the method _document_check_access would succeed if it was called with a non-existing id.

Now it will raise a MissingError.

PR: none
Task: none
2018-08-17 10:40:07 +02:00
Sébastien Theys 02a73ed62c [IMP] sale,sale_management: fix minor bugs and rename strings
Sales Order report:
- fix Total table alignment (to the right)
- remove misplaced /> characters
- remove page-break before optional products

Sales assets:
- fix duplicate ID preventing assets files from being loaded

My Home:
- fix link to sales orders

Optional Products:
- renamed various strings
- made product_id required to prevent a traceback

PR: none
Task: 1838924, 1876864
2018-08-17 10:40:07 +02:00
Mathieu Duckerts-Antoine 3ec6624754 [FIX] web: time range menu flickering
The search view always instantiates a time range menu but hides it
when it is not used.

Now, when the time range menu is not used, every time the search view
facets are rendered, the time range menu is also rendered entirely
and becomes visible shortly before being hide again. This caused
a bad screen flickering.

This commit fixes that problem by avoidind the unnecessary rendering of
the time range menu.
2018-08-17 10:26:31 +02:00
Joren Van Onder 750e70e0a1 [FIX] l10n_co: remove duplicate account template
Introduced by 986a7550a5.
2018-08-16 14:56:51 -07:00
Alexandre Kühn c995aa2cfd [FIX] mail: tests: remove phantomjs hack with discuss
Revision on https://github.com/odoo/odoo/commit/e0a51edd856b36bfdf1cacb4d7e8d70fad7884fa

In the commit above, we added an option to Discuss widget
to render threads specifically for PhantomJS. The reason
for this is that a test was failing, because it needs full
support of CSS flexbox to pass.

However, PhantomJS does not support flexbox very well. As
a result, it was messing with the rendering of threads.
We couldn't make the hack just in the test itself, because
it is already at the moment of rendering the thread that
PhantomJS messes the whole process of the test.

PhantomJS has been replaced with Chrome headless [1], So
the hack is no longer be necessary, as Chrome headless
fully supports CSS flexbox.

[1] https://github.com/odoo/odoo/commit/de84ad9c1f4853cb8a748ee1d0c880081dae9fe2
2018-08-16 22:26:50 +02:00
Rémi Rahir dd00a3d9f9 [FIX] snailmail: added missing dependency 2018-08-16 18:45:53 +02:00
Alexandre Kühn f1a0a32e46 [FIX] web:tests: do not rely on testUtils.patch in tests
Revision on https://github.com/odoo/odoo/commit/10f43955d81ff3e7b5ab050656b312ec19f927c5

Commit above uses `testUtils.patch` in the test.
However, this utility function does not seem to work.

That sucks...
2018-08-16 18:38:49 +02:00
Thomas Binsfeld f9644a7674 [IMP] purchase: split compute methods
No advantage to group a search on purchase.order and another one on
account.invoice.
Avoid potential access errors if a user has access to one model but not the
other one.

Closes #25761
2018-08-16 17:34:23 +02:00
Gustavo Valverde 89273f8d72 [IMP] hr_payroll: order salary rules by sequence
The most important part of building salary rules is having them in the right
sequence. Unsure all the rules are evaluated in a deterministic order.

This also makes it easier to know how the payslip will show the order of the
salary rules.

Closes #25756
2018-08-16 17:30:03 +02:00
qsm-odoo 8a85cb9ea4 [REF] website_sale, *: organize JS to use new system
* website_sale_comparison, website_sale_wishlist, website_sale_options
2018-08-16 16:59:25 +02:00
Alexandre Kühn 10f43955d8 [FIX] web: render JournalDashboardGraph when in DOM
The lib 'nvd3' renders graph when they are attached to the
DOM. However, widgets are rendered in fragments and
appended to the DOM when ready (to prevent flickering).

Before this commit, we used a `setTimeout(0)` and cross
fingers that the widget was attached to the DOM when the
`render` method was called.

With this commit, the render method is called when it is
attached to the DOM.

Task-ID 1868252

Closes #26410
2018-08-16 16:52:56 +02:00
Martin Duvergey 35bc8fec94 [CLA] JANUS signs CCLA
Closes #25365
2018-08-16 16:48:49 +02:00
Raphael Collet 2a2ff6eb5c [FIX] tools: serialize lazy to json 2018-08-16 16:39:20 +02:00
Dennis Sluijk b30dd020fd [FIX] hr_timesheet: use float_time widget
To display the sum as a time and not a float number

Closes #26405
2018-08-16 16:28:14 +02:00
Martin Trigaux 86a25a68e7 [I18N] resynchronise all translations with .pot
Regenerate all child translations based on the .pot
Remove the terms that are either equal to the parent, either equal to the
source term.
Remove empty translation files
2018-08-17 01:29:55 +12:00
Martin Trigaux 428fbd0381 [FIX] tools: skip bad translations 2018-08-17 01:29:54 +12:00
Darshil Trivedi 69dd3dfa90 [FIX] stock: scrap: bypass confirmation wizard if not storable
If a user wants to scrap more quantity than he has in stock, we return
to him a confirmation wizard. This doesn't make sense when scrapping
consumables products, as there are no quants for these kind of products.

task 1864026
2018-08-16 15:14:54 +02:00
Christophe Monniez 49fb7a4682 [FIX] tests: avoid traceback when websocket-client is not installed
The account module needs to import Form from "tests.common" causing a
traceback when websocket-client module is not installed.

As this module is only required for the tests, there is no reason to add
it to the "requirements.txt" file.

With this commit, Odoo account can be installed even when
websocket-client is not installed, in that case, the HttpCase tests that
needs to run Chrome headless will be skipped with a warning.

Closes: #26404
2018-08-16 15:07:43 +02:00
Simon Lejeune f57bc96d32 [REF] stock: add a group to display/hide the lot name on the delivery
initial work by Alexandre Moens <mao@odoo.com>
task 1832574
closes #24299
2018-08-16 15:01:25 +02:00
Arnold Moyaux 6671725c3b [FIX] mrp: manufacture to resupply archive pbm/sam rules and routes.
Usecase to reproduce:
- Check manufacture to resupply and manufacture in 2 or 3 steps
- Uncheck manufacture to resupply
pbm and sam rules in global route(mto/manufacture) are still active

It happens because the condition to archive the rules was not complete
the check on manufacture to resupply was missing
2018-08-16 14:45:14 +02:00
Yannick Tivisse 9aaa32b6f6 [IMP] base: Better implementation of 8166eae 2018-08-16 14:40:46 +02:00
Toufik Benjaa 2479c797f7 [FIX] sale_timesheet: Perf issue on projects overview
- Generating the overview for a project may have a high memory usage for
projects with a lot of tasks.
  This is due to the usage of "mapped" which stores data in the cache.
  To avoid this, we instead use "search_read".
2018-08-16 14:36:45 +02:00
Thibault Delavallée b4715952cb [FIX] mail: fix server action view requiring not required fields
Some fields are required only when defining an activity-based server
action. Required domain was not correctly written leading to server
actions being blocked.
2018-08-16 14:34:50 +02:00
Yannick Tivisse 8166eae0bf [IMP] base: Don't set customer=True on new users
Purpose
=======

Create a user, then the partner is shown in Customers.

Most of the time, user is not a customer.
2018-08-16 14:19:37 +02:00
Graeme Gellatly 7d898ad72f [FIX] purchase: rounding in supplier info
- Set 'Product Price' accuracy to 5 places
- Create a PO for a product to a new supplier
- Enter price at 3.14561 / unit

Supplier info entry rounded to 3.15, while it should be 3.14561.

Closes #22253
Fixes #22252
2018-08-16 13:44:23 +02:00