Commit Graph
126133 Commits
Author SHA1 Message Date
Frederik Kramer 60c9742dfb [CLA] backport signature for initos
This is a backport of 5a53e5b8e9 as requested at #26638
Added Florian Kantelberg to our team of contributors
2018-09-12 16:25:04 +02:00
Christophe Simonis 87b3ca13bf [FIX] stock: correct tests to create pickings without using new() 2018-09-12 16:15:04 +02:00
GabbasovDinar e82a9ae0e1 [IMP] point_of_sale: better merge detection
If sells
1. product A
2. product B
3. product A

the lines of product A were not merged

Closes #25540

closes odoo/odoo#26602
2018-09-12 13:52:55 +00:00
GabbasovDinar 9e0906b3ed [IMP] point_of_sale: display pricelist button only if enabled
If the option use_pricelist is disabled, no need to display the button

Closes #25540
2018-09-12 13:55:50 +00:00
Robot Odoo 993860e465 [pos] master fixes
Trying a two commits PR to challenge a bit @robodoo

closes odoo/odoo#26915
2018-09-13 13:18:55 +02:00
Martin Trigaux 6dacb3269d [IMP] point_of_sale: check constraint at session creation
The constraints could be bypassed if a user set a jourmal/account/location to
the pos.config and, then, modifies the location configuration.

Checking the value of current_session_id makes sure the constraints is triggered
also when the session is created.

Prevents workarounds such as explained at #26641
2018-09-13 09:49:35 +00:00
Martin Trigaux 6caeed1fd7 [REF] point_of_sale: clean dead code 2018-09-13 07:28:12 +00:00
Raphael Collet cd6e9ab4fb [FIX] mail: _compute_need_moderation() 2018-09-12 15:15:10 +02:00
Wolfgang Taferner 8e15dc87a4 [IMP] account: extract_payment_vals + explicit communication hand-over 2018-09-12 15:12:42 +02:00
Alexandre Kühn 611b42409e [FIX] mail: filter messages in thread (Discuss)
Revision on https://github.com/odoo/odoo/commit/ec8c505bc1c9ec21939e9ffef53a9cc6f63f30c7

The commit above changes the way threads are rendered: the template
now uses a thread object, instead of a list of messages.

However, it was not handling messages that have been filtered from
the searchview. As a result, it was not possible to filter messages
at all.

This commit re-adds the possibility to filter messages, by providing
information on the domain of the thread in the template.

Task-ID 1877502
2018-09-12 15:02:22 +02:00
Alexandre Kühn 3b76886f9a [FIX] mail: toggle show/hide search options in discuss
Before this commit, the search option buttons were not
hidden when clicking on the zoom-in/zoom-out button next
to the searchview.

This is due to updating the control panel with the list
of buttons as the searchview buttons, instead of the
container. Since the visibility of the searchview buttons
is defined on the container, the toggler button and the
search view options lost synchronization.

This commit fixes the issue by providing the container
that is shared between search option buttons.

Task-ID 1877502
2018-09-12 15:02:22 +02:00
Alexandre Kühn 4ee7a009f7 [FIX] im_livechat, mail: any thread window has an ID
Before this commit, only thread windows in the backend had the
method `getID`. However, it should also be the case for the thread
windows in the frontend (website livechat), as the template of any
thread window makes use of this method.
2018-09-12 15:02:22 +02:00
Alexandre Kühn 5b4aebb441 [FIX] im_livechat: correctly display livechat statistics
Layout broke from bootstrap 4 migration.

Task-ID 1878249
2018-09-12 15:02:22 +02:00
Alexandre Kühn 6a9a20d025 [REF] mail, im_livechat: clean typos 2018-09-12 15:02:22 +02:00
Alexandre Kühn d52864569d [IMP] mail: bigger emoji size in the composer selection
The emojis were too small, thus hard to read.

Task-ID 1882595
2018-09-12 15:02:22 +02:00
Aaron Bohy 18bd4fa749 [FIX] web: remove race condition at webclient startup
Before this rev., there was a race condition making some tours
randomly fail on runbot, when the following steps occurred in that
order:
  - load webclient
  - as soon as the menu is ready and visible, click on a root menu
    which thus leads to a doAction
  - in the meantime, an RPC is done by the webclient to retrieve
    the (optional) default action of the user (if there is no
    state in the url, which is the case for tours in general)
  - when that RPC returns, this action (if any), or the action of
    the first menu is executed, thus leading to a second doAction
  - the ActionManager using a DropPrevious, the first doAction is
    dropped and thus the action linked to the clicked menu is
    never shown, making the tour fail

This rev. uses the state of the ActionManager's DropPrevious to
prevent the default action from being executed if another action
is already being executed, thus removing that race condition.

Note that this fix is temporary, as the community webclient is
currently being refactored.
2018-09-12 13:30:24 +02:00
Nicolas Lempereur 8e77632e58 [FIX] *mail_thread: don't modify modified help
The 'help' of window action is often fiddled with, adding thing before,
after or arround it.

For example in CRM leads, we add at the beginning "Click to add a new
opportunity" with an arrow towards the button, and after if there is a
mail alias: "All email incoming to * will automatically create new...".

But for crm.lead, hr.expense, sale.order this would not take into
account that the fiddled "help" can be edited, so if we edit 2 times
help in studio or backend action editing, we would get:

  Click to add a new opportunity
  Click to add a new opportunity
  Click to add a new opportunity
  [Original help content]
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...

And see several "arrows" towards the button (in enterprise the
additional ones are on same color background).

With this commit we do what is done in "mail.thread" by default which is
not fiddling with the `help` if has been fiddled before (if it contains
"oe_view_nocontent_create" class).

note: this is the 11.0 version of #26912

opw-1877663
closes #26911
2018-09-12 13:18:35 +02:00
svs-odoo f339ed6ff6 [FIX] web: avoid annoying xdg-open prompt
Due to the route beginning with 'test: ', it was interpreted like a
protocol and on some OS (ubuntu for example), a xdg-open prompt pops up.
So, the window looses focus and some tests will fail because of that.
2018-09-12 13:17:54 +02:00
Nicolas Lempereur 72d7dd8994 [FIX] *mail_thread: don't modify modified help
The 'help' of window action is often fiddled with, adding thing before,
after or arround it.

For example in CRM leads, we add at the beginning "Click to add a new
opportunity" with an arrow towards the button, and after if there is a
mail alias: "All email incoming to * will automatically create new...".

But for crm.lead, hr.expense, sale.order this would not take into
account that the fiddled "help" can be edited, so if we edit 2 times
help in studio or backend action editing, we would get:

  Click to add a new opportunity
  Click to add a new opportunity
  Click to add a new opportunity
  [Original help content]
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...
  All email incoming to * will automatically create new...

And see several "arrows" towards the button (in enterprise the
additional ones are on same color background).

With this commit we do what is done in "mail.thread" by default which is
not fiddling with the `help` if has been fiddled before (if it contains
"oe_view_nocontent_create" class).

note: for 10.0 up to not including 11.0 which is fixed by #26911

opw-1877663
closes #26912
2018-09-12 13:11:21 +02:00
Antony Lesuisse 0abae675e8 [FIX] base: improve rtlcss warning message with instructions 2018-09-12 13:04:21 +02:00
Romain Derie d7ea1030ab [FIX] web_unsplash: row without container not taking all width in bs4
This commits add a container to make row full width, it also use bs4 classes to
make the content centered.
It also clean useless DOM.

Task-1878245 (chatter)
2018-09-12 11:30:19 +02:00
Romain Derie 4fb73a3de0 [FIX] web_editor: BS4 input group button height glitch
As an `form-group` can contains element having `form-control` class and other
not having it, we should not force height on `form-group` elements.

Typically, we could have:
div.form-group
  input.form-control
  button

Forcing height only on `form-control` will make the input thinner than the
button.
2018-09-12 11:30:16 +02:00
Goffin Simon 561ee39356 [FIX] sale_timesheet: Validating an invoice with timesheets
Steps to reproduce the bug:

- Go to  Timesheets > Settings and set Invoicing policy to “Approved Timesheets Only”
- Create a expensable product P with Type "Service", Invoice based on
“Timesheets on tasks” and Service Tracking “Create a new project but no Task”
- Create a new SO using P and confirm it. A project PR will be created
- Add a task TA to PR
- Add two timesheets(T1, T2) to TA, one for the current date(T1) and one for a future date(+1 month, T2)
- Go to  timesheets and  validate”  the timesheet T1
- Go to the SO and now the delivered_qty is equal to 1, so create the invoice I
- Validate I

Bug:

T1 and T2 were linked to I instead of just T1 (because invoice based on
“Approved Timesheets Only”)

opw:1879051
2018-09-12 11:08:56 +02:00
qsm-odoo 51f38a8466 [FIX] website: restore proper carousel options
We have JS which tooks care of customizing the color and background
options of .carousel elements so that the active carousel item is
edited instead. The recent snippet refactoring added those options on
.carousel-item elements directly, so that slide and carousel options
are separated in the customize menu. This however made the options
complex to use and some of them impossible to use. This also added color
and background options on non-snippet carousels like for the products in
the shop, which was not meant to be. This commit goes back to the old
system for now.

Note: using "[class*='s_']" as a selector to match snippets is not
correct as it matches the elements whose classes contains 's_'... and
in our case the body was matched because it has the class
'editor_ha*s_*snippets'. A proper way would be to use this selector:
"[class^='s_'], [class*=' s_']". But even then, this is not really a
good way.

task-1878245
2018-09-12 10:56:55 +02:00
qsm-odoo 1b4f317a08 [FIX] web_editor: BS4, do not suggest XS size for buttons
The XS size for buttons was removed in BS4. We lowered the size for
btn-sm though, so those are the replacement.

task-1878245
2018-09-12 10:56:55 +02:00
qsm-odoo 2041a61cac [FIX] website: use full width form for menu item dialog
This was always supposed to be full-width but this was buggy since
before 11.0.

task-1878245
2018-09-12 10:56:54 +02:00
qsm-odoo f1ccc4978b [FIX] web_editor: do not ask for link style during menu item edition
The menu item dialog is an extension of the link dialog where all the
.form-group elements which contain a .link-style option element are
removed. A new link style option was recently added but with the wrong
class, preventing it to be removed for the menu item dialog.

task-1878245
2018-09-12 10:56:54 +02:00
qsm-odoo 39a441e902 [FIX] web_editor: restore link dialog preview
By default, all btn colors are suggested in the link dialog (alpha,
beta, gamma, delta, epsilon, link, primary, secondary, success, info,
warning and danger). In lots of themes (and the default one), primary
= alpha and secondary = beta, which led to having two suggestion with
the same apparent color.

A new system was introduced to automatically remove the duplicates...
but this system also removed the button preview as it considered it to
be a duplicate.

This commit also adapts the preview to BS4.

task-1878245
2018-09-12 10:56:46 +02:00
jem-odoo 0cbf638730 [FIX] project: remove default group_by
When seeing the task of a proejct, we don't want to force
the group by stage on the list view.
2018-09-12 10:44:12 +02:00
jem-odoo 32700ebacc [IMP] hr_timesheet: remove calendar view for timesheet
The calendar view does not make many sense for timesheet. Moreover
recording timesheet from it is strange since there is no end date
on the timesheet model.
Removing this view avoids confusing for users.

Task #1883326
2018-09-12 10:44:12 +02:00
jem-odoo a01b5eb402 [IMP] *_timesheet: improve tests
This commit only improve timesheet tests, by adding
more assertions.
2018-09-12 10:44:12 +02:00
qsm-odoo 797442a024 [MERGE] portal, *: redesign portal screens
This commit redesigns all portal screens, improve bootstrap compliance
and increases maintainability. See sub-commits for details.

Closes https://github.com/odoo/odoo/pull/26849
2018-09-12 10:36:09 +02:00
Nicolas Martinelli a2acef42a0 [FIX] account: reconciliation models
The reconciliation models are not available in the Manual Reconciliation
widget. This is simply because they were not loaded.

opw-1878944
2018-09-12 10:24:24 +02:00
qsm-odoo 49923edc90 [FIX] portal: adapt tests to portal changes 2018-09-12 09:37:56 +02:00
qsm-odoo 545638c8f4 [FIX] portal: at least use background mixin for portal dark background 2018-09-12 09:37:56 +02:00
sri-odoo a56a476a97 [REF] sale, project: move edit button into portal top banner 2018-09-12 09:37:56 +02:00
sri-odoo 9aafeb8429 [IMP] portal: make fullwidth top banner
Add template that render a top banner. This box is intended
to be used to prompt system message, like links to the backend.
2018-09-12 09:37:56 +02:00
sri-odoo aac0f8e9fc [REF] website_crm_partner_assign: use template for 'opportunities' 2018-09-12 09:37:56 +02:00
sri-odoo 9dc300b467 [REF] project, hr_timesheet: use template for 'tasks' and 'projects' 2018-09-12 09:37:56 +02:00
sri-odoo 8ba6e3b0c3 [REF] sale(_management): review 'sale order' and 'quotation' templates 2018-09-12 09:37:56 +02:00
sri-odoo afdee7d67f [REF] account, account_payment: review 'invoice' design 2018-09-12 09:37:56 +02:00
sri-odoo 86ab1c55b4 [REF] portal: prepare single entry layouts (with and without sidebar)
Create single entry templates to be used in portal apps.
Add the ability to customize the bg-color for single entry pages
2018-09-12 09:37:56 +02:00
sri-odoo 084a162196 [REM] portal: js sidebar resize function
Not longer necessary, we'll use boostrap default classes instead
2018-09-12 09:37:56 +02:00
sri-odoo c78a2dbd8f [REF] portal, *: use a template for tables
Use a template in order to simplify maintenance and keep a consistent design
2018-09-12 09:37:56 +02:00
sri-odoo 1f946a2bec [REF] portal, *: move breadcrumbs in searchbar
* account, project, purchase, sale, website_crm_partner_assign

In some circumstances, we need to move the breadcrumbs into the
searchbar.
2018-09-12 09:37:56 +02:00
sri-odoo 5f71dad5e3 [IMP] portal, *: review home entries templates
* account, project, purchase, sale, website_crm_partner_assign

- Create a single template to be used for all doc's entry in order to
  simplify maintenance
- Make the entire entry clickable using bts4 classes
- Fix an alignment issue between title and badge
2018-09-12 09:37:56 +02:00
sri-odoo d5c66ca1fa [REF] portal: review 'salesperson' design 2018-09-12 09:37:56 +02:00
sri-odoo 7a419ec2c2 [REF] portal: review 'search/filters' toolbar 2018-09-12 09:37:56 +02:00
sri-odoo 60d837044a [FIX] base, portal: format address widget
Empty space were used to compensate the icons size.
Unfortunatly icons may have different sizes and the surrounding text
barely match the empty space provided, causing misalignment.
2018-09-12 09:37:56 +02:00
sri-odoo b1d5af2e6c [REF] portal: review main layout 2018-09-12 09:37:56 +02:00