Commit Graph
126133 Commits
Author SHA1 Message Date
jem-odoo a1572fe673 [FIX] hr_timesheet: bind format/parse method for timesheet_uom widget
The `timesheet_uom` is a fake widget: it is bind in field widget
registry on other existing widget depending on the session_info
preferences (e.i.: float_time, float_toggle, ...). Therefore, it
does not have formatter/parser methods in the field utils method.

This commit binds the formatter and the parser of the widget on which
`timesheet_uom` is bind, to make it coherent. This avoid having a
traceback on pivot view when the `timesheet_uom` widget is set on
a field node.
2018-09-19 14:10:42 +02:00
XavierDo 97dbdc418d [FIX] mail: keep update of subtypes in dropdown
Since saas-11.4 the subtype dropdown don't keep changes of subtype.

Before saas-11.4 the update was relying on the fact that the follower id
changes on each subtype edition. This is no longer the case.
The test is addapted to remove the hack simulating this behaviour.

The read_followers route is not called if no there is no changes
in the follower ids
https://github.com/odoo/odoo/blob/905e01921f3c3ef43ace6fc537d1d8c0d280002c/addons/mail/static/src/js/followers.js#L195
Leading to the follower list not being update

Note that the subtype update in dropdown was working fine after adding a
new follower: the read_followers will return a None as suptype when called
for a list of partner not containing the current user. Since the subtypes
was falsy, the render was not rendering the dropdown again, keeping
the value of the checkboxes. We can still create some inconsistency by
editing the subtype from the follower list. To avoid that a check is made
when updating subtypes after calling read_followers.

The chosen solution here is to keep the update on subtypes in memory.
This will avoid a call on read_followers to fetch information that we
already know, using the assumption that the operation was successfull
whish should be the case when a user edit subtypes on a record
he has access to.

Others solutions:
-force the call to read_followers with the current user, maybe by removing
it from this.follower after editing subtypes.
-call read_subscription_data explicitely

Obviously follower.js should be refactored to fix this a better way.

Task: #1886982
PR: #27093
2018-09-19 14:10:19 +02:00
qsm-odoo c12b472dba [FIX] website, *: review navbar color system
* web_editor, website_slides

Current system is styling all navbars with the user color. This was not
the expected behavior but it is in fact quite nice, so we decided to
keep it. There was however a problem: choosing the menu text color only
applied to the main navbar (as it was an xpath toggling the navbar-dark
class).

This commit solves the problem by forcing navbar-light to behave as
navbar-dark automatically if the menu background is dark, and this
without any JS or extra CSS rules. This allows to get rid of the menu
text color option.

This commit also reviews the light and dark colors which are used when
website is not installed.
2018-09-19 14:09:12 +02:00
qsm-odoo 2ca2b89485 [FIX] web: add missing report assets file 2018-09-19 14:09:12 +02:00
Toufik Benjaa d30fa83114 [FIX] payment: crash when validating a payment.transaction
- If a payment.transaction is already linked to an account.payment, the
  transaction validation crashes.
2018-09-19 14:08:00 +02:00
Thibault Delavallée e570c52f78 [MERGE] various: improve search filters, menu organizations and some labels
Impacted applications: crm (and dependencies), sale (and website_sale), point
of sale, accounting, purchase, base/mail, calendar, mrp.

This commit is related to task #1878516 and closes PR #26929 .
2018-09-19 13:25:10 +02:00
Pratima Gupta c788bc4190 [IMP] mrp: improve search filters
Specifications: improve search filters and groupby, reorder filters

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:18:35 +02:00
Pratima Gupta 840312a64f [IMP] calendar: improve filters
Specifications: remove unnecessary filters

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:18:30 +02:00
Pratima Gupta a4407f0a82 [IMP] base, mail: improve filters on partner model
Specifications: improve search filters and groupby, reorder filters

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:18:26 +02:00
Pratima Gupta a645d7d795 [IMP] point of sale: improve filters and labels
Specifications: improve search filters and groupby, reorder filters, update
some field labels.

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:18:23 +02:00
Pratima Gupta ac5b32cb75 [IMP] purchase: improve search filters
Specifications: improve search filters and groupby, reorder
filters.

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:18:02 +02:00
Pratima Gupta 5aad33098a [IMP] account, point_of_sale: improve menu, filters and search views
Specifications: improve menu organization, search filters and groupby, reorder
filters, update some field labels.

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:17:55 +02:00
Pratima Gupta 21e5198da1 [IMP] sale, website_sale: improve menus, labels and search filters
Specifications: improve menu organization, search filters and groupby, reorder
filters, update some field labels.

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:17:01 +02:00
Pratima Gupta 8eec468c19 [REF] website_crm_partner_assign: remove crm.lead.report.assign report
As all information present in this report can be found in the opportunities
dashboard this report can be removed.

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:17:42 +02:00
Pratima Gupta a6ad87a4d9 [IMP] crm and dependencies: improve menus, labels and filters
Specifications: improve menu organization, search filters and groupby, reorder
filters, update some field labels.

crm
===

Restructure the menus as
  * Sales
   * My Pipeline (default filter: My Opportunities)
   * My Quotations (default filter: My Quotations)
   * Team Pipelines (opens sales teams in kanban view)
   * Customers
  * Leads
   * Leads
   * Scoring Rules
   * Teams Assignation
   * Leads Assignation

sale_crm
=========

Change the parent menu for 'My Quotation' menu item as menus are changed in
sales:  crm.crm_menu_pipeline -> crm.crm_menu_sales

website_crm_partner_assign
==========================

Removed the menu and its action: crm -> Reporting -> Opp. Assignment
Change the menu sequence for crm -> Reporting -> Partnerships. Menu should
display as
  * Leads
  * Pipeline
  * Activities
  * Scoring Page views
  * Partnerships

This commit is related to task #1878516 and PR #26929 .
2018-09-19 13:17:01 +02:00
Sébastien Theys bb6813956e [FIX] base: fix "flex-direction: column" for wkhtmltopdf
This css rule is used notably by bs4 .card-deck. The fix is needed to make sure multiple cards inside a card-deck prints on a new line instead of overflowing horizontally out of the view.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 6cde21413c [IMP] sale: improve left menu and quotation builder
Adapt the left menu to correctly display each heading on a new line.

Always show the left menu navigation, especially on mobile where it is the most useful to quickly go below.

Remove unnecessary code from the quotation builder template.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 4decbcc55c [IMP] account,sale,web: use classes for section and note
Instead of using custom CSS.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 3ef1394806 [FIX] account,portal,sale: fix left menu borders
The menu wasn't correctly responsive. Now we always set the left and bottom border on the list elements, and remove them from the parent. This way the style will be correct even if the elements flex to the same line on some screen size.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 34c47eecd3 [IMP] various,sale: improve sign, pay and reject
Flow
====

Have one model field responsible of telling when the sales order has to be signed or paid to avoid inconsistencies.

The general rule is: sign & pay are only used upfront to confirm a sales order. If a sales person starts to modify (confirm) it manually, we don't need those features. Especially at that point pay should be done with invoices.

Modal
=====

For the sign, we want to force refresh the page to update its state, and thus we need to show the confirmation message on the reloaded page.

For sign and pay, we changed a bit the structure of the text in the modal to allow to translate it more easily. Also fixed the payment selection by moving it into the body instead of the footer.

For the reject modal, we want the feedback field to be required, so we can see in the chatter by who and why it has been rejected.

Misc
====

Moved remaining bits of code related to preview/pay/accept/decline from sale_management into sale, where it should have been in the first place.

Sales Order:
- Improved status/contextual alerts.
- Hide discount from small to fix responsive.

PR: #26801
task-1876864

remove sales help
2018-09-19 12:00:37 +02:00
Sébastien Theys 0a52493444 [IMP] sale: make signature responsive
PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys a92104c3a5 [IMP] sale: remove product image from sales order
We want to keep the image on the shop flow, but not on the final sales order document.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys a7f32c2649 [IMP] account,sale,website: improve buttons text and class
Website generic: change "edit to backend" class to match other menu dropdown items.

Invoice: add "back to edit mode" banner.

Sales Order:
- "Reject" in red, we really don't want the user to click it.
- "Accept & Sign" renamed to better convey the meaning and match the button on the popup.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys d50aa61cf7 [IMP] sale_management: prevent from archiving default template
This will prevent confusion from the user at a later time.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 4a1ad6f536 [IMP] various: rename electronic payment to online payment
To be consistent with "online signature".

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 78e51c429d [IMP] sale: improve demo, default data, and manifests
*** Activate pay and sign, as well as quotation template, by default when using demo data.

Previously, the features would show by default on runbot because they activated on installing modules.

Now that they are settings of sale_management, we need to specifically activate them for demoing. However we don't want them for on-boarding.

*** Remove the default template from sale_management, move it into sale_quotation_builder

The default template was useless in sale_management because it was empty: it was previously a required field, which is not the case anymore.

It was only filled and used in sale_quotation_builder to display an example quotation, which is why it is now moved there.

*** Update manifests

Fix category of sale_quotation_builder and slightly improve its text.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 83f9ef9059 [FIX] account,web: fix invoice iframe height
a7a89f3174 introduced a change that broke the invoice iframe.

The #wrapwrap corresponds to the client body, therefore the container must be inside it, and the scrollbar will now be on it instead of on the iframe body.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
Sébastien Theys 36d1b456d2 [IMP] portal,various: factorize "back to edit mode"
The same code was duplicated in several places. This commit creates a single template for it.

PR: #26801
task-1876864
2018-09-19 12:00:37 +02:00
jem-odoo a2456b20e9 [FIX] hr_timesheet: create project with allow_timesheet checked by default
The default value when creating a project is true for 'allow_timesheet'
field. This will automatically create an Analytic Account (if not
provided). However, the old onchange reset the allow_timesheet to false
if no AA was given, which is a contraction with the expected behavior
on project creation. But, we might want to uncheck 'allow_timesheet'
when we remove the AA on an existing project (Users can not log
timesheets without an active analytic account).
This commit fixes the erasing default value on creation by checking
the record is currently existing in the database.

Task #1886691
2018-09-19 11:35:06 +02:00
jem-odoo 8e875f58cf [IMP] hr_timesheet: move demo data
For people having only hr_timesheet installed, it could
be cool to have the hourly cost per employee set on some
demo data.
2018-09-19 11:35:06 +02:00
jem-odoo 4739d6067d [FIX] sale_timesheet: avoid access error on recomputing invoice_type 2018-09-19 11:35:06 +02:00
SimoRubi 05f1a7886c [FIX] project: project does not have hierarchical structure anymore
The action is not used anywhere but was not working

Closes #27034
2018-09-19 11:32:44 +02:00
Nicolas Martinelli d3ee7a7a15 [FIX] sale_mrp, sale_stock: procurement qty of kits
- Create a BOM kit for product F with:
  2 Unit(s) of A
  1 Unit(s) of B
- Create a SO for 1 Unit(s) of F, confirm
  => a picking with 2 Unit(s) of A and 1 Unit(s) of B is created
- Modify the Ordered Qty to 2 Unit(s)

The picking is not updated.

This is because `_get_qty_procurement` wrongly computed the product
quantity based on the moves' quantities. This is not correct since the
moves are for products A and B, not product F.

At this point, it is not possible to make sure of the real procurement
quantity. therefore, we use a very simple approach: we compare the sold
quantity before and after modification, and return the difference.

opw-1881227

closes odoo/odoo#27064
2018-09-19 09:27:17 +00:00
Nicolas Martinelli 8a88bbeb8b [FIX] website_forum: translate the welcome message
opw-1884718

closes odoo/odoo#27273
2018-09-27 09:04:53 +00:00
qsm-odoo 66d3783428 [FIX] website: add correct ID on demo pages container
closes odoo/odoo#27244
2018-09-26 16:13:49 +00:00
Christophe Simonis 77849703a1 [MERGE] forward port branch saas-11.5 up to 197119a37d
closes odoo/odoo#27088
2018-09-19 09:12:38 +00:00
qsm-odoo fa12ae4009 [FIX] website_theme_install: fix the enable_view method
The method failed to enable views which were created by copying a
theme.ir.ui.view. This is because standard views were found with the
'ref' method while those particular ones were found thanks to the
copy_ids field... which only found the already active ones by default.
2018-09-19 10:24:35 +02:00
qsm-odoo 3ecf2fbc7e [FIX] website_theme_install: review customization dialog message
The priority was set to a low value while it was meant to be a high
value. Indeed, we want that if that template is active, the customize
modal is emptied no matter what, so it has to be called last.

This is to have an understandable behavior if our code fails to mark the
template as inactive on a theme installation. With this commit, the
customization dialog will be empty. Without this commit, it gives an
error which can lead to think we made a mistake writing the theme's own
customization dialog while it was in fact inheriting from an emptied
dialog.
2018-09-19 10:24:00 +02:00
qsm-odoo 1c946f79fc [FIX] website: review customize modal definition
- Remove theme specific parts and move them in theme_common
- Use IDs to ease theme overrides
- Use the same convention for all options: the default one is not bound
  to any xml_id (that's just the default scss files)
2018-09-19 10:23:29 +02:00
Pratima Gupta 197119a37d [FIX] mrp: add missing space in warning message
opw-1886349
Closes #27053
2018-09-19 09:46:54 +02:00
Nicolas Martinelli b9473c09c6 [FIX] account, sale: Intrastat delivery address
Forward-port of fix 034e1d37d9
Since there is not link module between `sale` and `account_intrastat`,
we use a common method in `account.invoice`.

opw-1878590
2018-09-19 08:07:50 +02:00
David Arnold 453f957d8d [ADD] point_of_sale: js test for 2m fp 2018-09-18 21:18:46 +00:00
David Arnold 202ed1bf7d [IMP] account: add fp2m unit test 2018-09-18 21:18:46 +00:00
David Arnold bc71e85c9f [FIX] point_of_sale: align with backend fp mapping
The backend allows to map one source tax to various target taxes. The POS
diverged from this behaviour.

This commit alignes the behaviours and lets the point of sale handle mapping
to multiple taxes the same way the backend does.
2018-09-18 21:18:46 +00:00
Aaron Bohy 66c716d781 [FIX] *: adapt calls to _is_superuser
Rev. 2f7c03d added a second admin user (id 2), the 'human' one, on
top of the 'technical' one (id 1, also known as the superuser).
Basically, all calls to _is_superuser() should have been changed to
_is_admin(). They weren't. As a consequence, some features that
were previously available for the admin weren't anymore (e.g.
tours).

This rev. replaces all calls to _is_superuser() by calls to
_is_admin().
2018-09-18 20:31:28 +02:00
Martin Trigaux 952889c056 Revert "[FIX] account don't make administrator part of account users group by default"
This reverts commit e2c28ed3d6.

This commit was making the reconciliation test fail
2018-09-18 18:33:32 +02:00
Toufik Benjaa 968f16dd30 [FIX] payment_ogone: set payment done with 3ds in pending mode
- When receiving a 3DS payment notification from Ingenico the payment
  transaction should be set to "pending" and not in "done".

  Then a second notification is send by Ingenico to set the
  payment.transaction to "done".
  This is the reason for accepting "pending" as a valid state on the
  feedback validation.
2018-09-18 18:14:10 +02:00
Alexandre Kühn 95331042f1 [FIX] web: do not re-render app menu on every app click
This was necessary because the rendering was always determining
which app item should have the class 'active'.

This was an issue with the 'Click Everywhere Test': at the beginning
of the script, it gets the jQuery element that matches all nodes
`a.o_app` in the app menu. When an app item is clicked, it re-renders
the whole app menu, so that older referenced nodes are detached from
the DOM. As a result, clicking on them no longer works, because it
never triggers the MouseEvent `click .o_app`.

This commit fixes the issue by rendering the whole app menu once.
When an item in the app menu is clicked, it dynamically changes
the `active` app.
2018-09-18 18:12:03 +02:00
Odoo Translation Bot 53908da50c [I18N] Update translation terms from Transifex 2018-09-18 18:08:33 +02:00
Martin Trigaux 1421949c67 [FIX] tools: import translation file without pot
Due to fccfd36 and 4ba7fbb the translations were only imported, considering the
.pot as the reference.

During import or a manual csv or po file, there is no pot file.

Add tests with Klingon and Dothraki

Fixes #27044
2018-09-18 18:02:19 +02:00