Commit Graph
5 Commits
Author SHA1 Message Date
Christophe Simonis 70d0148d0d [MERGE] forward port branch 11.0 up to fbfb91799e 2018-08-21 16:58:17 +02:00
Nicolas Lempereur ac1e187eea [FIX] document: no query attachment out of form view
Since cce70fd4 the attachment menu is only displayed for form view.

But if in another view there is active_ids (eg. selecting record in a
list view), we will still make a query to ir.attachment without using
the result.

Without the code change, the added test would fail when doing a
search_read RPC call to ir.attachment model.

related to #26213
2018-08-17 15:33:40 +02:00
Kirti Choudhary 80118dd8a2 [IMP] document: added QUnit testcase
note: backport 562d467 from saas-11.2 to 11.0 to add a similar test

related to #26213
2018-08-17 15:33:40 +02:00
Aaron Bohy 32b8cec536 [REF] web,*: ActionManager/ViewManager refactoring
This rev. is the first part (out of 3) of the refactoring of the
ActionManager and ViewManager layer of the webclient.

The main changes are:
  - there is no ViewManager anymore, its work is now handled by the
    ActionManager itself, but isolated in a specific file ; this
    eases a lot of things, as the breadcrumbs handling for example.
  - the ActionManager code is converted to the new coding principles
    and guidelines ; mainly, children widgets communicate with it by
    triggering events up, and not by function calls anymore.
  - the ActionManager layer is now testable, and a lot of tests have
    already been written.
  - the code in other addons has been adapted consequently.

What's coming next:
  - introduce the 'AbstractAction' Widget, and make client actions
    and view controllers inherit from it ; this widget will
    implement a common API that could be used uniformly by the
    ActionManager (e.g. restore(), canBeLeft(), renderButtons(),
    getTitle()...).
  - move the ControlPanel handling from the ActionManager to the
    AbstractAction.
2018-01-16 20:49:19 +01:00
Kirti Choudhary 562d467b52 [IMP] document: added QUnit testcase 2017-10-19 16:58:06 +02:00