Commit Graph
111138 Commits
Author SHA1 Message Date
qsm-odoo c44578ee1a [IMP] web: improve qunit logging and config
When a qunit test fails, the log only contains the assertion message.
This is in fact useful to have the "actual" and "expected" values to
understand the bug.

Also, we recently updated the configuration so that the "hide passed
tests" option is enabled by default. This is in fact useful to have
it disabled if the user wants to run only one test (debugging).
2017-05-11 10:39:06 +02:00
qsm-odoo ac7da497a2 [REF] web: form_tests.js was wrongly indented 2017-05-11 10:39:06 +02:00
Aaron Bohy 067815f97d [FIX] purchase: sort order_line by sequence
Commit 9d4efc8 added the sequence field on model
'purchase.order.line' and added this field in the
tree view (with 'handle' widget), to allow to
re-order the purchase order lines in the purchase
order form view.

However, for this to actually work, the default order
on the model should be on sequence field, otherwise
the rows will still be ordered by id even if the user
changes their sequence value by re-ordering them.
2017-05-11 10:15:10 +02:00
Thibault Delavallée a60b3b6c8c [MERGE] various: be fussy on report names
Report naming has been recently updated at commit efdb5373c3 . However
some people, same kind of people who cannot walk on two stone steps at
a time or have to put their pens parallel on their desktop, thought
another step could be done in order to have the same convention of naming
for every report. Convention for report naming is now "<report name> -
<object name>".

This commit also improves the RNG validation of report tag in order to
be able to directly put print_report_name into the report declaration
instead of having to define it in a separate ir.actions.report.xml node.

This merges remote-tracking branch 'dev/master-report-name-youpie'.
2017-05-11 10:00:44 +02:00
Géry Debongnie c31bf95e4e [FIX] pad: make it work with the new views
The pad widget was partially updated to the new views, but was no longer
working.  In this commit, we rewrite the widget to make it work.

Note that we did some functional changes:
- we do only one rpc to check if the server is configured. the result is
  stored on the prototype, so we do not need to do it again
- we do some rpcs with shadow: true, so we will not stop the rest of the
  ui if the server is slow to respond
- we display a loading message in readonly, when the content is not
  loaded yet.
2017-05-11 09:53:10 +02:00
Géry Debongnie 33710d540c [FIX] web: small fixes in test framework
We fix in this commit three small issues in the test framework.

1. throw an explicit error when we try to do a fieldviewget in the mock
server with a model that does not exist.  This will make it easier to
figure out what went wrong when copy pasting a test from one file into
another, and forgetting to change the model in the createView parameters

2. wrap the result of special methods in the mock server in a deferred,
so we can simply return a value when using that functionality.  Also, it
is more consistent with the rest of the mock server

3. for iframes, we no longer change the src attribute to #test:url.
This had the problem of actually loading the page.  Instead, we change
it into about:blank and we copy the old url into the data-src attribute for
reference.
2017-05-11 09:53:08 +02:00
Olivier Dony 7dc2ed94c3 [MERGE] Forward-port 8.0 up to e0014387 2017-05-11 09:05:32 +02:00
Olivier Dony e0014387c5 [FIX] report: always close pdf files after merge
If an exception during the merges (such as a file descriptor overrun), we
would otherwise depend on the next garbage collection to close the
files. But the next GC may never come.

For example if we ran out of OS file descriptors during merge, all future
requests will crash for the same reason, and the process will never recover
because the GC will never run.

Much easier to explicitly close the files all the time.
2017-05-11 09:01:12 +02:00
Olivier Dony 3978713996 [FIX] mass-mailing: unsubscribe even when archived
A record (Partner/Lead) that was archived can still be unsubscribed.
2017-05-11 09:00:44 +02:00
Aaron Bohy 4e8e546ed7 [FIX] web: DebugManager: open view: search and qweb views
can't be opened that way.

For now, only views that can be opened with a view manager are
supported, i.e. views like form, list, kanban, graph...

So this fix filters out the views of type qweb and search from the
list.
2017-05-11 08:52:24 +02:00
Jérome Maes 527d639148 [MERGE] hr_timesheet_sheet: remove the module
This module is buggy and unusable. The goal is to
simplify timesheet flow.
New validation flow is bring with timesheet_grid
(enterprise edition ....)

These commits provides adaptations and removal
of hr_timesheet_sheet.
2017-05-11 08:36:59 +02:00
Jérome Maes af00486791 [REM] hr_timesheet_sheet: kill the module
Remove the module, since we deprecate complex
sheet management.
2017-05-11 08:36:11 +02:00
Jérome Maes cfe1b2e371 [IMP] project: change planner link to hr_timesheet_sheet 2017-05-11 08:36:11 +02:00
Jérome Maes 2e251f7599 [IMP] hr_timesheet_attendance: remove timesheet_sheet dependency 2017-05-11 08:36:10 +02:00
Thibault Delavallée 00d5a2f039 [IMP] inventory related addons: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .

Improve report naming in product, stock, mrp and mrp repair.
2017-05-10 17:16:09 +02:00
Thibault Delavallée b380347b0b [IMP] hr related addons: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .

Improve report naming in hr_attendance, hr_expense and hr_payroll.
2017-05-10 17:16:09 +02:00
Thibault Delavallée 0e9d397978 [IMP] event: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .
2017-05-10 17:16:07 +02:00
Thibault Delavallée ad2ccbbb59 [IMP] account related addons: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .

Improve report naming in sale, point of sale, l10n_ch, purchase,
purchase requisition, report intrastat, website_quote
2017-05-10 17:15:02 +02:00
Thibault Delavallée 3a52e5e5c9 [IMP] import, report: allow print_report_name when defining a report
Otherwise you have to have another xml block just to define the print
report name instead of doing everything in the report tag.
2017-05-10 17:10:04 +02:00
Thibault Delavallée dbe6aa4292 [FIX] account: finally allows to reinit the module
Otherwise a constraint is raised because new line are added to the
payment term instead of recreating them from scratch. This constraint
blocks people from reinitializing the module, which is quite boring
when developing.
2017-05-10 17:09:29 +02:00
Haresh Shyara 29d108601f [IMP] project_issue: change description field type into html
Because task has an html file and issue was jealous. And also to have
clickable links.
2017-05-10 16:53:04 +02:00
Juan Jose Scarafia 53dfb12394 [FIX] sale: deposit product with multiple company taxes
When creating a down payment for a SO, the applied taxes must
be the taxes of the company order. In this way, it's the same behavior
as a product with multiple taxes is added on a SO, only the order company
taxes are applied.

opw:741958
2017-05-10 16:38:48 +02:00
David Monjoie e1edd62320 [FIX] web: toggle checkboxes when clicked in editable list view
Previously, the checkbox was not checked when it was clicked in
editable list view, it only opened the row but did not check the
checkbox.
2017-05-10 15:20:03 +02:00
Goffin Simon 508e5ed9dd [FIX] stock: PO line with unit_price = 0 and cost_method = 'real' or 'average'
Let's consider the stockable product P with an internal category set
with cost_method = 'real' and 'average'. When creating a PO with P
and a unit_price=0, after delivering the product, the cost transfered to
the stock valuation account  was equal to the product cost multplied by
the product quantity instead of the unit_price set on the PO multiplied
by the quantity.

PS: The quant is created with the stock.move in _quant_create_from_move and the unit_price
set on the stock.move is taken with function get_price_unit.

opw:740865
2017-05-10 15:14:57 +02:00
Goffin Simon a1aed26d52 [FIX] account: Payment cancelled when cancelling statement line
Steps to reproduce:

1. Create a payment of 999 with bank
2. Create a statement line of 1000 on bank journal
3. Go to reconcile interface, choose the 999 line and make an adjustment of 1
4. The payment has been reconciled with the statement line, and one new journal
entry has been created for adjustment of "1"
5. Cancel statement line (you need to enable this functionality on bank journal)

Bug:The payment journal entry of 999 is deleted and payment remains confirmed

After the fix: The payment journal entry of 999 is UNRECONCILED and the payment
entry still exists.

opw:741619
2017-05-10 15:10:02 +02:00
Rohan Patel d797829fc9 [IMP] project_issue: move recently modified reporting views into views file 2017-05-10 15:07:08 +02:00
Rohan Patel 84e6f7b5c8 [IMP] project: update xml_ids of views not on report model anymore 2017-05-10 15:07:08 +02:00
Dhaval Suthar dcccb667bb [REF] project_issue: replace report by pivot / graph views
hr.recruitment.report is not necessary anymore as it can be replaced by
classic pivot and graph views on hr.applicant model.

Applicant has been slighty modified to ease reporting

 * adding group_operator average on both days to computation;
 * adding group_operator average on working hours computation;
2017-05-10 15:07:08 +02:00
Rohan Patel c0b2d51d00 [IMP] hr_recruitment: move recently modified reporting views into views file 2017-05-10 15:07:08 +02:00
Rohan Patel 446d834469 [IMP] hr_recruitment: update xml_ids of views not on report model anymore 2017-05-10 15:07:08 +02:00
Dhaval Suthar 956b9f88f7 [REF] hr_recruitment: replace report by pivot / graph views
hr.recruitment.report is not necessary anymore as it can be replaced by
classic pivot and graph views on hr.applicant model.

Applicant has been slighty modified to ease reporting

 * adding group_operator average on both salary fields;
 * adding missin delay to close computation on applicant;
2017-05-10 15:02:17 +02:00
fka-odoo 25411cfbd0 [IMP] payment_paypal: finally add a field to store PDT token instead of hidden configuration parameter 2017-05-10 13:57:02 +02:00
zeroheure 7a9d57bd1f [FIX] doc: various typos and missing words
Closes #16903
2017-05-10 13:54:21 +02:00
zeroheure 94f37fa9c8 [CLA] signature for zeroheure (Xavier Brochard)
Done at #16903
2017-05-10 13:54:21 +02:00
dbh 2df2af8a52 [REM] sale: Remove unused less rule 2017-05-10 13:33:36 +02:00
dbh 9ab421d99a [ADD] sale_management: Separate sales menu items from sale app
Purpose
=======

Don't display sales app icon in Odoo homepage when installing ecommerce (only website should be visible)
it's confusing to have sales icon  -> where do I manage my sales? In sales or in website? -> in website

Specfication
============

We need one new modules to add Sales menus to the homepage. Currently they come with "sale". So when installing "website_sale", we get them (because sale and account are dependencies of website_sale). We don't want that anymore. Along with that you need to replace modules in Apps menu:
sales menu items must be in the new sale_management module, no longer in sale

- create new app "sale_management"
- Currently 3 app icons when installing ecommerce (Sales, Invoicing, Website) -> too many icons, where to start? -> GOAL: Only 2 icons > Website, Invoicing
- new module to display Sales Icon (like account_accountant): "sale_management"
- move menu items to sale_management
- sale, sale_management: move app description, rewrite the manifest file
- sale, sale_management: move tour from sale > sale_management
- Changes in some dependency module "sale" > "sale_management" modules: event_sale, mrp_repair, pos_sale, report_intrastat, sale_crm, sale_expense, sale_stock, sale_timesheet, website_quote

Menu items to move 'sale' --> 'sale_management'
===============================================

Sales
	Quotations
        Sales Orders
Invoicing
	Orders to invoice
        Orders to Upsell
Catalog
	Products
        Product Variants
        Pricelists
Reporting
	sales
Configuration
	Settings
        Products -Attributes, Attribute Values, Internal Categories
2017-05-10 13:33:36 +02:00
Thibault Delavallée b1642f8710 [IMP] event: remove reply_to field
Events currently have a reply_to field that is purely informative. Indeed
it has to be explicitely taken into account when using mail templates and
is not used for setting classic reply-to of other messages.

This commit removes this field as it is simpler to have a standard
behavior as in all other addons. If a custom reply-to is required it
can be set on the mail template or using the mail composer.
2017-05-10 13:17:55 +02:00
Jigar Patel e7b71a4b21 [IMP] web_settings_dashboard: Add a Translations and a Company settings block
Add blocks on settings dashboard to:

- Load a translations
- Set up company information
2017-05-10 13:10:19 +02:00
Aaron Bohy e4e2735e87 [FIX] web_kanban: traceback when quickly drag&dropping
... records on models having a sequence field (e.g. project.task).

When a record is dragged and dropped, the following RPCs are done:
 - write (the new group id on the moved record)
 - read (the moved record)
 - resequence (the column where the record has been moved to)

To perform the resequence RPC, we need to retrieve the list of ids
of the records being in the column. We do that by iterating over
the cards in the column and reading the id in their data attribute.

However, a traceback might occur if the resequence was triggered
exactly when the user was holding a record over the column being
resequenced, because jquery-ui creates a placeholder for the record
being dragged and dropped, and this placeholder doesn't have the
required data attribute.
2017-05-10 11:10:38 +02:00
Lucas Perais (lpe) ec3baa6027 [FIX] l10n_fr: fix description of taxes 2017-05-10 10:54:26 +02:00
Lucas Perais (lpe) 189b2b5ce2 [FIX] l10n_fr: remove exclusion of account_cancel
l10n_fr is compatible per se with account_cancel, although cancelling account moves is not the right or best practice in accounting anyway.
2017-05-10 10:45:26 +02:00
xmo-odoo fffaf735f5 [FIX] P3: list -> iterable builtins (#16811)
In Python 3:

* various builtins and dict methods were changed to return
  view/iterable objects rather than lists
* and the separate Python 2 view/iterable builtins and methods were
  removed altogether

This is problematic when using these items as list (which the happens
repeatedly in Odoo), but more viciously when iterating *multiple times*
over them (which also happens, which I've messed up multiple times while
writing this, and which is a pain to debug even when you've just created
the issue).

Convert all code using these to semantics-matching cross-version
helper functions to get the LCD behaviour between P2 and P3, and
forbid the builtins via lint.

issue #8530
2017-05-10 09:39:55 +02:00
Nicolas Martinelli 4e205b7549 [FIX] l10n_fr_hr_payroll: identification number
The field `ssnid` is used on the payslip. However, it is not available
in any view, therefore it is impossible to fill it.

We replace by the `identification_id`, which is the field commonly used
for identification.

opw-742204
Closes #16798
2017-05-10 09:39:35 +02:00
Martin Trigaux ecf3555dee [FIX] pad: bad reference to old menu
The configuration has moved.

Fixes #16828
2017-05-09 17:20:58 +02:00
Géry Debongnie 84187f972a [FIX] web: prevent view_dialogs from changing env
With this commit, we prevent view dialogs from changing the 'global'
environment in the view manager.  Here is how it could cause a problem:

* open a form view for a bill of material
* click on one of the component, it will open a form view in a dialog
  (and will change the environment with a wrong res_id)
* click on the many2one product -> it will open a new action in the
  background, and change the environment again
* click on the breadcrumb to come back to the bill of material: the view
  manager will try to restore the correct res_id (which is the wrong id
  from the component form view), the form view will do a read (when
  reloading the data), will get an empty result, will update its
  information with no data, then will be in a wrong state which means
  that the basicmodel will fetch a x2many with a wrong res_ids list
* boom
2017-05-09 17:03:30 +02:00
Martin Geubelle 136a119311 [FIX] web_editor: use new rpc system
Directly use `ajax.jsonRPC` makes it untestable as the RPCs can't
be mocked.
2017-05-09 15:19:00 +02:00
Martin Geubelle 0ac2d8f015 [FIX] web: add o_input class on m2o dialog input
Since the rev https://github.com/odoo/odoo/commit/250e716c3a12e88acb4a199b427dc47d4ec55d5d
the class `o_input` needs to be set on an input to correctly style it.
2017-05-09 15:19:00 +02:00
Nicolas Martinelli 3bdea9eb54 [FIX] account, account_tax_cash_basis: incorrect entry
- Activate multi-currency: EUR is main currency, USD is secondary
  currency
- USD currency rate is:
  1.2 on 2017-01-01
  1.5 on 2017-02-01
- Create a journal in USD (e.g. Cash)
- Create a tax with Cash Basis activated
- Create an invoice of 100 USD on 2017-01-15
- Register a payment of 100 USD on this invoice on 2017-02-15
- 4 journal entries are created:
  the payment itself
  the exchange rate difference
  the cash basis linked to the payment
  the cash basis linked to the exchange rate difference

The cash basis linked to the exchange rate difference should not be
created, it is not necessary. The amounts are already included in the
cash basis linked to the payment.

opw-728767
2017-05-09 15:13:29 +02:00
Akash Bhavsar 10eee18a04 [IMP] product,sale,...: Restructure Product Form
Purpose
=======

- product form is a bit disorganized with fields showing up at wrong place:
- inventory tab for services -> to remove
- subscription & events fields under Invoicing tab
- inventory tab is not structured
- invoicing and bill control fields are not grouped together
- etc.
2017-05-09 15:04:35 +02:00
Aaron Bohy 7e98e32959 [FIX] web: traceback when quickly clicking on back button
Before this rev., there might be a crash when the user quickly
clicked several times on the browser's back button. This crash
occurred in the code saving/restoring the scroll position of the
current action.

When clicking fast on the back button, several actions are
executed but don't wait for each other (those actions are triggered
by the hashchange event), so when it is fast, and mainly when the
appswitcher is involved, it may happen that we try to get the
scroll position of an action that isn't loaded yet.

opw~741814
2017-05-09 14:54:15 +02:00