Commit Graph
127250 Commits
Author SHA1 Message Date
Varun Raval 419c57a78b [IMP] snailmail, snailmail_account : remove menu in accounting
The purpose of this commit is to remove the menu for the snailmail letters in accounting.
They are accessible from technical settings since 53cdd68e7c

In addition, since 8f486db52d, the error management has been improved. So this commit makes all the fields in form view editable.

Task-ID : 1947066

closes odoo/odoo#32294

Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
2019-05-13 07:34:42 +00:00
Shreya Modi 28f465cff1 [IMP] project: add customer field on task kanban
To make the kanban view of tasks more readable, we now display
the customer name on kanban, if the customer is not present
then display the email_from.

task-1931168

closes odoo/odoo#31045

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-05-07 06:21:48 +00:00
Hetal Dhanak 7cc34885a1 [FIX] project: correctly align buttons on project kanban
Previously, footer buttons on the project's kanban were not
being shown properly due to improper CSS rules.

This commit fixes the issue by removing fixed width and evenly
distributing available space between the buttons.

Task - 1948176

closes odoo/odoo#33039

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-05-06 06:41:06 +00:00
Julien Castiaux 4ae4aed254 [FIX] web: load binary data in separate http req
The `read` done by `_fetchRecord` in `basic_model.js` expicitly set a
`bin_size: true` in the context. That context option tells the backend
to send the size of the binary payload instead of the payload itself
thus slim the response size. Frontend widgets are then responsible to
fetch the actual payload in a separated http req.

The `search_read` done by `_searchReadUngroupedList` didn't set the
context option thus all the binary fields were sent b64 encoded along
with the `search_read` response.

opw-1963842

closes odoo/odoo#33014

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-05-02 07:30:02 +00:00
mreficent e373f55d49 [IMP] base: make use of SUPERUSER_ID in ir.model.access
In case it is a different ID

closes odoo/odoo#33264

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-05-10 11:40:31 +00:00
Rishabh Jadia 3ace78f63c [IMP] mrp: MO printing not based on reservation
A MO printing was based on stock.move.line with the reserved lot/sn and
the pickup location. However in order to have stock move line, the MO
has to be reserved. Also a partial reservation would result with a print
that only contains the reserved product and the other product were
ignored. Since v12, the picking before manufacturing exist and the
picking operation display the same information than the current MO
report. The purpose of this commit is to only display the useful
information to the manufacture user (the product and the quantity he
needs). The location and lot should be in the PBM document.

It also remove duplicate information like print date which is already
present in the header.

Task id #1931811

closes odoo/odoo#31338

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-05-10 11:39:33 +00:00
mreficent 0632274451 [IMP] base: add hook to be able to hide more module categories
closes odoo/odoo#32662

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-05-10 10:21:44 +00:00
jbm-odoo 86c9ec91ae [IMP] sale_subscription: Change payment method popup
In payment dialog, add a button to manage payment methods.

closes odoo/odoo#33204

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-05-07 07:43:31 +00:00
Shreya Modi a375471bea [IMP] account : show type of tax in fiscal position.
On fiscal position, there is a mix of sales & purchases invoice
which makes it difficult to understand.

So display the type of tax on fiscal position and
improve the name_get so type must be translated.
also improve the default tree view of tax so it will display the
same on 'search more' of many2one.

Task-ID: 1943502
Closes: #32241

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-05-10 09:39:36 +00:00
Robot Odoo b48d47b806 [MERGE] digest, various: improve digest email layout and content
Purpose of this merge is to provide improvements in digest emails layout

- Added "Connect" button to connect to the database.
- Changed the messages count which will now only consider real messages and not notes, notifications etc.
- Fixed some margin , padding issues and minor message improvements.
- Added a tip for administration users which will be sequentially sent first to them.
- Moved recipients to a new tab.
- Changed to company's email as email author.
- Changed '>' to greaterthan and '<' to lessthan in default template. (according to updated Jinja2)
- In one of the tip, we are showing all kinds of users in the list. So, it was replaced with only internal active users.

Related to task 1918364

closes odoo/odoo#29599

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-05-10 13:06:06 +02:00
Jinal Patel 356e04a06d [IMP] mail: add default values coming from activity types when scheduling activities
Purpose of the commit is that in some cases people would like to add a
default user and a default description on their activity types. Those
default values will be propagated to created activities.

This commit adds fields to set the default description and default user on
activity type and propagate them through the various scheduling methods as
default values when the user did not give specific one.

Other usability improvements
* rename "Category" into "Action to Perform";
* change 'Other' value to 'None';
That way it is clearer that standard activities perform no action.

Related to task 1929742

closes odoo/odoo#30511

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-05-10 08:31:31 +00:00
William Henrotin 563eec5ece [IMP] mrp: workorder kanban view suitable for tablets
This commit adapt the kanban view of workorder in order to
set card more easily clickable on tablet

Task : 1940358

closes odoo/odoo#31230

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-05-08 13:59:39 +00:00
William Henrotin ca35f98c7f [IMP] stock: hide 'reserved quantity' column in receipt
A reception don't need any reservation. The column 'Reserved
Quantity' on picking are so useless

Task: 1940358
2019-05-08 08:03:36 +00:00
William Henrotin e28cc1775d [IMP] stock: supplier info view clean up
Required field should be asked before optional ones

Task : 1940358
2019-05-08 08:03:36 +00:00
William Henrotin 02e537e52e [IMP] mrp: rename 'raw material' by 'component'
Uniformity across all views

Task : 1940358
2019-05-08 08:03:36 +00:00
Robot Odoo f147fed9af [MERGE][IMP] (website_)sale: send and improve emails when payment is processed from portal or ecommerce
Purpose of this merge is to improve emails sent when confirming
sale orders. A new template is added that contains lines with image
for bought product to be used in eCommerce.

See sub commits and task for more details.

Related to task ID 1873634

closes odoo/odoo#33283

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-05-09 18:11:52 +02:00
Mitali Patel 74c5c00aff [IMP] sale, website_sale : improve emails sent on confirmation and payment
Purpose of this commit is to send the order and payment details email to user
when they purchase any order from ecommerce or when do the payment from
portal. Currently it was sending quotation mail when the payment is processed.
Now it send an email for quotation, and one email for sale confirmation that
may contain more detailed content if coming from website (eCommerce).

In sale

 * create new confirmation template and set the default template in sales
   settings;
 * when payment enabled in sales settings then display template option to send
   default confirmation mail when payment is processed or order signed;
 * add tool method to find the right template to use when sending the
   quotation / SO by email;
 * ensure email is sent everytime SO is confirmed;

In website_sale

 * add option in website setting in order, to set the confirmation mail
   template;
 * ensure email is sent everytime SO is confirmed;

Related to task ID 1873634
Linked to PR #28781
2019-05-09 14:58:21 +00:00
Mitali Patel b55b4a42a6 [REF] sale: get rid of 'Send email' context key
Purpose is to prepare improvements in emails sent in confirmation and payment.
A context key forcing email used only once in the code is removed. Method
used to send email is inlined. It allows to better understand flow.

Related to task ID 1873634
Linked to PR #28781
2019-05-09 14:58:21 +00:00
Barad Mahendra b12ab8008b [IMP] mail: improve "Pay Now" email notification layout
In mail custom layout template display 'best regards' and signature in email
only when user exists and is not odoobot.

Border-bottom style is also now white-listed in sanitizer in order to ease
customization of emails.

Related to task ID 1873634
Linked to PR #28781
2019-05-09 14:58:21 +00:00
Nikunj Ladava d0be25d277 [FIX] payment: fix error msg display
when we get an error while making the payment, it should be shown to the user.
But the message is not getting from proper dict, so it will break every time.

closes - https://github.com/odoo/odoo/pull/33231

closes odoo/odoo#33231

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-05-08 07:05:45 +00:00
Nikunj Ladava 0aefe72b77 [FIX] payment_alipay: improvement as per the current payment
No need of return URL as '/payment/process' will handle all the cases for payment.
use of _set_transaction_state as per the state of the transaction.

closes - https://github.com/odoo/odoo/pull/33231
2019-05-08 07:05:11 +00:00
Xavier Morel 2cc7f0dd49 [IMP] core: allow auto_install restriction on a subset of dependencies
Currently, auto_install is triggered when all dependencies get
installed, but there are cases where one would want such trigger on
only a subset thereof.

e.g. we want `website_sale_dashboard` to auto-install when
`website_sale` is installed. Currently, it requires `web_dashboard` to
also be auto-installed otherwise `website_sale_dashboard` would "wait"
for both dependencies to be explicitly installed before the
auto-install triggers. That's despite `web_dashboard` not being very
useful on its own. More generally this is an issue with technical
modules which need to be marked as auto_install so as not to block
e.g. bridge modules from automatically installing.

This change allows setting `auto_install` to a subset of `depends`:

* if auto_install is set to `False`, the module does not get
automatically installed (no change in semantics)
* if auto_install is set to `True`, the module gets automatically
installed if and only if all its dependencies are installed (also no
change in semantics)
* if auto_install is set to a list of dependencies, the module will be
installed when all *these* dependencies are installed, other
dependencies (excluded from auto_install) will be installed
alongside as a consequence
* auto_install can be set to an empty list, in this case the module
will always be automatically installed regardless of its
dependencies (and will force their installation).

So after this change, `web_dashboard`'s auto_install can be set to
`False` (such that it's not installed if no module defining dashboards
is installed) and `website_sale_dashboard`'s manifest can be edited
to:

'auto_install': ['website_sale']

possibilities:

# no automatic installation
'depends': ['a', 'b'],
'auto_install': False

# automatic installation if both a and b are installed
'depends': ['a', 'b'],
'auto_install': True

# automatic installation if both a and b are installed (explicit)
'depends': ['a', 'b'],
'auto_install': ['a', 'b']

# automatic installation if b is installed, a will get forcefully
# installed if it isn't yet
'depends': ['a', 'b'],
'auto_install': ['b']

# always automatically installed, will cause the installation of
# its dependencies even if they're not marked explicitly
'depends': ['a', 'b'],
'auto_install': []

Task 1851328

closes odoo/odoo#29431

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-05-07 11:44:26 +00:00
Martin Geubelle b9ec983571 [FIX] mail: first column width in activity view
The first column should have a minimum width to avoid the table to
resize when changing the domain for example.

Task 1894990

closes odoo/odoo#33273

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-05-09 11:23:53 +00:00
Priyanka Kakadiya b01ce6e7ef [FIX] mrp: add group for 'plan production order' server action
added group to hide a server action of 'Mrp: plan production orders' when 'work orders feature of settings is inactive'

before this commit:
when 'WO feature(group_mrp_routings)' is inactive it still displays 'Mrp: Plan production Orders' server action.

after this commit:
'Mrp: plan production orders' server action will display only when 'WO feature(group_mrp_routings)' is active.

task id - 1945291

closes odoo/odoo#33117

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-05-08 09:40:11 +00:00
Priyanka Kakadiya ac77a6ce8e [REF] base: handle groups for server action
Users may not do all actions bound to a model. We add the `groups_id` field
on `ir.actions.server` so that `get_bindings` can filter out unauthorized ones.

task id- 1945291
2019-05-08 09:40:11 +00:00
Parth Choksi 9e6cb6e62f [IMP] digest: active internal users in tip
One of the first tip is about using @ in chatter.
It should only take active internal users who already have logged in.
Currenly it takes all the users (eg: portal, inactive etc)

This commit will allow only internal users to be shown in the list.

Task-1918364
2019-05-07 07:04:34 +00:00
Parth Choksi 8776306e80 [FIX] digest: using greaterthan and lessthan builtins
Before this commit, when you send a digest template to the user,
the user would receive a blank mail(without any content).
And while rendering the template we were getting the following error:
jinja2.exceptions.TemplateSyntaxError: unexpected char '&' at 4039

This was due to the changes made in commit:
https://github.com/odoo/odoo/commit/a7ac71ed4404aa2630619c331d725f4f545626f8#diff-705145eec648d5ef61b7b4060ae96b9dR8
In this instead of using CDATA, there was a change of the field type to 'html' and thus there were issues of parsing for jinja.

Now after this commit, we will be using builtins of jinja:
 - 'greaterthan' instead of '>'
 - 'lessthan' instead of '<'

Task-1918364
2019-05-07 07:04:34 +00:00
Parth Choksi 52b4942525 [IMP] digest: improve the digest email layout
Purpose of the task is to improve the usability of digest email layout.

- Click on Connect button to connect to the database.
- Use same left padding in the header as in the section title.
- 2 decimal digits for monetary amounts, no space with currency symbol.
- Count real messages only, not notes or notifications.
- Add new tips for video tour.
- Moved recipients to a new tab.
- Changed email author to company's email.
- Some minor layout fixes.

Task-1918364
2019-05-07 07:04:34 +00:00
Olivier Dony e554ce345f [FIX] requirements: bump up jinja2 reqs
Recommended by GitHub's repository alerts.

We normally stick as close as possible to the version we depend
on in the official DEB packages. This in turn depends on the version of
Debian stable at the time of release - for 11.0 that would be Debian 9
(stretch) and thus Jinja 2.8 (with security backports).

However Jinja2 before 2.10.1 suffers from a few issues that could lead
to crashes of Odoo processes.

It seems it's worth an exception to our rule for pip users, similarly to
previous bump up at d2605bccdb.

closes odoo/odoo#32601

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-05-07 07:04:34 +00:00
Parth Choksi a6ee929bb1 [FIX] digest: tips will be displayed properly
Currenly in the digest when you send the template, tips are not being seen.

The reason for this is, we are getting tips from the context but we dont have it in the context.
Instead, we are fetching the tips by calling the compute_tips method and assigning it to 'tips'.

Hence, this commit will remove the usage of context to get the tips as we are getting it
from the method and not from the context.

Task ID: #1918364
2019-05-07 06:54:29 +00:00
Jalpesh Patel e524a25004 [FIX] digest: fix m2m typo that would not do whats expected
m2m ORM operation (4, id, _) was not correctly used, resulting in an
unexpected behavior. Instead of adding the record, it would add the record and
also the res.user(4,).

As that used is generally the public user, without an email address, that bug
would not be that critical but if that res.user(4,) does not exist (eg deleted),
then the code simply crash as it tries to read user 4 from db.

closes odoo/odoo#32425

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-08 09:30:41 +00:00
Christophe Simonis fef49061ea [MERGE] forward port branch saas-11.3 up to 4c61621efb 2019-04-08 19:52:29 +02:00
Thibault Delavallée ebba721130 [FIX] mass_mailing: fix statistic state computation
Replied / Bounced / Opened states should be computed prior to Sent state.
Indeed Sent is the default state once the email is sent. Then replied,
bounced and opened are states that happen after sending the email. It
is therefore necessary to re-order the state computation to correctly compute
the statistic state.

Related to task ID 1924711
Linked to PR #32496

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-08 12:39:41 +00:00
Thibault Delavallée b0491c4445 [FIX] mass_mailing: correctly find partner email in mass mailing
In mass mailing access to partners when performing a mass mailing has been
done in batch to speedup computation [1]. Emails are put into a dictionary
allowing to find back the email based on partner_id.

However the matching between the partner and its emails is done using a
shortcut using the current document ID as partner ID. It works when performing
a mass mailing on partners but fails when performing a mass mailing on models
having message_get_default_recipients not returning only emails. Currently
in saas-14 main models return only emails (crm, event, mailing contacts) but
other models may encounter issues (applicants, tickets).

This commit fixes it by correctly matching partner id and its found email.

Related to task ID 1924711
Linked to PR #32496

[1] See 65ed4553a5
2019-04-08 12:39:18 +00:00
Andrey Semko 986e405457 [CLA] signature for andriisem
closes odoo/odoo#32490

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-08 10:26:36 +00:00
Mohammed Mahgoub 8ac788adff [FIX] doc: Steps to install website theme in v12.0
Correct the instructions needed to install a website theme
In 12.0 the steps have changed

closes odoo/odoo#31886

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-08 12:41:14 +00:00
Mohammed Mahgoub 8f5a0d782f [CLA] signature for Mohammed Mahgoub 2019-04-08 12:38:15 +00:00
SimoRubi 6431e366a8 [FIX] web: call method with correct record
_compute_website_url can only be called on singletons
It should not be called with self but the record we are iterating on

closes odoo/odoo#32369

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-08 09:26:01 +00:00
Bohdan Lisnenko da28c37a4a [ADD] l10n_ua: Ukraine - Localization
One module with 2 chart of accounts:
- psbo (local)
- ias (ifrs rules)

We added the VAT taxes with tax groups.

Tags are already added for if we want to add
the VAT report later.

Closes #21402

closes odoo/odoo#32468

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-04-05 13:58:16 +00:00
Martin Trigaux 42530b02fe [FIX] web_editor: override fonts in reports
Fixes odoo/odoo#27487
Noto Color Emoji produces an error on wkhtmltopdf, cf
wkhtmltopdf/wkhtmltopdf#4149

In the backend assets, the $font-family-sans-serif is changed in
web/static/src/scss/bootstrap_overridden.scss

In the reports assets, the $font-family-sans-serif was NOT changed in
web_editor/static/src/scss/bootstrap_overridden.scss

The default boostrap fonts were still used in reports, ignoring the changes made
for backend.

closes odoo/odoo#32312

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-15 12:14:40 +00:00
Martin Trigaux 02a321cffb [FIX] web: use specific font for Arabic, Hebrew and Cyrillic alphabet
The basic font-family offered on Odoo do not support a large set of characters
and rely on the system fonts for non-latin languages
On a system without specific fonts installed, the characters were replaced by �
For Hebrew, the system sans-serif font (at least on Windows pc) was too small.

Rely on the unicode-range range CSS descriptor to load a font only for a
specific range of unicode code.
https://developer.mozilla.org/en-US/docs/Web/CSS/%40font-face/unicode-range
This way, the fonts are ignored for English text (and you don't have to load
the fonts of every possible language).

Add Noto fonts that covers many charsets.
There is an heavy version for many charset and lighter ones for Arabic and Hebrew
More ranges can be added later

Serve the fonts on our CDN to avoid shipping several MB of fonts for everyone
but lazyload it when needed.

Fixes odoo/odoo#32228
Fixes odoo/odoo#21781
2019-04-15 12:14:14 +00:00
Julien Castiaux 9ef33f4d43 [FIX] mail: File deletion on module uninstallation
PR #30798 introduced thread, message, and attachments deletion on a
module uninstallation. When removing attachments it was also removing
files in the filestore even if those files were still in use by other
attachments.

opw-1968117

closes odoo/odoo#32682

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-04-15 12:40:44 +00:00
Nicolas Martinelli 8906807669 [FIX] website: submit form
Example where the issue occurs:
- Publish an event
- Go to the website, register for that event
- At confirmation, when the email address is requested, click quickly
  several times on the 'Continue' button

Several registrations are created since nothing prevents multi-clicks.

The stateful button feature of the `button.js` jQuery plugin has been
dropped in Bootstrap 4 (see [1]).

[1] https://getbootstrap.com/docs/4.1/migration/#buttons

opw-1958580

closes odoo/odoo#32571

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-04-15 06:29:05 +00:00
Jorge Pinna Puissant b2d2668f85 [FIX] account: negative invoices in batch payments
Avoid the user to use batch payment with negative invoices (credit notes
or refund) and positive invoices (customer invoices and vendor bills).
This will create two different payment, one for the negative invoices
and one for the positive invoices, it will not partially reconcile them
before register the payment.

The normal behaviour is to add the negative invoice (outstanding debits
of the supplier or the customer credit notes) to the positive invoice
(vendor bill or the customer invoice), and after register the payment of
the balance.

opw-1959687

closes odoo/odoo#32250

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-04-10 12:21:42 +00:00
Alex Tuyls 49eb24a467 [FIX] account, sale_timesheet: access rights when validating invoice
When validate an invoice, if the user is member of the timesheet user
group and the billing user group, it is forbidden to create an analytic
line without a project set. The previous commit (81218a8) allow the user
to create an analytic account line by adding a record rule in the
sale_timesheet module.

If only the account and timesheet modules' are installed, before this
commit, an error was raised when trying to validate an invoice in the
account module. This issue occurs because the record rule to allow the
user to create an analytic account line is found in sale_timesheet
module, and this one is not installed.
As an invoice can be validated without the need of the sales module's,
from the purchase module, or directly in the account module.
In this commit, the record rule was move to the account module.

opw-1948132

closes odoo/odoo#31661

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-04-10 13:40:54 +00:00
Martin Geubelle 120359bf0c [FIX] web: restore handle and remove button width on list
Rev. odoo/odoo@9fbb4fb wrongly removed the fixed width on handle and
button width on list views.

This commit restores it.

closes odoo/odoo#32467

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-04-05 13:37:56 +00:00
Martin Geubelle cdd644befc [FIX] web: correctly update modifiers in editable list with buttons
Since rev. odoo/odoo@015958d it is possible to add buttons in list group
headers. These buttons are defined in <groupby> nodes, pointing to m2o
fields. Modifiers specified on these buttons thus use fields on the m2o
comodel.

There was a traceback in editable list view, when grouping by a m2o
that defines a groupby button with modifiers as the modifiers are not
registered with the same datapoint. When updating the modifiers, one
must ensure that the modifier are related to the updated record.

closes odoo/odoo#32456

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-04-08 11:23:24 +00:00
Aurélien Warnon b424aba504 [FIX] sale_product_configurator: remove es6 JS code
Task#1964518

This commit removes es6 code that was unintentionaly introduced
by the product configurator for better compatibility

closes odoo/odoo#32452

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-12 06:37:09 +00:00
Christophe Simonis 3fc2577c01 [MERGE] forward port branch saas-12.2 up to be3c981423 2019-04-11 19:27:36 +02:00
Christophe Simonis be3c981423 [MERGE] forward port branch saas-12.1 up to 636df25f21 2019-04-11 18:17:25 +02:00