Commit Graph
140847 Commits
Author SHA1 Message Date
Christophe Simonis e21ce71927 [FIX] board: use defined variable in newly added test
Oversight of previous forward-port
2018-10-16 19:14:19 +02:00
Christophe Simonis ef7b24eb75 [FIX] wbesite_sale_coupon: inherit to correct view
Adaptation of a0a811861332e34fb3ee0bcdedccfe7057685a5d to new version.
2018-10-16 19:02:17 +02:00
Christophe Simonis d23ddbd6ee [FIX] account: add missing field to view
This field is required since 1a99d22f19
2018-10-16 18:47:20 +02:00
Christophe Simonis 41bf8ce6d9 [MERGE] forward port branch 11.0 up to b29b545fe8 2018-10-16 17:53:26 +02:00
Nicolas Martinelli 60280e6bb1 [FIX] website_sale: image in carousel
Backport of https://github.com/odoo/odoo/commit/19255ee2604c196197b14427e2a4338604b11a8a

opw-1889960
2018-10-16 17:41:07 +02:00
Christophe Simonis 2532200c04 [MERGE] forward port branch 11.0 up to 263773c35f0 2018-10-16 17:26:16 +02:00
qsm-odoo a9f11fb477 [FIX] web_editor: properly remove all bg when choosing a bg color
The code which removed the background image of a snippet when choosing a
background color worked kinda by chance. Indeed, on the final click on
the color option, the snippet background-image was reset... to the
current background-image, which is none thanks to the color preview.
Unfortunately, in some themes, the gradient color option interferes:
the current background-image at a color choice is equal to the current
gradient, and thus, that gradient is being moved as an inline style.

The bug was introduced with https://github.com/odoo/odoo/commit/285d95e946e5a15139c961e30dbe3598e0d99f6a
(as, before, the background reset was done by simulating a click on the
'background: none' option item, which was removed).

Closes https://github.com/odoo/odoo/pull/27808
2018-10-16 13:32:23 +02:00
Aaron Bohy 7063c50924 [FIX] web: FieldMany2one: don't ignore tabindex in readonly
opw 1889710
2018-10-16 10:58:49 +02:00
Nicolas Martinelli b29b545fe8 [FIX] sale_timesheet: project overview
Complement of commit fc1ba68c6a

opw-1893397

closes odoo/odoo#27835
2018-10-16 08:31:56 +00:00
Lucas Perais (lpe) 6e28e4f26c [FIX] account: display partner.bank on journals
Before this commit, when accessing journals through the menu item
Bank Account, one was able to enter an partner.bank account number
But, in case the partner.bank already exsited, there was no way to select it
and a cryptic unicity constraint was raised

After this commit, one can select an account already existing

OPW 1884515

closes odoo/odoo#27840
2018-10-16 10:24:16 +00:00
Goffin Simon 84e3ae140e [FIX] purchase_requisition: System pick wrong operation type in Purchase Agreement
When creating a "purchase.requisition" record, the default Operation Type was
always the one defined in the company 1 even if the user was not in the company 1.

opw:1890190

closes odoo/odoo#27830
2018-10-16 07:55:56 +00:00
Goffin Simon 7bee068a0f [FIX] sale: Sale channels duplicate field
Steps to reproduce the bug:

- In CRM, create an new Sales Channel
- Go to Reporting/Sales Channels
- Click in the new channel on "Click to define a target"

Bug:

Two input fields called "Set an invoicing target" appeared in the new channel

opw:1889406

closes odoo/odoo#27781
2018-10-16 07:41:50 +00:00
Florent de Labarre 57d9f9ee32 [FIX] qty_invoiced is wrong if uom_id in invoice line is updated
closes odoo/odoo#27837
2018-10-16 08:34:56 +00:00
Lucas Perais (lpe) a7732bb839 [FIX] board: translate custom views according to current user
forward port of 62cbc5f

Have a user in English, put a sale report as "favorite" (pinned to dashboard app)
Change the user's language

Before this commit, the pinned view was in English (because it was recorded that way)

After this commit, the pinned view is in the user's language.

OPW 1890664
closes #27799
2018-10-16 08:12:48 +02:00
William Henrotin f652c8d1da [FIX] mrp: done workorder on multiple reserved move lines
Producing a manufacturing order on components with more than one unit
could leads to multiple move line reserved on this component. Marking the
workorder as done, in that case, will trigger an error saying "Cannot set
the done quantity from this stock move, work directly with the move
lines". Instead of setting the quantity done directly, this commit
uses the magical function _set_quantity_done() that manage the case
of more than one move lines.

OPW-1888780

closes odoo/odoo#27773
2018-10-15 13:20:52 +00:00
Joren Van Onder 6c42ca8a7b [FIX] point_of_sale: make card readers work again on payment screen
Swiping a credit card through pos_mercury no longer worked on the
payment screen.

3a74afd21e introduced some special code
in BarcodeEvents for mobile Chrome. This code relies on an invisible
input being filled in by barcode device. On the payment screen the POS
uses a keypress event handler on body to manage input. This handler
preventsDefault which stops the input from being filled in.

It's worth noting that this new approach in
3a74afd21e is not fully equivalent to
the original barcode events handler. Events are not redispatched, so
this effectively disables keyboard input on the payment screen (or
anywhere where it is used).

opw-1888466

closes odoo/odoo#27820
2018-10-15 21:05:17 +00:00
William Henrotin 939b022ebf [FIX] mrp: done workorder on multiple reserved move lines
Producing a manufacturing order on components with more than one unit
could leads to multiple move line reserved on this component. Marking the
workorder as done, in that case, will trigger an error saying "Cannot set
the done quantity from this stock move, work directly with the move
lines". Instead of setting the quantity done directly, this commit
uses the magical function _set_quantity_done() that manage the case
of more than one move lines.

OPW-1888780

closes odoo/odoo#27773
2018-10-15 13:20:52 +00:00
Nicolas Martinelli 121fb6f1e7 [FIX] stock: incorrect translation
The translation was not ported in saas-11.3 by Transifex.

opw-1889820
opw-1893527
2018-10-15 15:20:37 +02:00
Arnold Moyaux dd501bbe37 [FIX] stock: replenish infinite loop with production
Usecase to reproduce:
- Create a BoM for a product with route Manufacture
- Use replenish wizard in order to fill your stock

It traceback due to an infinite loop.
It happens because when the production order creates the raw
moves, it does not set a product template. However a default_product
template is in the context and is used as default value. So it creates
a raw move with the component as product.product and the production product
as template. Since they are related it will modify the product_tmpl_id
of the product.product. It result by having a component with the
finished product as template and it will use the same stock rules and
bom again and again.

This commit clean the context before running procurement rules.

opw-1890661
2018-10-15 15:05:56 +02:00
Christophe Simonis 900db95457 [MERGE] forward port branch saas-15 up to f026255f12
closes odoo/odoo#27792
2018-10-15 12:21:50 +00:00
Martin Geubelle 70560d1f11 [IMP] web: add showSearchInput option on ModelFieldSelector
The option `showSearchInput` has been added on the ModelFieldSelector to allow
the user to easily filter the displayed fields. An input is displayed in the
popover title.

The search method is fuzzy for optimal results.

closes odoo/odoo#27788
2018-10-15 11:59:33 +00:00
Yenthe V.G 9e3583fc87 [IMP] survey: remove debug statements
Leftovers from debugging

closes odoo/odoo#27768
2018-10-24 08:29:26 +00:00
Yenthe V.G d4f83da1c3 [IMP] hr_salary: add sheet to form views
Adapt xpath that was no longer working
Add name attribute on some missing groups

closes odoo/odoo#27340
2018-10-24 08:37:51 +00:00
Romain Derie 2876b216d2 [IMP] delivery, stock: reorganize stock.picking form view
This commit will avoid having the company_id and/or website_id field(s) alone
on the top right of the 'extra' tab if the `picking_type_code` is in `incoming`

task-1894793

closes odoo/odoo#28016
2018-10-23 09:17:33 +00:00
Aaron Bohy 03fe95d6af [REF] web: small refactoring pass on some web components
(mainly views and ActionManager)

- add missing docstrings
- fix typos
- correctly order functions and imports
- put functions in correct sections
- stop using 'event' as argument of handlers
- don't call handlers directly
- remove trailing spaces/tabs
- move module created in stable version to its own file
- follow js guidelines in general

closes odoo/odoo#28024
2018-10-23 10:56:12 +00:00
Christophe Monniez 3c59add416 [FIX] survey: fix sent_survey domain
survey.user_input type was renamed to input_type in 35a5db9.
This domain was forgotten and made the click_everywhere test fail.

closes odoo/odoo#28010
2018-10-22 12:53:45 +00:00
Christophe Simonis c9356a1096 [FIX] core: adapt forward-ported code after 4d581e26c2 2018-10-22 19:26:18 +02:00
Christophe Simonis 9dbb7d199c [MERGE] forward port branch 12.0 up to b81c2bce84 2018-10-22 17:57:08 +02:00
Géry Debongnie a8cec47c93 [IMP] assets: remove css files split
Before this commit, our asset bundles had a special behaviour for
bundles of type css: because of an old limitation in IE9, css files had
to be split to make sure they had less than 4095 rules per stylesheets.

Since we no longer support IE9, this code can be removed, which should
slightly simplify the bundle code, and should slightly reduce the number
of requests required to properly load odoo.

closes odoo/odoo#27933
2018-10-19 09:18:28 +00:00
Vincent Schippefilt 2b0642d09e [IMP] web: remove es5 shim
The library es5 shim was usefull for older browsers that do not implement
completely the es5 specifications, like IE9.

As we do not support browsers older than IE11, that fully supports all
the features of es5, the library has become useless.

Removing this library will remove a little bit of noise in the callstack
when debugging.

closes odoo/odoo#27877
2018-10-19 08:49:56 +00:00
Fabrice Henrion 9d7ad0fe54 [FIX] terminology
The last time when a user connected to Odoo is a different concept than the last time when a user authenticated to Odoo. I can authenticate once and connect many times afterwards (cookie/session).

closes odoo/odoo#27963
2018-10-19 08:02:17 +00:00
Robot Odoo b262dc7c1c [MERGE][REF] various: rename columns "type" to be more business oriented
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.

closes odoo/odoo#27722
2018-10-19 14:16:32 +02:00
Robot Odoo 64971170d2 [IMP] hr_*: Improve the search views for department fields
1 Display department on manager list views
==========================================

On the manager list views (Leaves/Allocations to approve), the department
is not displayed. Display it on these list views, but keep it hidden for the
employee views.

2 Allow to search employees on allocations
==========================================

3 Search on department and on children departments
==================================================

Currently when searching on a department (on the employee view for example)
we only retrieve employees from the specific department. It should return
all the employees from the department and also from its children
departments, like for partners or companies.

Adapt all the search view where a department field is used by
specifying a 'child_of' operator.

TaskID: 1892639

closes odoo/odoo#27902
2018-10-19 11:44:40 +02:00
mreficent 46b2fe4db1 [REF] hr_holidays: rename hr.leave.report type to report_type
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.
2018-10-19 09:13:15 +00:00
mreficent 35a5db92c2 [REF] survey: rename survey.user_input type field to input_type
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.
2018-10-19 09:13:12 +00:00
mreficent b70ccc45bd [REF] survey: rename survey.question type field to question_type
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.
2018-10-19 09:13:09 +00:00
mreficent 77e5e8b7ff [REF] base: rename ir.server.object.lines type field to evaluation_type
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.
2018-10-19 09:13:06 +00:00
mreficent fb7ac56d65 [REF] base: rename ir.logging type field to logging_type
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.
2018-10-19 09:13:03 +00:00
mreficent 529c1a2e28 [REF] fetchmail: rename fetchmail.server type field to server_type
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.
2018-10-19 09:13:00 +00:00
mreficent 4f9afa6a64 [REF] calendar: rename calendar.alarm type to alarm_type
Purpose of this commit is to rename type column to something matching the
the real business use of the field. That way it is easier to find and grep
in the code. It also lessens potential conflicts with type build-in python
function. It also lessens conflicts when using the field in JS as type
is a build-in attribute.

Renaming type column is a long-living issue. We choose to do it at the
beginning of the v13 development to catch errors as soon as possible.

This commit is linked to task ID 1896245. It is also a subpart of community
PR #27599.
2018-10-19 09:12:55 +00:00
lul-odoo b952e1a197 [IMP] hr_holidays: Display department on manager list views
On the manager list views (Leaves/Allocations to approve), the department
is not displayed. Display it on these list views, but keep it hidden for the
employee views.
2018-10-19 08:22:48 +00:00
lul-odoo d7b505f09b [IMP] hr_holidays: Allow to search employees on allocations 2018-10-19 08:22:26 +00:00
lul-odoo a086761848 [IMP] hr_*: Search on department and on children departments
Purpose
=======

Currently when searching on a department (on the employee view for example)
we only retrieve employees from the specific department. It should return
all the employees from the department and also from its children
departments, like for partners or companies.

Specification
=============

Adapt all the search view where a department field is used by
specifying a 'child_of' operator.
2018-10-19 08:16:55 +00:00
lul-odoo 584211b1c9 [IMP] hr_holidays: Update department on upcoming validated leaves
Purpose
=======

Currently if a department is modified on an employee, the department is
modified accordingly on the leave request if it still in 'draft' or
'to submit' states.

This should also be the case for confirmed leaves, if it is still planned
in the future.

Note: A test has been added for this specific use case.

TaskID: 1882544

closes odoo/odoo#27661
2018-10-19 08:04:51 +00:00
Robot Odoo ed322f76a2 [IMP] mail: Return a browse record in _track_subtype instead of xmlid
Purpose
=======

- A manager could want to follow only home working of its own department
- A HR officer could want to follow only sick leaves of all dpts.

We have to improve what people follow and how they follow it in the leaves module

Specifications
==============

Subtype on department
---------------------

In department form view, right now, people can follow approvals

Instead we should have some generic and specific subtypes depending on the leave type

For instance, a HR Officer wants to follow only sick leaves and a manager only home working

Following mechanism
-------------------

Remove first / second approval subtype differences
if a leave type is not linked to a specific subtype, consider only classic
people follow it (employee and assigned HR people / manager)

Link leave type to subtypes, with some by default (i.e. home working, ...), not mandatory

When creating a leave type, link it to the department to be able to
activate the subtype for only one department.

closes odoo/odoo#27620
2018-10-19 11:44:24 +02:00
TWA 398f0eb8e9 [IMP] hr_holidays: Define notifications by leave type
Purpose
=======

- A manager could want to follow only home working of its own department
- A HR officer could want to follow only sick leaves of all dpts.

We have to improve what people follow and how they follow it in the leaves module

Specifications
==============

Subtype on department
---------------------

In department form view, right now, people can follow approvals

Instead we should have some generic and specific subtypes depending on the leave type

For instance, a HR Officer wants to follow only sick leaves and a manager only home working

Following mechanism
-------------------

Remove first / second approval subtype differences
if a leave type is not linked to a specific subtype, consider only classic
people follow it (employee and assigned HR people / manager)

Link leave type to subtypes, with some by default (i.e. home working, ...), not mandatory

When creating a leave type, link it to the department to be able to
activate the subtype for only one department.
2018-10-19 07:52:41 +00:00
TWA e61286ecd4 [IMP] mail: Return a browse record in _track_subtype instead of xmlid
Purpose
=======

It's possible to gain some requests with returning a browse record instead of
an xmlid. It's also cleaner.
2018-10-18 13:07:30 +00:00
Gert Pellin 9e90817530 [FIX] point_of_sale : display discount on ticket
According to the setting set on the pricelist

More the discount_policy field from sale to product to be usable in point of
sale, even without sale installed

Task id: 1853454

closes odoo/odoo#27310
2018-10-18 06:09:03 +00:00
Yenthe V.G 83dee8e449 [IMP] hr: add sheet to employee tags form view
closes odoo/odoo#27332
2018-10-17 12:21:14 +00:00
Yenthe V.G ea4c27233f [IMP] mrp: add missing sheet to Productivity Loss form view
closes odoo/odoo#27329
2018-10-17 13:11:31 +00:00