'batch' and 'batch_size' fields are community fields and their
features are also in community so we moved the form view inherit
that add both fields in form from enterprise to community.
Task 1967745
removed move_id from view to prevent traceback.
added readonly and no_create attribute on account_id to be consistent with
form view.
Task-1974059
closesodoo/odoo#33269
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
After deep comparison between majors versions, it seems that
there is no breaking changes and this fix a lot of issues in
mobile.
e.g.:
Before this update, the validity date wasn't correctly formated
and the end user had to enter the right format himself.
Some users were blocked at the payment process.
The root cause for this issue is the inconsistent list of native
events triggered by mobile devices.
Note that this library is only used for acquirer forms (S2S Form
Template) when "Redirection to the acquirer website" is checked
(payment_flow == 's2s') in the acquirer configuration.
We are aware that this library is deprecated and should be replaced
in the future.
See https://github.com/stripe/jquery.payment
opw-1986545
closes#33356closesodoo/odoo#33376
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
This commit improves the performance of product expiry activities generation.
It also removes direct refs to activity types to ensure code stability in case of user deletion of system data.
The xml refs to activity types should only be used through mail methods to ensure fallback strategies can be managed in the mail module only.
closesodoo/odoo#33300
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The disconnected/connected notifications were broken due to changes in
the way the Notification template was loaded. We need it loaded in
assets as we cannot load it afterward if the server is disconnected.
This was broken by : https://github.com/odoo/odoo/pull/32793closesodoo/odoo#33252
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
There is now a default groupby for the linktracker
graph, it is grouped by country.
task-1961604
closesodoo/odoo#33181
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Reorganise the categories of the events sorting them by sequence.
Same behavior as "eCommerce Product categories".
task-1917687
closesodoo/odoo#32010
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Since the kanban module refactoring, the module technical name is most of the
time not visible in debug mode. Only module with a very short name leave enough
space for the technical name to be shown (completely).
We can now correctly see the technical name in debug. It will replace the
description (which is not really mandatory in such a mode).
Adding it in top of the description would've break the cell 'height pixel
perfect' looking, thus breaking the layout.
closesodoo/odoo#33374
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Purpose of this task is, some aspects of the CRM searchview
do not make sense with leads so remove those search filters.
add string="Lead" to the name quicksearch
remove partner_id quicksearch
remove lost_reason quicksearch
remove lead/opportunity, won filter as this is irrelevant to lead
remove stage,lost reason, conversation date, expected closing date as it is not related to lead
Task-1941642
closesodoo/odoo#32407
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit introduces the duration (time) units of measures, flagged as internation
unit of measure. We already have the "working time" UoM, but those ones are customizable
and might differ from the International System of Units; indeed, one working day means
8 hours (more or less) for some company.
The rational here is, when we are handling datetime, we need to get the UoM in the Odoo
System to convert the result; for instance, computing the difference between 2 datetimes
will return the number of days (or hours). But you need to match it with an odoo UoM to
extract informations from that value.
This unit of measure 'duration' is like a master data, because existing in the real world
and that many module will depend on.
Task-1971491
closesodoo/odoo#32840
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
This commit rename the measrurement_type 'time' into
'working_time' to be more precise, as time might means
duration.
This changes prepare the distinction between 'working time'
and international duration unit.
Task-1971491
Commit ca35f98 change the picking view but introduce an error by
calling 'self'.
closesodoo/odoo#33361
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
The lunch application works fine, but some usability points need to be
improved in order to have a smoother onboarding.
These include:
Making lunch location tree view editable, instead of having to use the form view
Auto filling partner details from vendor form
Fixing typos in various labels
Add a name field on lunch.alert instead of using the message as _rec_name
Adding a stat button on lunch category to see the associated products
Task 1942776
closesodoo/odoo#33091
Signed-off-by: Romain Libert (rli) <rli@odoo.com>
This commit changes the presentation of the "Create new course"
modal so that it is closer to what we have in backend
task id: 1978734
closes: #33119
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
Another purpose is to prepare blacklist and bounce management improvements
by improving blacklist mixin. It is now reflected on models and build on
top of mail.thread. It is renamed to mail.thread.blacklist to be coherent
with mail.thread and mail.thread.cc mixins.
Related to task ID 1911679
closesodoo/odoo#29483
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
* mail.blacklist.mixin now clearly make inheritance on mail.thread. Indeed
we consider models using the blacklist mechanism as being used in mailing
features, meaning they will anyway inherit form mail.thread. In standard
Odoo it is the case for the 3 models using it (Lead/Opportunity, Contact
and Mailing Contact);
* define message_bounce directly in mail.blacklist.mixin. Bounce counter
is indeed linked to the blacklist and mailing mechanism;
* rename mail.blacklist.mixin to mail.thread.blacklist to ensure coherency
with mail.thread and mail.thread.cc (another mixin build on mailL.thread);
Inherit declarations in various addons are updated accordingly.
Related to task ID 1911679
Linked to PR #29483
Like already done for some mail mixins
* mail.thread reflected on ir.model: see 1119fdd8a3c7fb0a18b348c4724d71eebf53a28e;
* mail.activity.mixin reflected on ir.model: see f48021846a2b54d84d4317b40fa7128f76c28d10;
We allow to reflect the mail.blacklist.mixin on ir.model in this commit. This
inheritance imply the mail.address.mixin to allow normalization of emails on
models using the blacklist mixin.
It is useful notably to clearly store this inheritance and also allow
future tweaking through studio to enable more advanced mail capabilities
to custom models. Blacklist is useful when dealing with mass mailing and
marketing automation.
It will also be used in mailgateway to find all blacklist-related models
in Odoo and update the blacklist accordingly to the bounce and error
management in the mailgateway. Those improvements will come soon.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_get_suggested_recipients as private. As it is
used in discuss JS we define a controller that controls access to this method.
It explicitly checks for related document access rule and rights before
calling the private method.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_receive_bounce as private. Future commit(s)
will probably rewrite part of the bounce logic.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_get_default_recipients as private. Its API
is improved to clearly separate model-inherited method (overriden in some
addons) and general tool method given by the mixin. Finally all sudo hidden
in the computation are removed. Caller now give a sudo-ed record set in order
to be more explicit. Low level method just computes the result and does not
care about sudo-ing or ACLs.
Note a model approach for this method is necessary as mass mailing using
mail.template records does not ensure records to check inherit from mail
thread.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_partner_info_from_emails as private. As it is
used in discuss JS we define a controller that controls access to this method.
It explicitly checks for related document access rule and rights before
calling the private method.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
With a settings added in the stock settings, it is now possible to
show the SN/LN for every product in an invoice.
To achieve this, we fetch every `stock_move_line` from the related SO,
then we keep only the returned and delivered moves. We then filter those
move lines using a range of dates, the starting date being the date of the last
invoice related to the SO, the ending date being the current date. Finally,
we compute de quantities delivered with every related sn/ln in order to show
them on the invoice.
TaskID: 1923220
closesodoo/odoo#33022
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Purpose
=======
Allow the user to select the allowed companies for which he wants to see records
on top of selecting his current company.
It is confusing for users to see the records from the company he is connected to
and the records of the children companies.
Instead of using the hierarchy of companies to access records across companies,
the user can now select (from his set of allowed companies) the companies for
which he wants to access records.
/!\ This means that the user will interact with records from company A when in
company B.
Example: a SO has been created and confirmed in A. When in B, I create the
invoice from it.
Specifications
==============
1/ Deprecate the parent/children hierarchy on the res.company model. The fields are
kept on the res.company model to ensure the retro-compatibility, but won't be used
accross the standard code anymore. The only functional usage for this mechanism
was to allow to see records from several companies by creating a virtual parent
company, which will be possible with the new mechanism.
2/ By default, a user will only see the records of the company he is connected
to (or records without a company). (It is still editable by the user if needed).
For that, put this information in the user context, to allow having different
configurations on different browser tabs. Instead of having domains like
['|',
('company_id', '=', False),
('company_id', 'child_of', user.company_id.id)]
you'll have something like
['|',
('company_id', '=', False),
('company_id', 'in', company_ids)]
Note that the 'company_ids' is a value that is passed in the evaluation
context on the record rule, as we already have user, or time.
company_ids is a list of the ids of all the enabled companies in the
user's context.
3/ Out of the generic improvements brought by this task, this will illustrate
issues that could exist since several versions. For example, it should not be
possible to create a scrap order for the company A with a package of the company
B, or it should not be possible to create an invoice on the company A with
payment terms from the company B. Before the version 12.0, it was easy to
encounter this kind of issues as the admin was the SUPERUSER_ID. A positive side
effect of the fact that the SUPERUSER_ID has become an inactive user was to
make it more difficult to introduce mismatch on the records, but haven't solved
the issue, as it was still possible to do it with parent companies
configuration. Some of these issues have been fixed in this commit, but all the
business flows should be re-tested to check if an ir.rule should be introduced
(eg: a multi company rule for stock.quand.package), if the company of a record
is correctly transfered to another record created from the first record (eg:
From a SO, create an invoice and a payment, the company of the sales order
should be transfered on the invoice and the payment, even if the company of the
sales order is A and I'm logged into the company B with the company A enabled.
4/ Currently, if I click on a button on a notification email (example 'View
Task'), I face a traceback if I'm not logged into the company of the record.
Now, if you click on a button and if you have access to the record, the correct
company will be automatically set.
5/ If I display a kanban view with several records from several companies (and
an image), all the images should be displayed.
6/ Currently if you copy paste an url, this will crash if you're not in the
correct company. This won't be fixed because it's quite impossible to do it in
a clean way. This task brings a workaround. Copy/Paste -> Traceback -> Log into
the correct company, re-copy/paste -> Ok.
7/ 2 property methods have been added on the environment to retrieve the company
on which the user is logged in and the companies the user enabled, on a specific
tab.
That way, when creating a record, instead of doing
default=lambda self: self.env.user.company_id
do
default=lambda self: self.env.company_id
On the other hand, to retrieve the enabled companies, do
companies = self.env.company_ids
8/ Modify the Company Switcher widget to allow to log into another company
WITHOUT writing on the res.users (and thus bringing cache invalidation issues
and so on). Also allow to enable several companies and see records from several
companies, and independantly of the other browser's tabs.
9/ When focusing on a tab, save the current company configuration on the local
storage. That way, when doing 'CTRL+T' or a middle click, the context is
propagated to the new tab.
10/ Improve the error message in case of multi company access errors. Now, when
the user is in debug mode, display the related names of the records and the name
of the user who brings the issue.
11/ Remove the context erasing when writing on a res.users
This is probably coming from the migration to new API of the base module.
The context was not propagated at this moment, which was a common mistake at
that time. When migrating the module, probably by using the 'black box' method,
as the context was not propagated, it was erased on the new version. This is
now an issue because the context (i.e. the enabled companies) was erased when
writing on a res.users, leading to tracebacks.
See: https://github.com/odoo/odoo/commit/7eab8e26d3d46c53f4be924d6a34e80a66e74960#diff-4c2e738ee8f64f11806c889ea097b5e7R624
12/ Fix the crash manager on redirect warnings. The issue is the following
- Create an invoice on a company without a configured CoA.
- Set a partner
- On the onchange_partner_id, a redirect warning is raised to propose you
to configure a CoA
- Click on 'Go to the configuration panel'
- A generic warning says something like 'Do you want to discard your changes?'
- Click on yes, the page refreshes, but not on the redirect action.
Now, set correctly the action on the hash, and reload instead. The breadcrumb is
lost for example, but you reach the correct action at least.
13/ Introduce a res.group to enable/disable the multi company per tab
feature.
14/ To help the users to know which tab is in which company, add the
possibility to have a favicon per company. When creating a company,
the classical 'O' icon is colored by default in a random color.
15/ Remove the company switcher on the frontend. This was mainly there
to allow a user to swicth to the company linked to the website.
This behavior is now transparent to the user. If the website A is
activated, then the company set on the context is the company of the
website.
16/ Deprecated the _company_default_get method on the res.company
model. Remove the method _get_company on the res.users model.
17/ Add 'allowed_company_ids' and 'current_company_id' on the pyeval
context. You can now use those variables on domains in the views to
access directly to the activated company.ies on the current tab.
TaskID: 1960971
closesodoo/odoo#32341
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, when trying to import a module, if there is an error
related to dependencies, it is not shown in a decent format. For
example, technical names of the modules are being displayed in
a single line, separated by comma.
This commit makes the dependency error message readable by
displaying short description of the modules (instead of
technical names), each on a new line.
task-1830483
closesodoo/odoo#33029
Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
The purpose of this commit is to remove the menu for the snailmail letters in accounting.
They are accessible from technical settings since 53cdd68e7c
In addition, since 8f486db52d, the error management has been improved. So this commit makes all the fields in form view editable.
Task-ID : 1947066
closesodoo/odoo#32294
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
To make the kanban view of tasks more readable, we now display
the customer name on kanban, if the customer is not present
then display the email_from.
task-1931168
closesodoo/odoo#31045
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
Previously, footer buttons on the project's kanban were not
being shown properly due to improper CSS rules.
This commit fixes the issue by removing fixed width and evenly
distributing available space between the buttons.
Task - 1948176
closesodoo/odoo#33039
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
The `read` done by `_fetchRecord` in `basic_model.js` expicitly set a
`bin_size: true` in the context. That context option tells the backend
to send the size of the binary payload instead of the payload itself
thus slim the response size. Frontend widgets are then responsible to
fetch the actual payload in a separated http req.
The `search_read` done by `_searchReadUngroupedList` didn't set the
context option thus all the binary fields were sent b64 encoded along
with the `search_read` response.
opw-1963842
closesodoo/odoo#33014
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
A MO printing was based on stock.move.line with the reserved lot/sn and
the pickup location. However in order to have stock move line, the MO
has to be reserved. Also a partial reservation would result with a print
that only contains the reserved product and the other product were
ignored. Since v12, the picking before manufacturing exist and the
picking operation display the same information than the current MO
report. The purpose of this commit is to only display the useful
information to the manufacture user (the product and the quantity he
needs). The location and lot should be in the PBM document.
It also remove duplicate information like print date which is already
present in the header.
Task id #1931811closesodoo/odoo#31338
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
On fiscal position, there is a mix of sales & purchases invoice
which makes it difficult to understand.
So display the type of tax on fiscal position and
improve the name_get so type must be translated.
also improve the default tree view of tax so it will display the
same on 'search more' of many2one.
Task-ID: 1943502
Closes: #32241
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Purpose of this merge is to provide improvements in digest emails layout
- Added "Connect" button to connect to the database.
- Changed the messages count which will now only consider real messages and not notes, notifications etc.
- Fixed some margin , padding issues and minor message improvements.
- Added a tip for administration users which will be sequentially sent first to them.
- Moved recipients to a new tab.
- Changed to company's email as email author.
- Changed '>' to greaterthan and '<' to lessthan in default template. (according to updated Jinja2)
- In one of the tip, we are showing all kinds of users in the list. So, it was replaced with only internal active users.
Related to task 1918364
closesodoo/odoo#29599
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of the commit is that in some cases people would like to add a
default user and a default description on their activity types. Those
default values will be propagated to created activities.
This commit adds fields to set the default description and default user on
activity type and propagate them through the various scheduling methods as
default values when the user did not give specific one.
Other usability improvements
* rename "Category" into "Action to Perform";
* change 'Other' value to 'None';
That way it is clearer that standard activities perform no action.
Related to task 1929742
closesodoo/odoo#30511
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit adapt the kanban view of workorder in order to
set card more easily clickable on tablet
Task : 1940358
closesodoo/odoo#31230
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Purpose of this merge is to improve emails sent when confirming
sale orders. A new template is added that contains lines with image
for bought product to be used in eCommerce.
See sub commits and task for more details.
Related to task ID 1873634
closesodoo/odoo#33283
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of this commit is to send the order and payment details email to user
when they purchase any order from ecommerce or when do the payment from
portal. Currently it was sending quotation mail when the payment is processed.
Now it send an email for quotation, and one email for sale confirmation that
may contain more detailed content if coming from website (eCommerce).
In sale
* create new confirmation template and set the default template in sales
settings;
* when payment enabled in sales settings then display template option to send
default confirmation mail when payment is processed or order signed;
* add tool method to find the right template to use when sending the
quotation / SO by email;
* ensure email is sent everytime SO is confirmed;
In website_sale
* add option in website setting in order, to set the confirmation mail
template;
* ensure email is sent everytime SO is confirmed;
Related to task ID 1873634
Linked to PR #28781
Purpose is to prepare improvements in emails sent in confirmation and payment.
A context key forcing email used only once in the code is removed. Method
used to send email is inlined. It allows to better understand flow.
Related to task ID 1873634
Linked to PR #28781
Arnold Moyaux