Commit Graph
140847 Commits
Author SHA1 Message Date
Sébastien Theys 45e3be94c0 [IMP] tools, base: removed unused image helpers
PR: #34925
2019-08-02 16:47:58 +00:00
Sébastien Theys 1e9772889b [IMP] *: use image.mixin when appropriate
The following models are already using big images, or they might need big images
in the future:

- partner
- hr employee
- shop category
- lunch product
- gamification badge and karma rank

PR: #34925
2019-08-02 16:47:58 +00:00
Sébastien Theys f0ffbea173 [IMP] *: remove unnecessary image sizes
The big images are probably never going to be used for the following models:

- pos category
- fleet brand
- livechat channel
- mail channel
- payment acquirer

And if big images are needed some day the model should use image.mixin instead.

PR: #34925
2019-08-02 16:47:58 +00:00
Sébastien Theys 1b85ab93ec [IMP] base, product, website_sale: move image zoom out of mixin
This field is not necessary on most models so move it to the few places where it
is needed to avoid computing it and storing it everywhere.

PR: #34925
2019-08-02 16:47:58 +00:00
Sébastien Theys 58a2ffa26f [IMP] *: rename image fields
image_original => image_1920 (now resized to 1920)
image_big => image_1024
image_large => image_256
image_medium => image_128
image_small  => image_64
image replaced by image_1920 (when writing) or by image_1024 (when displaying
	what was previously the big size)

+ add new intermediate format:
image_512

PR: #34925
2019-08-02 16:47:58 +00:00
Sébastien Theys 8206b5b4cc [IMP] fields: add image field
PR: #34925
2019-08-02 16:44:47 +00:00
Hardik Prajapati ec32fd5459 [FIX] account: traceback while creating Bank statement
Validate a bank statement from reconciliation widget and then open the statements view from the widget and try creating a new statement. An error happens when trying to select a partner because the default journal is not set in the action

closes odoo/odoo#35418

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2019-08-02 15:19:38 +00:00
mreficent aafc5f7821 [IMP] base: add external id in error message
The view name is often not very informative, add the external id for a better
error

closes odoo/odoo#29473

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-02 14:58:14 +00:00
Robot Odoo de4a945304 [MERGE][REF] utm, mass_mailing: improve and use utm.campaign
This merge removes the mass_mailing.campaign model. Instead of having a
fully fledged model, we will simply inherit utm.campaign.

This change implies that mass_mailing.tag and mass_mailing.stage move to
the utm model along their associated views/data.

These changes were made so that campaigns could be used in the future by
social, mass_mailing and mass_sms and available in the same view

This commit also removes the source_id and the medium_id fields on the
campaign. Indeed those depends on the flow, not the campaign (mass mailing
is a source, email is a medium for example).

In this merge we also add statistics from crm and sales to the campaign
model like what has been done for mass mailing previously.

Task ID: 2002029&
PR: #34015

closes odoo/odoo#34452

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-02 17:49:45 +02:00
qmo-odoo 01ec59b2e5 [REF] mass_mailing: Renaming 'mass_mailing_' fields to mailing
This commit renames the mass_mailing_ids and the mass_mailing_clicks_ratio
to mailing_ids and mailing_clicks_ratio. Indeed it is shorted and more
inlined with the new model names.

Task ID: 2002029
PR: #34015
2019-08-02 12:36:07 +00:00
qmo-odoo d716b53883 [REF] website_links: set is_website to True on the campaign
PURPOSE

This commit removes the mass_mailing.campaign model. Instead of having a fully
fledged model, we will simply inherit utm.campaign. We will also add relevant
statistics on utm campaign model in order to use it in various applications.

SPECIFICATIONS

This commit changes website_links.js so that, when creating a campaign,
the field is_website is set to true.

This will allow us to filter irrelevant campaigns in mass_mailing and social

Task ID: 2002029
PR: #34015
2019-08-02 12:35:39 +00:00
qmo-odoo 4f92430139 [FIX] mass_mailing_sale: fix domain for invoiced
PURPOSE

This commit removes the mass_mailing.campaign model. Instead of having a fully
fledged model, we will simply inherit utm.campaign. We will also add relevant
statistics on utm campaign model in order to use it in various applications.

SPECIFICATIONS

This commit fixes the domain used to get the invoiced amount generated
by the mailing.mailing.

The new domain will be the same as the one used in the invoice report

Task ID: 2002029
PR: #34015
2019-08-02 12:34:17 +00:00
qmo-odoo 682b62f825 [IMP] sale, utm: add sale statistics to utm campaign
PURPOSE

This commit removes the mass_mailing.campaign model. Instead of having a fully
fledged model, we will simply inherit utm.campaign. We will also add relevant
statistics on utm campaign model in order to use it in various applications.

SPECIFICATIONS

This commit adds revenue and quotations statistics on the
kanban and the form view of the utm.campaign

Kanban and form views will now display the invoiced_amount
and the number of quotations generated by the campaign.

TaskID: 2002029
PR: #34452
2019-08-02 12:33:56 +00:00
qmo-odoo f49d83f07d [IMP] utm, crm: add lead/opportunity stats on campaign
PURPOSE

This commit removes the mass_mailing.campaign model. Instead of having a fully
fledged model, we will simply inherit utm.campaign. We will also add relevant
statistics on utm campaign model in order to use it in various applications.

SPECIFICATIONS

This commit adds leads/generated statistics in the kanban and
the form view of the utm campaign.

Kanban and form views will now display the number of leads and
opportunities generated with the campaign

TaskID: 2002029
PR: #34452
2019-08-02 12:33:42 +00:00
qmo-odoo a661b00015 [REF] utm,mass_mailing: replace mass mailing campaign by utm campaign
PURPOSE

This commit removes the mass_mailing.campaign model. Instead of having a fully
fledged model, we will simply inherit utm.campaign. We will also add relevant
statistics on utm campaign model in order to use it in various applications.

SPECIFICATIONS

This commit removes the mass_mailing.campaign model. Instead of having a fully
fledged model, we will simply inherit utm.campaign. This change implies that
mass_mailing.tag and mass_mailing.stage have to move to the utm model along
their associated views/data.

These changes were made so that campaigns could be used in the future
by social, mass_mailing and mass_sms and available in the same view

This commit also removes the source_id and the medium_id
fields on the campaign.

This commit also moves the unique_ab_testing field from the mass_mailing_campaign
to the mass_mailing model

Task ID: 2002029
PR: #34015
2019-08-02 12:32:35 +00:00
wan 2d086f5d8f [IMP] account: credit note usability
Task 2038326

* Tick the credit note sequence by default on the customer invoices and vendor bills journals
* Write Customer Invoice/Vendor Bill/Credit Note/Customer refund at the top of the document
* The reference field should be printed on the credit note pdf (interesting because it gives source and reason)
* If the document is a credit note, there shouldn't be any payment information on the pdf (the customer doesn't have to pay you) (currently you see the "payment communication" the customer is supposed to use)
* Rename Credit Note to Refund on dashboard
* Add tooltip on payment widget

closes odoo/odoo#35231

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2019-07-31 14:39:22 +00:00
Goffin Simon b6e7af37eb [FIX] account: Incorrect due date for credit notes
Fine tuning of this commit: d0f3e896d4

To ensure that the date_invoice is a date object because a comparison is
made with date_due

opw:2033438

closes odoo/odoo#35058

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-07-22 12:02:55 +00:00
Jigar Vaghela b1150c696c [FIX] l10n_in: fix gst payment report calculations and demo data
closes odoo/odoo#35067

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-07-22 12:00:38 +00:00
Xavier Morel fce64e7d94 [FIX] core: auto_install modules being very sticky
An unintended side-effect of #29431 is apparently that auto_install
applications automatically get reinstalled when uninstalled, which was
not the goal.

Move the auto_install selection back into db.py, this version seems to
work even though the previous attempt was apparently unsuccessful.

closes odoo/odoo#35180

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-07-25 12:10:18 +00:00
Shreya Modi f9e6c76168 [IMP] mass_mailing_sale: traceback due to invoice stat button
when opening the sale promotion in mass mail, it creates a traceback
due to invoice compute method as it does not have invoice id because
of changes in account.move.

task-2036203

closes odoo/odoo#35222

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-07-26 11:24:12 +00:00
Martin Trigaux 06f8f04699 [MERGE] Forward port of 11.0 to saas-11.3 up to eb4700f17f
closes odoo/odoo#35054

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-22 09:47:11 +00:00
Luis Torres 9b921dae5e [FIX] hr_expense: Correct states are used in the payment_mode field
The states for the expense are:
- draft
- reported
- approved
- done
- refused

So in the definition of the `payment_mode` field, these states must be used.

Before this fix, wrong states were used in the definition of the field
`payment_mode`.

opw:2038715

closes odoo/odoo#35051

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-07-22 08:42:39 +00:00
Goffin Simon d18336bcd7 [FIX] product_margin: Product margin
Steps to reproduce the bug:
- Install accounting.
- Go to Accounting Settings and activate multi-currencies and margin analysis.
- Company currency in EUR
- Currency rate for EUR is 1.0 and 1.5 for USD
- Create two invoices, one in USD and the other in EUR. Both for 30 and for product P.
- Confirm and register payment to make them fully payed.
- Go to Accounting > Reporting > Product Margins > Open Margins.

Bug:

The average sale unit price for P was 60 instead of 25

opw:2035968

closes odoo/odoo#34998

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-07-22 11:13:59 +00:00
Nimesh Jethva a9819b0f20 [FIX] point_of_sale: Customer display choose image
You are not able to choose an image for the customer display because of
the bold tag, so we removed it and applied a css class instead.

closes odoo/odoo#34854

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-07-22 09:49:12 +00:00
Nimesh Jethva de61fc0c99 [FIX] point_of_sale: Customer display snippets issue
We were not able to choose the colors of customer display anymore.
2019-07-22 09:44:12 +00:00
Mohammed Shekha 0ac4055504 [IMP] web: do not set focus on form when lastActivatedFieldIndex is not set
When opening a dialog using mouse and closing it, form_dialog_discarded is
triggered, which tries to set focus on form while lastActivatedFieldIndex
is -1, as dialog is opened using mouse directly

do not set focus back to form widget if lastActivatedFieldIndex is -1

task-2031706

closes odoo/odoo#34684

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-07-22 10:23:29 +00:00
Martin Trigaux 324d3fc93a [MERGE] Forward port of saas-11.3 to 12.0 up to 06f8f04699
closes odoo/odoo#35064

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-22 11:43:54 +00:00
Romain Derie ac170e8a82 [FIX] web_editor, website: stop snippet animations before cloning
Before this commit, when a snippet was cloned, its animation was not destroyed
first. The flow was:
1. Clone the snippet (DOM) - web_editor trigger `snippet_cloned`
2. Start cloned snippet animation - website listen `snippet_cloned`

This was causing bugs, eg facebook snippet for which the animation is to create
an iframe containing the facebook widget.
When cloning this snippet, its iframe would be cloned to, then its animation
would be started, creating another iframe.

To fix such flows, the snippet cloning flow should be:
1. Strop the snippet animation
2. Clone the snippet (DOM) - web_editor trigger `snippet_cloned`
3. Start cloned snippet animation - website listen `snippet_cloned`
4. Restart the original snippet animation

task-1951466

closes odoo/odoo#35029

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-07-22 08:30:21 +00:00
Goffin Simon f58fa65c2b [FIX] hr_expense: Encoding negative amount in expense
Before this commit: 15fa0c23d9
It was possible to encode negative amount for an hr.expense.

Before the fix, it raised a Error saying:

"Cannot create unbalanced journal entry."

opw:2036620

closes odoo/odoo#34953

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-07-22 07:38:53 +00:00
Martin Trigaux eb4700f17f [MERGE] Forward port of saas-14 to 11.0 up to 160b7c87bb
closes odoo/odoo#35044

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-22 07:17:43 +00:00
Martin Trigaux 160b7c87bb [MERGE] Forward port of 10.0 to saas-14 up to f7b6d3b0b8 2019-07-22 08:32:52 +02:00
Odoo Translation Bot 1e66c38238 [I18N] Update translation terms from Transifex 2019-07-21 03:09:04 +02:00
RomainLibert 5e699c65dc [FIX] payment: Do not show stat button if no token
If there is no token to be shown, don't show the stat button as this
might confuse the end user

closes odoo/odoo#32548

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-07-19 12:44:14 +00:00
Nans Lefebvre d727adcd70 [FIX] sale, website_sale: push record rule lower in module dependencies
Some modules expect the users having the sales_team.group_sale_salesman group
to be able to read payment tokens (credit cards).
Payment tokens are defined in payment.
Both are a dependence of sale, which is thus the lowest common denominator.

opw 1965213
2019-07-19 12:44:14 +00:00
Aaron Bohy 04a600486e [FIX] web: remove lazyloaded controller from stack
... if the current action can't be executed.

Let's assume a form view for a record with a multicompany ir.rule.
If the user switches to another company, the webclient is reloaded,
but he doesn't have access to that record anymore. In this case,
he is redirected to the Home menu.

Before this rev., when he clicked on an app in this situation, it
crashed. This was due to a leftover reference of the failed action
(the lazyloaded, multi-record controller) in the controller stack.

closes odoo/odoo#34994

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-07-19 12:07:56 +00:00
Martin Trigaux e266c7c98a [MERGE] Forward port of 12.0 to saas-12.2 up to 5e4c1b3701 2019-07-23 13:41:00 +02:00
Alexandre Kühn cda4f3c308 [FIX] mail: send ir.needaction notifications
Revision on https://github.com/odoo/odoo/commit/de7c119e666d108564b3889d1c08e5bf2e4da082

Partners are registered on notification channel
`(dbname, 'ir.needaction', partner_id)`.

closes odoo/odoo#34974

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
2019-07-18 10:12:16 +00:00
Christophe Simonis 18edb1c205 [FIX] stock_account: adapt test to new version (again)
The right patch was already there, I should just have to remember to get
it. See https://github.com/odoo/odoo/pull/34912#issuecomment-511794024
2019-07-26 17:56:21 +02:00
Christophe Simonis 7233c6ffa2 [FIX] stock_account: adapt test to new version
Oversight of previous forward-port.
2019-07-26 16:33:08 +02:00
Antoine Guenet af56405753 [FIX] website_form_editor: properly edit select fields
Select fields were not `contenteditable=true`, which means they could
not be edited. Besides, being that each of their option was individually
considered a snippet, and that they were contained in `div` tags, they
were effectively unbreakable, which means that adding new options by
hitting `ENTER` did not work (note: this also currently doesn't work
properly in v12.0, for other reasons as the concept of an "unbreakable"
node didn't exist yet). This fixes those issues.

closes odoo/enterprise#4817

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

X-port/Cherry-pick of odoo/enterprise@af51d9ff2a
2019-07-26 15:21:48 +02:00
Christophe Simonis bfd34e14b1 [MERGE] forward port branch saas-12.3 up to 40e8b67179 2019-07-26 15:12:29 +02:00
Christophe Simonis 40e8b67179 [FIX] mail: add missing requirement in test
Oversight of previous forward-port.
2019-07-26 14:34:48 +02:00
Christophe Simonis e0f9c092cc [MERGE] forward port branch saas-12.2 up to 1d6d790513 2019-07-26 11:32:43 +02:00
Géry Debongnie 7d78795f8b [FIX] web: properly handle (grouped list) pager
when last field is numeric

closes odoo/odoo#35176

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-07-25 12:23:51 +00:00
Julien Mougenot 5c34091361 [FIX] web: improve editable list column widths
Changed the way some field types are displayed.

Before this commit, column width in a list were calculated according to
a given factor (integer), determining their weight.

Now, some specific fields have an hardcoded width instead. This task
also slightly tweaks some width factors, in order to try to have a
better layout in most list views

Task 1985916

closes odoo/odoo#35147

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-07-24 14:05:02 +00:00
svs-odoo 4d0f36ac01 [FIX] web: context when read on multi edit
Before this commit, in list editable, when user save multiple records in
the same time, the context is passed for the write but not for the read.
Now, the context is passed also for the read.

closes odoo/odoo#35113

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-07-24 07:05:32 +00:00
Martin Trigaux a98427834e [MERGE] Forward port of saas-12.2 to saas-12.3 up to 860ab5a1c2
closes odoo/odoo#35119

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-24 10:32:23 +00:00
Géry Debongnie 4e6ee3ac97 [FIX] web: allow groupby buttons in list view at any level
The initial implementation of the special group by buttons in list
groups only supported the first level of groupby.  So, if one grouped a
list view by field A, it worked (if A had a groupby defined).  However,
if we want to group by B/A, this no longer works.

opw 2040725

closes odoo/odoo#35090

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-07-23 08:09:50 +00:00
wan 26b5b446b3 [FIX] account: sql in constraint
Task 2002068
The constraints were executed before the data was written in the database. Therefore, the data was not correclty constrained.
Also add the invoice date in the constraint on duplicated vendor references as sometimes, your vendor uses a numbering that loops over time (each year it restarts at 0 for example) and in this case you may receive two different bills that legitimely have the same reference.

The reference on a refund is now 'Reversal of {name}: {reason}'. Before
the reason was in the payment reference, and it didn't make much sense.

closes odoo/odoo#35046

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-07-22 10:13:50 +00:00
Romain Derie bac4b43a23 [FIX] web_editor, website: remove unused param
`_view_get_inherited_children()` `options` parameter is not more useful.
Introduced with ae8232136d and not used since edce2fd6d0.

Also, the opportunity is taken to rename `options` in `_views_get` into
`get_children. Indeed `options` does not mean much.

closes odoo/odoo#35157

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-07-24 16:06:27 +00:00