Commit Graph
140847 Commits
Author SHA1 Message Date
William Henrotin 238e5ed9ca [IMP] stock: assign quantities to services in batch
Since 2137e45bb5, services have their stock
quantities computed to 0. As it's the same value for all of them, we can
do it in one batch instead of iterating over products.

closes odoo/odoo#36214

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-08-29 08:05:37 +00:00
ryv-odoo 695c65131b [FIX] elearning: fix invisible kanban view label
In the the kanban view of slide.channel, text belong numbers
was invisible (white on white) on the community version.
We change the class to be visible for each version.

TASK-ID : 2049115

closes odoo/odoo#35858

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-20 13:25:37 +00:00
qsm-odoo 3daed421f4 [FIX] website: restore edit menu dialog
Since saas-12.5, with recent ORM changes, writing on non-existing fields
does not trigger a warning anymore but instead crashes. This revealed
that the 12.0 "Edit Menu" dialog was doing some of that. Indeed,
depending on what was edited, we ended up writing on the 'is_homepage'
field, the 'text' field, the 'isNewWindow' field, ... which do not
exist.

This commit takes advantage of the fix to also lint the dialog code and
convert some of it to ES6.

Discovered while working on task-1925319

closes odoo/odoo#36204

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-29 07:24:16 +00:00
Victor Feyens 4e9416b4d5 [FIX] account: product view
Minor revert of https://github.com/odoo/odoo/pull/35381

closes odoo/odoo#36203

Signed-off-by: vfe <Feyensv@users.noreply.github.com>
2019-08-28 15:50:22 +00:00
Odoo's Mergebot 4953b79484 [MERGE] website_slides: add UI and frontend tests
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Introducing eLearning test tours

* a tour in website_slides that tests a tour taken by a member notably
using the fullscreen player;
* a tour in website_slidesthat tests a course creationg by a publisher;
* a certification tour in a new test_website_slides_full module that tests
a payment-based certification tour;

In this merge we also

* improve and adapt demo data, notably to have a tour testing various
use cases;
* provide fixes due to bugs spotted when developing those tours;

See sub commits for more details.

Thanks @awa-odoo and @lul-odoo for their input.

LINKS

Task ID 1937768

closes odoo/odoo#36059

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-28 18:18:58 +02:00
jbm-odoo 58cf9b6754 [FIX] base: Open One2many with not yet updated values
When we have an onchange that modify items in One2many's lines (for
example the quantity of each line based on general quantity) and
we click on a record immediately after changing the field that
trigger the onchange, we have the the old value in the dialog box.
Indeed the dialog opens before the onchange has return the new
values, so the old one are used. This case appears only if the
One2many's line was never saved.

With this fix, we wait that the model is free of mutex, and so the
onchange is terminated before displaying it.

closes odoo/odoo#35306

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-28 13:51:40 +00:00
jbm-odoo cf7c9bd9b7 [FIX] mrp: Avoid creating new line when changing qty to produce
When we change quantity to produce in mrp, all component lines are
removed and new line with the updated amount to product are created.
The problem appears when we change the quantity to produce and directly
click on a component line, because we open the line that will be
deleted. So if we change the quantity for this component manually,
this suppressed line will be added with the new value. And the computed
line will be also be added. So the line for one component will be
present twice (one with computed value and one with manual entry value).

To avoid this problem, when we change the quantity to produce, we update
information of each line (instead of deleting and creating new one).
So if we click on a component line just after changing the quantity,
we open the updated line (and not de deleted one).
2019-08-28 13:51:40 +00:00
RomainLibert d6c65aa4d4 [FIX] base: allow users to read themselves in multicompany
You should always be able to read your own user whatever the company you
are logged into

closes odoo/odoo#36190

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-28 13:47:39 +00:00
Thibault Delavallée fe0f5a8b04 [FIX] website_sale_slides: fix demo data about optional products
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit move commented demo data due to dependency issues (see 9920f20e4c).
Optional products are now installed with the "full elearning setup" module
introduced recently.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon 4bd598e0c1 [ADD] test_website_slides_full: add a full certification testing flow
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit adds a new module whose purpose is mainly to add tours on a
full eLearning configuration. It depends on

  * website_sale_slides: eCommerce integration with checkout process and
    on-payment channels support;
  * website_slides_forum: forum integration in eLearning;
  * website_slides_survey: certifications support in eLearning;

This module adds a first test tour that tests the certification course.
It is composed of a single certification lesson customers have to buy.
Failing and being removed as well as succeeding and gaining completion are
tested.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon e7c4761464 [ADD] payment_test: add a payment acquirer to be used for testing only
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This new module implements a simple test payment acquirer in order to allow
testing successful payments behaviors, notably on eCommerce. Its usage is
prevented in other state then test to avoid any potential misuse.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Thibault Delavallée ff768a0642 [IMP] website_slides: add a publisher tour
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit adds a course tour that test a flow for course publishers. Main
steps of this tour are :

  * a user (website publisher) creates a course;
  * he updates it;
  * he creates some lessons in it;
  * he publishes it;

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon 215af4e1de [IMP] website_slides: add a member course tour
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit adds a course tour that test a flow for course members. Main
steps of this tour are :

  * an user (either employee, website publisher or portal) joins a public
    course;
  * he has access to the full course content when he's a member of the
    course;
  * he uses fullscreen player to complete the course;
  * he rates the course;

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Thibault Delavallée e9a5dcff74 [IMP] website_slides{_*}: improve demo data
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Add some demo data to allow demonstrating various flows: training, lessons,
public, private, quizzes, ...

Also prepare future test tours by improving courses that will be used for
tours, notably the public one.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon 5862f1d91f [IMP] tests: allow auto play in chrome headless
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Purpose: allow video auto play without any required user action. It allows to
have test tours using youtube autoplay feature like future website slides
tours (spoil, spoil).

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée 5252f9e8cd [FIX] website_rating: correctly trigger click on stars
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Current implementation of rating using stars is a bit strange and may miss
some clicks, notably in testing tour. Let us fall back on a classic simple
implementation based on clicking on a star.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Lucas Lefèvre a9462adfcb [FIX] website_slides: allow portal users to rate
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Portal users cannot post reviews as they have no write right on channels.
When trying to post a review on a channel this leads to a 403.

In this commit we correctly propagate channel access token to the composer
in order to allow rating.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée 608ea7f85d [FIX] website_slides: lessen concurrent update by waiting slide completion
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

When switching through slides using the fullscreen player it is quite
common to have concurrent updates on slide.slide.partner model as it is
used to store the viewed and completed. By correctly waiting for the
completion to be done we lessen potential concurrent errors.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée 9b12a8b9d7 [FIX] website_sale: fix access right issue when paying
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Commit fe518f1fea introduced a search on sale order model in checkout
process. However this may fail as access rights are not always granted

  * portal users can see orders linked to their company;
  * salesman and a lot of specific groups (accounting, ...) can see their own
    orders, all orders, or depending on some condition;
  * BUT standard users (employee only for example) cannot see any sale order.

Indeed they do not even have right to read, meaning a search fail. Let us
sudo the search as this is contained in a sub method used to fetch some
data.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée f93064606f [FIX] website_slides{_*}: fix completion computation, notably with certifications
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Since 9920f20e4c course completion when finishing a certification survey
is broken. Indeed channel completion is not correctly recomputed. A
certification course can therefore never be completed and awarded. This
commit fixes that and correctly update channel completion based on survey.

In this commit we also rename some methods

  * _compute_completion: renamed to _recompute_completion to avoid naming issue
    with computed field convention;
  * _post_completion_hook is not unnecessary as code in hr_skill can be done
    after calling super of _recompute_completion;
  * _completed_callback is renamed to _set_completed_callback to be coherent
    with slides naming;

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Jeremy Kersten c712e49b74 [FIX] website_blog: remove ranking computed field
No more used

closes odoo/odoo#36188

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-08-28 12:56:25 +00:00
Yenthe666 89a59558aa [FIX] hr: fix typo in OdooBot notification
closes odoo/odoo#35971

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-28 13:06:07 +00:00
Martin Trigaux 8430da8f3f [I18N] base: export saas-12.5 source terms
closes odoo/odoo#36145

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-28 10:19:31 +00:00
Martin Trigaux f49e8879b5 [IMP] *: unify module manifests
The description should be an action for the user (i.e. "with this
module, you can ...")

Correct English errors
2019-08-28 09:55:34 +00:00
Martin Trigaux 95620bb03c [IMP] base: rephrase sentence
Was not clear groupby is the attribute
2019-08-28 09:55:34 +00:00
Martin Trigaux b4faa5d70c [FIX] base,web_editor: fix typo
Remove redundant _description
2019-08-28 09:55:34 +00:00
Martin Trigaux e212099d39 [FIX] mass_mailing: use better wording 2019-08-28 09:55:34 +00:00
RomainLibert 6aaef4a3d9 [FIX] website: fix ctx argument
In the call to Chart.js we pass a ctx which should be a DOM element,
however we pass `null` as the ctx.

It seems that what happens is that we look for the DOM element inside
the `document` (via getElementById) but this element is not yet inserted
into the document, hence this returns `null`.

Since we already have a reference to the canvas element which should be
used as ctx, we can probably just reuse this reference

closes odoo/odoo#36072

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-08-28 11:13:18 +00:00
Jinal Patel 85b5c9bbb4 [ADD] mrp: add BOM Type field on BOM tree view
task-1949618

closes odoo/odoo#32785

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-28 12:17:39 +00:00
Jinal Patel 59463c6a35 [IMP] mrp: 'Quality' option always visible in settings
task-1949618
2019-08-28 12:17:39 +00:00
Jinal Patel 3b520ed4f1 [IMP] mrp: rename filters
-'Waiting for Material' > 'Waiting for Component'
-'Material Available' > 'Component Available'

task-1949618
2019-08-28 12:17:39 +00:00
Jinal Patel 81577bf24e [IMP] mrp: remove unnecessary menus from MRP Configuration
-'Working Times'
-'Productivity Losses'

task-1949618
2019-08-28 12:17:39 +00:00
Jinal Patel 4781f1028a [IMP] mrp: stay UPDATE button in edit or read mode on MO
task-1949618
2019-08-28 12:17:39 +00:00
Jinal Patel dbc393ef10 [IMP] mrp: change position of CANCEL button on MO
task-1949618
2019-08-28 09:22:17 +00:00
Jinal Patel b3651ab9f9 [IMP] mrp: hide 'Material Availability' field in form view
-apply group_stock_multi_locations group on Miscellaneous tab

task-1949618
2019-08-28 09:22:17 +00:00
Jinal Patel 9f7e597126 [IMP] mrp: hide UNLOCK button in draft state
task-1949618
2019-08-28 09:22:17 +00:00
Jinal Patel e4bd824592 [IMP] mrp: hide attachment icon in edit mode
-also improve tooltip on attachment icon
-and also hide attachment count in edit mode

task-1949618
2019-08-28 09:22:17 +00:00
Jinal Patel cedb6d9440 [IMP] mrp: improve help message on MO
task-1949618
2019-08-28 09:22:17 +00:00
Aaron Bohy 711a10162a [FIX] web: enter edition editable list with <widget>
Let's assume an editable list view with a <widget> node in its
arch. Before this rev., when clicking on a field cell positionned
*after* the widget, the field next to the clicked one was focused.

closes odoo/odoo#36176

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-08-28 11:24:48 +00:00
Rémi Rahir 52c6a060d6 [FIX] base_setup: allow extension of the edition widget
The refactoring of the settings in a0c34138f88c4eb5d8a86340df55bbc091c5a252
did not properly take the enterprise edition into account. In
particular, we had lost the information about the expiration date.

This commit adds that information in community as the alternative would
be to extend the widget ResConfigEdition in web_enterprise which would
imply an explicit dependency between web_enterprise and base_setup and
we would like to avoid that situation.

closes odoo/odoo#36114

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-08-28 10:35:09 +00:00
Odoo's Mergebot 7d6a326501 [MERGE][FIX] gamification, test_lint, web: Edge does not support obj spread operator
As of August 20 2019, Microsoft Edge partially supports ECMA2018.
For instance, `Promise.prototype.finally()` can be used, but the
spread operator does not work on objects.

Task-ID 2056070

closes odoo/odoo#36054

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
2019-08-28 14:08:02 +02:00
Alexandre Kühn 6f6445be8c [FIX] gamification, web: Edge does not support obj spread operator
As of August 20 2019, Microsoft Edge partially supports ECMA2018.
For instance, `Promise.prototype.finally()` can be used, but the
spread operator does not work on objects.

Task-ID 2056070
2019-08-28 08:50:56 +00:00
Jigar Patel ed64250503 [FIX] mrp: update expected duration when finished planned date is change
task-1939533

closes odoo/odoo#35016

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-28 08:30:42 +00:00
Jigar Patel 90df41f0da [IMP] mrp: improve the usability of workorder Gantt view
- display WO in red which has a late planned start date.
- hide the WO which are in done or cancel state.
- show progress of WO.

task-1939533
2019-08-28 08:30:42 +00:00
Lucas Lefèvre a5d42ff6d9 [FIX] membership: Adapt customer and supplier filters
The fieds `customer` and `supplier` no longer exist
since 3e97cff.

But 9a0fedf re-introduced filters using those fields,
probably when rebasing the branch.

closes odoo/odoo#36165

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-28 08:37:07 +00:00
qsm-odoo 4f27e52cab [IMP] web_editor, *: introduce and restore new web_editor UI
* mass_mailing, note, website, website_blog, website_form,
website_mass_mailing, website_sale

This commit, unfortunately, mixes three things:

- Restoring as much as possible the scss organisation to allow styling
the web_editor UI properly.

- Fixing some bugs like a border around the page once the editor is
loaded, no ability to scroll the snippets, etc

- Introducing a whole new UI for snippet options: a left panel instead
of the old dropdown & button overlay.

Note: this commit also do some linting and ES6 convertion even though
some of it has been done in the parent commit.

Note 2: some elements that were removed are still styled in the POS apps
but this is because part of a feature was removed while leaving dead
code behind, this is handled in another PR which is to be merged
(https://github.com/odoo/odoo/pull/36136).

Part of https://github.com/odoo/odoo/pull/36068
task-1942370

closes odoo/odoo#36068

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-28 09:04:55 +00:00
qsm-odoo 05f9b1f4e6 [REF] web_editor: do some linting and ES6 adaptation before UI refactor
This commit aims at linting and converting to ES6 some parts of
web_editor JS to avoid as much noise as possible in UI refactor in next
commit.

Part of https://github.com/odoo/odoo/pull/36068
task-1942370
2019-08-28 09:04:49 +00:00
qsm-odoo b47f097feb [FIX] web_editor, *: review assets organisation
* mass_mailing, point_of_sale, website

- Lib files were included twice
- Variables files were split but added multiple times in the same assets
  bundle
- Useless assets templates were defined or split
- ...

Part of https://github.com/odoo/odoo/pull/36068
Related to task-1942370
2019-08-28 09:04:25 +00:00
qsm-odoo 7acb22a5e5 [FIX] web_editor: restore moving snippets to nearest dropzone
Hard to say when this was broken since the current work and revert of
the editor: when dropping a snippet outside of a dropzone it was not
dropped in the nearest one anymore because the dropzones were somehow
destroyed first in the current code.

Part of https://github.com/odoo/odoo/pull/36068
Discovered while working on task-1942370
2019-08-28 09:04:18 +00:00
Priyanka Kakadiya 5f35819fff [IMP] web: remove 'ID' field from custom groupby dropdown
purpose of this commit is to remove ID from the fields to group by on the
searchview as it does not work nor does it make sense.

removed field 'ID' from custom group by on search view.

task-2028105

closes odoo/odoo#34752

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-08-28 08:43:03 +00:00