When the header goes affixed, a compensating padding-top is added on
the content so that the scroll does not flicker. That padding-top was
added a bit too late and was enough to mess up the scroll on pages where
the content is about the height of the viewport: the header goes affix,
the scrollable content becomes smaller, the padding top is added, a
scroll is detected, the header is un-affixed since above scroll point
-> bug. If the padding top is added first, then there is no problem.
Note: the scroll effects code could probably use some refactoring.
Part of https://github.com/odoo/odoo/pull/56936
task-2312878
closesodoo/odoo#58859
X-original-commit: bb77cd2961e71deaf048cbaad20f8cb72a646cab
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit the height of a snippet with the full height option
enabled was not correctly updated.
task-2312878
closesodoo/odoo#58782
X-original-commit: b371cb42cb67115692464c102813b7ebd54785d9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: website
As the text editor is still the summernote one, this improvement was
made possible through a series of hack. It has to be reviewed once the
new editor is ready.
This makes the text tools only appear in the style tab by switching to
it as soon as the summernote tools are updated. To prevent flickering,
css and js hacks had to be made.
This also moves the undo/redo buttons in the top bar with another hack:
those simulates click on the hidden summernote ones.
Part of https://github.com/odoo/odoo/pull/58638
X-original-commit: 0f65015b1b0a849bf109df11fd18a9e3a62820e4
*: website
Inside a color combination (or outside, as considered the same as inside
color combination number 1), the link color can be configured. It is
set by themes to one of the 5 theme colors. Sometimes, no color of
those 5 colors contrast enough with the color combination's background
and we accepted that before, relying on the fact the user can change the
link color if he wants too. Now we automatically increase the contrast
of those link colors, except if the user overrides it.
This system might be extended to all foreground colors in the future but
the system has to be improved for that.
closesodoo/odoo#58739
X-original-commit: f8abb476fe0475799a3da66d49a92c7de2ace8a0
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit, the colors of the navbar in the table of content
menu were not adapted to the color combinations system. With navbar in
top position, the background and the colors of the links were using the
same color.
After this commit, the colors of the list-group-item links are also
adapted with color combinations.
task-2312878
closesodoo/odoo#58645
X-original-commit: a0dc17676c570887773854243bcb8cd8823359d5
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit the layout of the off-canvas menu was broken with an
affixed header.
task-2312878
closesodoo/odoo#57442closesodoo/odoo#58528
X-original-commit: 6e1c2ad5db69fe7eaa8f53c8da8375435b59f486
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
* Prior to this commit the dynamic snippet was flickering (destroy followed
by init) because the parallax option triggers a _refreshPublicWidgets
in the onFocus. As such each time the user clicks somewhere in the snippet
the snippet desapears and reappears which can be confusing for the user.
* After this commit, the parallax option will only trigger a refresh on snippets that
are using parallax. This commit also prevent the user from selecting an element of
the dynamic snippet as it is not customizable.
task-2339246
closesodoo/odoo#57693closesodoo/odoo#58525
X-original-commit: ac2d836af9a38687dd0c6d377212f49b102892af
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Currently, when there is modal dialog in website the header part of
the modal is hidden behind the navbar and the modal is not centered.
so in this commit, When the modal is in #wrapwrap, modal position
top should be size of the navbar.
closesodoo/odoo#56056
Taskid: 2320303
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
*: web, web_editor
Since the right-panelization made with [1], the modals were not
compensating the body scrollbar when opened anymore and the backdrop
was misplaced. This commit fixes the problems generically, to support
modals with non-body scrolling.
[1]: https://github.com/odoo/odoo/pull/57975closesodoo/odoo#58442
X-original-commit: ebd0c90a146145079061e79c2d4c37fa182a2975
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Bug
===
You can enter in a fullscreen mode in the frontend, of the slide channel.
In this view, the default website header should not be visible.
To do that, we play with z-index, but since 0f2cab4aeb ,
the z-index of the website header has been changed without changing the z-index
of the fullscreen view.
Task-2345016
closesodoo/odoo#58483
X-original-commit: 8d35540df6d21af6fe716f73aefa37bfb66c7ac2
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
In case you don't have the trailing slash and are on your homepage, the indexOf
will return -1 and you will be redirectected to the pathname.substr(-1)
Now if you don't have trailing slash in your url after position 1, we don't
subtract anything.
domain.com/fr_BE
Before this commit:
=> redirect to domain.com/E
After thi comit
=> redirect to domain.com
task-2345490
closesodoo/odoo#58458
X-original-commit: ada2e2ce68dbc8b1df701691d9d3e958fef4ea31
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
The affixed header was not properly repositioned in editor full screen
mode (introduced in 13.4).
closesodoo/odoo#58447
X-original-commit: 7502c8aa6e5422b1ecf446002e187fa2f7ca3aa7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This reverts commit 8b8c26877a41e55eb0f3acb1909ac0c3abbf37d7.
While it fixes cases on colored background, it is ugly on black bg.
Waiting another colution, real white edge ?
closesodoo/odoo#58326
X-original-commit: b14694bc679280e99caad04676668462f4e8bdb2
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
The text tools were moved in the right panel with a temporary solution
but as there is no right panel in translate mode, the text tools were
just floating summernote-way. This commit restores the top editor bar
in that case while waiting for the new editor.
Part of https://github.com/odoo/odoo/pull/58347closesodoo/odoo#58372
X-original-commit: b9d4ccfc8db1f3425b8ee0e8d6311ebaac0f26b2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Those were misaligned since the merge of the right-panelization.
Part of https://github.com/odoo/odoo/pull/58347
X-original-commit: be59e6cd0d30c8e5fb70311db4d9657826a9d43f
Reword some theme options, highlight <we-title> components when used as
a "sub-section" titles.
task-2335267
Part-of: #57942
X-original-commit: d6acbfee1834ab32460300b9d7f5dd9188f68014
Fix the design. Trig animations hovering any part of the button rather
than its inner image only.
task-2335267
Part-of: #57942
X-original-commit: 55424d41b355ae1303f040bdd953e357365289f3
Adjust shadows/borders in order to make the color-combination box
stand-up.
task-2335267
Part-of: #57942
X-original-commit: 38ce0c20c6a82b75d77406419b25d90259b50293
Since [1], the editor panel is now on the right. The top actions z-index
was not adapted and was now too high and going above modals. It worked
before because the zindex was confined into the topbar stacking context,
which does not exist anymore.
[1]: https://github.com/odoo/odoo/pull/57975closesodoo/odoo#58257
X-original-commit: 1d74680fe195a2ece367ad7251f4cc3a52dc132f
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Since [1], the editor panel is now on the right. The fullscreen mode
was not adapted correctly.
[1]: https://github.com/odoo/odoo/pull/57975closesodoo/odoo#58242
X-original-commit: 8359ae12d8049ecf6f6de810ae74f096769038e2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit the redirect message was not added at the end of
the countdown if the content-with option of the snippet was not Regular
It was because we did an append on the '.container' class to add this
message and that class is replaced when we change the content-with.
task-2312878
closesodoo/odoo#58201
X-original-commit: f4e3cc6edda13d76368a38f3807be6ea5a279141
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Commit [1] broke the vertical alignement for half/full height snippets
while trying to improve it. Mentioned commit's goal is kept: not
messing up the alignement when enabling the scroll button and allowing
those height and scroll options for the big boxes snippets, but now
the content is still vertically centered (with or without scroll button
now). If the user do not want it centered, he still has the possibility
to increase the bottom padding.
[1]: https://github.com/odoo/odoo/commit/9d5cd2c1747488524c107e6165d7c55d74b80606
Part of https://github.com/odoo/odoo/pull/58192closesodoo/odoo#58214
X-original-commit: 08154fb956b4983187eebc3116975772da7b95c4
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: web_editor
The big boxes snippet's content was appearing below the background
layers (filters, shape, video, etc).
Part of https://github.com/odoo/odoo/pull/58192
X-original-commit: f1bd8bc7ef8b084168816bc22d821acdffe2aaf6
*: website_event, test_website
This commit is a series of hacks. The goal is to move the summernote
text tools to the editor panel for the website editor. All the code
to use the text tools in a top bar is kept (mass mailing, etc) and the
text tools are placed at the right place for website in an ugly way.
This is obviously temporary, until we can implement those text tools
more generically and in a better way thanks to the new editor.
Part of https://github.com/odoo/odoo/pull/57975
task-2344227
closesodoo/odoo#58199
X-original-commit: ff81fa4798e232a03daf0eeff7d85ad35a52b25c
Related: odoo/design-themes#365
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: website, mass_mailing
See parent commit for information about the scrollbar moved to the
'#wrapwrap' element, which was necessary to achieve this right panel
design. Note: in the future, having the scroll on the #wrapwrap may
not be necessary anymore as the edition might be done in an iframe.
Part of https://github.com/odoo/odoo/pull/57975
task-2344227
X-original-commit: 2abe8517063b2696cc89e9a453dcc3921fb3b8c7
*: web, web_editor, portal, account, website_blog, website_forum
This is probably not ideal to move the scrolling behavior out of the
html element but this will be needed for the editor to not have a double
scrollbar on the right. This is actually also useful for the scrollbar
to appear under the purple odoo menu instead of its right.
This commit, if to be reverted in the future, however contains many
improvements to make the transition easier that should be kept: jQuery
and Odoo functions to be able to scrollTo a specific element, get the
top scrollable element, check if an element is scrollable, etc. Also,
some magic was done: if some code tries to scroll to a specific scroll
position via jQuery's scrollTop or animate functions on the html/body
element, those will still work as intended (obviously, using the new
utils to do that is however recommended).
This commit also reviews our scroll behaviors to make them more robust
and share the code.
Part of https://github.com/odoo/odoo/pull/57975
task-2344227
X-original-commit: 4e7be69825163c0a0ff41c882a196fc7f3158fb3
*: website_blog
This was fixed and rebroken quite a few times. Hopefully, with this
commit and the next ones, the feature will be more robust: when clicking
on a link anchor, the animation now considers the fixed header height if
any *even if the header becomes fixed during the animation*.
Part of https://github.com/odoo/odoo/pull/57975
task-2344227
X-original-commit: 416b125803d043badef8e4b022c100e33d1dba04
The class is supposed to be placed on elements which are absolutely
positioned over the main scrolling element at the top of the page. It
was wrongly placed on headers as soon as they become fixed while they
should have been placed on headers as soon as they become fixed *and*
over the main scrolling element.
Part of https://github.com/odoo/odoo/pull/57975
task-2344227
X-original-commit: ee47bd9ce0da526ea5b3387a354ab8fbd06cc55f
*: website
This is not the cleanest of fixes because the original code have to
be refactored first but this solves the problem we had *sometimes*
when drag and dropping a snippet then immediately saving (only saw the
bug in automatic tests): same as all snippet options, the operation had
to be mutexed so that saving is done after its full execution.
Part of https://github.com/odoo/odoo/pull/57975
task-2344227
X-original-commit: 277f39904e7218bef2dd23b1c5b719ce8660008f
This reverts commit 27158a0f612897e41601bf9e9d20861e9b87279f
Why keep a new option now that it has been developped ?
X-original-commit: bd4628e69df1e27498f88f348812a269cc9d3648
This commit attempts to update the old "website.ThemePreview.Loader" style
by integrating a loading animation when theme is being installed
Common code used to add loader and install the selected theme in both
ThemePreviewController & ThemePreviewKanbanController.
(preview theme and pick a theme)
task-2338062
closesodoo/odoo#58068
X-original-commit: fbe89b8617c17a3fa93970b4d706a7f0d6421ae5
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
*: website, web_unsplash, website_blog
We have recently created an odoo media library that exposes a public API
for searching for open-source media, including dynamic SVGs that can be
used with the dynamic background-shape system to create illustrations
whose colors can be changed by the user. This commit adds the
corresponding client-side functionalty: search for the images in the
media-library, creating a corresponding attachment when selected, as
well as an option to customize the colors of the dynamic SVGs.
In the process, adaptations have been made in the web_unsplash module to
avoid duplicating code and to adapt code that was making assumptions
that are no longer valid.
To make new users more aware of this feature, all default images have
been hidden from the media-dialog, so that the user is prompted so
search for images. Some tests and tours that were relying on having
default images in the media-dialog (eg in website_blog) have been
adapted to match.
task-2316651
Linked to: odoo/iap-apps#235closesodoo/odoo#57888
X-original-commit: 7a1308b426f94b33e2bd55e5d58e661067e26ff3
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
- Share the code for tab switching loading and slow option loading.
- Now add a loading effect over the content when the content is changed
and a loading effect over the editor panel when the editor panel is
being changed
Part of https://github.com/odoo/odoo/pull/55614
task-2213114
closesodoo/odoo#57879
X-original-commit: e126cd3bb2b20bc993d2472eee5fe16cc7a74ea9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: website_blog
- The scroll button option is now again available for all snippets, not
only when the height is forced to 50% or 100%. Indeed, nobody would
think to change that option if the snippet is already naturally tall
and you could well want that scroll button on small-height covers.
- The scroll button is now placed on top of the snippet content instead
of below in its natural flow. This allows it to work with snippets
like "Big Boxes" and actually prevent to miscenter the snippet content
just by adding that scroll button.
- Review the option UI and allow to control the spacing around the
scroll button.
- the "Big Boxes" snippet was at last adapted to work well with 50% and
100% height options.
- The 100% height option has now associated JS so that the height is
computed to use 100% minus the size of the header.
Note: this may be backported to 13.2 where the option was introduced and
where those improvements may appear essential for the feature to not be
considered as buggy.
Part of https://github.com/odoo/odoo/pull/57764
task-2224404
X-original-commit: 9d5cd2c1747488524c107e6165d7c55d74b80606
before this commit, when selectioning the snippet with an invalid API
key, a traceback was triggered and the snippet was destroyed.
task-2338730
closesodoo/odoo#57689
X-original-commit: 2c5b0c6b915546ccdac2ed4248f24a4e691fadd1
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
This commit makes it easy to generate a tour depending on a theme.
As each theme will have different tour which will recreate
the theme preview, this feature is able to create all of them.
task-2172208
X-original-commit: 6de336990d8eb1667eefcc93701dd519cec7e16c
Do not auto open the media dialog after the drop if there are images in
snippets images wall and images gallery.
task-2312878
X-original-commit: ab2dacbb844b36793df891a844e89482cf12f14e
Now we only support tour in edit mode already.
We win a click on onboarding., and after the install of a theme
It avoid to have 2 tips on the same page that can be confusing
X-original-commit: 347b5ab3cfb5ebcef7c074f4a65223df0e349f2a
Now that we will write tour by theme, this part is useless.
We just keep the old steps that will be not covered by future theme tour.
task-2172208
X-original-commit: 02e1b1f659d5f588cc4e52f48217f8e2c7771ad4
qsm-odoo