Commit Graph
119468 Commits
Author SHA1 Message Date
Lucas Perais (lpe) aa4ccef418 [FIX] account: fix planner extra features 2018-07-25 09:21:26 +02:00
Christophe Simonis 78eff004bf [FIX] im_livechat: enforce empty domain in action 2018-07-24 19:09:32 +02:00
Christophe Simonis ba202dbe63 [MERGE] forward port branch saas-11.2 up to 3c521f6d05 2018-07-24 18:10:32 +02:00
jbeficent a955aee429 [IMP] l10n_es: improves groups
add name + some missing groups

Was PR #23922. Courtesy of Jordi Ballester (Eficent)
2018-07-24 17:43:33 +02:00
Raphael Collet 2054b59285 [FIX] models: make onchange return a smaller diff
Large diffs (specifically in x2many fields) cause performance issues.  They
overload the web client, which considers all returned fields as dirty.
2018-07-24 17:12:04 +02:00
Christophe Simonis 3c521f6d05 [MERGE] forward port branch 11.0 up to c51488c2f4 2018-07-24 16:43:26 +02:00
Wolfgang Taferner 62770ae9b8 [FIX] stock: test should actually fail, but did not for months
Commit dc1681b1 did change the name of the inventory creation from
direct qty update, but test still tries to compare the product.name

closes odoo/odoo#25948
2018-07-24 14:17:38 +00:00
qsm-odoo 24a8bce542 [IMP] website: add BS3/snippets showcase demo data
(should not be forward-ported)

- Backport of https://github.com/odoo/odoo/commit/9f2750d9ebda20758345724cd2a0934ab08d1f00
- Backport of https://github.com/odoo/odoo/commit/925fdbc683c546e096d1ae99aa22606480f78a0e

closes odoo/odoo#27187
2018-09-24 10:44:09 +00:00
Nicolas Lempereur 07cdd24f30 [FIX] product: is_product_variant true if variant
In 11.0 7e724f96c5 is_product_variant has been introduced back (it was
removed in 10.0 b747b05fa). But related of _inherits are computed on the
related model so is_product_variant would always be false.

Without fix, added test fails with:

 AssertionError:
  Items in the first set but not the second: True, Items in the second
  set but not the first: False, Product variants are variants

fixes #26961
related to opw-1814973
closes #27163
2018-09-24 09:45:52 +00:00
Yenthe V.GandReinaldo Ramos ecea8c4df3 [FIX] sale_timesheet: set value on correct key
The view timesheet.plan expects a to_invoice key

Fixes #27160

Co-authored-by: Reinaldo Ramos <reinaldo.ramos@arxi.pt>

closes odoo/odoo#27166
2018-09-24 08:10:44 +00:00
Jeremy Kersten ef0f9556f8 [FIX] base: action - fix on_change on new record
Before this commit, if you create an automated action with trigger 'on_change'
it was not called because the run() function don't have active_id.

Now if we have onchange_self in the context but not active id, we call the
function nevertheless. (withtout active_id in context!)

closes odoo/odoo#27167
2018-09-22 21:02:30 +00:00
Nicolas Martinelli ee96c84a60 [FIX] stock: quant domain in valorisation
- Create a Customer location (CL) and set a Company on it
- Configure Product A in FIFO / Perpetual
- Receive 2 Unit(s) of A in Stock
- Create an Internal Transfer
  1 Unit(s) of Product A
  Source location: Stock
  Destination Location: CL
- Validate

The Inventory Valuation report incorrectly retrieves a quantity of 2 in
stock instead of 1.

The error is first due to a misconfiguration: the CL should not have a
Company set. However, we should not take into account any quantity in a
customer location, even if there is a Company set.

opw-1884675
opw-1884835

closes odoo/odoo#27145
2018-09-21 11:50:55 +00:00
Nicolas Martinelli 461871e7f8 [FIX] stock: no company on customer and supplier
Make sure that the company is not set on the customer and supplier
locations of the demo data. Otherwise, any quant in these locations will
be set a `company_id`, which is incorrect (e.g. valuation report will be
incorrect).

opw-1884835

closes odoo/odoo#27144
2018-09-21 08:47:14 +00:00
Christophe Simonis 199eb8dde3 [MERGE] forward port branch saas-15 up to d23601cc67
closes odoo/odoo#27156
2018-09-21 13:09:12 +00:00
Nicolas Lempereur b3a3ad8099 [FIX] document: updateEnv->redraw on not form view
In ac1e187ee some unecessary code and RPC were removed by ignoring
attachments in the sidebar when they would never be shown.

But there was an regression since `updateEnv` function would not
longer call redraw (which is also called in _super function).

report: https://github.com/odoo/odoo/commit/ac1e187eea3#r30569171

related to opw-1865736
closes #27146
2018-09-21 11:08:11 +00:00
Nicolas Martinelli a1501c3e58 [FIX] google_drive: current record
- Open a partner view, click on Action > Partner Review
- Switch to another partner
- Click again on Action > Partner Review

The Google Doc file of the second partner is the same than the first
partner.

This is due to `_onGoogleDocItemClicked` which is always called with the
same `resID`, i.e. the `resID` used at `start`.

We retrieve the active ID at each click instead.

opw-1882068

closes odoo/odoo#27132
2018-09-20 11:37:50 +00:00
Lucas Perais (lpe) f38afe68ca [FIX] l10n_in: right group on invoice lines table
Activate the group in the sale module: Sections on sale orders

Print an invoice

Before this commit, there were twice the same table filled with the invoice lines

After this commit, only one table and the right one is printed

OPW 1885549

closes odoo/odoo#27137
2018-09-20 12:34:51 +00:00
rocketgithub fdc9ea054f [FIX] base: currency and vat label for Guatemala
The VAT label for Guatemala should be NIT:
https://aprende.guatemala.com/tramites/documentos-mercantiles/que-es-nit-guatemala/

Closes #27075

closes odoo/odoo#27085
2018-09-19 07:57:11 +00:00
Goffin Simon 0a823342d5 [FIX] purchase: Error in test
Steps to reproduce the bug:

On a new db, just launch:

./odoo-bin --addons-path=../enterprise,./addons --test-enable -d s11 -i l10n_be,account_accountant,stock,sale_management,purchase

An error occured in test_02_check_mto_chain due to the supplier taxes set on the product.

opw:1878341

closes odoo/odoo#27069
2018-09-18 15:27:59 +00:00
Nicolas Martinelli 0b81117295 [FIX] stock: package content
We clarify the `stock.quant.package` view to highlight the difference
between the case where the content is retrieved from the move lines or
the quants.

Otherwise, this is confusing for a user who sees the same record with
the same view, but not the same content.

opw-1883714

closes odoo/odoo#27098
2018-09-19 13:38:28 +00:00
SimoRubi c5c9627da4 [FIX] stock: incorrect domain
The field `parent_id` has been removed in
https://github.com/odoo/odoo/commit/809605bb8f16cf1398ff5070ec0d5bd568aef343#diff-807e5ce512b0669468b040be7a9c470fL236

Therefore, `child_of` cannot be used anymore.

Closes #26850
opw-1883655

closes odoo/odoo#27083
2018-09-19 07:03:42 +00:00
Goffin Simon 00d286012a [FIX] base: address_format for Mexico
The address_format of Mexico must follow the format explained
in https://en.wikipedia.org/wiki/Address_(geography)

opw:1883174

closes odoo/odoo#27062
2018-09-18 13:32:22 +00:00
dreambits 190841ba41 [CLA] Dreambits Technologies. Pvt. Ltd. signs Odoo's CCLA
Closes #27071
2018-09-19 08:53:34 +00:00
Lucas Perais (lpe) 6ce265b815 [FIX] sale_stock: translate product name
Use case: have a partner in fr_FR while operating with a user in en_US
Create a SO for that partner
add a product which name is translated in french

Before this commit, the description of the sale order line takes the
*untranslated* name of the product

After this commit, it takes the *translated* name of the product

The issue was due to a limitation of sudoing within an onchange for related fields
(typically the case of product.product.name)
In this case, values that are missing in the cache are retrieved from another one

In our case:
First, _onchange_product_id_check_availability triggers the evaluation
of product.name as sudo (later in the stack), without lang in context

Second, the function that actually uses the product.name (product_id_change)
retrieves the value found before from the 'wrong' cache

OPW 1863305, 1884106
closes #27031
2018-09-19 09:12:51 +02:00
Nicolas Martinelli 7640575a24 [FIX] stock: extra move in return
- Create a PO with 5 units of A and 10 units of B
- Receive the products
- Return the picking, but return 12 units of A and 10 units of B

The first picking (done state) will contain:
- 7 units of A, 0 qty done => it is an extra move
- 10 units of B, 10 qty done

But another picking (not done) is created, with
- 5 units of A, 12 qty done

The core of the issue is that the `origin_returned_move_id` is not
copied on the extra move. Therefore, it is not merged by `_merge_moves`
since the latter field is in the list of
`_prepare_merge_moves_distinct_fields`.

opw-1882959
2018-09-19 08:06:13 +02:00
Nicolas Martinelli 2aa5c81248 [FIX] stock_landed_costs: do not prorate
- Set the product A in FIFO, real-time valuation
- Receive 5 units @ 2000 each
- Create a landed cost of 1000, apply on the picking
  => the cost of A is 2200
- Sell one unit
- Create another landed cost of 1000, apply on the same picking

The cost of A is 2360, while one expects 2400.

The value of the move after the second landed cost is computed as:
value = previous value + prorata of landed cost 2
      = 11000 + (1000 * 4/5)
      = 11800

This is not correct. The whole value of the second landed cost should be
taken into account for the `value` field. The prorata is only useful for
the field `remaining_value`.

opw-1878229
2018-09-19 08:04:43 +02:00
len-odoo 0b9d4643ec [FIX] point_of_sale: make test work with localisation modules
When localisation modules such as l10n_no are installed, the test
TestAngloSaxonCommon broke.
We isolate the test more by setting the right accounts on the products to make
the test pass.
This is useful for odoo.sh clients that install localisation modules and see the
tests break.

opw 1881014
2018-09-18 16:04:33 +02:00
len-odoo 598fafb3aa [FIX] website_sale: fallback on partner sales team if undefined on website
When a sale is done on the website, a corresponding sale order is created in the
backend. By default the salesperson and sales team associated to the sale are as
defined on the website.
When we prepare values, we fallback on the partner sales team in a way that is
coherent with the way it falls back on the partner for the salesperson.

opw 1882640
2018-09-18 12:38:02 +02:00
Lucas Perais (lpe) bd4b50f75a [FIX] account*, sale*, website_event, portal: public user not necessarily in right company
Have the main company (A) with the public user
Have an invoice in company B

Make a brand new browser access the invoice with the token

Before this commit: the token link ended up asking the customer to login,
eventhough it wouldn't if the invoice were in company A

After this commit: the whole payment with access token flow works as expected.

OPW 1879999
closes #26744
2018-09-18 11:02:58 +02:00
Thibaud Ducasse c51488c2f4 [CLA] signature for tducasse
Closes #25895
2018-07-24 15:29:31 +02:00
Christophe Simonis 6c736a6874 [FIX] account: lint test file to please pylint check 2018-07-24 15:07:41 +02:00
Julien Machiels e9901d1422 [FIX] barcodes: barcodes working in button in dropdown
On mobile, some barcodes didn't trigger in the picking screens, notably
O-BTN.validate. This is due to the use of parent() to check if the
button is in a dropdown, as parent() only checks one DOM-level upwards.
The button being inside a <ul><li>, we need to check more levels than
one to pass the condition and trigger the button press.

By changing parent() to parents(), the entire chain will be checked, not
just one level, and the button press is correctly triggered.

opw-1860964
closes #25941
2018-07-24 14:45:57 +02:00
Goffin Simon 41bea4125c [FIX] stock: Delivery slip with quantity = 0 until validation
Partial backport of https://github.com/odoo/odoo/commit/ccafe50500a803fe8c8345ab0318128a92bce3b5

Now the initial demand is used when the state is not done.

opw:1867906
2018-07-24 13:00:06 +02:00
Alexandre Kühn b67b89c315 [FIX] web: correctly align value/text in stat button
Before this commit, the style of the value and text in some stat buttons were
broken.

The design of the stat button is to have a single value and a single text which
are stacked as follow:

  [CSS]                       [Visually]           [Example]

  .o_stat_info                +---------+          +------------+
     .o_stat_value            |         |          |            |
     .o_stat_text             |  value  |          | 10         |
                              |  text   |          | Forecasted |
                              |         |          |            |
                              +---------+          +------------+

However, some stat buttons use multiple values or texts. For example:

  [CSS]                       [Visually]           [Example]

  .o_stat_info                +-------------+      +------------+
     .o_stat_value            |             |      |            |
        .o_stat_info          |  value text |      | 3 Hour(s)  |
          .o_stat_value       |  text       |      | Lost       |
          .o_stat_text        |             |      |            |
     .o_stat_text             +-------------+      +------------+

  [CSS]                       [Visually]           [Example]

  .o_stat_info                +---------------+    +---------------+
     .o_stat_text             |               |    |               |
     .o_stat_text             |  text  value  |    |  Min:  10.00  |
  .o_stat_info                |  text  value  |    |  Max:  20.00  |
     .o_stat_value            |               |    |               |
     .o_stat_value            +---------------+    +---------------+

The latter is works fine with block, which guarantees vertical alignment.
However, the former case has some alignment issues like this:

    [Visually]

    +------------+
    |            |
    | 3          |
    |   Hour(s)  |
    | Lost       |
    |            |
    +------------+

This is due to the use of `display:block` for any `.o_stat_text` and `.o_stat_text`.

This commit fixes this issue, without affecting the other cases.

Task-ID 1841523
2018-07-24 12:51:14 +02:00
Martin Trigaux a425695e92 [I18N] remove es_AR translations
Courtesy of Juan José Scarafía, ADHOC
The quality of the Spanish (Argentina) translations is very poor.
Remove them all and will start from scratch, translating only when needed.
2018-07-24 10:45:46 +02:00
Goffin Simon ca14f232e0 [FIX] base_vat_autocomplete: Create contact using VAT number
Let's install base_vat_autocomplete and  base_address_extended
When creating a contact with a VAT number, the street was not
formated by the autocomplete in a correct way because the function checkVat all the time
returns the street with the following format: '%(street_name)s, %(street_number)s/%(street_number2)s'
and this function doesn't take the street format of the country into account.

So the function _split_street tried to split the street into street_name, street_number, street_number2 with the
street_format of the partner but the street was  not well formated by checkVat.

opw:1867491
2018-07-24 09:54:29 +02:00
Jeremy Kersten f045186f23 [FIX] report: fix padding for ul in report pdf
Rendering in html was correct thanks to the webkit-padding-start 40px added
by the browser. But once printed with wkhtml, the padding was missing.

Now we force the padding manually.

This commit closes #7375
2018-07-23 17:02:09 +02:00
Raphael Collet 1748fa2aa0 [FIX] crm: fix access rights in test 2018-07-23 16:32:46 +02:00
Martin Trigaux 7fbf7e233c [IMP] base: do not load local file resources
The generation of the manifest should not be platform dependent, its content
should be the same whatever local files are present on the filesystem
2018-07-28 11:25:24 +02:00
Raphael Collet 629886434c [FIX] crm: fix access rights in test 2018-07-23 16:32:46 +02:00
Martin Trigaux 4c7e74f5e9 [IMP] base: do not load local file resources
The generation of the manifest should not be platform dependent, its content
should be the same whatever local files are present on the filesystem
2018-07-28 11:25:24 +02:00
Christophe Simonis 4e76173a43 [MERGE] forward port branch 11.0 up to 219d2296d6 2018-07-23 16:03:25 +02:00
Christophe Simonis 219d2296d6 [MERGE] forward port branch saas-15 up to c4ee29345a 2018-07-23 15:45:08 +02:00
Christophe Simonis c4ee29345a [MERGE] forward port branch saas-14 up to 9ee882564f 2018-07-23 14:57:03 +02:00
Christophe Simonis 9ee882564f [MERGE] forward port branch 10.0 up to 6e71cf8a71 2018-07-23 14:21:06 +02:00
Priyanka Kakadiya 78a6124d5a [FIX] web: no traceback on button call action of type 'button'.
Before this commit, there was a traceback when clicking on a button
that generates a button call action with type `'button'`.

This is due to the handler of such an action that assumes only a small
set of button actions. Each of those cases correctly sets the local
variable `def` to a deferred, so that the post-processing is correct
(i.e. it handles this variable as a deferred). However, this is wrong
with a different button call action, so that this variable is `undefined`
instead of a deferred.

This commit fixes the issue by ensuring that the variable `def` is always
a deferred. As a result, the post-processing can make the correct assumption
that this variable is a deferred.

Steps to reproduce:

 - Install Google Drive Integration app
 - Go to General Settings
 - In the category "Google Drive", click on "Get Authorization Code"
   (displayed as "Get Author...")

Task-ID 1861630
2018-07-23 13:48:09 +02:00
Christophe Simonis 6e71cf8a71 [MERGE] forward port branch 9.0 up to af2e480e41 2018-07-23 13:41:04 +02:00
Christophe Simonis af2e480e41 [FIX] http: refresh request environment after authentication
This allow the `/web/session/authenticate` route to return correct
partner and company.

Closes #25652
2018-07-23 13:25:42 +02:00
Ivan Yelizariev 1e1d3ed9e6 [FIX] base: suggested default ACL should be safer
When there is no ACL for a model, the system emits a log with a sample
ACL entry that developers should consider adding. This proposed ACL
should be safe: a default read-only access for internal users
seems appropriate.

Closes #25919
2018-07-23 13:18:04 +02:00
Florent de Labarre 3528e804de [FIX] stock: Error message don't contain the name of product
The message don't show the name of product.

Before the fix:

The message was: "It is not possible to reserve more products of than you have in stock."

After the fix:

The message is: "It is not possible to reserve more products of [0221] Product A than you have in stock."

opw:1868449
2018-07-23 12:09:12 +02:00