Commit Graph
124195 Commits
Author SHA1 Message Date
Alexandre Kühn 9445d2f04d [FIX] web: hide nocontent helper in grouped kanban with no column
Before this commit, the no content helper was displayed in grouped
kanban without any column.

It should be hidden, because the user expects to have a button to
create a task, which is intentionally hidden in this case.
(To sum up, the user is expected to create new columns before being
prompted to create new tasks)
2018-02-22 14:23:03 +01:00
Duc Dao ad3cc1b231 [FIX] resource: Fix default empty timezone
Since the method `_get_leave_intervals` assumed that field `tz` is always filled in.
There is a case in default function, when `self._context` had key `tz` but its value was `False`,
which may causes null value of field `tz` and lead to mismatch interval between leave and payslip
2018-02-22 14:09:49 +01:00
Christophe Simonis cf2d07aa22 [MERGE] forward port branch saas-16 up to 521c29317c 2018-02-22 13:53:28 +01:00
Dennis Sluijk f2501bfd3c [FIX] web: return dialog in web.CrashManager functions
This is more a architecture fix than a bug fix.  With this commit, it is easier to modify the behavior of the dialog using the super function. like this: this._super.apply(this, arguments).opened(...)

PR #23255
2018-02-22 12:01:57 +01:00
Goffin Simon 0da5d63f52 [FIX] account: Register a partial payment as fully paid
Due to this commit: 3267e76520

Steps to reproduce the bug:

When registering a payment for a customer invoice in an other currency than
the company currency and marking it as fully paid, it raised an error:
"Wrong credit or debit value in accounting entry !".

Reason: counterpart_aml['debit'] and counterpart_aml['credit'] were both incremented
and it violated the constraint credit*debit=0

opw:815465
2018-02-22 11:52:52 +01:00
Christophe Simonis d4a67bbcf4 [FIX] web_editor: do not try to expose non existant widgets 2018-02-22 11:43:21 +01:00
Goffin Simon 5cdefcc39a [FIX] purchase: Adding PO on refund vendor bill
The function  _prepare_invoice_line_from_po_line has not been
designed to compute in a right the quantity for a  line in an
in_refund invoice. So it has no sens to display the field purchase_id
for a refund vendor bill.

Closes #23095

opw:816717
2018-02-22 11:21:13 +01:00
Nicolas Martinelli 075f13ac63 [FIX] pos_discount: error if misconfigured product
In case the discount product is misconfigured and therefore not loaded
by the POS, a traceback appears when applying a discount.

Add a comprehensive error message instead.

opw-817527
2018-02-22 11:01:40 +01:00
Nicolas Martinelli 310e3c15fd [FIX] pos_discount: default product
Several issues:
- If product `product_product_consumable` was deleted, an error is
  raised.
- The default values are inconsistent with the fact that
  `module_pos_discount` is `False` at POS creation.
- The domain should ensures that both `available_in_pos` and `sale_ok`
  are `True`, otherwise the product won't be loaded by the POS.

opw-814426
2018-02-22 10:50:28 +01:00
Christophe Simonis 9a84ba5533 [MERGE] forward port branch saas-11.1 up to e750bb6e11 2018-02-22 10:39:15 +01:00
Yannick Tivisse 521c29317c [FIX] l10n_be_hr_payroll: Adapt the warrant costs to the new 20% law
https://www.claeysengels.be/en-gb/news-events/m/a/rulingdienst-begrenst-gebruik-warrants-en-opties-op-bevek-aandelen-invoering-van-de-20-grens/

The law seems to change every 2 days.
2018-02-22 10:28:27 +01:00
Christophe Monniez cd21ea414e [FIX] packaging: include missing files needed for tests
The test_mimetypes and base_import modules need various files for their
tests. Before this commit some of those files (.ods, .odt, .xlsx, .docx,
.zip) were not included in the packages.

Fixes #22778
2018-02-22 10:22:42 +01:00
Laurent Smet cdca5d4751 [IMP] account: improve the multi currency handling on register.payment.wizard
Previously, in multi-currency, the user was not allowed to register a payment on several invoices (picked in list view) and choose the currency, or to make a writeoff. This is now possible.
Also, the behavior and default amount/currency proposal is now much better in this wizard since it proposes you to register a payment in the same currency for the total amount (which is what users expect)

[FIX] account_check_printing: fix bad displayed check_amount_in_words

Was task: 34684
Was PR #20466
2018-02-22 10:19:39 +01:00
Lucas Perais (lpe) ab37094ec4 [FIX] website_quote: default require_payment instead of compute
Commit a0f8ee92c3 solved the use case where
a quotation was created through the website shop and where the default quote's
template's require payment should be transmitted to the quote.
However, this commit made the field readonly

This present commit solves both problems by assigning a default to the problematic field
rather than computing it

OPW 817510
2018-02-22 10:17:56 +01:00
Adrian Torres 8e7aaf8c82 [FIX] sale_management/account_invoicing: properly reinstall
Commit 985c224 introduced a way to properly uninstall these two modules,
however if a user were to reinstall them the views would stay inactive,
in the case of sale_management this would mean some menus were missing,
in the case of account_invoicing this meant that not even the top-level
menu would not appear, effectively misleading users into thinking the
module was not installed.

The solution is to create a post_init_hook (to ensure that all
potentially missing menus are already installed) that activates the
previously deactivated menus.

Fixes #23245
2018-02-22 09:55:59 +01:00
Romain Derie 97cae87812 [FIX] portal: use user timezone to display hours on portal chatter
Before this commit:
User timezone would be taken into account when displaying message date on
chatter. It would always display the hour in the server format (UTC).

Now, we correctly use the user timezone to format the date being sent by the
server.

This closes #22812
2018-02-22 08:55:37 +01:00
Joren Van Onder 3ae382f8df [FIX] point_of_sale: do not recompute manually set prices
The POS recomputes order lines when the pricelist changes. This is
different from the sale app on purpose: in a usual POS flow the customer
and thus pricelist is selected after taking the order.

But users commonly use a 'Miscellaneous' product when they are selling
something that is not in their POS system. The user can select this
product and manually set the price. When now a customer is
selected (even if the pricelist has not changed) these miscellaneous
order lines get recomputed. So now the cashier is forced to input
these prices again.

To avoid this we keep track of lines that have had their price changed
through the UI and we don't update them.

opw-817353
2018-02-21 16:12:40 -08:00
Christophe Simonis e750bb6e11 [FIX] sale: remove extra line wrongly added by previous forward-port 2018-02-21 20:43:09 +01:00
Christophe Simonis ae6a65753e [MERGE] forward port branch 11.0 up to dbb713c2f8 2018-02-21 20:19:26 +01:00
Christophe Simonis dbb713c2f8 [MERGE] forward port branch saas-16 up to 49f8548557 2018-02-21 19:17:01 +01:00
Christophe Simonis 49f8548557 [MERGE] forward port branch saas-15 up to 085ff2f9c4 2018-02-21 18:36:36 +01:00
Christophe Simonis 085ff2f9c4 [MERGE] forward port branch saas-14 up to 8c692aac88 2018-02-21 18:09:17 +01:00
Christophe Simonis 8c692aac88 [MERGE] forward port branch 10.0 up to aad677c338 2018-02-21 17:57:00 +01:00
Thibault Delavallée 62e8e5f305 [MERGE] various: add menus to configure activity type and move mail data in their file
Purpose of this merge is to ease future tasks improving activity
configuration, generation and tweak of various mail related data and
features. It contains

 * add menus in hr_recruitment and project to configure activity types;
 * split data in various main applications to have mail-related data in
   their own file;

Future tasks will be about generating activities, improving the mail
activity mixin and removing some subtypes. This merge is related to the
task 60962. #Closes #23232 .
2018-02-21 17:47:27 +01:00
Christophe Simonis aad677c338 [MERGE] forward port branch 9.0 up to 4432e1d5c3 2018-02-21 17:35:11 +01:00
Christophe Simonis 4432e1d5c3 [FIX] project: do not reset task's partner when changing project if project is not linked to a specific partner 2018-02-21 17:26:16 +01:00
Josse Colpaert 6ec6d3e8a1 [FIX] stock: remove action_traceability method on lot fixes #22299 2018-02-21 17:14:13 +01:00
jem-odoo cb53485d71 [FIX] sale: reinvoice only vendor bills
When validating a vendor bill, we want the product
with expense policy set to be reinvoice on the open
sales order matching the analytic account of the invoice
line. Applying the same mecanism for customer invoice
does not make sense, as we might confirm a SO and validate
its invoice, we don't want a new SO line to appear (avoid
loop).
Unfortunately, since a long time, this is possible in Odoo,
and really make no sense. We should only take negative
analytic lines (coming from vendor bills and expense, not
the customer invoice) into account for adding SO line.

This commit correct this problem to avoid having
many null SO line created on customer invoice validation.
All test cases are correctly written, but there was no
check to prevent this mecanism to be apply on customer
invoice.
2018-02-21 16:59:39 +01:00
Thibault Delavallée 1aa0f9a4db [MOV] maintenance: split data to separate mail data from other data
It is simpler to have data split by main model or application like we
already do for models and views. It allows to easily have an overview
of data a module holds.

As we will work on mail related data like adding activities or tweaking
subtypes and templates, having them all in a single file and not lost
between other data helps finding and working with it.

This commit only moves code. No functional change should occur.
2018-02-21 16:52:28 +01:00
Thibault Delavallée 12ef8b6312 [MOV] sale: split data to separate mail data from other data
It is simpler to have data split by main model or application like we
already do for models and views. It allows to easily have an overview
of data a module holds.

As we will work on mail related data like adding activities or tweaking
subtypes and templates, having them all in a single file and not lost
between other data helps finding and working with it.

This commit only moves code. No functional change should occur.
2018-02-21 16:52:15 +01:00
Thibault Delavallée 561ae286f9 [MOV] hr_expense: split data to separate mail data from other data
It is simpler to have data split by main model or application like we
already do for models and views. It allows to easily have an overview
of data a module holds.

As we will work on mail related data like adding activities or tweaking
subtypes and templates, having them all in a single file and not lost
between other data helps finding and working with it.

This commit only moves code. No functional change should occur.
2018-02-21 16:51:38 +01:00
Thibault Delavallée 0e595ee81a [MOV] hr_holidays: split data to separate mail data from other data
It is simpler to have data split by main model or application like we
already do for models and views. It allows to easily have an overview
of data a module holds.

As we will work on mail related data like adding activities or tweaking
subtypes and templates, having them all in a single file and not lost
between other data helps finding and working with it.

This commit only moves code. No functional change should occur.
2018-02-21 16:46:53 +01:00
Martin Trigaux 113385fdd7 [FIX] pos_mercury: do not translate mercury XML
untranslatable content
2018-02-21 16:43:30 +01:00
Thibault Delavallée 634a688653 [MOV][IMP] project: improve action to configure activity types and move in its own file
Purpose of this commit is to ease project managers in their daily job
organization by ensuring that newly created activities in project
configuration are by default associated to tasks, and not global.

Activity types actions and views are moved in their own file in order
to match the guidelines.
2018-02-21 16:43:26 +01:00
Thibault Delavallée 883f634ec8 [IMP] hr_recruitment: add menu to configure activity types
Purpose is to ease HR recruitment people in their daily job organization
by allowing to tune activity types. A menu is added in configuration to
access activity types. Those are by default associated to the applicant
models.
2018-02-21 16:41:53 +01:00
Christophe Simonis 68379cadbc [MERGE] forward port branch 10.0 up to 2bdc0cc7eb 2018-02-21 16:37:49 +01:00
Swapnesh Shah d6174dd226 [Fix]mrp: Removed unused copy_data method 2018-02-21 15:55:08 +01:00
Nicolas Martinelli c0fa53e45c [FIX] crm: link in planner
The link to configure incoming emails is not correct anymore after the
Sales reorganization.

opw-813987
2018-02-21 15:49:14 +01:00
Yannick Tivisse 4d614f55c3 [FIX] l10n_be_hr_payroll: Use the warrant costs on gross computation
Purpose
=======

The warrant cost formulae has been modified at 5d22170.

Instead of using the (remaining) warrant costs formulae, use the corresponding field instead.
2018-02-21 15:14:26 +01:00
Christophe Matthieu 5fb21b4db4 [FIX] web: evaluation of xml templates must be retro compatible
Issue:
domain="[('date','=',time.strftime('%%Y-%%m-%%d'))]"
is converted into a domain equal [('date','=','%2017-%12-%12')]
instead of [('date','=','2017-12-12')]
2018-02-21 15:09:16 +01:00
Aaron Bohy 898cd0a5c1 [FIX] web: Calendar: display period in breadcrumbs
In Calendar views, the displayed period should be written in the
breadcrumbs (e.g. in month mode, '(February 2017)'). This has been
broken by rev. 7b6056a0b5.
2018-02-21 14:56:18 +01:00
Christophe Simonis 2bdc0cc7eb [MERGE] forward port branch 9.0 up to 2120e667b9 2018-02-21 14:36:35 +01:00
Olivier Dony af7860c94c [FIX] project: restore portal visibility
Odoo 11 comes with unified features for Project Tasks and Project
Issues. Specifically, issues were retro-fitted into tasks, and saw their
specific features added to the features of tasks.
During this refactoring, the portal controller for issues was superseded
by a unified portal controller for tasks, via
623ea43268

One case was lost in the process: portal visibility of
tasks/issues/things that are individually followed by customers, without
the customer following the project itself.
This is important for `transversal` projects, such as a "Helpdesk"
project common to all customers, where each customer only sees their own
issues.

This commit restores the feature, previously added to issues by
1cc8252a95

Note: this clearly requires a proper regression test, to be added soon.
2018-02-21 14:12:15 +01:00
jem-odoo 95f6743054 [FIX] sale_timesheet: improve new demo data
Some label or name for new demo data are not clean.
This commit imrpoves them by:
- rewritting clean descirption for timesheets
- set negative amount for expenses analytic lines
2018-02-21 14:04:00 +01:00
Nicolas Martinelli 1fa6b63c0f [FIX] stock_account: groupby
Set the groupby according to what is done in `_read_group_raw`.

opw-816358
2018-02-21 14:03:40 +01:00
Nicolas Lempereur e2280783a2 [FIX] mail: no view edit on forum link in notif
When sending notification from the frontend, if a template is rendered
for it and the user has the group "website.group_website_publisher" he
will get inherit_branding adding on elements things like:

  data-oe-id="42" data-oe-model="ir.ui.view" data-oe-field="arch"

but the chatter system has feature automatically redirecting an element
that have attribute "data-oe-id": this caused for example that a
link notification towards the forum would instead be redirecting to
editing the view of the notification.

This fix distinguish the inherit_branding in the chatter feature and
ignore them.

opw-813333
closes #23225
2018-02-21 13:39:25 +01:00
Thibault Delavallée 1feeff4deb [FIX] mail: fix display of unnecessary : in message about activity done
If the activity had no summary the messages has a : leading to nothing
which is not very nice. If there is no summary, only display the "done
by" message followed directly by the feedback.
2018-02-21 13:35:11 +01:00
Nicolas Martinelli 005614ef72 [FIX] stock_account: apply ir rules
- Enable multi-company: without sharing products and partners
- Create 2 companies (company1 and company2)
- Create 2 users one for each company
- Create inventory transaction (receipt) by user1 in company1
- Create inventory transaction (receipt) by user2 in company2
- Using user2 run inventory valuation report with 'At a specific date'
  option.

You got read access error for product.product.

This is due to commit 5c5098f740. We should apply the `ir.rules` to
the query.

opw-816663
2018-02-21 13:31:20 +01:00
Nicolas Martinelli 1460ed08c9 [FIX] mail: tracking of custom field
- Create a custom field
  Field Type: monetary
  Tracking: Always
- Install any module

A crash occurs in `_instanciate_attrs` since `attrs` is `None`.

In some special cases, the instanciation of the attrs of a field is
delayed at the very end of the setup. For example, in case of a Many2one
for which the comodel is not yet loaded.

Therefore the override of the method should take this case into account.

Closes #22922
opw-815185
2018-02-21 13:27:02 +01:00
Christophe Simonis eebc7b6e32 [MERGE] forward port branch 10.0 up to 1512618d3e 2018-02-21 12:42:46 +01:00