Currently, the rounded-pill around many2many_tags_email tags is not rendered correctly: the color and the box-shadow style attributes are not applied.
This commit fixes that by adding the o_tag class to email tags, in order to apply the o_tag.o_tag_color_0 css rule.
closesodoo/odoo#103770
X-original-commit: 2a61a3c17c933c712c05a10359ee0d8bffa1dccc
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Some of our current bus notification only insert data in the models system. We
can now simplify the way we handle them by using a generic `mail.record/insert`
handler.
closesodoo/odoo#102863
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The emoji search bar should not be automatically focused when using odoo
on mobile.
This commit re-introduce the auto-focus of the search bar, and also
cancel auto-focus if using odoo on mobile
Task-3015386
closesodoo/odoo#103672
X-original-commit: 282a09c5d62d32a35636c9357033b8f18631b85f
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This commit introduce a field to determine condition for
reloading chatter parent view when a file has changed.
This allow patching the field so that more conditions
could trigger a view reload.
Task-2886634
closesodoo/odoo#103660
X-original-commit: 3e097db1c92a316fb7c5de0ce6124ce5ea7e07be
Related: odoo/enterprise#33005
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Move code from components to models, so that eventually all the
business logic is in models.
The benefit of business code in models is to ease proper modelling
of whole state of the discuss features, which is highly desireable
for easily maitainable code or to implement sophisticated features
in a robust way.
[IMP] mail: move code to models (AttachmentViewer)
Task-2996277
[IMP] mail: Move code from components to models (DropZone)
Task-3004211
[IMP] mail: move code from components to models (ChatWindow)
Task-3004259
[IMP] mail: Move code from components to models (ChatWindowHiddenMenu)
Task-3014736
[IMP] mail: Move code from components to models (ChatWindowHiddenMenuItem)
Task-3004253
[IMP] mail: pass only record as props (ChatWindowHeader)
Task-3001202
[IMP] mail: Move code from components to models (MessageList)
Task-3004204
closesodoo/odoo#103591
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, when a recipient is suggested in composer header
and current user click on checkbox, there was the following warning
in the console:
```
read-only SuggestedRecipientInfo/isSelected on record(SuggestedRecipientInfo_1) was updated
```
The state of a selected suggested recipient is determined by being
manually selected on UI, but also that there's a partner related
to this recipient. `isSelected` is a computed field with itself
as dependency, and it was also imperatively set. We don't want
any computed field to be set imperatively, hence the warning in
the console.
This commit fixes the issue by introducing another field that
is specific to selection on UI by current user. This field does
not depend on whether there's a partner. This field is imperatively
set, and then `isSelected` is fully declarative as a computed field
with no self dependency and no imperative update.
Task-3032869
closesodoo/odoo#103573
X-original-commit: 8e2980e1e871a8046f09d3d0affb6400ee030eeb
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
WebClientViewAttachmentViewContainer was missing in the FormRenderer components
This prevented opening account.payment lines from the Batch Content tab of Batch Payments
closesodoo/odoo#103450
X-original-commit: 2d58c5bf8679cffd4d0ad33782f47962b72cc3cd
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The toggle star action view currently does not take into account the
starred state of the message, returning "Mark as Todo" unconditionally
as a title for the button.
This commit adds a check for the starred state to return an appropriate
title if the message is already starred.
closesodoo/odoo#103432
X-original-commit: b77660850bb0dbf4fad2a52d931e230f4acde975
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
When having falsy values, we may end up with 'False' as a string. Better be
defensive when trying to parse res_id.
Task-3025143
closesodoo/odoo#102576closesodoo/odoo#103378
X-original-commit: ac8d97262d196c7bb4c4fc15db63cc66512be838
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
These are deprecated since Owl 2, and lead to memory leak in the
compatibility layer. This PR removes the last ones in the mail code.
task-2877316
closesodoo/odoo#103301
Related: odoo/enterprise#32842
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, the active category was wrongly computed,
which results is wrong display of the active category while
scrolling and while clicking on the category bar.
The bug was that computation relied on condition of 1st rendered row,
instead of 1st visible row. Rendered rows include the extra before
the 1st visible one, here 10 extra rows above.
As a result, the computation of active category acts as if the
viewport was offset by 10 rows upward.
Task-3017324
closesodoo/odoo#103124
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
On the emoji picker, additional rendered rows on top and bottom
were not loaded correctly on top.
This commit fixes the top rendered rows not working properly.
Also fixes computation of some fields that should contain
integer values (index) but had float instead, which required
late rounding.
Task-3000424
X-original-commit: 24d9b970d032709b8f80cf49da057156ccd7fde5
Part-of: odoo/odoo#103124
Prior of this commit records without activities buttons were rendered
with a double border (eg. CRM > Sales Teams > Team's formView).
This commit will adapt the layout accordingly avoiding to render a
border when it's not necessary.
closesodoo/odoo#103145
X-original-commit: 1903f7aa2553b555b58df066f584feb4caf25e71
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, the callViewer could end up too small and only have
space for the callActionList, which was hiding call participants.
taskid-3014640
closesodoo/odoo#103144
X-original-commit: b9370f5fdf0dcbcf23280f370408eab5183433e6
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, trying recover a connection that didn't exist
anymore would cause a traceback. This commit fixes this issue.
closesodoo/odoo#103088
X-original-commit: 44973577e4bfc7b36b5d3aa356519a36fb6ecc78
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
This PR improves the style of the kanabn actiivty popover after the wowl
refactoring. It focuses on:
- Restoring button hover style
- Restoring scroll behavior for multiple activities
- Restoring text ellipsis on long activity summary/name
- Centering mark done buttons
task-2998139
closesodoo/odoo#102983
X-original-commit: 2cebfd9
Related: odoo/enterprise#32667
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, when clicking on category in category bar,
the search bar was (re-)focused.
It was flickering, especially when device prompt a soft keyboard,
such as on mobile.
This commit fixes the issue by not (re-)focusing the search bar
when clicking on a category from the category bar.
Task-3013819
closesodoo/odoo#102987
X-original-commit: 61790c029b3b78c2a099ec72b0d688c28d803374
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, when clicking on a mail failure in
the messaging menu in mobile, it crashed.
`NotificationGroupView` is already destroyed, so it crashed
due to attempting to access a field (`messaging`)
Task-3013202
closesodoo/odoo#102986
X-original-commit: 73b94715f0d0086d361937491c27c611a03a9f67
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Instead of having a dedicated module for all-things dark mode related,
this commit moves the (S)CSS files into their respecting modules and
uses `web` and `web_enterprise` to provide the base infrastructure for
the dark mode (cf. dedicated assets bundle).
Note:
Don't forget that you have to handle 2 cases:
1: SCSS variables must be placed BEFORE bright ones
2: CSS variables must be placed AFTER
task-2710677
Part-of: odoo/odoo#102868
Prior to this commit, the border of any badge was set to "1px
$o-brand-primary" in order to achieve the default badge design that
comes with transparent background.
Unfortunately this rule was affecting colored badges too, leaving no
choice rather then either remove the border (causing misalignment with
siblings default badges) or hide/re-color/keep the undesired decoration
, but with mixed results.
These commit will review the behavior applying an outline (that doesn't
affect badge's placement) to "default badges" only.
Commit preparatory to the introduction of dark-mode.
task-2710677
Part-of: odoo/odoo#102868
Since the view's background-color has been historically white, the
`bg-white` class has been used to make match several UI components.
Despite working for the default color-scheme, this approach leads to
inconsistencies when the default view's background-color changes, eg.
dark-mode.
This commit introduce 'bg-view' to set any element to match the view's
background-color, whatever it is.
Commit preparatory to the introduction of dark-mode.
task-2710677
Part-of: odoo/odoo#102868
BUE
Steps to reproduce
- go to Apps, switch to studio and create and create a new app.
- on the form view, add a Many2one field related to 'Sales Order'.
- add a Ralated Field, related to 'Sales Order > Total'. You will be
presented with a prompt informing you that you need a currency field
on the model. Click 'OK' to add the currency field.
- again, add a Ralated Field, related to 'Sales Order > Total'.
- close Studio, fill the form you just created and save.
- switch back to studio and, again, add a Ralated Field, related to
'Sales Order > Total'.
You will be met with a traceback.
FIX
Actually defining a currency field on currency fields is mandatory. We
don't have to provide a fallback, hence we don't have to fix the fallback.
Simply remove it.
Task-3012648
opw-2951697
Closesodoo/odoo#94831Closesodoo/odoo#94962closesodoo/odoo#102918
X-original-commit: 899f3b4897f34576d502cf442ab7059c489870dd
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The field was not correctly aligned because the invisible rule was not
the same on the field and the sibling's DIV. So in some case, we can
have an empty DIV present with no label (e.g. when `is_log = false` and
`composition_mode = mass_mail`).
Note that now with grid, we need two filled columns otherwise we will
have a shift for the next following labels/fields, because grid will try
to fill the empty space.
Steps to reproduce:
* Open Helpdesk
* Select a Team
* Select the list view
* Check a row (line)
* Click on "Action" menu
* Click on "Send Email" => BUG
closesodoo/odoo#102941
X-original-commit: 52c8a8f4c16fe5765d64265f718164162f1cf172
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Form view has multiple containers that are exclusive, before this commit
switching from one container to the other would lose all current chatter state.
closesodoo/odoo#102934
X-original-commit: a3d151d0c9c84c2dcffc28a342c40f38d0b28370
Related: odoo/enterprise#32644
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
*: mail, website_livechat
This commit adds new option in Livechat Button visibility
"Show with notifcation", which allow to see livechat button
and also display a customizable floating text next to button.
This text appears 1 second after the livechat button become visible.
Task-2937993
closesodoo/odoo#102930
X-original-commit: 785356f46b49d1b3d9b975319c87f39266694b82
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
There is no strong need to have default values on identifying fields,
while allowing it adds overhead to every insert. The trade-off is not
worth it, therefore this commit removes the support for identifying field
default values and simplifies the code of findFromIdentifyingData
accordingly.
closesodoo/odoo#102912
Related: odoo/enterprise#32634
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Context:
We want to get rid of default values on identifying fields, and
SoundEffect/path is currently the only field to present this pattern.
Merging path and filename fields together makes the default value no
longer meaningful, as there is no full path that is shared by multiple
records and which would therefore consist of a relevant default value.
The point of removing default values from identifying fields is to
simplify the code of findFromIdentifyingData, which is called by every
single insert, so that we no longer have the overhead of looking for
default values.
This commit modifies the SoundEffect model in order to enable the
simplification (and therefore, optimization) of findFromIdentifyingData.
Part-of: odoo/odoo#102912
In 15.3, the width was applied on `o_form_sheet_bg`.
As the form view has been refactored in 16, we have to apply
it on the new parent `o_form_view_container`.
We also restore the chatter width to the same value as in 15.3:
```scss
.o_FormRenderer_chatterContainer {
&.o-aside {
width: $o-chatter-min-width;
}
}
```
Steps to reproduce:
- Open Helpdesk on screen at 1534x657
- Open a vip support
- Unfold 'Done'
- Click on 'Ugly Chair', the chatter take a lot of space => bug
Steps to reproduce
- Open Sales
- Open a quotation
- Switch between Order lines, Other info, Customer Signature
notebook tabs a flicker occurs => bug
closesodoo/odoo#102911
X-original-commit: 3e71df358caf878409947af1619378fbfeb2be4b
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Before this commit the creation of the message(s) was done within a for loop in a big function.
Due to this there is no easy nor clean way to override and modify values on the mail.message record(s).
By placing the preparation of message data in a subfunction it can be overwritten and modified as wanted.
closesodoo/odoo#102825
X-original-commit: 6d6d7c12ac456e648bd35645f9617cd1d8ff60e6
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this PR, the chat window hidden menu dropdown would have been
opened to the bottom of the corresponding button. The issue is that,
this button is position at the really bottom of the page, causing the
dropdown to be outside of the page.
This PR fixes this issue by adding the missing `data-bs-toggle`
attribute.
task-3011161
closesodoo/odoo#102765
X-original-commit: a4b69feb13852dd13160564bce3b0ae1cb453c0b
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>
`activeActions` is a set of boolean values determining what actions
(i.e. 'create', 'delete', etc.) can be performed on the current view or
subview (x2many).
Before this commit, the x2many fields used a different naming convention
than the one set on the views (e.g. 'canCreate' instead of 'create').
This caused mismatches when subviews would try to rely on the parent
view `activeActions` to define their own. This also introduced a bad
design where the "type" of `activeActions` would be determined by that
same mismatch.
Another issue was that the list renderer did not always check for the
existence of activeFields in its props, despite defining them as
optional.
This commit unifies the names of the active actions accross views and
x2many fields, while adding a "type" property to it s.t. its owner
can determine what context it finds itself in.
closesodoo/odoo#102115
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Before this commit the neutralize system introduced in v16 was using ORM
methods in order to change appropriate records. Although flexible, this approach
could lead to call some methods with side effects while neutralizing
(eg: overloads of write).
This patch converts the neutralize system to a safer "inert" SQL based approach
by migrating the generic method _neutralize to SQL files exposed in the
data folder.
Task id: 2961687closesodoo/odoo#102792
X-original-commit: e5dbded9bb363351feff7ca8a56c7f8a6860f492
Related: odoo/enterprise#32580
Signed-off-by: Fabien Meghazi <fme@odoo.com>
The commit odoo/odoo@babf7634e0 broke a
previous fix in odoo/odoo@6228500a3f
allowing the chatter to grow beyond its original size.
This commit restores the `flex-grow: 1` on the chatter's container but
also limit its maximum width (like in saas-15.3) to avoid it becoming
unreadable.
closesodoo/odoo#102767
X-original-commit: 3db27dc6c2e22b2b86650d1828f8e52929c43df6
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Signed-off-by: Romain Estievenart (res) <res@odoo.com>
Before this commit, some mouseenter and mouseleave
handlers were prone to raising a traceback due not
being properly guarded.
closesodoo/odoo#102652
X-original-commit: f0dafec5c17b0ae0c645156a253c5d93beea7372
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Remove no longer needed `!important` on `overflow: visible` because the
new list view doesn't have any stacking context issue. Thanks to the
`o_PopoverManager` inside the `o-main-components-container`.
Steps to reproduce:
> Open the helpdesk app
> Click on VIP Support tickets
> Go to the list view
> reduce the size of the activities column
=> it's produce text contain overlapping with the other column => bug
X-original-commit: e22abffdc230c2ae494a85fdf7fd8d6b488be3ea
Part-of: odoo/odoo#102608
Add missing feature of the ModelFieldSelector popover :
* keyboard navigation
* additional debug value
* add default value page ( for dynamic placeholder)
* add validate callback
Migrate dynamic placeholder to be compatible with new OWL field.
task-2978722
X-original-commit: 929108e29168058fad5da85e0ff9c66d2c5b2525
Part-of: odoo/odoo#102603
This commit force the button's width to the longest string available,
depending by the language either "Following" or "Unfollow".
It also force "Unfollow" text-color to "warning".
Indeed, since it appears on :hover only, the text color used was
ultimately the :hover(ed) version, that's substantially darker.
task-3005130
closesodoo/odoo#102528
Related: odoo/enterprise#32453
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Reproduce:
Click "send_reminder_preview" button on purchase form and error raise.
Missing check if actions are None or not before get its length.
closesodoo/odoo#102563
X-original-commit: 0ba99bd71d47571ac748ab0ecd68c52891cddb9f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Yuchen Huang (yhu) <yhu@odoo.com>
Previously, the emoji data that is used in the emoji grid was part of
the main assets bundle. This file is almost 500kB and the data it needs
is only needed when opening the emoji grid. This commit moves this file
into its own bundle and only loads it when opening the emoji grid
instead.
This PR also batches the inserts in the emoji model, bringing the time
it takes to do those inserts from ~8000ms to ~800ms.
closesodoo/odoo#102562
X-original-commit: e272e4fc6abce3153cce3748d8a5a7df63565916
Related: odoo/enterprise#32468
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The commit https://github.com/odoo/odoo/commit/c877cab866f2c1968f4f9aaf8ceebc02fa014eed
has recently refactored the css of the kanban column progress bar making
the rules for o_legacy_kanban_counter be applied only in legacy kanban
views. This lead the style of the progress bars in activity view to be
broken. Here we fix that style by copying the rules we want in the
file activity_view.scss.
closesodoo/odoo#102520
X-original-commit: 84788c27a6c22a55bb0d7e375ae60b78beeea050
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Shawcker