Commit Graph
37 Commits
Author SHA1 Message Date
Xavier Morel aab90cc5bd [FIX] crm: recompute mail.alias defaults when *unsetting* use_leads on teams
Default mail.alias for crm.team are currently recomputed/modified
when *setting* use_leads on the team (type changes from opportunity to
leads), but not the other way around (*unsetting* use_leads doesn't
rollback type to opportunity).

Fix this issue.

Leaves over the issue that *disabling* the global setting doesn't
recompute aliases, which it probably should.

OPW-728690
2017-04-24 10:10:33 +02:00
Martin Trigaux 2c1257fe88 wow 2017-03-17 14:40:45 +01:00
Martin Trigaux 13bfc8ee50 [FIX] crm: remove unused field from fields to merge
The field email is no longer present on the crm.lead object

opw-725112
2017-03-17 14:33:44 +01:00
Nicolas Martinelli c0f1f27dbd [FIX] crm: translation in merge message
- Install a language different from English, set it to your user
- Merge two opportunities

The merge message which summarizes the operation contains the name of
the fields in English.

opw-708381
2017-03-07 12:09:45 +01:00
Olivier Dony daff406a22 [FIX] crm: re-introduce fix of b46b0936a8
The new API migration in aa44700dcc
discarded the b46b0936a8 patch,
reintroducing the bug.
2016-12-07 13:00:34 +01:00
Jeremy Kersten e94de1484f [FIX] *: make field 'name' from some *.tag model tanslatable 2016-11-22 16:44:25 +01:00
Christophe Simonis dece72d010 [MERGE] forward port branch saas-12 up to ca20038 2016-11-15 13:58:55 +01:00
Jeremy Kersten 6b3b18958d [FIX] crm: merge don't tamper fields constant
Based on odoo/odoo@ec6a6782
This commit fix opw-692280

Override from _merge_data in website_crm_partner_assign add 3 fields to
the list of fields to merge.
Before this commit, 3 fields was added at each merge and so the chatter
become very long with many duplicated field.

Bug introducted by migration new api.
2016-11-14 15:21:02 +01:00
Nicolas Martinelli c544aa298f [FIX] crm: kanban color
Commit 4b2091e8c9 introduces a change in the state color of the kanban
view. However, that doesn't match the description.

opw-693540
2016-11-14 09:14:27 +01:00
Christophe Simonis 341bea8f88 [MERGE] forward port branch saas-12 up to 43cb4ac 2016-10-10 13:00:05 +02:00
Olivier Dony f9da4970ab [MERGE] Forward-port saas-11 up to eb6b256f99 2016-10-04 01:20:17 +02:00
Thibault Delavallée 458aaca328 [IMP] mail: reimplement grouping of notification recipients
There is now a single method easier to inherit to add specific behavior
for the display of access button as well as actions buttons. All addons
using this mechanism are updated accordingly.
2016-09-23 10:01:41 +02:00
Christophe Simonis 856476d441 [MERGE] forward port branch saas-12 up to b1b700a 2016-09-22 15:23:45 +02:00
Jeremy Kersten 6d8ae0a039 [FIX] crm: fix bug introduced by new api in #aa44700
Before migration:
  'phone': customer and customer.phone or lead.phone,
After migration:
  'phone': customer.phone if customer else self.phone,

So if a customer exists and that it has no phone, the phone
on the lead need to be preserved during convertion in opp.
2016-09-20 12:25:45 +02:00
Martin Trigaux fe0cbf897d [FIX] add missing tag and correct typo
Thanks Transifex reporters
2016-09-19 16:20:30 +02:00
Raphael Collet fa082019a0 [IMP] models: change API of _group_by_full
The dictionary `_group_by_full` is replaced by a field parameter `group_expand`
that is assigned to the method name.  The API of the method has been simplified
as well:

    @api.multi
    def _read_group_stage_ids(self, domain, read_group_order=None, access_rights_uid=None):
        # the stages are given by self.ids (wrong model);
        # read_group_order is the order given to read_group() on self;
        # return stages.name_get(), {stage.id: stage.fold)

    _group_by_full = {'stage_id': _read_group_stage_ids}

is now written:

    stage_id = fields.Many2one(..., group_expand='_read_group_stage_ids')

    @api.model
    def _read_group_stage_ids(self, stages, domain, order):
        # stages is a recordset;
        # order is the order to use on stages' model;
        # return a recordset which is a superset of stages
2016-09-16 17:35:24 +02:00
Martin Trigaux d22676dc07 [FIX] typo 2016-09-07 16:19:39 +02:00
Raphael Collet bf668b64c1 [IMP] all: clean usage of safe_eval
Specifically: do not import `safe_eval` as `eval`, keep it explicit instead.
2016-08-11 15:36:56 +02:00
Jeremy Kersten d8e33e2ced [FIX] crm: remove team_id field from crm_lead_tag model
Now tag are always shared between all saleteams

Courtesy of @antonylesuisse
2016-07-07 17:52:02 +02:00
Jérome Maes 4f48319207 [FIX] crm : activity should not be a default subtype by default
This aims to prevent everybody to follow the activity
subtype. It prevents the default behavior of
mail.message.subtype.
2016-07-04 17:28:06 +02:00
Xavier Morel d9b2f47fb1 [FIX] crm : apparent bug in handle_partner_assignation
Starting from 32fb2f0940 if a lead is
already assigned to a partner instead of returning the already assigned
partner we ignore that, possibly reassign the lead and return either the
new assignment or ``False`` (if not in action=create and no partner_id
was provided).

This seems like an error which passed through and was never noticed as
the method isn't called much and only from wizards.

Either way, revert that. And remove the comment which apparently was
never updated.
2016-07-04 17:28:06 +02:00
Xavier Morel 5b02825194 [FIX] crm : name_get use
In the new API, ``name_get`` doesn't normally lose sort information
anymore: the result of ``search`` (or ``browse(_search)``) is correctly
ordered and ``name_get`` sequentially resolves record names.

Thus the post-facto re-ordering mess should be unnecessary,
``records.name_get()`` will be ordered as ``records`` is.
2016-07-04 17:28:06 +02:00
Xavier Morel 3e2e1d6b90 [IMP] crm : various code cleaning
- try to make better use of recordsets (and recordset APIs)
- remove pointless decorators
- remove redundant ensure_one
- make 'stage_find' a private method returning a recordset
- etc ...
2016-07-04 17:28:06 +02:00
Jérome Maes 4f899f17d4 [IMP] crm : add related fields from subtype to avoid override create method
Using the field inheritance to avoid patching create method. So the
res_model and iternal field are directly related to subtype.
2016-07-04 17:28:05 +02:00
Jérome Maes 1b2ba5707d [IMP] crm : remove try/except from computed fields
Rather adding a group on the view to avoid Access
Error, than adding a try/except catching the
exception for opportunities and mettings count on
partner form view
2016-07-04 17:28:05 +02:00
Jérome Maes 58bd6a848f [IMP] crm : change return values of merge_opportunity method
Since new API works with record, convert the return values from ids
into recordset.
2016-07-04 17:28:05 +02:00
Jérome Maes 1414b3e56e [REF] crm : some code improvements
- remove backward compatibility method `case_mark_won` and `case_mark_lost`
- change signature of `find_stage` method, by setting team_id optional, since
we can get if from `self.team_id`
- remove unused methods in crm_lead.py
- remove unsed code in base_merge_partner.py
- remove unused method in res_partner.py
2016-07-04 17:28:05 +02:00
Ravi Gohil aa44700dcc [MIG] crm : migration to new API
Also adapt code in crm_partner_assign according to migration of crm.lead
2016-07-04 17:28:04 +02:00
Jérome Maes 01886c9990 [FIX] crm, website_crm_partner_assign : fix dependencies due to moved files 2016-07-04 17:28:04 +02:00
Jérome Maes fa7fdc525a [MOV] crm : reoganize module directory and files 2016-07-04 17:28:03 +02:00
qdp-odoo 7a3d63b377 [MERGE] forward port of branch saas-7 up to revision 71d16a369e 2016-03-16 10:27:19 +01:00
Goffin Simon e2b3d50ca9 [FIX] crm: deleting a crm.activity
crm.activity inherits mail.message.subtype with the field subtype_id
Before rendering "chatter.ChatComposer", the internal subtypes are fetched
on model mail.message.subtype(in function "fields_view_get").
But when deleting a crm.activity, the linked mail.message.subtype was not
deleted.

Used case:

When deleting a crm.activity, the activity still appeared in the chatter
if you log an internal note for an opportunity as an employee.

opw:670654
2016-03-14 13:30:21 +01:00
Fabien Pinckaers 60c010d306 [IMP] crm: activities reloaded
Activities in opportunities are now handled through a wizard and not through
the form view anymore. The wizard is called via a Log an activity button. The
wizard allows to log an activity and to schedule the next activity. It
replaces the various <next activities> / Done / Cancel link buttons on the
form view that nobody seemed to inderstand.
2015-11-26 10:48:25 +01:00
Thibault Delavallée ebcc2ea4eb Revert "[IMP] better handling of next activities"
This reverts commit ab303435d3.

Changing a feature one week before freezing a new saas, without review,
without spec, without testing, does not seem to fit the R&D process.
This commit will be set in a branch, tested and reviewed accordingly.
2015-11-20 10:18:52 +01:00
Fabien Pinckaers ab303435d3 [IMP] better handling of next activities 2015-11-19 15:15:21 +01:00
Martin Trigaux 087f8bed48 [FIX] correct some English mistakes
Missing spaces, typos, rephrase unclear text
Courtesy of Eric Geens
2015-09-10 12:22:17 +02:00
Jay Patel ff2b14d4c3 [IMP][ADD] crm: add the concept of activities, allowing
to define custom light workflows on opportunities.

Activities are linked to mail.message.subtype through inheritance.
This means that the follow mechanism works for activities. When
an activity is done, a message with the matching subtype is posted
on the opportunity.

Activities are internal by default. They are only visible by
employees.

A shortcut in the 'log a note' chatter option allows to post a
note linked to an activity (subtype).
2015-07-08 17:15:22 +02:00