Commit Graph
308 Commits
Author SHA1 Message Date
Nicolas Lempereur 5ed198294f [FIX] account: fixes reconciliation mode change
When reconciliating manually, it may be possible to filter between
`All`, `Customers`, `Suppliers`, `Others`.

When changing this mode, we could end up in a situation such as:

1)

- reconciliation widget X is available
- reconciliation widget line XB is being loaded
- mode is changed -> reconciliation widget X is removed
- reconciliation widget line XB loading finishes

-> error because the parent reconciliation widget exists no more.

2)

having no (or less than the expected) or too few results because
removing reconciliation items (when for example we switch from supplier
to customer mode) can be done asynchronically. But the code expected it
to be done synchronically. Also all elements displayed were removed
instead of only the ones of other types.

thus instead of displaying the expected number of reconciliation items:
 MIN({num of record to display}, 10)

the records displayed were:
 MIN({num of record to display}, 10 - {num records displayed before})

which could amount to 0 event if there was thousands available ones.

This commit solves these two issues:

1) by not adding line to a reconciliation item without error,
2) by counting and removing displayed items correctly

opw-725796
opw-728309
2017-04-20 08:23:27 +02:00
Lucas Perais (lpe) d24f86337e [FIX] account: account_reconciliation: t-values shouldn't be translatable
+ .pot update
OPW 706759

Closes #16239
2017-04-05 08:51:10 +02:00
Martin Trigaux 685f146d48 [FIX] account: correct pluralisation
Do you ever think about translators?
"Bankafschrift afsluitens" is not valid Dutch

opw-709657
2017-02-24 11:01:54 +01:00
Martin Trigaux e8f1c5dbc6 [FIX] account: untranslated popup
The content of the popup message was not translated.
opw-708345
2017-02-14 11:46:52 +01:00
Christophe Simonis 44276dfdc3 [MERGE] forward port branch saas-11 up to a0aca47fef 2017-01-17 19:12:20 +01:00
Christophe Simonis 70f86ce4e8 [MERGE] forward port branch 9.0 up to 16fa61b34f 2017-01-17 18:04:57 +01:00
Goffin Simon 562e2657f6 [FIX] account: invoices on unmatched payment
Fine tuning of this commit: 69c41c7
When cancelling a payment, the remove_move_reconcile function was called and
it removed the payment from the invoice and in the payment history, only the
validated payments were kept.

This commit keeps the behavior before this commit: 69c41c7

opw:691692
2017-01-11 13:56:12 +01:00
Nicolas Lempereur 983237a53c [FIX] account: fix css congratulation message
The css clear was using jquery ui class for enterprise which now may
not be available on the given part. This commit replace it with class
defined in account_reconciliation.

With this the style could have issues such as not displaying the
congratulation message after reconciliation.

fixes #14743
2017-01-02 16:27:27 +01:00
Christophe Simonis aec8e2582f [MERGE] forward port branch saas-11 up to 345755e 2016-12-06 17:24:37 +01:00
Christophe Simonis 5301951931 [MERGE] forward port branch 9.0 up to 1f3f155 2016-12-06 15:18:45 +01:00
Nicolas Martinelli b67871d5c7 [FIX] account: account domain in reconciliation
In the reconciliation widget, create a counterpart line. No domain is
applied on the "Account" field regarding the company, meaning that we
can select an account from any company.

opw-694149
2016-12-06 12:41:06 +01:00
Goffin Simon e48d4bb85f [FIX] account: tax_ids in function prepareCreatedMoveLinesForPersisting
For the field "tax_ids", a command must be written in the the returned dictionary.
In this way, the ids of the tax will be set on the account move line.

opw:689806
2016-12-05 15:57:40 +01:00
qsm-odoo fb363b572b [FIX] *: adapt odoo interface violet
Change color #a24689 to #875A7B

Commit https://github.com/odoo/enterprise/commit/8ac1c19fac7615fecd51e670f798d13158a4e53c
changed the odoo interface violet by changing the main LESS variable
but forgot there was many direct occurences in XML/HTML/... (for
example for the mobile browser color).

Even if it's community the odoo interface violet is used at many places
(module description, XML demo data, ...).
2016-10-05 10:29:00 +02:00
Christophe Simonis f4fc3985b6 [MERGE] forward port branch saas-12 up to 10cde43 2016-09-16 11:03:50 +02:00
Christophe Simonis 10cde43fd4 [MERGE] forward port branch saas-11 up to 4c2b536 2016-09-16 10:34:39 +02:00
Christophe Simonis f8a601cad7 [MERGE] forward port branch saas-10 up to e634a52 2016-09-15 18:55:01 +02:00
Christophe Simonis 784eaf28dc [MERGE] forward port branch 9.0 up to 6647e1f 2016-09-15 16:45:13 +02:00
Nicolas Martinelli c3f4c73953 [FIX] account: monetaryIsZero
An issue arises in the following use case:
- Company rounding policy in "round globally"
- Tax excluded of 20 %
- Create a statement of 3.80 EUR
- Reconcile the statement thanks to the reconciliation widget
- Click on "Choose counterpart" in order to manually create a line to
  reconcile with the 3.80 EUR statement
- Add an amount of 3.17 EUR, and choose the 20 % tax

The widget creates an extra line of 0.00EUR . This is because the
remaining amount is 0.004.

The reason lies in the `monetaryIsZero` function. There is a hardcoded
decimal precision of 4, while it should be 2 for EUR.

We add an extra parameter to the function so it is possible to adjust
the decimal precision required. Only the problematic calls are modified
to avoid unnecessary intrusive modification.

Closes #13452
opw-688399
2016-09-15 11:22:07 +02:00
Jainik Patel 531ed05a43 [IMP] account: add bank statement operation presets as template in l10n modules.
In details:
* account.operation.template object renamed into account.reconcile.model
* account.reconcile.model.template object created
* added some records for l10n_be

Was PR 11230
2016-08-30 09:55:24 +02:00
qdp-odoo a267d8205b [FIX] account: fix account_reconciliation_widget when a tax is used. compute_all() now expects browse_records as parameters 2016-08-29 18:03:05 +02:00
rap-odoo 1b1c0d0777 [IMP] account: Improve graph proportions in accounting dashboard
========
Purpose
========

The graphs on the accounting dashboard give the impression that we had $0 in the bank because the graph is at the bottom of the kanban kard.

==========
Specification
==========

The bottom should be zero, the top should be the maximum of the visible period, and the rest of the graph should be proportionate.
2016-08-22 11:29:04 +02:00
Christophe Simonis 235ed4b2c1 [MERGE] forward port branch saas-12 up to 9ad5f26 2016-08-20 18:08:19 +02:00
Christophe Simonis 9ad5f26b3f [MERGE] forward port branch saas-11 up to 3a2147d 2016-08-20 17:18:31 +02:00
Christophe Simonis 3a2147d95c [MERGE] forward port branch saas-10 up to bc1a0a3 2016-08-20 16:57:36 +02:00
Christophe Simonis bc1a0a32ca [MERGE] forward port branch 9.0 up to 58cbcba 2016-08-19 16:59:29 +02:00
Cédric Snauwaert 5b4404f628 [FIX] account: optimize the bank reconciliation widget + add of a button to auto-reconcile instead of auto-reconciling directly when opening the widget.
* This new button is a behavior change, but this is needed for big databases with a lot of statement lines to process. Indeed, in that case we prefer to load the widget as soon as possible and thus let the user process the lines manually or click on that button (but at that time he knows why it takes time).
* Opimization of various method in order to speed reconciliation and view opening : added indexes, direct use of sql queries...and also removed the code that was looping on open debit/credit to propose a sum of entries to match the statement line's amount, because it was a little greedy and wouldn't give accurate results most of the time.
2016-08-17 14:23:08 +02:00
Yannick Tivisse d6e1d41128 [MIG] account: Migrate remaining old API chuncks of code 2016-08-08 12:24:40 +02:00
Christophe Simonis f670b3b1df [MERGE] forward port branch saas-11 up to 3aea814 2016-07-29 15:33:51 +02:00
Christophe Simonis 529f88dbd3 [MERGE] forward port branch saas-10 up to 4ca04fd 2016-07-29 13:01:29 +02:00
Christophe Simonis 73cc3611b4 [MERGE] forward port branch 9.0 up to d35f425 2016-07-28 12:31:29 +02:00
Thomas Binsfeld a3fe9eb440 [FIX] account: allow to override abstract widgets
Improve possibility of inheritance.
Return abstract widgets in order to override these.

It closes #12870
2016-07-26 16:17:51 +02:00
Nicolas Lempereur 41ba673524 [FIX] account: popover payment information unclickable
In the account invoice the payments are shown and a popover with more
information is displayed when clicking on an (i) icon.

In this popover two buttons are available, but the used type of popover
disappear immediately when clicking on them, thus the buttons were
directly removed and would not work.

This commit add a delay when hiding the popover so the buttons
functionnality is not lost.

opw-680095
2016-07-25 15:00:27 +02:00
Géry Debongnie d56b35e26e [REF] web, *: move QWeb odoo init to web.QWeb
this js module centralizes all odoo initialization
2016-06-17 13:27:18 +02:00
Fabrice Henrion 5548bbe961 [IMP] account: consistent terminology
Closes #11663
2016-05-27 11:37:28 +02:00
Foram Shah db0b846b27 updated the description of 'account' 2016-05-10 15:24:43 +02:00
Mansi Gandhi fe0dd01e2f [IMP] account: 'Save and new' instead of 'New Operation' in bank statement reconciliation
It says what it does better, and it is more consistent with Odoo's usability.
2016-04-11 13:15:25 +02:00
Kinjal Mehta a57592abe4 [IMP] analytic: Replaced account_type field by active field
Currently there is a selection field 'account_type' on the
account.analytic.account model with 2 values : Active or Archived

Let's use an active field instead and add a Archive stat button on the
form. That way, we can remove all the domain ('account_type','=','normal')
which are implicit with the generic active field behavior
2016-03-23 16:35:34 +01:00
Nicolas Martinelli 7a44effd09 [IMP] account: rename "Done" to "Skip"
When less than 2 entries are selected, no action will be performed.
Therefore, the "Done" label is misleading.

opw-670503
2016-03-23 09:31:59 +01:00
Aaron Bohy bda451ab31 [FIX] *: adapt addons to views refactoring of previous commit 2016-03-18 10:44:52 +01:00
Fabien Pinckaers 4c8e908b49 [IMP] Speed up app switcher loading: 645k --> 137k lossless compression for all icons 2016-02-26 11:39:38 +01:00
Yannick Tivisse 215cad9cae [IMP] account: Protip for the ctrl+enter access key
A similar protip has been added in the enterprise 'account_reports' module.
We took this opportunity to rename the class protip into o_protip and to apply
this kind of style with standard attributes and classes + to correct typos
2016-02-03 18:27:38 +01:00
Arthur Maniet 04fce95875 [FIX] account: reconciliation widget monetary values comparison
Since monetary values are stored as float, use the method intented for float
comparison using the maximum number of digits a currency can use.

Until V9, the number of digits used was fetched from table decimal.precision,
but as of V9, the accounting module stopped using it in favour of the digits
number defined on currencies.
2015-12-29 13:30:36 +01:00
qdp-odoo f6d6762dc7 [FIX] analytic: workaround to re-enable the feature to close an analytic account that has been unfortunately removed by mistake in commit 2a8c077.
It is using an already existing field that wasn't used anymore ('account_type') but as a lot of domains on analytic accounts were
 - wrong (still using old fields state and type that have been removed as well in the same commit),
 - or defined directly in the views
so, an update of some modules may be needed in order to avoid further problems.
2015-12-11 14:57:46 +01:00
Arthur Maniet 5339665806 [FIX] account: reconciliation widget's 'create writeoff' tax domain
Allow for both sale and purchase taxes since using a sale tax on a writeoff
makes sense in cash basis accounting.
2015-12-11 12:02:34 +01:00
Cedric Snauwaert 088db58967 [FIX] account: when trying to reconcile an entry, if label is empty, by default it should be the name of the line
It was the case in Saas-6 and prevent many mistakes
2015-12-10 11:54:06 +01:00
Goffin Simon e9dadadd07 [FIX] account: Bank statement reconciliation
The partial reconciliation can just be proposed on the last selected line when:
self.get("balance") * (last_line.debit - last_line.credit)<0
2015-11-26 16:53:12 +01:00
Géry Debongnie 329552b78e [FIX] web,account,website_links: update nvd3 to last version
This commit was necessary to fix weird problems in 9.0-nightly.
Phantomjs and the old nvd3 implementations did not play well together.

* transitionDuration() replaced by duration()
* tooltips() & tooltipContent replaced by tooltip.enable and tooltip.contentGenerator
* remove useless less for tooltip

Thanks to mge for his help
2015-10-29 22:15:44 +01:00
Arthur Maniet 3a26046b88 [FIX] account: bank statements reconcile invoice / match payment logic
The only difference between payment matching and reconciliation is that
in the former the reconciliation was already made while in the latter we
do it at bank statement reconciliation time.

So they behave the same in the interface except that partial reconciliation
is not proposed for payment matching.
2015-10-02 11:18:46 +02:00
Arthur Maniet ceb8536b55 [FIX] account: reconciliation interface broken M2O dropdowns 2015-10-01 17:33:44 +02:00
Arthur Maniet abbd635470 [REVERT] changes wrongly added to a0ea75e5f1 2015-10-01 11:30:26 +02:00