Commit Graph
122661 Commits
Author SHA1 Message Date
Arnold Moyaux 8c8b32e5e4 [FIX] mrp: manufacture user can not record production
Usecase to reproduce:
- Connect with demo user
- Create a MO w/h routing
- Confirm and produce it
- Record the production wizard

Access right error on product.product for field tracking

It happens because the wizard use a related to product.tracking howerver
it is not set as readonly on the view and send to the server as a value
on save. Since it write on a related field it will try to write on the
linked model(product.product).

This commit set the field as readonly so it is not set to the server.
The field is just used inside domain and it is invisible to the user
so it do not modify any behavior.

opw-1918684

closes odoo/odoo#29942
2019-01-04 14:15:35 +00:00
Juan José Scarafía 0babee58b7 [FIX] base: correct typo in state name
Argentina state is Entre Ríos

closes odoo/odoo#29959
2019-01-07 08:58:54 +00:00
Lucas Perais (lpe) 0e0c726805 [FIX] purchase: don't change status when writing a note through the composer
Have a RFQ in draft. Log a note or send a new message, but use the full composer to do it.

Before this commit, the RFQ was set to sent

After this commit, it stays rightfully in draft
It is mark as sent, only if the button SEND RFQ is used

OPW 1908094

closes odoo/odoo#29902
2019-01-04 13:18:14 +00:00
Jorge Pinna Puissant 9cf6662880 [FIX] account: compute_fiscalyear_dates non leap years
Before this commit, when the fiscal year was setting to 29/02.
The function that compute the fiscal year dates gives an error.
This occurs when the date passed as parameter wasn't a leap year.

Now, for the non leap years we use the 28/02.

opw-1917035

closes odoo/odoo#29932
2019-01-04 10:23:44 +00:00
Alexey Pelykh 1ffc485689 [FIX] hr_holidays: extra space in state check
The condition was never validated

closes odoo/odoo#29898
2019-01-04 10:18:30 +00:00
Alexey Pelykh 11e5688d0f [CLA] Brainbean Apps OU signs Odoo CCLA 2019-01-04 10:18:24 +00:00
Nicolas Lempereur 27a084eb81 [FIX] web: attach document fix click on firefox
As of saas-11.3 there is a "Attach document" widget that is meant to
more easily add attachment.

But on firefox the click event is coming from the button, where on other
browsers it was possibly from a child element.

So the code expecting the child element did not work on firefox.

opw-1920842
closes #29903
2019-01-03 17:00:18 +00:00
Christophe Simonis d96c42ea88 [MERGE] forward port branch 11.0 up to 22637aadec 2019-01-03 15:31:05 +01:00
Raphael Collet a07a076c45 [FIX] models: avoid prefetch hell when reading fields
The method `read()` may be very slow when reading relational fields and
computed fields, because the computed fields can be computed on a recordset
that is larger than expected.

The issue occurs on model 'res.partner' when reading fields 'child_ids' and
'purchase_order_count', for instance.  Suppose we read those two fields on a
partner with 1000 contacts.  First, the one2many field is read from the
database and stored to the cache; the latter adds the value ids to the
prefetching of 'res.partner'.  Then, the fields are fetched from the cache.
When 'purchase_order_count' is accessed on the partner, the field is computed
on all its children as well...

closes odoo/odoo#29867
2019-01-03 12:45:48 +00:00
Jorge Pinna Puissant 8ac1cdde2e [FIX] web_planner: prepare_backend_url give a bad URL
opw-1920590

Before this commit, the function prepare_backend_url forced in the url
the view_type 'form'. This occurs because a misunderstand between the
fields ir.actions.act_window.view_type (That indicate if an hierarchy
in the view list exists, with as possible values : form and tree, which
can be mistaken as views types) and ir.actions.act_window.view_mode
(which is a list of allowed views).

Now, if not ask otherwise, the function give the url of the first
(the default) allowed view; or one of the allowed view if asked for it.

closes odoo/odoo#29882
2019-01-03 11:16:30 +00:00
Odoo Translation Bot d331d28fdf [I18N] Update translation terms from Transifex 2019-01-06 03:24:31 +01:00
Robot Odoo 5aa16e4507 [IMP] l10n_be_hr_payroll: Update salary rules up to 2019
Update withholding taxes and child allowances for the new fiscal year.

Documentation: https://finances.belgium.be/fr/entreprises/personnel_et_remuneration/precompte_professionnel/calcul

closes odoo/odoo#29931
2019-01-04 15:05:11 +01:00
Yannick Tivisse 3569d053d3 [IMP] l10n_be_hr_payroll: Update witholding taxes reductions up to 2019 2019-01-04 12:37:01 +01:00
Yannick Tivisse 551bffd3a1 [IMP] l10n_be_hr_payroll: Update 'bonus à l'emploi' up to 2019
Documentation: https://www.socialsecurity.be/employer/instructions/dmfa/fr/latest/instructions/deductions/workers_reductions/workbonus.html
2019-01-04 12:37:01 +01:00
Yannick Tivisse a6ba0b6678 [FIX] l10n_be_hr_payroll: Remove wrong rule
This rule is not correct, and shouldn't be applied here.
2019-01-04 12:37:01 +01:00
Yannick Tivisse f543cb2b18 [IMP] l10n_be_hr_payroll: Update salary rules up to 2019
Update withholding taxes and child allowances for the new fiscal year.

Documentation: https://finances.belgium.be/fr/entreprises/personnel_et_remuneration/precompte_professionnel/calcul
2019-01-04 12:37:01 +01:00
David Tran 1377c45f4d [FIX] sale: allow execution on multiple records
avoid singleton error when self contains multiple orders

closes odoo/odoo#29922
2019-01-04 10:47:17 +00:00
Martin Trigaux 838c9e5617 [I18N] export 11.0 source terms
To integrate recent content changes and benefit from cd4080839f and 7f8631a91

closes odoo/odoo#29933
2019-01-04 10:13:05 +00:00
Nicolas Lempereur 3125d20da3 [FIX] web: X2Many read propagates field context
Most operations on X2Many widget possibly propagates a field context
(name_create, name_search, ...) but the original read or read on an
onchange does not.

With this changeset, the field context is also used in these instances.

The assertions added in the added test failed with:
  expected: ["world"], result: [undefined]
  expected: ["world","world"], result: [undefined,undefined]

fixes #29203
opw-1914466
closes #29866
2019-01-04 09:44:49 +00:00
Nicolas Martinelli 04369bab39 [FIX] rating_project: pop group_by
- Go to 'Project'
- Group by 'Manager'
- Click on the rating

A traceback occurs.

This is because the grouping field `user_id` does not exist in the
target model.

Fixes #26060
opw-1920979

closes odoo/odoo#29900
2019-01-03 16:04:50 +00:00
Martin Trigaux 7f8631a913 [FIX] tools: properly verify the size of HTML nodes
Instead of checking the size of text only node, let the xml_translate verify it.

The size verification using etree was introduced at 40efdccc3d but was
probably too simple.
Since 45352512a8, this becomes redundant with the nonspace method which can
be extended.

The re.sub is still relevant as some terms may contain only non-alphanumeric and
use push_translation (e.g. '>=' as a selection or xml terms extracted by babel
in static repository)

closes odoo/odoo#29432
2019-01-03 15:01:10 +00:00
Raphael Collet cd4080839f [FIX] translate: inline elements with translatable attributes only 2019-01-03 13:46:27 +00:00
qdp-odoo 22637aadec [FIX] account: typo introduced in d44437f93830afae60e5354e0b4777413be29c93
closes odoo/odoo#29874
2019-01-03 09:21:50 +00:00
Christophe Simonis a23e8c081a [FIX] account: adapt forward-ported test 2019-01-02 17:11:36 +01:00
Christophe Simonis e618845112 [FIX] web: adapt forward-ported test 2019-01-02 16:08:25 +01:00
Sanjay Jamod 03b0e153ac [FIX] account_check_printing: Fix traceback on onchange
Method amount_to_text() having self.ensure_one(), it should not be
called with empty recordset

Closes #29854

closes odoo/odoo#29865
2019-01-02 14:46:07 +00:00
Christophe Simonis 79f1ecd756 [MERGE] forward port branch 11.0 up to d82c0d133e 2019-01-02 15:37:01 +01:00
Christophe Simonis 6e933e42ef [MERGE] forward port branch saas-14 up to a80bde859c 2019-01-02 11:44:07 +01:00
Wolfgang Taferner d82c0d133e [FIX] stock: tell the user which product is causing the issue
closes odoo/odoo#29857
2019-01-02 10:36:57 +00:00
Christophe Simonis 7d45e43a13 [MERGE] forward port branch saas-15 up to 6e933e42ef 2019-01-02 13:42:12 +01:00
Enric Tobella c8de59ad2b [CLA] siognature for Enric Tobella
closes odoo/odoo#29593
2019-01-02 10:57:03 +00:00
Christophe Simonis a80bde859c [FIX] base: correct res.partner name_search
Oversight of previous forward-port when adapting cc217569b7
2019-01-02 11:12:37 +01:00
Christophe Simonis 015f2582ad [MERGE] forward port branch saas-14 up to 1d672b33a7 2019-01-02 10:50:46 +01:00
Christophe Simonis 1d672b33a7 [MERGE] forward port branch 10.0 up to 9ef7802520 2019-01-02 10:49:56 +01:00
Nans Lefebvre 874425c69e [FIX] stock_account: fix default field value in wizard
Default time was set to default=fields.Datetime.now() instead of
default=lambda self: fields.Datetime.now(),
resulting in a discrepancy when printing the report.

opw 1917523
2018-12-28 15:19:15 +01:00
Nicolas Lempereur 222f3166b0 [FIX] account: apply currency on uom change
When creating a new line on a customer invoice, we could get the price
unit in the company currency instead of the invoice currency.

This is because the uom_id onchange would ignore currency when setting
the price.

Changing an invoice line's price unit on uom_id change was introduced
in february 2018 in saas-11.3 with 3a38080ff.

Change to how currency is applied when setting an invoice line's price
unit was introduced in june 2018 in 9.0 with 367fadc8.

So there was a missing part in saas-11.3 to adapt 367fadc8 for 3a38080ff
change that is added with this commit.

Without the fix, the added test failed with:

  AssertionError: 10.0 != 20

opw-1920504
closes #29776
2018-12-28 13:20:52 +00:00
Nicolas Lempereur a6279fe169 [FIX] hr_holidays: demo data error on 31 december
On installation demo data causes an error on 31 december since we test:
 is 31 december at midnight < now() => so after midnight error.

Solve this by comparing today instead of datetime.

opw-29776
closes #29830
2018-12-31 11:31:02 +00:00
Josse Colpaert f5fe1f4064 [IMP] l10n_no: Norway tax update, see #28422
closes odoo/odoo#29852
2018-12-27 10:45:53 +00:00
Romain Derie d73c4e583a [FIX] website_*: prevent record to be unpublished on website change
Before this commit, when changing the website field in a record form view,
the is_published field would be force to false, ending unpublishing the record
if it was published.

That behavior was coming from the fact that is_published field is missing from
the form view. Thus, onchange on website is triggering a recompute server side
without is_published as the JS framework is not sending the field.
The ORM is then fallbacking on default Boolean value (False) for is_published
when sending back the onchange result.

This would only appear on object with 'website.published.multi.mixin' and with
website_id in the form view.

task-1919689

closes odoo/odoo#29707
2018-12-21 13:47:58 +00:00
RomainLibert 8d6bb22298 [FIX] hr_holidays: use a better heuristic when mode != employee
closes odoo/odoo#30082
2019-01-09 15:50:14 +00:00
Pierre Masereel ad40ed029c [FIX] delivery: weight computation without quant
The weight computation was not working anymore on packages that don't
have any quant, because they are fresh ones.

We fix this by setting back the behaviour with the picking id in
context and adapt the function to find the corresponding move lines.

closes odoo/odoo#30071
2019-01-09 12:52:01 +00:00
Nicolas Martinelli a323b86ecb [FIX] l10n_nl: incorrect tax template
Following forward-port.

closes odoo/odoo#30056
2019-01-09 09:28:20 +00:00
Nans Lefebvre 8c5ec851fc [FIX] website: fix menus unlinking
Fine-tuning of commit b48d2b6b5e.
The call to unlink inside the unlink can recurse infinitely
in case there is a copy of a menu.
We replace that direct call by an accumulator so no recursion occurs.

opw 1922448

closes odoo/odoo#30032
2019-01-09 10:29:52 +00:00
Laurent Smet f24d5dd2b6 [FIX] account: Fix missing cancel option in Misc. journal form
Introduced by:
https://github.com/odoo/odoo/commit/73fc643057958edd37e385148dcf22c768e3cc01

-opw: 1921034

closes odoo/odoo#29885
2019-01-03 12:27:56 +00:00
Laurent Smet 57c6dab075 [FIX] account: Fix payment's move_name when cancelling
Create a paiement, post it, cancel it, set it to draft, post it again:
The move_name has been incremented instead of staying the same as before.

-opw: 1919241
2019-01-03 12:19:30 +00:00
Laurent Smet 0600253f22 [IMP] account: Search res.partner.bank without partner in reconciliation
Search bank account without partner to handle the case the res.partner.bank already exists but is set
on a different partner. Without this commit, the error 'An account with the same number already exists'
was raised.
2019-01-03 11:38:31 +00:00
Romain Derie d927dd51bb [FIX] website_sale_delivery: allow to restrict delivery to a website
Before this commit, website_id field would not be added in form view, making it
impossible to set a website on a delivery method and so impossible to restrict
a delivery method to a specific website.

Now, adding this field will be enough as we already search() on
website_published carrier and the delivery.carrier model has the
'website.published.multi.mixin' mixin that will filter accessible website when
searching on website_published field.

+ add missing groups on website_id field
+ remove useless website_published

opw-1918189

closes odoo/odoo#29749
2018-12-26 12:03:42 +00:00
Priyanka KakadiyaandMohammed Shekha ccb2fffc65 [FIX] web: prevent crash in kanban in some cases
Before this commit, if a user tries to group a kanban view by a date or
a datetime interval, then tries to drag and drop a record from one column to
another, then the web client crashes.  This is actually an invalid
operation, and is supposed to be disallowed.  There is already some code
that properly handle the situation.  However, the field attribute was
not properly read in the case of fields of type date/datetime.

Related to Issue: #1911975

Co-authored-by: Mohammed Shekha <msh@openerp.com>

closes odoo/odoo#30029
2019-01-09 09:13:59 +00:00
Nicolas Martinelli 6be112ac2c [I18N] website: export missing translations
Following https://github.com/odoo/odoo/commit/7f8631a913de7aebb9b954

opw-1908220

closes odoo/odoo#30060
2019-01-09 09:51:52 +00:00
Xavier Morel 1e9ed52052 [FIX] mail, sale: indentation & spacing in docstrings
rST is somewhat unforgiving when it comes to whitespace. The extra
indentation on list would generate (nested) blockquotes instead of
just paragraphs & list items, and the missing empty lines would make
rST parse the entire block as a single paragraph rather than a
paragraph followed by a list.

closes odoo/odoo#30058
2019-01-09 09:16:02 +00:00