Commit Graph
130352 Commits
Author SHA1 Message Date
Pierre Masereel 9ae33dd50c [FIX] point_of_sale: offline with invoice
When you are offline, and you validate an order with an invoice, the
rejection of the Promise is not well handled and propagated which lead
to enter in a resolve even if it has failed.

We are now correctly propagting the rejection of the call to the server.

closes odoo/odoo#35974

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-22 13:14:30 +00:00
Nicolas Martinelli e0c7a36858 [FIX] account_check_printing: set the amount in words
- Create a vendor payment by check
- Remove the amount in words
- Confirm

It is impossible to set the amount to print the check.

We add an action button to recompute the amount in words. It is only
visible when the amount is not set.

opw-2046339

closes odoo/odoo#35968

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-08-22 12:14:18 +00:00
Julien Castiaux 1e914bc11e [FIX] l10n_it_edi: fetchmail.server.type renamed
Fine tuning of 529c1a2e

closes odoo/odoo#35962

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-22 11:37:28 +00:00
Nicolas Lempereur da474d0e87 [FIX] web_editor: parallax effect in sanitized field
A sanitize fields by default remove all attributes outside of a
whitelist (if sanitize_attributes on field is not set to false).

This prevent to use parallax widget in Html sanitized field since
attribute "data-scroll-background-ratio" define parallax effect speed
but was not in whitelist.

note: also keep data-interval for gallery widget

opw-2053983
closes #35961

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-08-22 10:30:47 +00:00
Lucas Perais (lpe) 4855b52c55 [FIX] web: graph: id not in groupby
Before this commit, when having the field "id" in the graph view
it was selected to group by on it.
This doesn't really make sense, and triggers an sql error anyway

After this commit, we filter out that field from the groupbys

OPW 2053444

closes odoo/odoo#35958

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-08-22 09:58:23 +00:00
Julien Mougenot 55feae2436 [FIX] web: searchbar: focus first item
Doesn't focus hovered option in the searchbar

Before this commit:
When typing in the searchbar while having the cursor right under it,
the selected option was automatically the one hovered by the cursor.

Now, the default option is the first one (typically name search) and the
cursor hovering only takes effect when moved for the first time.

Task 2058656

closes odoo/odoo#36099

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-08-27 14:27:41 +00:00
Luis 4109053388 [FIX] base: add js_class to calendar rnd
Fix missing js_class attribute on the calendar xml validation file
Make possible to create new custom views based on the calendar view

Was already done in master at 496920a8f5 but was not present in 11.0

Closes odoo/odoo#26750
Closes odoo/odoo#31679
Closes odoo/odoo#36156

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-28 07:22:39 +00:00
Mohammed Shekha 01f66151c0 [IMP] web: remove m2o from supportedTypes in selection widget
currently widget selection is not working in m2o in editable list view and
to fix this issue it need a lots of changes to make it work properly,
i.e. make '_fetchSpecialRelation' use correct domain for each record,
batch requests as much as possible, also make all '_fetchSpecial...'
work in the list case.

So to avoid major changes remove supportedTypes from selection widget
so user can not tempted to apply selection widget on many2one field.

task-1871698

closes odoo/odoo#33485

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-08-28 05:52:03 +00:00
Christophe Simonis 4833aeb960 [MERGE] forward port branch 11.0 up to ab8c564f44 2019-08-22 11:21:23 +02:00
Christophe Simonis cb5f8241af [MERGE] forward port branch saas-14 up to edf44cdaee 2019-08-22 11:12:39 +02:00
Christophe Simonis edf44cdaee [MERGE] forward port branch 10.0 up to 8443a74cd6 2019-08-22 11:12:08 +02:00
Nans Lefebvre ab8c564f44 [FIX] account: fix default_get of account move lines
Obvious typo of 67d82b875c.

opw 2046137

closes odoo/odoo#35939

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-08-22 07:07:27 +00:00
mreficent 8443a74cd6 [FIX] account: computes correctly belongs_to_company
Typo of https://github.com/odoo/odoo/commit/b154e219f68cc378ba8cc9dedf1d48819cd8e87a

closes odoo/odoo#35937

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-21 21:35:57 +00:00
Christophe Simonis 9ee8d846b8 Revert "[FIX] l10n_es: fix base tags for groups of taxes"
This commit shouldn't have been forward-ported.

This reverts commit 2078fefdb1.

closes odoo/odoo#35928

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-21 15:47:08 +00:00
Christophe Simonis 668c360e32 [MERGE] forward port branch 11.0 up to 1b234b1be7 2019-08-21 16:58:16 +02:00
Laurent Smet b73789a53b [FIX] account: Fix cancelling a payment
This commit fixes a wrong condition since the new "cancel" state has been introduced in
journal entries.

issue: https://github.com/odoo/odoo/issues/35362#issuecomment-520641052

closes odoo/odoo#35911

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-21 11:14:33 +00:00
Laurent Smet 09f672c1a6 [FIX] account: Fix fixed tax in invoice with foreign currency
Before this commit, a fixed tax amount was incorrect in invoices in a multi-currency
environment as the amount was applied both in company's currency and in foreign currency.
In this commit, the amount is converted when dealing with a foreign currency.
2019-08-21 11:12:16 +00:00
Laurent Smet 9bd600027d [FIX] account: Fix tax computation with quantity=0
Before this commit, the tax computation was done in invoices using the balance of each base lines.
However, when dealing with python tax having sometimes an amount only dependent of the price_unit,
we need to handle the case when quantity is zero.

issue: https://github.com/odoo/odoo/issues/35358
2019-08-21 11:11:49 +00:00
Laurent Smet 7b9720930a [FIX] account: Fix matching regex case insensitive in matching rules
The other filters are case insensitive, why not this one?

closes odoo/odoo#35899

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-21 09:28:56 +00:00
David Tran 569a29ecee [CLA] Update tvtmarine-automation.md
closes odoo/odoo#35747

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-22 08:56:59 +00:00
ARXI 2815485dc1 [CLA] Corporate signature for Arxilead
closes odoo/odoo#35687

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-22 07:57:09 +00:00
Christophe Simonis 46d3d06f04 [MERGE] forward port branch saas-11.3 up to 4833aeb960 2019-08-22 11:22:31 +02:00
Christophe Simonis 12e9613f96 [MERGE] forward port branch saas-11.3 up to 668c360e32 2019-08-21 18:26:18 +02:00
Lucas Perais (lpe) cf42d86549 [FIX] crm_reveal: bad import of a file variable
Before this commit, crm_reveal always pushed a stocky warning to the
bus on rule creation, even if GeoIP was rightly set
(i.e. python package AND the database in /usr/share/GeoIP)

This was because the file imported the variable from another one
that copy was not updated with the initialization of the session

After this commit, we call the variable at runtime rather than import it
at init time
There is no more sticky message

OPW 2052995

closes odoo/odoo#35906

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-08-21 11:38:06 +00:00
Christophe Simonis d8524aadf8 [MERGE] forward port branch saas-14 up to e854f68393 2019-08-21 11:26:41 +02:00
Christophe Simonis e854f68393 [MERGE] forward port branch 10.0 up to b058f70941 2019-08-21 11:25:05 +02:00
Simon Lejeune ea92e0b333 [REM] mrp_subcontracting
There was a first version of mrp_subcontracting at rev [1] and now
there's a second verion at rev [2]. As the second version sensibly
changed the flows and models AND we don't have the time to backport the
changes AND saas-12.3 will be released on the saas, we chose to remove
the module in saas-12.3 to not have to support both version once v13 is
released.

[1] d91db5bde6
[2] 9b6a5398df

closes odoo/odoo#35898

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-21 08:49:41 +00:00
Laurent Smet 1ca5c01b36 [FIX] account: Fix price_unit sign in taxes computation
Since the base in compute_all could be negative but is signed to perform the computation,
the price_unit should follow the same logic and be signed when evaluating a python tax.
Before this commit, the price_unit was equivalent to the base line balance and then, was negative
in case of a customer invoice.

E.g. For an out_invoice of 100, the price_unit is 100 but the balance is -100 for the base line.
Then, the computation is done using a base of 100 but having a sign of -1. However, when evaluating
a python tax dependent of the price_unit (here the balance), the price_unit was negative and then,
the tax amount will have a wrong sign at the end.
2019-08-21 07:03:14 +00:00
Lucas Perais (lpe) 06a516af40 [FIX] gamification, hr_recruitment, maintenance: kankan tooltip no longer supports field tag
In v10.0, it was possible, and kinda work, to have
```
<t t-name="kanban-tooltip">
<ul class="oe_kanban_tooltip">
<li><b>Project:</b> <field name="project_id"/></li>
</ul>
</t>
```

In v11.0 onwards, this "feature" has been dropped, since in kanban records
it doesn't make much sense to a field defined/displayed that way
The right way is to call

`record.(field).(raw_)?value`

This commit adapts the only two modules still having kanban-tooltip classes in their views

OPW 2055132
related to #29802

closes odoo/odoo#35869

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-08-20 14:57:22 +00:00
Wolfgang Taferner 61eccf212b [FIX] payment_stripe: backwards compatibility IE 11
closes odoo/odoo#35944

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-08-22 08:03:10 +00:00
Jairo Llopis f2b7427fb4 [FIX] website_event_track: suggest recipient with an email
If an event track had a speaker assigned who had an email, and the
email field in the track itself was empty, Odoo was suggesting the
user to send an email to an empty recipient, making an error

Now it only suggests the email if there's one.

Fixes odoo/odoo#35941

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-22 08:05:47 +00:00
Lucas Perais (lpe) 42820c35db [FIX] website_slides: adapt youtube api widget to promise
Before this commit, the adaptation of Deferred to Promise was not well done
Hence, the change in video playing status was not handled correclty
i.e. When a video arrives to its end, the next slide or the questions should be displayed

After this commit, when a video is finished, the next slides is displayed

OPW 2052971

closes odoo/odoo#35863

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-20 13:55:48 +00:00
Nicolas Lempereur b058f70941 [FIX] web_editor: font>a colorize a change font color
If you change the color of a link with the editor without using the link
edition menu, this do not work (which might be expected), but if the
text outside the font had been colorized, the font will be applied
outside of the link only.

This is unexpected since if we have: "hello <a>cruel</a> world!", if we
select only "cruel" and change color, the change only happen to "hello"
and "world!".

With this changeset, an anchor in the ancestor prevent to use an
ancestor font tag to change color (which prevent the issue).

opw-2044551
closes #35862

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-08-20 13:48:26 +00:00
Richard Mathot e6a1ac6e64 [FIX] models: avoid Unicode error when translating that error message
Same cause, error, rationale and fix than 0ec0a4a32e

#OneCharacterPatch, reloaded

opw-2056251

closes odoo/odoo#35857

Signed-off-by: Richard Mathot (rim) <rim@openerp.com>
2019-08-20 13:16:07 +00:00
Pierre Masereel 4a6d666246 [FIX] delivery: set carrier on order when carrier line added
When you are adding a line on your sale order that is a delivery line,
the carrier is not always set on the sale order which means that when
the carrier is not explicitly set on the sale order, the carrier won't
be set on picking created from the sale order.

When you are using the wizard on sale order, it works, but when the
carrier is selected on the e-commerce, it is not set on the sale order.

To avoid such difference in behavior, we are writing the carrier_id of
sale order in the function 'set_delivery_line' insread of the wizard and
e-commerce.

closes odoo/odoo#35855

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-20 12:52:05 +00:00
Romain Derie 4323008540 [FIX] website_sale_delivery: fix wrong selector + add test
Since commit e8916a817c, it was not possible anymore to go through the
ecommerce checkout when `website_sale_delivery` module was installed.

Indeed, it would raise a traceback on the confirmation step if more than one
delivery carrier would be available (different qweb if more than one carrier).

Thus, it would not be possible to click on pay now and buy the product.

This commit fixes it and improves the current test to ensure such flows are
working.

closes odoo/odoo#35577

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-20 12:33:15 +00:00
Christophe Simonis f26de445e5 [MERGE] forward port branch saas-12.3 up to 6f55fd65da 2019-08-20 12:17:04 +02:00
Christophe Simonis 6f55fd65da [FIX] mail: correct test adaptation to async version
Oversight of previous forward-port.
2019-08-20 10:42:44 +02:00
Alex Tuyls 60c438dfb7 [FIX] sale_coupon: performance issue with promotion programs
In case of large cart and promotion program with a discount reward
of percentage type, we are rewriting the reward order lines
multiple times while we can do all in one update.

opw-2038791

closes odoo/enterprise#5086

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

X-port/Cherry-pick of odoo/enterprise@243e66663a
2019-08-19 19:28:48 +02:00
Christophe Simonis 20e69b3299 [FIX] stock: correctly forward-port 5b83f7214f
Oversight of previous forward-port.
2019-08-19 19:27:53 +02:00
Christophe Simonis 168e54d488 [MERGE] forward port branch 12.0 up to 32039b2ab4 2019-08-19 18:57:08 +02:00
Christophe Simonis 32039b2ab4 [FIX] test_access_rights: add _description to new test model
Oversight of previous forward-port.
2019-08-19 17:08:08 +02:00
Christophe Simonis aac8e0c960 [MERGE] forward port branch saas-11.3 up to 121034f79a 2019-08-19 16:38:30 +02:00
Hiral Bhavsar bc6accc568 [IMP] mass_mailing_sale: remove complex computation of invoices linked to mailing UTM
UTM fields are available in the invoice without sale_crm. That's why just apply
search_read on account.move instead of doing

--> search on sale order
--> map on invoice_ids which is computed
--> search_read on account.invoice.report

to get sale_invoiced_amount.

Currently, stat button 'Invoiced' is not redirecting to invoices tree
view because of wrong action and domain parameters. Thus we, set proper
action and pass valid parameter to get that invoices tree view.

Task 1919391

closes odoo/odoo#35296

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-19 13:23:50 +00:00
Christophe Simonis 121034f79a [MERGE] forward port branch 11.0 up to 1e4de19cd4 2019-08-19 14:43:31 +02:00
Yannick Tivisse be983c7002 [FIX] hr: Expose employee timezone on public profile
Purpose
=======

It happens a lot that we access to the employee timezone to compute
presence states, leaves, ...

Instead of sudoing all those accesses, it looks better to expose this
data in the public profile.

closes odoo/odoo#35811

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-19 12:05:19 +00:00
Christophe Simonis 1e4de19cd4 [MERGE] forward port branch saas-15 up to c43de33643 2019-08-19 13:54:40 +02:00
wan 9f22d7a445 [FIX] base: same vat with empty string vat
If partner.vat is an empty string, python evaluates it as falsy and doesn't check the remaining of the line. This makes the framework to send ["", ""] as values for the many2one to the browser instead of false.
By forcing to have True or False, this is not a problem anymore as bool() will be False, and False will result in the correct value in the read.

closes odoo/odoo#35807

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-19 11:35:40 +00:00
Christophe Simonis c43de33643 [MERGE] forward port branch saas-14 up to fa26279014 2019-08-19 12:51:26 +02:00
Christophe Simonis fa26279014 [MERGE] forward port branch 10.0 up to 59c59cd8a0 2019-08-19 12:47:56 +02:00