Commit Graph
117975 Commits
Author SHA1 Message Date
rde f435267680 [FIX] website_quote: missing args on route throwing error
Before this commit, trying to pay a sale order from portal would throw an
error

 * create an order in back end, set a partner, a product, a quotation
   template and 'Online Payment' as Confirmation Mode;
 * confirm the order;
 * go to the order in portal (/quote/XX) and click on 'Pay Now';

It throws a server error because route is being called with unexpected
keyword arguments like success_url, error_url, callback_method.
2017-10-26 12:54:38 +02:00
Thibault Delavallée 1a6fd2f957 [FIX] account: add access_token propagation in portal
Otherwise access token is not correctly propagated notably in payment
form. This means customers paying invoices through the customer portal
without being logged are not correctly redirected once payment is done
as the access token used to display invoices is lost.
2017-10-26 12:54:18 +02:00
Thibault Delavallée 3c0d39baea [REV] base: revert "[IMP] base: no image (and kanban use default values"
This reverts commit cfd5f47493.

It is not clear why it has been done. Original author thinks it can
be reverted as it makes Odoo have people without image which is not
good when starting with Odoo. We don't know what we want but what is
certain is that we need images instead of ugly void placeholder.
2017-10-26 12:53:12 +02:00
Martin Trigaux e94dabce6b [IMP] mrp: add label to field
Label was unclear
2017-10-26 12:02:11 +02:00
Christophe Simonis fe715bd63f [FIX] mrp: deactivate failing test. 2017-10-26 11:40:06 +02:00
Jeremy Kersten 4a3801bc58 [FIX] google_calendar: allow to use the function number_of_week for synchro
get_param return string, but timedelta wait a integer
2017-10-26 11:10:13 +02:00
Martin Trigaux 801fb2967a [FIX] utm: fix the fix typo
Look at the commit message of c4ba5adc, not the content
2017-10-26 10:47:46 +02:00
Cedric Snauwaert 1c367e32d6 [FIX] account: reconciliation: fix trouble with reconciliation in multi-currency
This fixes several problems with the reconciliation widget when used with multi-currency.
- company in EUR, create invoice 25 USD, statement of 25 USD (in journal USD), try to reconcile, the amount is not correctly converted, we see two different values, can't reconcile
- company in EUR, create invoice in EUR, statement in USD journal, the amount displayed for the EUR invoice is not correct
2017-10-26 10:45:58 +02:00
qsm-odoo 6b767c8b1f [FIX] web_editor: properly show error line when saving wrong XML
When using the HTML editor, when attempting to save a syntax-invalid
XML, the error line is supposed to be displayed in red. This was not
the case anymore since saas-15. This was a simple mistake of comparison
between a stringified integer ID and its integer equivalent.
2017-10-26 10:44:07 +02:00
Josse Colpaert 365362a4a0 [FIX] mrp: on rereserve of mo, we can unlink stock.move.lots
On rereservation of an mo, it will remove the existing stock.move.lots
if no quantity was done on them.  We wanted to avoid however that it
 would remove the temporary stock.move.lots on the workorder.  On the normal
 ones however, there is also a workorder_id.  That way it would
 not unlink stock.move.lots when you had workorders.  By checking the temporary or
 not flag (done_wo) instead of workorder_id, we solve the issue.

 Courtesy of blaggacao fixes #19422
2017-10-26 09:50:33 +02:00
Christophe Matthieu e2190860a6 [FIX] web: calendar tests are good in US timezone
Calendar tests did not go into US for a timezone problem, making it more difficult to correct errors.
To do: pass all the tests js in US (with simplification for the calculations of the times)
2017-10-26 09:12:23 +02:00
Christophe Matthieu ffa4646af7 [FIX] web: calendar don't return to month mode in US
When click on the mini calendar, the calendar does not return to month
mode.
2017-10-26 09:12:11 +02:00
Christophe Matthieu 0c0fb63b0d [FIX] web: Calendar view of project tasks are displaying on the wrong day
Tasks are showing up on Wednesday when they are Thursday. Checked the dates
on the tasks and my timezone preferences are set to Americas-New York.

fix: Do not apply timezone for all day mode.
2017-10-26 09:12:11 +02:00
Aaron Bohy 16c90138bd [FIX] web: handle onchange on nested one2manys
Suppose that we have a form view with a one2many field o2m_1,
displayed as a list. The model of o2m_1 contains a one2many field
o2m_2 which isn't displayed in the list view, but which is in the
form view. If an onchange sets the value of o2m_1, e.g. with a
command 0 to create a new record, and that the value of o2m_2 for
this new record is set (e.g. with a command 0 as well), it crashed.
2017-10-26 08:22:00 +02:00
Aaron Bohy 6fa63eb15c [FIX] web: default value for o2m inside o2m
A traceback was raised when opening a new record for a model with a
one2many displayed inside a one2many (e.g. simply displaying the
number of records in the relation), and with an onchange setting a
default value to the inner one2many (for example, linking it to
existing records).

As the inner o2m has no subviews, it has no fieldsInfo, and the
code assumed that fieldsInfo was always set.

This was for example reproducible from v11 as follows:
  - create a product (with MTO/Buy and call for tender (need
    purchase agreement module))
  - create an SO with this product and confirm it
  - go to purchase order form view and add a move_dest_ids field in
    the tree definition of field order_line
  - go to menu purchase agreement and choose the PA generated by
    your SO
  - add a vendor, confirm the PA and click on 'New Quotation'.
2017-10-26 08:19:43 +02:00
Aaron Bohy 7b8001a847 [FIX] hr_expense,web: explicit link_to command for o2m
The ORM doesn't automatically link subrecords when it receives an
update command for a one2many. However, it may be necessary when
the default_get returns existing records for a one2many field. It
only worked before this rev. for the hr_expense model because of an
hack from 2016 (to reproduce: go to Expenses, check some expenses
from the list view, in Actions, click on 'Submit to Manager', the
new hr_expense_sheet contains the checked expenses (one2many), and
the webclient only sent an update command by linked subrecord).

This rev. fixes the problem properly: when the default_get returns
existing subrecords for a one2many field, a link_to command (4) is
generated alongside the update (1) command.
2017-10-26 08:19:43 +02:00
Géry Debongnie 0b41f21c16 [FIX] web: buttons with confirm attribute works properly
Before this commit, buttons in form view with the confirm attributes had
a peculiar behaviour:
- < saas-16: they saved the record as soon as you clicked on them, so
  the warning was basically ignored
- in saas-16+ (the new views): the button did not save the record before
  calling the method, at all.

This can be a problem, obviously.  Also, it does not seem consistent to
have a different behaviour when the user clicks on OK in the confirm
dialog, compared to a button without the confirm attribute.

So, with this commit, we just make sure that such buttons save the
record before calling the method, just like other buttons.
2017-10-25 21:51:36 +02:00
Christophe Simonis 2a1456a29c [FIX] web: _applyChange() should return list of changed fields, even when no onchange are performed 2017-10-25 17:58:01 +02:00
Lucas Perais (lpe) f45edfbe6d [FIX] web: image widget is dependent on its record's last_update
As a way to optimize loading, images are not necessarily fetched in db.
They have, in their url a "unique" parameter, which is the last_update date on **the record** and controls on the python-side whether it should get the image from a cache or from the db.

Before this commit, this __last_update field wasn't present in the view, so it wasn't fetched, and writes on a model's image worked but did not refresh.
The image displayed was the old one.

After this commit, when the image field widget is present, we force the loading of the __last_update field of the record.
Upon update, the image displayed is the new one.

OPW 777552

closes #20457
2017-10-25 16:39:52 +02:00
Laurent Smet 505a7f853f [ADD] account_tax_cash_basis: add hook to change the cash basis base amount account
To be able to retrieve the base amount of cash basis taxes lines, an additional move is created.
However, this additional move contains a several lines that are considered as pollution in reports.
This hook allows to move these additional lines to an another account if needed.

-task: https://www.odoo.com/web#id=35605&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720
2017-10-25 15:44:50 +02:00
Raphael Collet 446be392ea [FIX] base_import, web: error messages related to data import modules
OPW 777366
2017-10-25 15:44:18 +02:00
xmo-odoo f13cab6aa6 [FIX] website_mail_channel: unsubscription
Fixes 27280fefa9:

* `partner_id` is an `int` not a recordset
* qweb Response is lazy (the template is only looked up and rendered
  when we actually need to send the content over the wire) => the error
  would occur outside of the try..except block. Force rendering
  (`Response.flatten`) so we can handle the issue here
* Uses the HttpCase interface to contact the server over a new socket
  (same as tours & al) because using `werkzeug.test.Client` would not
  use the correct cursor (?) and so the test data would not be visible
2017-10-25 15:31:58 +02:00
Deep Patel eb9d7f8b6f [IMP] website_form: name of submitted attachments
In case of custom field 'upload file', the attachement
name will be the technical name of the input tag of the
form (aka 'attachments'). It is more user friendly to have
the name of the uploaded file.
2017-10-25 15:24:53 +02:00
Simon Lejeune 46af955328 [FIX] stock: display lot_name in the detailed operations view
If the user selected 'use_create_lots', he should see the text field and
not the many2one. This improves the usability of the barcode scanning in
a receipt, where the lots were not displayed (as it only set the
lot_name).
2017-10-25 15:17:57 +02:00
Lucas Perais (lpe) 6fc0793c30 [FIX] web: column aggregates should recompute when no records
1- When viewing for example journal items.
2- Now activate a filter that would display no record

Before this commit, the column aggregates of case 2 were the same as case 1.
After this commit, we recompute the aggregate, which ever case we are in.

OPW 777660

closes #20452
2017-10-25 15:02:13 +02:00
Christophe Simonis 693f8dc68a [MERGE] forward port branch saas-16 up to 7bfde6e05d 2017-10-25 14:57:24 +02:00
Christophe Simonis 7bfde6e05d [MERGE] forward port branch saas-15 up to d516d39948 2017-10-25 14:20:51 +02:00
Géry Debongnie c739bcf0d1 [FIX] web: update column aggregate when field changes (list)
A list view can display the sum of all values for one field, using the
'sum' attribute.  Before this commit, this sum was not updated whenever
a field was changed (but it worked when adding a line).
2017-10-25 14:13:14 +02:00
Christophe Simonis d516d39948 [MERGE] forward port branch saas-14 up to f86141aac2 2017-10-25 13:41:16 +02:00
Goffin Simon c7a6409fac [FIX] base: Changing password with false as new value
Before clicking on 'Change Password' button, a new password must be
written. Otherwise an error was raised: TypeError: secret must be
unicode or bytes, not bool.

opw:777921
2017-10-25 13:35:41 +02:00
Christophe Simonis f86141aac2 [MERGE] forward port branch 10.0 up to 598ac60a77 2017-10-25 12:52:00 +02:00
Nicolas Martinelli 87b2f3fadd [FIX] base: to_text
- Install Website Live Chat
- Publish a Livechat on the website

Crash on rendering:
```
<img t-att-src="user.image_small and ('data:image/png;base64,' + to_text(user.image_small)) ...
```

Commit 1df6f4c741 fixes a P2/P3 compatibility by including the helper
`to_text` in the QWeb context. However, it was included only for reports
(in `ir.actions.report`), while it is necessary for the rendering of all
templates.

opw-777681
opw-777630
2017-10-25 12:16:53 +02:00
Richard Mathot 598ac60a77 [FIX] account_voucher: fix SyntaxError introduced by e69fb3f82d 2017-10-25 12:15:53 +02:00
qdp-odoo e69fb3f82d [FIX] account_voucher: fix missing payment_id in "Pay Directly" voucher
Create an accout.voucher with "Pay Directly" as payment.
    You get something like:

                D  |  C
    --------------------
    Expenses:   x  |
    Cash:          |  x

    However, the expense line doesn't appear in the reconciliation widget
    because the payment_id is missing in the account.move.line and then, doesn't match
    the search domain for the reconciliation.

    To solve it, a payment_id is created for this line in case of "Pay Directly" payment.

    -opw: 775167
2017-10-25 12:04:38 +02:00
Giang Manh b844f3bfd5 [FIX] calendar: sorting error (P3)
When showing a list in Calendar, it is always sorted at least by
id. If the recordset mixes real and virtual (recurrent) events, this
will blow up as sort() will try to compare the int-typed real event
ids and the string-typed virtual event ids.

Generate a type-compatible id key for both real and virtual events in
order to properly sort.

Closes #20278
2017-10-25 11:33:27 +02:00
Christophe Simonis ea9b574ac6 [MERGE] forward port branch 9.0 up to 6366150484 2017-10-25 11:28:25 +02:00
Goffin Simon 135823a4d8 [FIX] stock: Forecasted stock report is not multi-company compliant
To take the company into account in the report.stock.forecast.

opw:777270
2017-10-25 11:15:07 +02:00
Martin Trigaux 8991021dc6 [FIX] survey: use verbs
The placeholders were not easy to understand
2017-10-25 11:12:14 +02:00
amoyaux 1d72dc3e6a [FIX] mrp: traceback BOM button on product template
[self.ids] represents a list of list and product_id
an integer thus the domain definition was not correct.
2017-10-25 10:59:14 +02:00
Martin Trigaux c4ba5adc04 [FIX] utm: use proper Englsih abreviation
ex is French
e.g. should be used
2017-10-25 10:57:59 +02:00
Nicolas Martinelli afccad3578 [FIX] stock: consumable in inventory valuation
Hide consumable products from the inventory valuation view since they
are skipped when generating accounting entries.
2017-10-25 10:52:09 +02:00
Denis Vermylen 33a04354eb [FIX] product,sale: allow negative discounts in pricelist advanced formula
Between v9.0 and v10.0 a pricelist refactoring made it so negative
discounts no longer worked correctly. They should always be
included in the unit price of the product (not to be displayed as a
negative discount even if the option to display the discount is
enabled).

This commit also corrects currency conversion issues when basing the
price on another pricelist with a differnt currency, and when making
the sales order in a company with a different currency than the
pricelists currency.
2017-10-25 10:35:12 +02:00
amoyaux b7d2bb3a8b [FIX] sale: impossible to validate SO
This reverts commit a5c82b0c57.
Since can_be_expense is only available when hr_expense
2017-10-25 10:31:39 +02:00
Victor Oliveira da Silva bcb8ef0b60 [FIX] website: fix typo in error message
Closes #20433
2017-10-25 09:42:59 +02:00
Nicolas Martinelli 6366150484 [FIX] point_of_sale: apply fiscal position
Commit https://github.com/odoo/odoo/commit/5afb5ecd04cf49be6bedb655b187b19a65e1e02d#diff-1c14accbe350f7a177b3e81e5846861bL1363
removed the call to `_map_tax_fiscal_position`. Fiscal positions are not
applied anymore...

Instead of applying the fiscal position in the `compute_all` method as
it used to be, we apply it just before the call. This mimics the
behavior of SO/PO/Invoices, where the taxes are changed directly on the
order line.
2017-10-25 09:37:32 +02:00
Andrew Latham b67e18bcb5 [IMP] tools: basic spelling and grammar corrections
Closes #20391
2017-10-25 09:22:52 +02:00
Christophe Matthieu 9d7f9cc38c [FIX] calendar: don't display the created or updated record
If the user change a filtered field, the record is not always displayed.
Wrong domain construction. The automatic filter must be use to filter and
remove items from the view for the unselected and not display the selected.
2017-10-24 17:26:48 +02:00
Nicolas Martinelli cc37b34f43 [FIX] point_of_sale: fix included price
Complement of 5b50284127

The mentioned commit works well when adding a product, but
- changing the quantity
- changing the customer

won't trigger the fix of the included price.

opw-776530
2017-10-24 17:06:39 +02:00
Martin Trigaux bc84eb2035 [FIX] l10n_multilang: translate country states name
Countries with several official languages often have multiple names for their
states. Allow to translate the state name for such countries.

Some monolingual countries but, yet, with a need of translation of the addresses
such as China or Germany can add the same flag in their respective l10n_* module

Closes #19481
Closes #20259
2017-10-24 17:04:12 +02:00
Géry Debongnie 616eedb7e4 [FIX] web: allow onchange to modify origin field
With this commit, we allow an onchange coming from a field to modify the
same field.  This was not working for field widgets derived from an
input field.
2017-10-24 15:39:14 +02:00