Commit Graph
117975 Commits
Author SHA1 Message Date
Jérome Maes fa0769c41c [IMP] project_timesheet_holidays: add tests
Tests to check the timesheet generation
when validating leaves.
2017-05-11 16:58:37 +02:00
Jérome Maes 486fe737b6 [IMP] hr_timesheet: add test cases
Add some tests case  about logging timesheet
2017-05-11 16:58:30 +02:00
Jérome Maes 6820863c59 [FIX] project_timesheet_holidays: correctly set the employee for generated timesheet 2017-05-11 16:58:23 +02:00
xmo-odoo bc4391471e [FIX] P3: lint away some already cleaned up stuff
These issues were checked/cleaned previously but the linter was not updated.
2017-05-11 15:27:02 +02:00
xmo-odoo 6659d5a7d2 [FIX] P3: metaclasses handling
* cross-version metaclass spec
* more formally deprecate browse_record and browse_null since they
  were using metaclasses anyway
* update docstrings referencing the latter
2017-05-11 15:25:36 +02:00
Nikunj Ladava 048f122f3d [IMP] account,sale,...: Remove 'internal category' menuitems when not useful
Purpose
=======

Internal categories are only useful for accounting & inventory.
-> so they should be only visible for such modules

Also terms are confusing: internal category -> category  "internal" is not obvious

Specification
=============

- remove internal categories menus from:
    sales
    website_sale
    pos

- rename menu in:
    purchase
    inventory

- add menu to:
    accounting
    products must be visible even if account.accountant is not installed
    categories only visible if account.accountant is installed

- rename categories in product form:
    - category
    - pos category
2017-05-11 15:15:16 +02:00
Aaron Bohy d068c4cac1 [FIX] sale: group_sale_layout shouldn't imply group_user
Because when it does, it can create a cycle in the graph of
implied groups. This happens when the option 'Sort products
in sections with subtotals and page-breaks' is checked in the
Sales settings. In this case, being in group_user implies to be
in group_sale_layout, and being in group_sale_layout implies to
be in group_user.

This is a problem for groups display in the 'Users' form view: the
employee groups are no more linear, and thus no more displayed as
a selection field, but there is an 'Employee' section where each
of the employee group can be checked. Activating the option in the
Sales setting should have no impact of the groups hierarchy of HR.

Moreover, there have been several imilar issues on production
databases, probably due to this cycle, but that we haven't been
able to fully understand/reproduce yet: with this option in the
'Sales' settings activated, after a mysterious operation, the
'Users' form view was broken, because the selection field
'sel_groups_'for HR was still referenced in the view, but didn't
exist anymore (as HR groups weren't displayed as a selection field
anymore).
2017-05-11 15:14:07 +02:00
qsm-odoo 40a026d5b2 [FIX] web: implement <newline/> form tag behavior
Before this commit, the new form view implementation was rendering
<newline/> tags as real <newline/> DOM element. The wanted behavior
is now restored:
- As outer group direct child, produce a <br/> tag, forcing the next
  group children to be on a new line
- As inner group direct child, produce nothing but forces the creation
  of a new <tr/> (for the next group children)
2017-05-11 15:09:25 +02:00
qsm-odoo 97517a1cc2 [REF] web: label creation on form view rendering
The original goal of the commit was to implement a missing behavior
for label tags in form view. This finally need some deeper refactoring
for it to work so this commit does not introduce any change in behavior,
only comments explaining the problem.
2017-05-11 15:09:25 +02:00
qsm-odoo 23beee818a [FIX] web: do not lose field/label pair on field rerendering
When a field widget switches between readonly and editable states, it is
fully rerendered. Labels have sometimes to get a specific class when
their associated field is (become) readonly and without any value. This
condition was evaluated on the initial widget and not on rerendered
ones.

Note that this commit only restores an already implemented behavior
broken by https://github.com/odoo-dev/odoo/commit/8f9362809e91ff7c2876ab464017abb13a4e0974
... but this time a test will prevent a new breaking
2017-05-11 15:09:25 +02:00
Martin Geubelle ef643783a5 [FIX] web: deal with malformed default_order
Even if the `default_order` attribute should be like 'name,id desc,coucou'
we want to support the syntax 'name, id desc, coucou' (i.e. with spaces after
the comma).

The commit also patches the mock server.
2017-05-11 14:48:35 +02:00
Christophe Matthieu 2e69c189b1 [IMP] web: calendar test: Error message when the screen is too small 2017-05-11 12:57:59 +02:00
Christophe Matthieu cc141dcce1 [FIX] barcode: Avoid making requests to onchange method on each scan
Usecase: A person scans various products in a warehouse or the network is slow.
Only one request per product must be made, the rest is changing the number locally
and all performed scans (products or actions) must not be lost.
The mutex ensures that the scan is performed in the correct order.
2017-05-11 12:57:44 +02:00
Christophe Matthieu eae62af904 [FIX] account: remove automatic reconciliation button for manual reconciliation
Functionality deprecated since v9
Add also some small rendering fixes for manual reconciliation:
* display congrats only once
* display journal_id as required
* use isValid to create a new proposition line
* Can erase all proposition lines in manual reconciliation
2017-05-11 12:57:32 +02:00
Thibault Delavallée 6b490ef247 [FIX] base, report: fix choose report template broken by 'new report'
Report module has been cleaned and moved into base at https://github.com/odoo/odoo/commit/e80238042c9d93d492ea8b06b0041aced0d81dcd.
However there are leftover references to report module. This crashes
the template choice feature.
2017-05-11 12:35:23 +02:00
Yannick Tivisse 19935c2c38 [FIX] sale: Display correclty 'Pro-forma #' on invoice report
Purpose
=======

When sending a proforma by email, the email template is correclty rendered. But 'Quotation #' id displayed on the printed report instead of 'Pro-forma' #

Specification
=============

- Retrieve correctly the context key in the template
- Remove the associated ir.actions.report.xml as we cannot pass a specific context from there
2017-05-11 12:25:53 +02:00
Yannick Tivisse 2a5cd52d83 [MERGE] various: Improve readability on mobile by adding default kanban views
See each commit message for more information about the impacted modules.
2017-05-11 11:40:14 +02:00
Kishan Gajjar 72553c6022 [IMP] base: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- base : kanban for currencies

- base : kanban for users

- base : kanban for Companies
2017-05-11 11:38:42 +02:00
Kishan Gajjar 8b40c29736 [IMP] various: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- report_intrastat: kanban for intrastat

- google_drive: kanban for Google Drive(Templates)

- anonymization: kanban for anonymized fields
2017-05-11 11:38:42 +02:00
Kishan Gajjar e9e7c63727 [IMP] project,survey,mass_mailing: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- mass_mailing: kanban for mailing lists

- mass_mailing : kanban for contacts

- marketing_campaign: kanban for campaigns

- marketing_campaign : kanban for segment

- survey: kanban for answers

- project : kanban for config >> project(reuse project dashbord kanban)

- project_issue_sheet: kanban for stages
2017-05-11 11:38:42 +02:00
Kishan Gajjar d2cddd66fb [IMP] hr_*,lunch: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- hr_holidays: kanban for leaves summary

- hr_holidays: kanban for allocation request(reuse  leaves summary)

- hr_holidays: kanban for leave details(reuse leaves summary)

- hr_attendance: kanban for attendances

- hr_timesheet: kanban for activities

- hr_contract: kanban for contracts

- hr_recruitment: kanban for Stages

- hr_recruitment: kanban for Job Positions(reuse Job Positions dashboard)

- lunch : kanban for previous order

- lunch : kanban for employee payment

- lunch : kanban for control accounts reuse kanban of employee payment

- lunch : kanban for control vendors reuse previous order

- lunch : kanban for product

- lunch : kanban for alerts

- lunch : kanban for today's orders(reuse previous order)

- website_event_track: kanban for track stages
2017-05-11 11:38:42 +02:00
Kishan Gajjar f1d87b37ed [IMP] account: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- account : kanban for purchases payments

- account : kanban for journal entries

- account : kanban for chart of accounts

- account : kanban for budgets

- account_analytic_default : kanban for analytic defaults

- account_asset : kanban for assets

- account_asset : kanban for asset types

- account_budget : kanban for Budgetary Positions

- account : kanban for fiscal positions

- account : kanban for taxes

- account : kanban for payment terms

- account : kanban for bank accounts

- account : kanban for journals(reuse Accounting Dashboard)

- analytic : kanban for analytic accounts

- analytic : kanban for analytic entries
2017-05-11 11:38:42 +02:00
Kishan Gajjar b2ebf59a11 [IMP] stock,mrp,barcode: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- stock: kanban for incoming products

- stock_picking_wave: kanban for picking waves

- stock: kanban for reordering rules

- stock: kanban for inventory adjustments

- stock: kanban for stock moves

- purchase_requisition: kanban for purchase agreement

- purchase_requisition: kanban for purchase agreement types

- procurement: kanban for procurement exceptions

- mrp: kanban for unbuild orders

- mrp: kanban for waiting availability mo

- mrp: kanban for routing

- mrp: kanban for bill of materials

- mrp_repair: kanban for repair orders

- mrp : kanban for work order messages

- mrp : kanban for productivity losses

- mrp : kanban for Orders to Plan(reuse Manufacturing Orders

- mrp : kanban for work centers(reuse Work Centers Dashboard)

- maintenance: kanban for equipment categories

- barcode : kanban for barcode nomenclatures
2017-05-11 11:38:42 +02:00
Kishan Gajjar fe4c3ab4eb [IMP] point_of_sale: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- point_of_sale: kanban for pos orders

- point_of_sale: kanban for pos session

- point_of_sale: kanban for pos category

- point_of_sale : account journal dashboard kanban in account can be used in payment methods

- pos_restaurant: kanban for floor plans

- pos_restaurant : kanban for order printer(use default kanban)

- pos_mercury: kanban for mercury configurations(use default kanban)

- point_of_sale : kanban for configration >> point of sale (Reuse Point of Sale (dashboard))
2017-05-11 11:38:42 +02:00
Kishan Gajjar 77451ba7a6 [IMP] crm, product, membership: Add kanban views for all menuitems used in mobile
Purpose
=======

Improve readability on mobile

Specification
=============

Activate Kanban view on those so it could be displayed by default on mobile instead of view list

List of impacted modules:

- crm: crm leads kanban

- membership: kanban for membership config

- product : kanban for pricelists
2017-05-11 11:38:42 +02:00
Pierre Masereel 36aebfb0f7 [FIX] base: ir_cron active_test in context
When the list view of 'ir_cron' is opened, the key 'active_test' is set
to False in the context to see all cron, even the archived ones.

The problem by passing 'active_test' in context is that it's propagated
to all actions launched from this view, for example whan you run
manually a cron, this key is passed to the cron action, which may leads
to call some actions on archived records which is not intended.

To fix this issue, we removed the key 'active_test' from context and
instead create a filter that show all crons set by default.
2017-05-11 11:25:11 +02:00
Martin Geubelle c8d063d357 [FIX] web: use o_tag_color outside of badges
Since rev https://github.com/odoo/odoo/commit/250e716c3a12e88acb4a199b427dc47d4ec55d5d
the colors have been mistakenly moved in a too restrictive rule and could only be
used in a badge.
2017-05-11 11:21:00 +02:00
Martin Geubelle 268397e880 [IMP] web: TestUtils: allow to smoothly intercept an event
A parameter has been added in the `intercept` function if one wants to
intercept an event without stopping its propagation.
2017-05-11 11:20:59 +02:00
Thibault Delavallée e6ba4e5f35 [FIX] base, report: fixes various bugs introduced when 'refactoring' reports
Commit https://github.com/odoo/odoo/commit/e80238042c9d93d492ea8b06b0041aced0d81dcd refactored and removed report
module. However it broke among other the feature allowing to customize
reports. This commit fixes first bugs preventing the 'choose template'
box to appear. Feature is still broken though.
2017-05-11 11:13:55 +02:00
qsm-odoo 69d572a015 [FIX] web: restore col(span) feature for form groups
Current new implementation of the form view ignored several properties
linked to <group/> elements:

- groups' col attributes were considered to always be 2
- groups' children colspan attributes were considered to always be 1
- elements different than <field/> and <label/> in groups were forced
  to their own row
- it was not possible to have a group hierarchy deeper than 2
- <td/> elements widths were not properly set
- ...
2017-05-11 10:39:06 +02:00
qsm-odoo c44578ee1a [IMP] web: improve qunit logging and config
When a qunit test fails, the log only contains the assertion message.
This is in fact useful to have the "actual" and "expected" values to
understand the bug.

Also, we recently updated the configuration so that the "hide passed
tests" option is enabled by default. This is in fact useful to have
it disabled if the user wants to run only one test (debugging).
2017-05-11 10:39:06 +02:00
qsm-odoo ac7da497a2 [REF] web: form_tests.js was wrongly indented 2017-05-11 10:39:06 +02:00
Aaron Bohy 067815f97d [FIX] purchase: sort order_line by sequence
Commit 9d4efc8 added the sequence field on model
'purchase.order.line' and added this field in the
tree view (with 'handle' widget), to allow to
re-order the purchase order lines in the purchase
order form view.

However, for this to actually work, the default order
on the model should be on sequence field, otherwise
the rows will still be ordered by id even if the user
changes their sequence value by re-ordering them.
2017-05-11 10:15:10 +02:00
Thibault Delavallée a60b3b6c8c [MERGE] various: be fussy on report names
Report naming has been recently updated at commit efdb5373c3 . However
some people, same kind of people who cannot walk on two stone steps at
a time or have to put their pens parallel on their desktop, thought
another step could be done in order to have the same convention of naming
for every report. Convention for report naming is now "<report name> -
<object name>".

This commit also improves the RNG validation of report tag in order to
be able to directly put print_report_name into the report declaration
instead of having to define it in a separate ir.actions.report.xml node.

This merges remote-tracking branch 'dev/master-report-name-youpie'.
2017-05-11 10:00:44 +02:00
Géry Debongnie c31bf95e4e [FIX] pad: make it work with the new views
The pad widget was partially updated to the new views, but was no longer
working.  In this commit, we rewrite the widget to make it work.

Note that we did some functional changes:
- we do only one rpc to check if the server is configured. the result is
  stored on the prototype, so we do not need to do it again
- we do some rpcs with shadow: true, so we will not stop the rest of the
  ui if the server is slow to respond
- we display a loading message in readonly, when the content is not
  loaded yet.
2017-05-11 09:53:10 +02:00
Géry Debongnie 33710d540c [FIX] web: small fixes in test framework
We fix in this commit three small issues in the test framework.

1. throw an explicit error when we try to do a fieldviewget in the mock
server with a model that does not exist.  This will make it easier to
figure out what went wrong when copy pasting a test from one file into
another, and forgetting to change the model in the createView parameters

2. wrap the result of special methods in the mock server in a deferred,
so we can simply return a value when using that functionality.  Also, it
is more consistent with the rest of the mock server

3. for iframes, we no longer change the src attribute to #test:url.
This had the problem of actually loading the page.  Instead, we change
it into about:blank and we copy the old url into the data-src attribute for
reference.
2017-05-11 09:53:08 +02:00
Olivier Dony 7dc2ed94c3 [MERGE] Forward-port 8.0 up to e0014387 2017-05-11 09:05:32 +02:00
Olivier Dony e0014387c5 [FIX] report: always close pdf files after merge
If an exception during the merges (such as a file descriptor overrun), we
would otherwise depend on the next garbage collection to close the
files. But the next GC may never come.

For example if we ran out of OS file descriptors during merge, all future
requests will crash for the same reason, and the process will never recover
because the GC will never run.

Much easier to explicitly close the files all the time.
2017-05-11 09:01:12 +02:00
Olivier Dony 3978713996 [FIX] mass-mailing: unsubscribe even when archived
A record (Partner/Lead) that was archived can still be unsubscribed.
2017-05-11 09:00:44 +02:00
Aaron Bohy 4e8e546ed7 [FIX] web: DebugManager: open view: search and qweb views
can't be opened that way.

For now, only views that can be opened with a view manager are
supported, i.e. views like form, list, kanban, graph...

So this fix filters out the views of type qweb and search from the
list.
2017-05-11 08:52:24 +02:00
Jérome Maes 527d639148 [MERGE] hr_timesheet_sheet: remove the module
This module is buggy and unusable. The goal is to
simplify timesheet flow.
New validation flow is bring with timesheet_grid
(enterprise edition ....)

These commits provides adaptations and removal
of hr_timesheet_sheet.
2017-05-11 08:36:59 +02:00
Jérome Maes af00486791 [REM] hr_timesheet_sheet: kill the module
Remove the module, since we deprecate complex
sheet management.
2017-05-11 08:36:11 +02:00
Jérome Maes cfe1b2e371 [IMP] project: change planner link to hr_timesheet_sheet 2017-05-11 08:36:11 +02:00
Jérome Maes 2e251f7599 [IMP] hr_timesheet_attendance: remove timesheet_sheet dependency 2017-05-11 08:36:10 +02:00
Thibault Delavallée 00d5a2f039 [IMP] inventory related addons: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .

Improve report naming in product, stock, mrp and mrp repair.
2017-05-10 17:16:09 +02:00
Thibault Delavallée b380347b0b [IMP] hr related addons: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .

Improve report naming in hr_attendance, hr_expense and hr_payroll.
2017-05-10 17:16:09 +02:00
Thibault Delavallée 0e9d397978 [IMP] event: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .
2017-05-10 17:16:07 +02:00
Thibault Delavallée ad2ccbbb59 [IMP] account related addons: improve report naming and use print_report_name
Purpose of this commit is to clean and uniformize report naming through
various addons. It has been chosen to name them using a formatting like
<report_name> - <object_name or suffix> .

Improve report naming in sale, point of sale, l10n_ch, purchase,
purchase requisition, report intrastat, website_quote
2017-05-10 17:15:02 +02:00
Thibault Delavallée 3a52e5e5c9 [IMP] import, report: allow print_report_name when defining a report
Otherwise you have to have another xml block just to define the print
report name instead of doing everything in the report tag.
2017-05-10 17:10:04 +02:00
Thibault Delavallée dbe6aa4292 [FIX] account: finally allows to reinit the module
Otherwise a constraint is raised because new line are added to the
payment term instead of recreating them from scratch. This constraint
blocks people from reinitializing the module, which is quite boring
when developing.
2017-05-10 17:09:29 +02:00