Commit Graph
117975 Commits
Author SHA1 Message Date
Pierre Masereel 62c6d6fc81 [FIX] stock: move_view without suggest
The move line view when the option no suggest is checked doesn't work
because it hasen't been adapted during the refactoring of stock module.

So to avoid having differences between the view in no suggest and in
suggest, we use the same tree view that we reference. Because the views
shouldn't be different if we are either in suggest or no suggest
2017-09-15 11:48:11 +02:00
Deep Patel 1c0befc8a6 [IMP] web: UX improvement on mobile for the sale order view 2017-09-15 11:16:11 +02:00
Martin Geubelle 74c27d81ed [FIX] web: deal with can_create and can_write option in M2O
The server postproccess the view to add attributes on many2one fields, i.e.
`can_create` and `can_write`, according to access rights.

These attributes are parsed by the client as string but should also be parsed by
the many2one when evaluating them.

The mock server has also been adapted to set these attributes.
2017-09-15 11:03:09 +02:00
Jose Suniaga [Vauxoo] 27edcaafd6 [FIX] l10n_mx: company in the journal cash basis configuration
When have more than one company, for all companies, the cash
basis journal  set in accounting configuration will be
always the related to first company.

This issue cause the followiong error trying to validate an
invoice for a company different to fisrt one:

'Cannot create moves for different companies.'

Because exist a 'cross-configuration' in the cash basis
journal.

The solution to this issue is include the company in domain
that does the search for cash basis journal.
2017-09-15 10:39:32 +02:00
Pierre Masereel b9be8402c3 [FIX] core: handle sql constraint exceptions in python3 2017-09-15 10:18:32 +02:00
Simon Lejeune a7fa3cc436 [FIX] stock, purchase: correctly remove stock_calendar 2017-09-15 08:34:35 +02:00
qsm-odoo 814304a227 [MERGE] web, *: add kanban column progressbar feature
* crm, project

See last merge commit for detail.
Work started by @pat-odoo and @stefanorigano
2017-09-14 23:51:48 +02:00
qsm-odoo 33f9e90bd5 [IMP] web, *: add kanban column progress bars
* crm, project

Add a new feature which allows to put a progressbar in the kanban
columns. The progressbar shows with the same color the amount of
records whose value of a given field are the same in the column.
It also indicate the sum of another given field or simply the total
number of records. It also allows to subgroup the column content.

To define a progressbar, add this as a direct child of the kanban
arch:

<progressbar field="<name of the field to use for subgroups>"
             colors="{<one possible value for the above field>: <success, warning or danger>, ...}"
             sum="<name of the field to sum or nothing to use total number of records>"/>

Also:
- Properly update record model data's parentID when moving a record
- ...
2017-09-14 23:48:56 +02:00
qsm-odoo 031dc1d952 [REF] web: allow to perform a standalone read_group
Before this commit, asking the basic model for a 'read_group' operation
was automatically followed by other operations to read groups content
('search_read', 'read', ...). This commit introduces an option to only
perform a 'read_group'.
2017-09-14 23:48:55 +02:00
qsm-odoo 76ad4e71a5 [REF] web: do kanban group manual update before saving a record move
Before this commit, when a record was moved in a kanban view, the
model saved the record change then manually updated the related groups
(to avoid performing a read_group and reloading the whole view). This
manual update can in fact be performed before the record save. This
allows customizing the save operation in some cases where a real
read_group would be needed.
2017-09-14 23:48:55 +02:00
qsm-odoo 8b00628aa2 [REF] web: also use _confirmSave when a kanban record is 'manually' updated
Normal flow for one record's changes to be saved is:

0) (use `_setValue` for fields)
1) `trigger_up('field_changed')`
2) field manager mixin: `_onFieldChanged`
3) model: apply changes and save
4) controller: `_confirmSave`

Kanban records are using another system for an unknown reason. This
system was calling the right model functions but was not calling the
controller `_confirmSave` and was instead re-coding it. This commit
makes sure that `_confirmSave` is now called.
2017-09-14 23:48:55 +02:00
qsm-odoo 5c6a7c9ea9 [REF] web: do not update groups model ID on read_group update
Performing a 'read_group' was creating new model group data which were
saving some properties of the old model group data. As KanbanColumn
widgets may not be updated in each case where we might want to re-do
a (partial) 'read_group', this commit changes the system so that old
model group data are simply updated with the useful new group data
properties (instead of being entirely replaced).
2017-09-14 23:48:54 +02:00
qsm-odoo f1370dfa0a [REF] web: allow adding custom stuff in kanban header
Previous kanban header was a div with `flex-flow: row nowrap`. So if
someone tried to add some stuff in it, it will be forced to stay on
the same row as the title and config buttons. This commit wraps these
row elements in a new div to allow kanban header customization (this
prepares for the kanban progressbars).
2017-09-14 23:48:54 +02:00
qsm-odoo 8496a31421 [REF] web: move misplaced kanban quick create code 2017-09-14 23:48:53 +02:00
qsm-odoo 268b4a5a1d [FIX] web: fix kanban alignments
Previous implementation contained negative paddings which are not valid
values for browsers. This also prepares for the kanban progressbars.
2017-09-14 22:46:04 +02:00
Christophe Simonis a63a805efb [FIX] core: python3 compat: do not modify dict during iteration 2017-09-14 19:41:13 +02:00
Prakash Prajapati 0c04aaa303 [IMP] account: generic PDF tax report for community.
Was PR #19097. Was task 35751.
2017-09-14 17:49:01 +02:00
Goffin Simon 82efd56593 [FIX] account: Reconciling residual payment in other currency
Steps to reproduce the bug:

-Let's consider a company A in the currency MXN
-Let's consider two invoices for customer C in USD one of 150$ and one of 50$
-Create a payment P of 180$ for customer C
-Reconcile P with the first invoice of 150$(with button add on the invoice)
-Go to the other invoice of 50$

Bug:

The residual amount of 30$ is not suggested.

Fix:

The residual amount is set in amount_residual_currency, that's why it
was not detected by the domain. Now the residual amounts in other currency
are also detected for the reconciliation.

opw:769090
2017-09-14 17:14:48 +02:00
Jeremy Kersten 8f99b24f6c [FIX] payment_sips, payment_ogone: remove call to partner_reference.
This field has been removed on transaction model in commit f8a98d9.
2017-09-14 16:27:43 +02:00
Jeremy Kersten 265f9ab509 [FIX] payment_sips: allow to override the default atos url.
Sips is generic, and others services that Atos use the same protocol.
It is not user-friendly, but that allow user to use alternative service
like 'Sogenactif'.

In next version, we need to add field on config to specify it and the
InterfaceVersion that can differ according to the provider.
2017-09-14 16:27:43 +02:00
Xavier Morel 359d91e94a [FIX] website_form: custom field thing blows up in P3
Custory reading seems to denote that field names are probably already
text in the normal case, and thus should not need decoding? It only
blows up in a tour so...
2017-09-14 15:41:13 +02:00
Cédric Pigeon bf8f701032 [FIX] purchase: multiple backorders
Avoid crash if multiple backorders are found.

Closes #19452
opw-771732
2017-09-14 15:16:57 +02:00
Simon Lejeune 5ec4401712 [FIX] sale_stock: adapt to procurements removal
Now, the move is directly linked to the sale order line.
2017-09-14 15:13:02 +02:00
Martin Geubelle 135a6fb45b [FIX] web: Kanban: move a record when grouped by selection
Move a record from one column to another in a kanban grouped by a selection field
leads to a traceback.

A selection field value is composed of a tuple ('value', 'String') and the write
command must send the `value` and not the `String` as it was done before this rev.
2017-09-14 15:03:29 +02:00
Martin Geubelle 7de94268fc [FIX] web: skip buttons when navigating in editable list
Clicking on a cell that contains a button (but not ON the button) leads to
a traceback (see "Scrap" button in Stock Operation for example).

This is due to the fact that a button is not registered as a widget so it can't
be activated.

This commit ensures that the next line is selected if the last column is a
buttton.
2017-09-14 15:03:29 +02:00
Jérome Maes 406ba5dcc0 [MERGE] sale_expense: reinvoicing flow
This merge provides some changes in the
expense flow.

The most important one is to reinvoice
an expense, employee set a SO on its expense
and not an analytic anymore (since it
requires special access group, ...)

This commit also bring back the auto
creation of analytic account when confirming
SO if expense product is sold (since AA is
required to generated analytic line of
the operation).

Some usability changes, and code cleaning
are also available. See subcommits for details.
2017-09-14 14:50:36 +02:00
Nicolas Martinelli 4e799fed8e [FIX] crm: expected closing
Backport of commit abea8d3513

opw-771843
2017-09-14 14:49:18 +02:00
Jérome Maes c8e23968d3 [IMP] sale_expense: add test cases 2017-09-14 14:48:07 +02:00
Dhawal Limbuwala 10a497011d [IMP] hr_expense: new tour for user onboarding
Steps:
- In home, expense app icon: "Go to the expense
to attach a receipt"
- In list, on create button : "Click here to create
your first expense and add it to below."
- In form, on save button : "Once your Expense is
ready, you can save it."
- In form, point out the chatter "Attach your
receipt here."
- In list, point out record selection: "Select
expenses to submit them to your manager"
- Point out "Action": "Click on Action Submit To
Manager to submit selected expenses to your manager"
- In expense sheet point out approve “Approve the
sheet here. Tip: if you refuse, don’t forget to
give the reason thanks to the hereunder message
tool".
2017-09-14 14:48:07 +02:00
Jérome Maes 04dd0a2dd4 [IMP] sale: create an ananlytic on SO confirmation when at least an expense product
This behavior kind of disappear with 48ea59d46e

Moreover, since the Analytic Accounting is hidden, and
a AA on expense is required to reinvoice product on
SO, an AA should be on the SO as default value.
2017-09-14 14:48:07 +02:00
Jérome Maes 751330a843 [IMP] sale_expense: reinvoice expense flow
The main change is we use SO and not analytic account
anymore to reinvoice expense.

When encoding an expense, each employee can directly
set the SO to allow re-invoicing the expense to a
client. Before this commit, this was done by determining
the SO based on the Analytic Account (magically) on the
expense.
This solution is less confusing and more explicit for
the end user.

This commit also bring usability improvements to
improve user experience during this flow:
- better expense product view
- access group on menu items
- ...
2017-09-14 14:48:07 +02:00
Jérome Maes 2dda108cb3 [IMP] hr_expense: link move line and expense for better tracking
Each move line generated from an expense posting will
be linked to the original expense. Some of those move
lines are for taxes, one for the product, ... but they
are all link to the same expense.
This will allow better reporting, and allow to access
the expense record from the move or its analytic lines
for futher developement.
2017-09-14 14:48:07 +02:00
Jérome Maes 84e96fe7dd [IMP] sale: add name_get and name_search on SO
The goal is to have a name_get for SO returning
a value like 'SO0002 - Michel F.'

To avoid performance problem, the chosen solution
is to add a context key 'sale_show_partner_name' to
provide the partner name in name_get(), otherwise
it will always add it and kill the performance.
This solution is preferred over adding a stored
related field for partner name (trigger recompute
when partner is renamed for all SO is bad).
2017-09-14 14:48:07 +02:00
Simon Lejeune 64c848a047 [REM] stock_calendar 2017-09-14 14:35:25 +02:00
Christophe Simonis 4bcd444eae [FIX] core: python3 compatibility for migration engine 2017-09-14 14:09:29 +02:00
Xavier Morel fccbe4ff4f [FIX] website_form: custom field thing blows up in P3
Custory reading seems to denote that field names are probably already
text in the normal case, and thus should not need decoding? It only
blows up in a tour so...
2017-09-14 12:21:26 +02:00
Christophe Simonis 97a9384c3e [MERGE] forward port branch saas-17 up to 4a878fa4dc 2017-09-14 11:45:54 +02:00
Pierre Masereel 858cb6534b [FIX] stock: barckorder on move with mulitple move_line
When a move is set to done and a backorder should be create, we get a
traceback saying that we cannot set the quantity done on a move with
multiple move move_lines.

This occurs, when the stock move has multiple move lines with quantity
done set to 0;

Because the new move only contains move lines having quantity done 0, we
remove the useless line that set the quantity done on the move
2017-09-14 11:25:26 +02:00
Goffin Simon ce2d00f346 [FIX] account: Register a payment with no sequence for account.payment
When registring a supplier invoice, if no sequence exists for code "account.payment.supplier.invoice"
then it failed for the creation of the counterpart lines because a name is required to create an
account move line.

ps: check function "_get_liquidity_move_line_vals" for the condition.

opw:767224
2017-09-14 11:13:39 +02:00
Jeremy Kersten dc49b85493 [FIX] website_customer: add access rights for res.partner.industry
List of industries is not a sensitive data, and public user need to have
access right for sitemap.
2017-09-14 11:12:34 +02:00
Goffin Simon 77566f5067 [FIX] website_sale: Pay Now button is clickable even without clicking policies and conditions
Steps to reproduce the bug:

-Go to the shop
-Add an item to card
-Checkout
-Insert address info
-Click proceed
-Enable "Accept Terms & Conditions"
-With the HTML Editor, remove the attribute checked="checked" in template Accept Terms & Conditions

Bug:

-Pay Now button is clickable but the Policy and Procedures box was not checked.

opw:771418
2017-09-14 10:57:02 +02:00
Mitali Patel ad79fed261 [IMP] im_livechat: add copy to clipboard for the website live chat widget code
This commit adds 2 buttons to copy directly the code needed to add the livechat
in the website.
2017-09-14 10:54:00 +02:00
Monish Soni 5228daf195 [IMP] web_setting_dashboard: improved dashboard responsivity 2017-09-14 10:53:26 +02:00
Parth Patel 84c0b81c6a [IMP] discuss: Adjust chat window to avoid overlapping the scrollbar 2017-09-14 10:53:01 +02:00
Xavier Morel 4a878fa4dc [FIX] P3: metadata update
* gitignore pycache folders (apparently appear for some)
* update xlwt requirement: 1.1.2 does not work with Python 3.6, 1.2 should work, 1.3 officially supports it
2017-09-14 10:18:06 +02:00
Mitali Patel 70942e4cfb [IMP] base: improve view rng validation (#17902)
Split big universal RNG into view-specific schemas and moved rng based view validation
into view_validation.py file.
Adapt old views, and remove deprecated tag `version="7.0"` from views.
2017-09-14 10:16:00 +02:00
Florent de Labarre 93d4da977a [IMP] account: improve error message raised
Add the code/name of deprecated account on the error message when it is used.

Was PR #19392. Courtesy of Florent de Labarre
2017-09-14 09:59:24 +02:00
Lucas Perais ecc7509277 [FIX] account, invoice analysis: negative amounts for in_invoice-like
Before this commit, the invoice analysis report summed the amount of invoices regardless of whether they were in or out,
as if it were an absolute sum.

This commit corrects the behavior back to v9's, where in_invoice have the minus sign and are hence subtracted

opw 769409. Was PR  #19413
2017-09-14 09:56:07 +02:00
Lucas Perais (lpe) c5b9bdcf9f [FIX] website_quote: images of acquirer should be dynamic
Echoes commit c255342e8f

Before this commit, the image that was fetched for the quotes was the static one, preventing it to be changed

Now, the image is dynamically fetched

OPW 769701

closes #19417
2017-09-14 09:53:39 +02:00
Lucas Perais (lpe) be3b0069fb [FIX] account_extra_reports: empty partner name in sales/purchase journal
Before this commit, since a partner's name can be empty, a traceback was thrown while opening the report in such a case.
Now, if the partner's name is falsy we don't try to do operations on it

OPW 769835

closes #19400
2017-09-14 09:48:12 +02:00