Commit Graph
35 Commits
Author SHA1 Message Date
Thibault Delavallée 56645335b7 [IMP] gamification: improve email sent when granting a badge
Give some details about the badge: its description, its image, who granted
it, ... Otherwise it is quite complicated to understand the email content.

Thanks to @mart-e who reviewed and tested.
2016-12-30 10:46:12 +01:00
Jeremy Kersten 26c7ff9118 [FIX] gamification: don't use multimode from render_template
If render_template get list and not id, a dict is returned.
Force the param to be a int, allow to don't use the multimode from render_template.

Avoid to get message like:
 <p>{1: u'\n        </p><p>Congratulation, you have received the badge <strong>Autobiographer</strong> !\n        </p>\n\n'}
 <p>{2: u'\n        </p><p>Congratulation, you have received the badge <strong>Autobiographer</strong> !\n        </p>\n\n'}
 <p>{3: u'\n        </p><p>Congratulation, you have received the badge <strong>Student</strong> !\n        </p>\n\n'}
 <p>{4: u'\n        </p><p>Congratulation, you have received the badge <strong>Supporter</strong> !\n        </p>\n\n'}
2016-09-22 18:17:55 +02:00
Thibault Delavallée 8b6f7e1fe6 [FIX] various: fix fields index parameter in new API still called select 2016-08-09 12:28:03 +02:00
Xavier Morel 0c649644db [MIG] gamification: Migrate to new API
Includes compatibility-change to website_forum: a selection(callable)
converted to a Selection(list) since that can easily be extended in the
new API.
2016-08-05 10:18:02 +02:00
Christophe Matthieu bad14a54d3 [IMP] gamification: add sql index on 'gamification.badge.user' to improve speed of 'gamification.badge' function fields 2016-03-23 12:53:16 +01:00
Christophe Matthieu 2abc2ceee0 [IMP] gamification: split multi function field to avoid massive prefetching of user records
Issue: website_forum takes 15 to 30 seconds to load the user page
2016-03-23 11:22:51 +01:00
Miku Laitinen c9163c5403 [FIX] gamification: Made gamification badge descriptions translatable
The badge name is already translatable but the description was not,
Regenerate .pot file for these modules.

Closes #8399
2015-09-30 14:44:35 +02:00
Raphael Collet 5a6e136172 [IMP] addons: adapt binary fields to store images in attachments 2015-09-28 15:19:47 +02:00
Olivier Dony 0bd4545348 [LEGAL] Use global LICENSE/COPYRIGHT files, remove boilerplate text
- Preserved explicit 3rd-party copyright notices
- Explicit boilerplate should not be necessary - copyright law applies
  automatically in all countries thanks to Berne Convention + WTO rules,
  and a reference to the applicable license is clear enough.
2015-06-02 03:16:04 +02:00
Ravi Gohil 2acad60391 [FIX] gamification: translatable email notification
This requires a manual update/migration for existing template. opw 619786
2015-01-21 12:30:34 +01:00
Goffin Simon 0fd773a486 [IMP] Cleanup and refactoring of exception handling
Unify and refactor exception handling in framework and addons.

The generic `except_osv` is now deprecated, and replaced by more specialized exception subtypes:
 - `UserError` (renamed from Warning, as it conflicts with the built-in `Warning`) raised when a non-technical error occurs during a business operation. It could be a missing information in the data provided by the user, or a misconfiguration.
 - `AccessError`: raised when any operation is denied because the user conducting it does not have the required access rights.
 - `AccessDenied`: raised when an operation that requires authenticated access is attempted via an unauthenticated request.
 - `MissingError`: raised when an operation is attempted on a record that does not exist.
 - `ValidationError`: raised when an operation violates a SQL or Python constraint.
 - All other exceptions are internal errors due to a system problem or bug, and raised untouched to the client-side, which should display a traceback.

All exceptions take a single message argument.

The `test_exceptions` module has been updated to showcase both new and old (deprecated) exceptions.

A great many old `except_osv` had a useless title with "Error!" or "Warning", those have been removed, as this is handled by the client-side widget that displays the messages.

This commit introduces a more consistent policy for logging errors and warnings:
 - All messages that do not require administrator attention should be logged at INFO level or lower. This includes all errors that are notified to the user in a friendly manner, even for access right problems or validation errors during business operations.
 - All messages that indicate a likely misconfiguration or malicious use by the users should be logged at WARNING level, as they typically require administrator attention.
 - All other unhandled internal errors cannot typically be handled by the user and should be logged at ERROR or higher level, as they require immediate administrator attention.
2015-01-16 17:15:18 +01:00
Julien De Coster d88c34d11e [IMP] Mass mailings send in cron
1. The merge of the "email_template" module into the "mail" module.
2. The send action of the mass mailing has been moved from the frontend to a cron, because it was too slow to send over 10,000 mails (the user's browser was blocked for 15 - 20 minutes). Mass mailings have now their own process in the kanban view.
3. Mails sent from the mail form are sent immediatly instead of from the mail queue (for instance, when you go to sales > customers > list view > select 2 -3 customers > More > Partner Mass Mailing).
4. Users have now the choice from which mailing list they want to unsubscribe when they click on the unsubscribe link at the bottom of the mail.
5. Mass mailings inherit from their campaign UTMs and mass mailing campaigns are linked to an UTM campaign.
6. Many little improvements
2015-01-07 18:01:58 +01:00
Christophe Simonis 2e3f59181d [MERGE] forward port of branch saas-3 up to db75994 2014-10-14 15:13:14 +02:00
Denis Ledoux f305b9e95b [FIX] gamification: on delete badge user, cascade
Otherwise, this is no more possible to delete users having badges
2014-10-07 10:24:57 +02:00
Thibault Delavallée 7cad4baa84 [FIX] [CLEAN] Various: fixed / cleaned use of dict.fromkeys.
Indeed using fromkeys with a list / dict as argument leads to the creation
of shared list / dict. This could create some ugly side effects when
used in loops. This commit fixes or cleans this kind of statement to avoid
unwanted side effects.
2014-09-18 11:18:30 +02:00
Martin Trigaux e95aeb659c Forward port of branch saas-5 up to 9a7f48a 2014-09-02 14:50:51 +02:00
Martin Trigaux b707719891 [IMP] gamification: improve 40e8437 to make only one global request 2014-09-02 11:25:02 +02:00
Martin Trigaux 40e843761f [FIX] gamification: performance improvement
On a large database, thousands of badges may have been granted. This code used to prefetch all fields of the users and badge users. This was highly inefficient. Replace this code by SQL query.
2014-09-01 17:40:47 +02:00
Jaydeep Barot 026e38b48f [REM] Unnecessary size parameters on char fields 2014-06-25 17:13:43 +02:00
Martin Trigaux f14f632ef5 [IMP] gamification: improve the name of some m2m relations
bzr revid: mat@openerp.com-20140512092718-s6143ajy2g18ofy4
2014-05-12 11:27:18 +02:00
Thibault Delavallée d0740bedb9 [IMP] gamification: messages posted on user when receiving a badge
now have a subtype, to ease their search.

bzr revid: tde@openerp.com-20140411175730-hq06b7qezurzymj6
2014-04-11 19:57:30 +02:00
Thibault Delavallée f091e9d6e5 [MERGE] Sync with trunk
bzr revid: tde@openerp.com-20140411155723-pqe8ofxh060afiuj
2014-04-11 17:57:23 +02:00
Martin Trigaux 21022c5472 [REF] gamification: add batch mode, improve some views, remove inprogess_update state (replaced with boolean 'to update')
bzr revid: mat@openerp.com-20140411142257-zpaul4sq3t5j5r64
2014-04-11 16:22:57 +02:00
Thibault Delavallée 70eb634173 [FIX] Fixe dlast commit: badge message is posted on the user
as before. Also updated code in mail/res_users that could big: partner_ids given
to message_post can be a list of commands, or a list of ids.

bzr revid: tde@openerp.com-20140409155003-32ccef4udlzfg5us
2014-04-09 17:50:03 +02:00
Thibault Delavallée 9b922d9858 [REVIEW] [CLEAN] gamification: reverted changes instead of
the fix.

bzr revid: tde@openerp.com-20140409152629-3div4vdfknjrtnb6
2014-04-09 17:26:29 +02:00
Turkesh Patel (Open ERP) 9bb6139cd2 [IMP] gamification: improved code to send notification message when bedge assigned, website_forum: improved code to show notification when badge assigned to user.
bzr revid: tpa@tinyerp.com-20140319090735-zi01wzh8a8u5cfb7
2014-03-19 14:37:35 +05:30
Martin Trigaux 7c6a6b26f1 [FIX] gamification: goal.condition -> goal.definition_condition, user_ids not in vals -> not vals.get(user_ids)
bzr revid: mat@openerp.com-20131223161229-lpoevttkt6ezt2ia
2013-12-23 17:12:29 +01:00
Martin Trigaux f4e42879d3 [REF] gamification: rename user_from_id -> sender_id, move constants
bzr revid: mat@openerp.com-20131223160143-8mgmwrgf6i3wo8ku
2013-12-23 17:01:43 +01:00
Martin Trigaux c0eef31160 [REF] gamification: add user_from_id on badge, remove outdated-doc, remove useless message_post call
bzr revid: mat@openerp.com-20131223155404-h4in4ocr8jakq3ff
2013-12-23 16:54:04 +01:00
Martin Trigaux aec8f50b20 [IMP] gamification: use constances
bzr revid: mat@openerp.com-20131220150557-xaomxnrdb4bxcex3
2013-12-20 16:05:57 +01:00
Martin Trigaux 90dfa5895d [FIX] gamification: send badge on user, fix function field
bzr revid: mat@openerp.com-20131218140333-nipcc21z5snhac1c
2013-12-18 15:03:33 +01:00
Martin Trigaux 938a07a361 [FIX] gamification: check grant badges are now sistematic except for superuser (always possible)
bzr revid: mat@openerp.com-20131218130039-y5vp0wt48ejd3jrh
2013-12-18 14:00:39 +01:00
Martin Trigaux 553e85f369 [FIX] gamification: move manifest order and remove useless browse
bzr revid: mat@openerp.com-20131218121459-zlfumwysdx9qm7d9
2013-12-18 13:14:59 +01:00
Martin Trigaux b63950e0dc [REF] gamification: mode to adequate folders
bzr revid: mat@openerp.com-20131218085907-6501sfdif2rk4a0b
2013-12-18 09:59:07 +01:00
Martin Trigaux 122c15c48d [REF] gamification: pretty much changing half of the code to make tde happy...
bzr revid: mat@openerp.com-20131217161541-oxsgy7gmko2x6qui
2013-12-17 17:15:41 +01:00