Commit Graph
120953 Commits
Author SHA1 Message Date
XavierDo 71663b7f57 [IMP] web: log user_error as info instead of error
Since a console.error will mark a tests as failed, logging user error
as info will allow to test a flow with user error without
marking the runbot red
2018-09-14 13:56:32 +02:00
Rémi Rahir b0cc678f17 [FIX] snailmail_account: bad inheritance of views
The xpath on the res config settings view was attached to a div added in the
account module but the record was inheriting from base and not account.
As snailmail account inherits from account, it was somehow working.
2018-09-14 13:53:49 +02:00
qsm-odoo 737d272997 [FIX] portal, *: use responsive BS text utilities instead of our own
* website, website_sale, website_sale_delivery

While we used BS3, we used our own responsive classes for text
alignment (text-right-sm, text-center-not-lg, ...). Now BS4 classes can
be used to achieve the same behavior so there is no point in declaring
our own ones anymore.

Also, as the breakpoint names changed (lg -> xl, md -> lg, ...), the
current code was not working as intended anymore anyway.
2018-09-14 13:41:35 +02:00
Nicolas Martinelli 6e0afe864b [FIX] website: AccessError
The AccessError made sense when it was introduced back in v10, but
doesn't make sense anymore since there is only one setting wizard.
2018-09-14 12:40:06 +02:00
qsm-odoo da55072a69 [FIX] portal, *: introduce responsive BS sizing classes
* website_sale

Bootstrap chose not to implement this feature, probably relying on their
grid system (see https://github.com/twbs/bootstrap/issues/21943).

We have a case where a responsive size of 0px is needed though: applied
on a table, this forces the table to its contents' natural width. So
this commit implements the behavior and adds the size of 0 to replace
the non-responsive class 'o_table_column_fit'.
2018-09-14 12:11:22 +02:00
Martin Trigaux a307d4fc80 [FIX] account_asset: use the last day of fiscal year for depreciation date
The depreciation was hardcoded as starting the first of January.
If a user changed the configuration to set a different value than 31/12 it had
no impact.

In saas-11.3, this was improved to allow to configure the behaviour at 805f3a610

opw-1878927
2018-09-14 12:03:21 +02:00
Yannick Tivisse eb11665bfc [FIX] rating: Send rating if no override of rating_get_parent
Purpose
=======

Currently if the method rating_get_parent is not overriden, then
sending a rating on a record of the model leads to a traceback.
2018-09-14 11:43:15 +02:00
Odoo Translation Bot 0b2349ee41 [I18N] Update translation terms from Transifex 2018-09-14 11:30:58 +02:00
Denis Ledoux 4fb5c57dc5 [FIX] tests: web tests, chromium fallback
On Ubuntu, the chromium executable is `chromium-browser`,
On other distributions, such as debian, it's `chromium`.

We therefore add another fallback
2018-09-14 11:28:56 +02:00
Martin Trigaux a47f7ee0e4 [FIX] product: do not translate at code import
Defined as this, the label of the selection field were translated during code
import, when building the python model, not when a user access the field values
as it should (and is already the case thanks to the ORM).

Trying to translate a string when no user-context is available is not only
useless but may cause bug on services with multiple databases (e.g. a SaaS).

In a multi-worker environment, when the code is imported, the _ method will use
multiple scenarios to detect the language and get a cursor.

As we have no available cursor in the frame (method _get_cr from GettextAlias),
the fallback is made on the cursor of the request.
In a multi-worker environment, this could be a cursor linked to a database in
another language than English.
In such scenario, the selections would be translated in the language of the
other database instead of displaying it in English

opw-1881956
2018-09-14 11:20:38 +02:00
Christophe Monniez 058b1993ab [FIX] l10n_eu_service: remove duplicate service tax rate
Since d5b687a an error is logged when trying to insert duplicates in
ir_model_data. An error appears when installing this module because of
the duplicate.

As this module is not yet tested, this error flew under the radar.

Note: a new test that installs l10n* is developped
2018-09-14 11:17:01 +02:00
Yannick Tivisse 4f9cc90c73 [FIX] rating: Send rating if no override of rating_get_parent
Purpose
=======

Currently if the method rating_get_parent is not overriden, then
sending a rating on a record of the model leads to a traceback.
2018-09-14 11:09:08 +02:00
Denis Ledoux 6e3e195324 [FIX] tests: chromium executable is chromium-browser
When installing chromium using apt
e.g apt install chromium-browser
the executable is `chromium-browser`,
not just `chromium`
2018-09-14 10:43:28 +02:00
Nicolas Martinelli 2e6c1aa5d1 [FIX] stock_account: return dropship
- Set a product with real-time valuation
- Create a SO, select the Drop Ship route
- Validate the SO, the PO, and receive the picking
  => an accounting entry is created
- Return the picking

The reversed accounting entry is not created.

This is because the return of a drop ship picking is not recognized as
some kind of dropshipping.

opw-1879117
2018-09-14 10:35:33 +02:00
qdp-odoo c52d809032 [IMP] account: add setting to hide the products in bills
Was part of PR #26876
Was part of task #1882329
2018-09-14 10:21:02 +02:00
qdp-odoo c5393118c6 [IMP] account: set default taxes on default sale/expense accounts
This will allow default tax to be proposed when no product are entered in vendor bill encoding

Was part of PR #26876
Was part of task #1882329
2018-09-14 10:19:33 +02:00
Olivier Colson 82e1aed2e6 [REF] account: refactors the onchange product_id on invoices
get the product_name thanks to a function, so that we can reuse it somewhere else (account_predictive_account)

Part of PR #26876.
Part of task #1882329
2018-09-14 10:19:33 +02:00
Lucas Perais (lpe) 9511cb2bb0 [FIX] point_of_sale: param for reconcile orders and payment
It has been argued that a regression took place because of e2efec8e54
Before that commit, everything was reconciled together
After, only payments and orders with a partner set were

While that commit improved performances (there are much less move lines to reconcile),
it introduced an inconvenience business wise because of the noise created
by the unreconciled lines

This commit proposes to cut the pear in half by introducing an ir parameter
to choose between the two options

OPW 1883594
closes #26971
2018-09-14 10:10:38 +02:00
Ankit Joshi b8cb25d052 [FIX] stock: views wrong groups on location
Show the source and destination location in the detailed operation view
if the multilocation is active. Also hide locations if only the delivery
package settings.

Issue: 1882695
2018-09-14 10:06:24 +02:00
Lucas Perais (lpe) 148182bf91 [FIX] website: seo add words no freeze
On a website page, click on promote and add the keyword "DS1517"

before this commit, the javascript froze

after this commit, it doesn't freeze

OPW 1880341
closes #26771
2018-09-14 09:58:57 +02:00
len-odoo c8441a69c2 [FIX] project: remove group_by from the context
The group_by was passed from context from the action spawning a new view.
This meant that it could give a group_by a field that was not defined on the
destination view, causing a js traceback.

opw 1884035
2018-09-14 08:34:42 +02:00
Christophe Simonis f3fa5a5ef7 [MERGE] forward port branch saas-11.3 up to 1e0a92c996 2018-09-13 19:30:33 +02:00
Sébastien Theys a670f092b9 [IMP] website: improve Optimize SEO and Page Manager
Modal generic:
- Fix footer overflowing buttons by pushing them to a new line.

Page manager:
- Add an SEO column to easily see which pages have incomplete SEO.
- Add an edit SEO column to navigate to the SEO modal on said page.
- Hide "edit in backend" column as debug.
- Generally improve the whole view by adding appropriate titles on icons, etc.

SEO modal:
- Improve general style.
- Add description length alert.
- Restructure the keyword table/suggestions.
- Reset page meta to their initial value on Discard.
- Various small usability improvements.

PR: #26897
task-1850579
2018-09-13 18:18:02 +02:00
Jeremy Kersten 7a298f89d9 [FIX] website_sale_wishlist: try to fix unreproductible bug
Rumor say that that 1x/100... the variant is not selected and that the tour crash.
So we are not sure that it will avoid that, but it will be not worse.

I will keep my fingers crossed for that.
2018-09-13 18:16:28 +02:00
Hiral Bhavsar 7f1c1b84ef [FIX] website: no overlap of text when opening burger menu
Issue: https://drive.google.com/open?id=1aXlkgpM7fWEWL18XMEAN5lI1uWgeZHqy

Closes #26434
2018-09-13 17:49:57 +02:00
Hiral Bhavsar 5373db1487 [FIX] mail, web: open systray menu dropdown in mobile.
Before this commit, it was not possible to open systray menus in mobile.
This is due to popper.js that is wrongly dynamically positioning the
dropdown menu.

This commit fixes the issue by disabling dynamic positioning by popper.js
for the systray menus, so that it uses ou custom styles for dropdown menu.

Closes #26434
2018-09-13 17:49:52 +02:00
Hiral Bhavsar 3ee4390bff [FIX] web: correct mobile screen size.
Revision on https://github.com/odoo/odoo/commit/d91ec258e6a31153beb9eb16cfe8f916546b7688

The commit above reverts a commit when we were using bootstrap 3.
The equivalent of XS in bootstrap 3 is SM in bootstrap 4.
So the correct revert with bootstrap 4 is to use SM.

Also removing useless style on 'o_mobile_menu_opened'.

Closes #26434
2018-09-13 17:49:36 +02:00
Jeremy Kersten 618c89fd87 [IMP] website_sale: allow to hide company/vat fields in checkout
task-1866941
2018-09-13 17:45:23 +02:00
qsm-odoo 0452d332af [FIX] website: remove hamburger menu option
Standard option is sadly not good enough to be kept. We will let themes
handle that one their own way.
2018-09-13 17:36:29 +02:00
Jeremy Kersten 5cfd3d5fa0 [FIX] hr: security - an officier is an employee/internal user
Tests from hr_recruitments work luckily until now.
Because module maintenance imply base.group_user for group_equipment_manager

    <record id="group_equipment_manager" model="res.groups">
        ...
        <field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
    </record>

and module hr_maintenante imply group_equipment_manager for hr_user

    <record id="hr.group_hr_user" model="res.groups">
        <field name="implied_ids" eval="[(4, ref('maintenance.group_equipment_manager'))]"/>
    </record>

After this commit launch test on hr_recruitment module without any other module will works.

Design-theme repo show this error because repo tests hr_recruitment without installing maintenance
(Repo install website_* modules -> website_hr_recruitment -> hr_recruitment -> hr)

Backport-of d5b0f99943 to have runbot design-theme green
2018-09-13 17:26:32 +02:00
Olivier Colson c568af83a2 [FIX] l10n_es: apply correct type to each account. 2018-09-13 16:28:46 +02:00
Olivier Colson 7dc13e237c [FIX] l10n_es: apply correct type to each account. 2018-09-13 15:49:58 +02:00
Toufik Benjaa 0c8a244e68 [FIX] mass_mailing: check duplicate recipients on mass mailing
- When checking if a recipient has already received a mass mailing, the
  record model for the recipient was not checked.

  Which leads to false positives.
2018-09-13 15:48:09 +02:00
jem-odoo d0022ef2a7 [FIX] sale_timesheet: generated project must be active
When choosing a project template on a service (product
config), and then archive it, the generated project
on sale line confirmation will be inactive too.
This commit forces the generated project to be active.

Task #1884328
2018-09-13 15:40:43 +02:00
Olivier Colson 7da25a9239 [IMP] account: remove invoice communication automatic sanitization option 2018-09-13 15:17:08 +02:00
jem-odoo d32d2394c2 [FIX] sale: sale line form view usability 2018-09-13 14:44:50 +02:00
jem-odoo f701ea75fe [FIX] mail: clickable kanban card
Task #1878152
2018-09-13 14:44:45 +02:00
jem-odoo 64adff43d8 [REF] sale_timesheet: make project billable wizard
When introducing the 'employee rate' mode to timesheet
on project, we break the wizard: its goal was to link the
existing timesheets to the SO line in order to invoice them.
(Employee rate commit: b4af54f9c2)

This commit makes the wizard compatible with the employee rate
feature, without breaking invoicing at task rate flow.

Two possible flows, starting with a non billable project:
  * project rate: the wizard will create a SO with one SOL,
  	and will link the task without SOL set to the new one.
  	The project will also be linked to that SOL.
  * employee rate: the user has to fill a map to associate
  	product and employee. If the same product is set 2 times
  	with the same price (and so, 2 different employees), only
  	one SOL will be created on the SO. When submitting, the
  	project map will be filled and the project will be linked
  	to the SO. No fallback SOL will be set on project or on
  	the tasks.

Both use cases will be stopped if a timesheet of the project's
tasks is already linked to a sale line. If not, the timesheets
will be associated to the correct SOL (dependning of the billable
type), and the delivered quantity will be incremented, making
the SO invoicable. The tasks'customer will also be set.

Future work: setting a product per task (which will be a real
'task rate' feature).

Task #1883640
2018-09-13 14:44:35 +02:00
Arnold Moyaux ecc8ff8260 [FIX] mrp: fix bom structure report link
complete commit e31048f6a4
scss cursor is not needed since it is already set on btn element that
are activate.
2018-09-13 14:16:22 +02:00
Arnold Moyaux f641113605 [FIX] mrp: rename label for report bom structure 2018-09-13 14:16:22 +02:00
Arnold Moyaux a84dded067 [FIX] mrp: bom structure text align 2018-09-13 14:16:22 +02:00
Jeremy Kersten 4a57d2619b [FIX] website[_theme_install]: fix website form view
Before this commit, you had 'choose a theme' into the form view.
It should be only visible in modal

task-1878245
2018-09-13 13:58:23 +02:00
Jeremy Kersten 96638bfcb0 [FIX] website: only show 'Follow tooltip' when possible
Before this commit, the message was always displayed.
Now we only show into the default homepage the message "Follow all the tooltip"
when there at least 1 tooltip in the current page.

task-1878245
2018-09-13 13:58:23 +02:00
Jeremy Kersten 54b70dd6fa [FIX] website: typo align, color
right align 'I have a promo code'
make close button white in Customize modal

task-1878245
2018-09-13 13:58:23 +02:00
Jeremy Kersten f620039527 [FIX] website: multi website and company switcher
Remove domain based
Use domain if set

That will imply that you need to reconnect on your new website too.

task-1878245
2018-09-13 13:55:51 +02:00
Jeremy Kersten 4cc4663c26 [IMP] website(_theme_install): keep breadcrumb when you choose theme
Before this commit, we return an act_url, in this case the breadcrumb is not
build and the user cannot retruen to the settings in one click.

task-1878245
2018-09-13 13:55:51 +02:00
Jeremy Kersten 9747ff249f [FIX] website: remove share page info option from page manager
Advanced user can do it from the backend by the way and it is not
obvious to understand the impact to set/unset this option.

Seems like I was the only guy to think that this feature was needed

task-1878245
2018-09-13 13:55:51 +02:00
RomainLibert 8e40fed773 [FIX] pos,product,sale_management: make pricelist available in pos
Before this commit pricelist was never available on the product form if
you only had pos installed.
2018-09-13 13:48:58 +02:00
Joren Van Onder 5756b00922 [IMP] l10n_co: additional data
add some additional taxes
add an additional document type (Used in electronic invoicing)

Was PR #26751
Was task #1874136
2018-09-13 12:54:35 +02:00
Nicolas Lempereur 4ec9b55a79 [FIX] web: background layout landscape no +1 page
The report layout "background" has an image background from bottom to
top. When we transform the report in PDF, we have no idea in the
document of how many page, which orientation, width or height it will
take.

Thus to be able to have the background at the bottom of a page when
there is not enough content, we set a min-height for the body content.
This height was 1000px originally and has been decreased to 900px in
41c75ad0c3 because an empty page was possibly added (since the height of
body + header + footer was bigger than page size).

This issue is about getting a blank page when pdf is in landscape.
For example in A4 with 90ppi has a 1052px height in portrait, but 744px
height in landscape so we always get at least two pages with possibly a
blank one.

With this commit we lower it to 620px allowing 124px headers/footers.

opw-1881059
closes #26962
2018-09-13 12:44:53 +02:00