Commit Graph
361 Commits
Author SHA1 Message Date
Rémy Baranx (bar) bbd4391c15 [IMP] various: update of documentation links in res.config
Purpose
=======

- Change the font-awesome icon from fa-book to fa-question.
- Change the icon color to text-secondary (the same than the multi-company
  icon).
- Adjust the icon size to the uppercase text size.

closes odoo/odoo#47210

Taskid: 2209062
Related: odoo/enterprise#9116
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-03-18 09:53:15 +00:00
Rémy Baranx (bar) 7485177be1 [IMP] various: add documentation links in res.config
Purpose
=======

A 'book icon' link to the documentation of a feature has been
added in its settings panel, when it is useful (complex feature).

Add a nightly test that parses all the res_config_settings views
from the base one and checks that all documentation links are still valid.

Add the o_doc_link class to all documentation links to be able to easily
catch them if needed.

closes odoo/odoo#45813

Taskid: 2180574
Related: odoo/enterprise#8601
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-02-28 10:47:15 +00:00
Rémy Voet (ryv)andVictor Feyens 2d623375d6 [REM] purchase(_stock): remove unused action
- Since 2c5022b4f3 , the action with
id:'purchase_order_action_generic' was unused.
- Since 7743af00bf , the action with
id='purchase_open_picking' was unused.

Co-authored-by: Victor Feyens <vfe@odoo.com>
2020-02-25 07:48:16 +00:00
Ankita Raval d675dbaa4c [IMP] account,* : Change type field to move_type in account.move
task-id: 2028z813
2020-02-19 09:09:20 +00:00
Yenthe666 20ff585c2b [IMP] purchase: remove double context key
Before this commit the purchase_rfq action had two context keys
defined. One being empty {} and one with quotation_only set to
True. After this commit there is just one context (the one that is
actually used and applied) on the action.

Empty key added in 12.0 at 6138686d41b
Second key added in 13.0 at b5cea7e2b6

closes odoo/odoo#44990

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2020-02-11 07:42:54 +00:00
Xavier Morel 01354a3314 [FIX] account, purchase: almost certainly incorrect domains
This started from noticing that purchase somewhat oddly *removes* a
filter (internal_type='other') from a domain which is fairly
rare. Looking at the file histories didn't yield anything of
interest ("v9 accounting") but finally looking at the model revealed
an additional multi-company filter missing from both views.

After consulting with @qdp-odoo, @sle-odoo and @lap-odoo, no good
reason was found for the discrepancies:

* internal_type filter should probably always be there, unclear why it
  would get removed from purchase
* whoever added the multicompany filter *probably* missed that it
  would never be used because there was not one but two views
  overriding it (differently)
* sibling "income" field, as well as the corresponding fields on the
  product category, should match (though they were less incoherent).

closes odoo/odoo#44602

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-02-04 14:44:59 +00:00
jbm-odoo 00b2046460 [IMP] calendar: Adapt views and test for new color and filters
closes odoo/odoo#41573

Taskid: 2153249
Related: odoo/enterprise#7157
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-01-27 16:08:34 +00:00
Ankita Raval 3df9b446d0 [IMP] purchase: hide by default company/min_qty in product supplier infos
In this commit, on the product form, in purchase tab, the quantity
and the company fields of the vendor pricelist should be set
with optional = hide.

taks-2144636
2020-01-24 09:16:12 +00:00
wan d8c5cc1335 [IMP] account: add a readonly group
Task 2092079
Accounting firms that want to give access to their customers avoiding
mistakes and risks will love this profile that can't do anything
wrong... Maybe as well as companies auditors..?

closes odoo/odoo#39860

Related: odoo/enterprise#6576
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2020-01-22 11:23:16 +00:00
mreficent 59a96739e0 [FIX] purchase: not setting context is not empty context
Previous versions of this action had a context. It was removed at
odoo/odoo@2d3e6d7383 Set explicitly an empty context to
force the removal when upgrading the module. Fine tunning of
odoo/odoo@9346563009

closes odoo/odoo#43319

X-original-commit: 63a5a795a57af0da3b7459e0acd83a247861eaf3
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2020-01-15 08:48:39 +00:00
Jason Van Malder b6714ee01d [FIX] purchase: prevent changes when a line has an invoice
Issue from rim:

    In runbot 12.3
    - Go to Purchase
    - Create a PO with one product line: qty 1 / unit price 1000
    - Validate the PO and create the Invoice
        => DON'T VALIDATE THE INVOICE YET
    - Go back to the PO, change the unit price to 2000
    - Go back to the invoice, validate it
    ==> the PO is marked as "fully invoiced" because the qty "1 unit"
        is counted as "invoiced"

    => we should not be able to change the price of a line that has
        already been invoiced, even in draft

Cause

    It seems that in all the PO's invoices state, we can edit a PO line.
    No restriction?

Solution

    Set the line price column to read only when they have a linked
    invoice.

OPW-2161477

closes odoo/odoo#42797

X-original-commit: b31c04040a2d7fe83741dec2d3a622487b7e46c3
Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
2020-01-06 16:23:02 +00:00
Yenthe666 7876af3ad0 [IMP] *: set name on page elements
page is an element that is often used for xpath

closes odoo/odoo#41718

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-12-16 15:10:24 +00:00
Kevin Baptiste 6cbe824871 [REV] web: reverts update to fontawesome 5.11.2
This reverts commit ff1c35513a.

closes odoo/odoo#41480

X-original-commit: 116057b26e71db4692280463669f3e80d813ddcc
Related: odoo/enterprise#7110
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-09 10:33:36 +00:00
Yenthe666 78ae3da902 [IMP] *: set name element on main containers in configuration views
This will improve the extendibility of view inheritance

closes odoo/odoo#41398

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-12-09 10:38:59 +00:00
Kevin Baptiste ff1c35513a [IMP] web: update to fontawesome 4.7.0 to 5.11.2
FontAwesome 5 introduced new names for some icons as described on
https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4#name-changes

This commit replaces the old names to the new ones.

closes odoo/odoo#35826

Taskid: 2050241
Related: odoo/enterprise#5180
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-28 10:05:12 +00:00
Victor Feyens c32e9a4788 [ADD] (*_)_product_matrix: test tours
closes odoo/odoo#40971

X-original-commit: d729460f5fc72aa70e0a024e1dff281299eed0e3
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-11-27 15:49:57 +00:00
Hetal Dhanak ca3e898481 [IMP] purchase, purchase_requisition: supplier.info tree view
* use an editable tree to edit the supplier info
* keep the original forms because they're used in the "vendor pricelist"
menuitem
* updated tour
* change the position of requisition_id

Task-2029380

closes odoo/odoo#35972

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-16 09:44:51 +00:00
Parth Choksi b65d94c89a [FIX] *: ux improvements in activities
*: mrp
   product
   purchase
   stock

Renamed the 'activities_exception' filter to 'Warnings' and moved it
to the bottom of the filters, isolated by separators

Task-2056425
Closes: #36027
2019-10-07 12:30:22 +00:00
Florimond Husquinet (fhu) db1bef9166 [FIX] purchase: missing variant description in portal view of purchase order
- Set Joel Willis (the portal user) as a vendor.
- Create a purchase order and add a line with a variant product, such as the
conference chair (aluminium).
- Confirm the order.
- Then switch user to the portal user.
- In the portal view, go to the purchase orders and select the purchase order.

Before this commit:

the product line does not show the variant, only the base name of the product.

After this commit:

the product line now shows the vendor specific product name and product code.
To set this name and code, go to the Purchase tab of the product, and add a
line for the vendor in the Vendors table, or modify the existing line for
the vendor.

closes odoo/odoo#38082

Opw: 2076962
X-original-commit: c2f2169ab7574c49fa6b544299aab7214b1f4698
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-07 12:31:01 +00:00
Antoine Vandevenne (anv) 849be97f5a [IMP] Product, purchase, stock : Modify placeholder of notes.
Placeholder contained some errors.

task-2052537
2019-10-01 15:11:55 +00:00
svs-odoo e394aeba62 [IMP] purchase: editable purchase order list view
Task #1938656
2019-10-01 14:24:02 +00:00
Julien Mougenot 6fea5b42d6 [IMP] *: editable readonly list views: adapt views
Since the commit allowing all list views to be editable, there are some
views in which we need to ensure that certain fields are always readonly.

Affected modules:
- account
- crm
- product
- purchase
- sale

Task 1967602
2019-09-25 07:20:36 +00:00
Sébastien Theys b6288e5446 [IMP] *: remove image_64 and clean views
There are too many image sizes. Since they are stored resized this takes time to
generate when saving a new image, it's more rows on the attachment table, more
files on the disk, ...

64px is close enough to 128px that it can be removed without a big impact on
download size.

It will even reduce download and number of requests when both images are
displayed because now only one has to be downloaded and then benefit from cache.

The difference between the two is typically around 1.5kB which is negligible
these days, especially when the request overhead is around 0.5kB already, not
even taking into account other factors such as latency.

If a 64px image must absolutely be returned, it is still possible to pass the
size parameters to the image route. But the current guideline is to handle
resizing in the views when necessary.

Views
=====

- remove width and height attributes when existing CSS rules are overriding them
  (eg. `.oe_kanban_avatar` in the right context)
- add CSS rules instead of width and height attributes when possible
- use `object-fit: cover;` where width and height are forced to avoid distortion
  of non-square images
- for products, use `object-fit: contain;` instead, keep ratio but without crop
- add new CSS rules where the expected size was max 64px*64px before due to the
  image size itself
- remove `img-fluid` where using size classes to avoid conflicting rules

task-2060865

closes odoo/odoo#36147

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2019-09-19 10:23:39 +00:00
mcm-odoo 9bfab43d92 [IMP] payment,sale: clean Payment Method in onboarding
The modifications are applied in account, sale and website_sale
- Changed description to "Choose your default customer payment method."
- Removed the "Pay with" from labels in Modal
- In sale: Renamed "Confirmation & Payment" to "Payment Method"

task-2032586
2019-08-29 14:14:50 +00:00
mcm-odoo 1c34882478 [IMP] account: improve account views
Changes in account views to make them cleaner and
easier to use and understand.

Invoices/Bills tree view
---
- Distinct Invoices tree view from Bills tree view:
  In Invoices:
  - invoice_vendor_display_name is "Customer"
  - invoice_date is "Invoice Date"
  - "Payment Reference" is hidden because it's the same
    as "Number"
  In Bills:
  - invoice_vendor_display_name is "Vendor"
  - invoice_date is "Bill Date"
- "Source Document" is moved next to "Number"
- Renamed "Payment Status" to "Payment"
- "Payment Status" value "paid" renamed to "Paid"
- Search filters:
  - Renamed "Open" to "Posted"
  - Added a separator after "Posted"
  - Removed "Linked to revoked mandate"

Invoices/Bills form view
---
- Removed "Original vendor bills" from form but kept it in list
  and renamed to "Original Bills"
- Renamed state "Unposted" to "Draft"
- "Draft *" titles are now in h1
- Added placeholders and removed tooltips on Payment Terms
- Removed tooltips of invoice date
- Hid Accounting Date on Customer Invoices
  because it's the same as Invoice Date
- Rewamped payment info popup:
  - Renamed title to "Payment Info"
  - Removed right alignment
  - Removed Name info
  - Reordered info: Amount, Memo, Date, Method
- Added optional to few fields in tab "Invoice Lines":
  - Analytic Account: show
  - Analytic Tags: show
  - Intrastat: show
  - Origin Country of Product: hide (and renamed to "Product Country")
  - Unit of Measure: show
  - Disc (%): show
  - Taxes: show
- Added optional to few fields in tab "Journal Items":
  - Label: show
  - Analytic Account: hide
  - Balance in Currency: hide (renamed to "Amount in currency")
  - Taxes Applied: hide (moved before debit and renamed to "Taxes")
  - Tax Grids: show (moved after credit)
  - Due date: hide (moved before Balance in currency renamed to "Due Date")
- Tab "Other Info":
  - Renamed sections:
    Sales Information -> Invoice
    Accounting Information -> Accounting
    Payments Information -> Payments
  - Website is now hidden if not set and tracked in chatter

Payment form view and modal
---
- State "Posted" renamed to "Validated"
- State "Cancelled" is hidden while module account_cancel
  is not installed
- Renamed "Payment Method Type" to "Payment Method"
- Renamed "Payment Date" to "Date"
- Renamed "Payment Amount" to "Amount"
- Renamed "Payment Journal" to "Journal"
- Reordered fields:
  Journal                   Amount
  Payment Method            Date
  Recipient Bank Account    Memo
- Payment Difference is now visible only with
  accountant access rights.

Journals form view
---
- Removed Journal Groups
- Changed position of "Bank Account"
  it's now the first tab
- In "Advanced Settings":
  - Renamed section "Accounting App Options" to "Posting"
    and only visible when Accounting rights
  - "Post at Bank Reconciliation" was a Boolean field and is now a
    Selection field with values pay_val for Payment Validation and bank_rec
    for Bank Reconciliation.
    In form view it's now a radio button.
    Removed tooltip of this field.
  - Section "Control-Access" is now visible with Accounting Manager rights
  - Renamed "Invoice References" to "Payment References"
  - Field "Communication Type" value "Based on Partner" renamed to "Based on Customer"
  - Reorder sections:
    Payment References
    Email your Invoices/Bills
    Control Access

Purchase form view
---
- In Purchase Order: Field Billing Status is invisible if the status
  of the purchase.order is draft/sent/to approve/cancelled

task-2032586
2019-08-29 14:14:50 +00:00
Kevin Baptiste 054685875c [IMP] *: finetune search views (back2basics)
The goal of this commit is to finetune search views in several modules.

TaskID: 2055972

closes odoo/odoo#36058

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-26 07:40:02 +00:00
Victor Feyens 7e45b447c3 [IMP] matrix : ui improvements 2019-08-22 15:27:59 +00:00
Lucas Lefèvre 46e48055ed [IMP] account: Store customer/supplier rank on partners
Purpose
=======

To correctly choose in which account a line should be posted,
we have to know if the partner is a customer or a supplier.

Specification
=============

Keep track of the number of account moves "in" and "out"
a partner has. These counts should be based on the posted
account moves. A customer that has been created from the
'Customer' menuitem will have a rank=1. When a customer
invoice will be created for him, the generated account moves
will be taken into account to compute its rank. The most
invoices we have for a partner, the higher his rank is.

Note: To avoid any concurrent update failures on the partner,
if one transaction has already locked a partner row, the count
update will be skipped that time.

This means the values may be approximative in the database!
The exact values will eventually be correctly computed at
the next successfull try.

Known limitation of this approach: The computation ignores
the set of currently selected companies. Actually, storing
context dependent values in the database is a bad practice,
and is avoided in that case by taking all the companies into
account.

Use the stored fields `customer_rank` and `supplier_rank`
to order partners when searching by name. This allows to show
best customers or best suppliers on top.

To choose if best customer or supplier are shown on top,
the context key `res_partner_search_mode` is used.
The context key can take two values: 'customer' or 'supplier'.
This decision partially reverts/revamps 8766f38 to only use
account moves instead of PO and SO

On actions showing partners, set a default filters to menus to
only display customers (customer_rank > 0) if the string is
"Customers", and only suppliers if the string is "Vendors" or
"Suppliers".

TaskID: 2049131

closes odoo/odoo#35942

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-22 09:29:26 +00:00
Florian Gilbert 9bc4a19d74 [IMP] accounting : Usability back2basics.
task #2041848

closes odoo/odoo#35381

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-21 19:07:26 +00:00
Parth Choksi ebaa132d5d [IMP] various: Clean settings UX (back2basics)
TaskID: 2028958

closes odoo/odoo#35551

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-21 12:12:33 +00:00
Damien Bouvy e3f029c33f [IMP] product: UX improvements in form view 2019-08-20 14:02:30 +00:00
lbs-odoo 9a0fedfc65 [IMP] various: improve searchviews UX
Improve searchviews UX in all the modules

TaskID: 2029731

closes odoo/odoo#35700

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-16 13:35:21 +00:00
Prakash Prajapati c058562d73 [IMP] various: Add multi company domains on views
When the many2xxx field relates to a model where company_id is required, set
this  domain [('company_id','=',company_id.id)]

When the company_id field of the related model is not required, set this domain
['|',('company_id','=',company_id.id),('company_id','=',False)]

When setting the domain on a field which is in the treeview of a xxx2many field
evaluate against the company_id of the 'parent'.

Some constraints have been added on sereval models. Take a look at the complete
specification for more details.

TaskID: 2024446
Closes: #35266

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-16 11:17:28 +00:00
Kevin Baptiste f23cc14d13 [IMP] purchase: improve usability (back2basics)
TaskID: 2040826

closes odoo/odoo#35394

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-06 13:05:32 +00:00
sri-odoo a50023c158 [IMP] *: adapted to the new calendar view
Task 1919926
2019-08-07 12:30:55 +00:00
Mitali Patel e3f327a61f [IMP] *: add visual indicator for exception activities in list and kanban
The new visual indicator for exception activities has been added on all
corresponding kanban and list views.

A new filter "Exception Activities" has also been added in the
corresponding search views.

Task 1889379

closes odoo/odoo#31839

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
2019-08-07 15:41:12 +00:00
Victor Feyens e6c2975e76 [ADD] (sale/purchase)_product_matrix 2019-08-07 12:50:09 +00:00
Victor Feyens f6f4b8bc1e [IMP] purchase : name for xpath 2019-08-07 12:50:09 +00:00
Dharmang Soni 840442a24f [IMP] *: hide all activity related filters
All activity filters are now invisible in the corresponding search views.

These filters were only used by activity redirection (when clicking on
the activity item in the systray) so we hide them to reduce the noise
for the user.

"My Activity" filter has also been removed, its corresponding domain is
now directly set in the action where it was used.

Task 2036392
2019-08-07 07:31:32 +00:00
Sébastien Theys 58a2ffa26f [IMP] *: rename image fields
image_original => image_1920 (now resized to 1920)
image_big => image_1024
image_large => image_256
image_medium => image_128
image_small  => image_64
image replaced by image_1920 (when writing) or by image_1024 (when displaying
	what was previously the big size)

+ add new intermediate format:
image_512

PR: #34925
2019-08-02 16:47:58 +00:00
Ankita Raval a2a39ef41e [IMP] purchase: set schedule_date of po lines as per date_planned of PO
In this commit -
1. Previously, date_planned of PO was computed and set while the creation of PO.
   In this commit, removed the compute logic and now field will be empty until
   user fills it.
2. ‘Set date to all order lines’ button is removed.
3. Now if user have filled the date_planned of PO, it will be copied to all po
   lines.
4. Schedule date of PO line will be readonly if date_planned have any value
   else will be editable.
5. Update the test cases of computation of date_planned.

Task-2032417
2019-08-01 08:11:59 +00:00
Prakash Prajapati 1a33056557 [IMP] various: Clean stat buttons across all modules.
Purpose
=======

Make them consistent.
Make sure context is correctly set.
Prevent creation when necessary.

Specification
=============

See https://www.odoo.com/web#id=2024467&action=333&active_id=1251&model=project.task&view_type=form&menu_id=4720
for the detailed list of all the requested improvements.

TaskID: 2024467

closes odoo/odoo#34561

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-01 11:39:51 +00:00
Lucas LefèvreandYannick Tivisse 3e97cff779 [IMP] base: Remove customer and supplier fields from res.partner
Purpose
=======

Fields `customer` and `supplier` on `res.partner`
are mostly used in domains of many2x fields.

Those domains can confuse end users because they don't
see the partner they are looking for; and it's not obvious why.

Some identified problems:

1. It can lead to duplicated partners: the user does not find
   the partner, so he creates a new one.

2. The user imports supplier contacts in the Contacts app, so they
   don't get the `supplier` flag. Then the user wants to make a purchase order,
   and cannot find the new suppliers in the list

3. A user removes the customer flag on a prospect, because they don't think
   it's a customer yet - except now they can't make a quote for that customer...

Specification
=============

Remove the two mentioned fields.

Since fields `customer` and `supplier` have been removed, all partners
are now shown in many2one dropdowns.

But in some cases, not all partners are relevant or some are more likely
to be relevant than others. e.g. when creating a PO, top suppliers have a
higher priority than other partners.

So, adapt the places where those fields were used with the new mechanism to
display the searched the partners, according to the number purchase/sales
orders they made.

TaskID: 2031147

Co-authored-by: Yannick Tivisse <yti@odoo.com>
2019-08-01 12:42:03 +02:00
Prakash Prajapati e0389c0f15 [IMP] purchase(_requisition): set optional field to simplify the tree view
Purpose of the commit is to set the new attribute OPTIONAL = SHOW/Hide on tree
view so the user can easily hide/show the optional fields on the tree view.

task-1997453
Closes #33888
2019-07-30 08:53:05 +00:00
Christophe Simonis d5e1fd16b4 [MERGE] forward port branch saas-12.4 up to cda4f3c308 2019-07-29 14:10:30 +02:00
Christophe Simonis bfd34e14b1 [MERGE] forward port branch saas-12.3 up to 40e8b67179 2019-07-26 15:12:29 +02:00
Christophe Simonis e0f9c092cc [MERGE] forward port branch saas-12.2 up to 1d6d790513 2019-07-26 11:32:43 +02:00
Christophe Simonis a4b1b532ea [MERGE] forward port branch 12.0 up to b82df99d7a 2019-07-25 20:01:05 +02:00
Goffin Simon ffe58a56bf [FIX] purchase: Saving PO with a foreign currency
Steps to reproduce the bug:
- Create a company C with currency = USD
- Create a vendor V with a supplier currency = EUR
- Create a PO for V with one line, the default currency is EUR
- Save

Bug:

The currency of the PO was USD when saving because the field currency is
in readonly when the state is draft.

opw:2035640

closes odoo/odoo#35144

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-07-24 12:48:06 +00:00
Hetashree Chauhan e532d4df0d [IMP] purchase: make products company consistence.
Purpose of the commit is to let user select only those
products which are being shared among companies or belongs to own company.

On purchase order user will only able to select those products
which are belongs to same company as purchase order or products
which are sharable by default.

task-2025168
closes: #34342

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-07-22 05:17:00 +00:00