Commit Graph
1548 Commits
Author SHA1 Message Date
oco-odoo ec603e2593 [IMP] account: remove now useless (and kind of unusable) "bank accounts" menu
Everything is managed from the regular "journals" menu, now.

closes odoo/odoo#40496

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-11-19 12:29:52 +00:00
Goffin Simon d3fe36d817 [FIX] account: Cannot search fiscal positions
It was not possible to search a fiscal position by name without a custom
filter.

opw:2124184

closes odoo/odoo#40404

X-original-commit: 72534d7ae21677b02d7cb26dd06d84d532be9514
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-11-18 10:25:20 +00:00
jbw 74c8c61d6f [IMP] Cash Rounding : adding loss account
Cash rounding only allowed for one account to be specified => Belgian accounting requires 2 types of account depending on whether the rounding line on the invoice is a + or - amount.
On cash rounding config (account.cash.rounding), one account is added (many2one). Existing account is renamed Profit account, new account is named Loss account.
The loss account is used when rounding line has a negative amount, and vice versa for profit account (account.move).
If no Loss account is set, only Profit account is used.

task : https://www.odoo.com/web?#id=2091658&action=327&model=project.task&view_type=form&menu_id=4720

closes odoo/odoo#39488

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-11-13 12:07:13 +00:00
fw-bot 8b7afc9d4d [FIX] account: pass tree_view_ref in a one2many analytic lines view
Without this commit, if you have the hr_timesheet installed, the one2many analytic lines view (in the Journal Items form) shows the hr_timesheet_line_tree view instead, which is not desired.

closes odoo/odoo#40196

X-original-commit: 0b92bde84afac4a78512c475de3c8c822a1fa4b2
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-11-13 13:17:07 +00:00
Xavier-Do eb2f0aabcf [FIX] *: various fixes in xml views 2019-11-13 11:05:14 +00:00
Laurent Smet 940733ec18 [FIX] account: Fix the 'state' live-cycle of account.payment
Introduced by https://github.com/odoo/odoo/commit/ab483a3a6610a09391ec00e9c1c49489ca4a4f12
There was no way to exit the 'cancelled' state of an account.payment.
The new live-cycle is:
- draft -> posted -> sent -> reconciled -> cancelled
- action_draft to move the account.payment from ('cancelled', 'posted', 'sent', 'reconciled') -> 'draft'
- cancel to move the account.payment from 'draft' -> 'cancel'

closes odoo/odoo#40193

X-original-commit: 53e83ae9e68d418bf7322374815b942309bf7fef
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-11-13 13:09:11 +00:00
Cedric Snauwaert 0d6332fdbb [IMP] account: statement automatically set starting and ending balance
To prevent having holes between statements and for better usability using import and synchronization
we try to automatically set the starting and ending balance based on the previous existing
statement.
To do that, we added a new field previous_statement_id so that whenever we change the ending_balance
of the previous statement, we recompute the starting balance and ending balance of the current statement.

Also creating a new statement in between 2 others statements will automatically set the correct value
to the starting and ending balance of that statement and all the statements afterwards.

Exception: creating a statement by hand won't automatically set the balance_end_real, however if you
create one between 2 statements, the balance_end_real of next statements will be recomputed

Was Task #1880409

closes odoo/odoo#38696

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-11-04 08:50:50 +00:00
jvm-odoo b967cbd28a [FIX] account: fix paid invoice send by email
When you create an invoice, you can register a payment to mark it as
"paid".

Before this commit:

    - You can't send & print the invoice anymore.

After this commit:

    - The button send & print is displayed

The second "send & print" button's domain was incorrect.

OPW-2115720

closes odoo/odoo#39650

X-original-commit: 18abdcf7b9b9d5af3d6f92c45c65f9a22e7177bf
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-31 13:13:22 +00:00
Hardik Prajapati 72fa7d7015 [FIX] account: added separator in res.partner search view
after this commit :
added a separator at the end of the inherited view

task - 2082289

closes odoo/odoo#39506

X-original-commit: 8777f525ced87890242e1c73cac55c70444de351
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-10-29 11:51:07 +00:00
wan 045e0c0a26 [IMP] account: Control Access: Journals that can be allowed by accounts
Task 2074811

Allow to specify on an account the journals that can be allowed

Example of use case :
* I create an IFRS journal and some specific IFRS accounts
* I want to make sure that the accounts I configured for the IFRS are
  only use to make entries in the IFRS journal

In this commit we also prevent from changing the configuration of a
journal if there are account.move.line that should not have been allowed
to be created with the new configuration.

closes odoo/odoo#38255

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-22 07:44:14 +00:00
Laurent Smet ebac65bebf [IMP] account: Cleanup remaining stuff of Aged Partner Balance
This report is only available in enterprise edition. This report is now entirely
moved in account_reports.

This report is no longer available in community since:
https://github.com/odoo/odoo/commit/e51b4f659fc5e4253d3156754ada21166c8d1bf8

closes odoo/odoo#38502

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-17 09:14:33 +00:00
wan 9ba8734f15 [MOV] account: reconciliation widget
Task 2034073
The reconciliation widget is now entirely part of the enterprise version
as it is an advanced accounting feature

closes odoo/odoo#38424

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-18 12:53:41 +00:00
svs-odoo f55adeaf34 [FIX] account: rename Suppliers into Vendors
For more consistency, as the menu item calling the corresponding action
is named "Vendors".

closes odoo/odoo#38783

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-15 10:47:20 +00:00
Swapnesh Shah 89d3293158 [IMP] account: Don't allow Invoice creation from Payment
Fixes https://github.com/odoo/odoo/issues/38233

New Invoices shouldn't be created from Payment screen.

closes odoo/odoo#38687

X-original-commit: 44226ec450e09d7893c5c3ca0d0d8e6533ccc246
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-14 09:13:07 +00:00
Andrea Grazioso (agr-odoo) 2300964058 [FIX] account: restore "View accounts detail" button
closes odoo/odoo#38474

X-original-commit: db32eafd3d67c158b76202187c7e311dd828d3f7
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-11 09:16:29 +00:00
fw-bot 2a60e82e98 [FIX] account: display button in 'matching number'
When a move line has been partially reconciled, it shouldbe accessible the button.

closes odoo/odoo#38155

X-original-commit: 0c1972144ce61a5baad35742c02678cbff75c9ea
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-08 07:32:20 +00:00
fw-bot 7b020ed318 [IMP] account: Invoice tax block is split into two pages
closes odoo/odoo#38102

X-original-commit: 724407453a8aba284c9b7edc46ec12c13b25d33d
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-07 13:56:26 +00:00
Parth Choksi c73d5cb1d6 [FIX] *: removed activity exception filter from searchviews
*: account
   crm
   event
   fleet
   hr_expense
   hr_holidays
   hr_recruitment
   mail
   maintenance
   mrp
   note
   project
   purchase_requisition
   repair
   stock_landed_costs
   stock_picking_batch
   survey
   website_event_track

This commit is making sure that the exception activities filters are
only defined where it make sense (i.e. where the system can actually
create an exception activity).

We have therefore removed 'exception activities' filters where the
system won't be creating any.

Task-2056425

closes odoo/odoo#36027

Closes: #36027
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-10-07 12:31:01 +00:00
Laurent Smet a0605ee442 [FIX] account: Fix sorted key on report journal
closes odoo/odoo#37941

X-original-commit: d8462c13d4aa296c4d2ddcc4e74420e7f39ba895
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-03 18:36:58 +00:00
Romain Derie ae6db1a5f4 [REM] account, project, sale, *: remove dead code 'return_label'
Since Odoo 9.0, the `return_label` in url was not working anymore.
What it did before 9.0 is add an item in the breadcrumb which once clicked
would redirect to the frontend.
This was handled in the `do_load_state` of the action manager in JS.

We don't need to reimplement that behavior as now we have the 'Go to website'
stat button. Thus we remove the code.

Closes #36325

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-02 07:13:27 +00:00
david 93157ebe19 [IMP] account,sale: add names to columns for better inheritance
closes odoo/odoo#37769

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-02 14:00:04 +00:00
Laurent Smet e121bacbd0 [FIX] account: Fix editable fields on editable grouped list views
Nothing is editable on account.move.line tree view.
On grouped tree views, only account_id, name, ref, tag_ids, date_maturity are editable.
The account hierarchy must not be visible on the partner ledger view.

closes odoo/odoo#37528

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-01 08:02:25 +00:00
Laurent Smet 8f6e383397 [FIX] account: Fix invoice report template
- Description is no longer needed since it provides the same info as the header.
- The ref field will be used to set a custom description on any invoice (not just vendor bills).
- Don't display the name on the report if the move hasn't been posted.

closes odoo/odoo#37683

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-10-01 11:15:52 +00:00
Florian Gilbert 87bc2e1547 [FIX] Remove "inalterable_hash" from account move view (put in enterprise).
closes odoo/odoo#37603

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-30 13:11:16 +00:00
oco-odoo fdc3555c8d [IMP] account: filter receivable and payable accounts so that they are not selectable as tax accounts on repartition lines
closes odoo/odoo#37572

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-30 09:21:36 +00:00
oco-odoo 2727b383b9 [IMP] account: filter tax tags on account.move form view
So that we only allow chosing the ones that are available for taxes, in the right country.
2019-09-30 08:48:33 +00:00
Romeo Fragomeli e8301cacb7 [FIX] account: missing fields in invoice line form view on mobile
Due to the merge of account.invoice.line and account.move.line
some views doesn't exist anymore.
On desktop, we only need editable list view to do the job but
it's not the case on mobile!

On mobile, the kanban view is loaded instead of "tree" and
the form view is opened when we add a record.
Before this commit, the corresponding form view wasn't usable
on mobile and some fields were hidden like product_id.

As kanban view and form view are important on mobile, we get them
back like on saas-12.3. So the workflow is quite similar as before.

Steps to reproduce:
* Open Odoo in mobile
* Go Accounting App
* Create a new record
* Add a new line
* There is no product field (BUG)

Task ID : 2061797

closes odoo/odoo#37424

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-09-30 09:05:03 +00:00
wan d745c4ee4d [FIX] account: add to check entries on misc journal on dashboard 2019-09-27 09:19:38 +00:00
Laurent Smet a007a70830 [FIX] account: Fix 'partner_id' field required in account.move view 2019-09-26 10:17:20 +00:00
oco-odoo b794bbdd3b [FIX] account: don't set the 'sales' filter by default when opening the move lines' tree view from the dashboard or clicking the 'reconciled entries' button of the move's form view 2019-09-26 10:15:11 +00:00
Laurent Smet 7de871cc38 [FIX] account: Don't change partner_id on grouped view 2019-09-26 09:58:26 +00:00
Kaushalya Mandaliya b7b3c33aa3 [IMP] account, *: adding domain in analytic account fields
*: hr_expense, project

Adding required domain which will allow to only select analytic accounts whose
company is same as current one or blank.

task-1966016

closes odoo/odoo#37450

Closes: #34270
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-25 15:58:59 +00:00
Florian Gilbert a2493ece06 [FIX] account: Delete attrs in account.move.tree.grouped
closes odoo/odoo#37434

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-09-25 13:59:54 +00:00
Julien Mougenot 6fea5b42d6 [IMP] *: editable readonly list views: adapt views
Since the commit allowing all list views to be editable, there are some
views in which we need to ensure that certain fields are always readonly.

Affected modules:
- account
- crm
- product
- purchase
- sale

Task 1967602
2019-09-25 07:20:36 +00:00
Laurent Smet 6b8acd0257 [IMP] account: Improve lock dates
The tax lock date no longer blocks the user when creating a journal entry priors to it.
Instead, the accounting date is moved automatically during the validation to the next
available date.

This commit also brings more flexibility when dealing with the tax lock date. Indeed,
the error is now shown only when adding something impacting the tax report that was not
always the case before (e.g. adding a new line not affecting the tax report must not
raise something).

Others check has been also refactored to be more consistent with the "fully editable" mindset.

closes odoo/odoo#36304

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-25 11:26:02 +00:00
Florian Gilbert ab483a3a66 [IMP] account: Add restrict mode and normal mode for account move.
This commit deletes account_cancel module and squash it into account.
The 'update_posted' field is changed by 'restrict_mode_hash_table' field.

If 'restrict_mode_hash_table' is true, you have a hash chain on your account journal.
These hash chains prove the inalterability of your accounting.

l10n_fr_certification module is deleted and all hashing method are moved in account module.
Now, you can download a PDF report about your inalterability in the company settings.

If you have l10n_fr or l10n_post_cert installed you have more information on this report
like the inalterability of pos orders, etc.

Task ID: 2039160
2019-09-25 11:26:02 +00:00
oco-odoo ac17e36987 [IMP] account: allow currency and amount currency on bank statement lines as an optional field
So that people encoding their statements manually can directly encode the exchange rate data on their lines.

closes odoo/odoo#37262

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-23 10:25:44 +00:00
Christophe Simonis d67b2483e5 [MERGE] forward port branch saas-12.4 up to 9ed4872ea0
closes odoo/odoo#37372

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-09-24 17:45:37 +00:00
oco-odoo 9ed4872ea0 [FIX] account: set partner_id field of account.move as not required in the view
Having this field required in the view forbade the 'send for digitalization' button of account_invoice_extract to work, as it could be empty there (as the invoice was created via .create({})). The constraint defined in the view was checked before executing the code related to the button and caused everything to fail before running anything.

closes odoo/odoo#37279

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-23 12:26:49 +00:00
Christophe Simonis ac4fc6e7c7 [MERGE] forward port branch saas-12.3 up to bd3e510edb
closes odoo/odoo#37314

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-09-24 09:44:56 +00:00
Florian Gilbert 4a1321bc99 [FIX] account: Show invoice due date on invoice report for customer.
Task ID: 2060475

closes odoo/odoo#37172

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-09-20 06:35:59 +00:00
Lucas Perais (lpe) d786d7d250 [FIX] account: cash basis base account not required
Before this commit, the field cash_basis_base_account_id, used
to keep track of the base on which a tax a computed for cash basis entries
was required in the tax form view

Since this account can be absent, and will be most of the time, and that
an account is retrieved anyway in the move creation process it is safe
to remove the required attribute in the view

After this commit, the field is not required in view anymore

OPW 2072750

closes odoo/odoo#37060

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-09-19 07:19:21 +00:00
Christophe Simonis 080f8b1f96 [MERGE] forward port branch saas-12.3 up to d8ce75466e 2019-09-17 17:49:09 +02:00
Nicolas Lempereur 80b1c12f09 [FIX] account: invoice pivot do not display unsigned
On the pivot view, there is the following unsigned measure fields:
"account_tax" and "account_untaxed".

It can cause mistakes since for example the sum of a invoice an its
full credit note should be zero, but here it will be double the amount.

So here we complete 97aec9f8 for two fields that were still available.

opw-2071027
closes #36940

closes odoo/odoo#36971

X-original-commit: 2dc8e2feec9e5b604e0c0acae52562822a113342
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-09-16 14:59:08 +00:00
Antoine Vandevenne (anv) abbc44952d [IMP] account: make product menus show templates instead of variants
As of this commit, the menu items Customers/Products and Vendors/Products now display product templates instead of product variants, which makes more sense in the scope of invoicing/accounting.

task-2052537

closes odoo/odoo#36802

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-09-12 15:42:20 +00:00
Laurent Smet 4d31bebff5 [FIX] account: Fix 'partner_id' field in account.move view
- partner_id must not be required for receipt.
- context.get('type') is not the way to pass a default value.

closes odoo/odoo#37260

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-09-23 10:20:56 +00:00
Jairo Llopis 5dad570423 [FIX] *: remove buggy calls to with_context
When .with_context() is called with a dictionary as 1st positional
argument, it will replace context (and not modify the referenced keys)
It may create bugs when losing the content of the context (e.g. remove
partner's language)

This is a partial merge of #36164 without the inventory part as
discussed.

closes odoo/odoo#36729

X-forward: 4717ccfa
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-09-12 06:18:18 +00:00
wan b487537c24 [FIX] account: wrong filter_domaini on move_id from aml
closes odoo/odoo#36964

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-16 11:18:50 +00:00
Christophe Simonis 58a83d1222 [MERGE] forward port branch saas-12.4 up to 4a1321bc99
closes odoo/odoo#37127

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-09-20 14:33:54 +00:00
Sébastien Theys b6288e5446 [IMP] *: remove image_64 and clean views
There are too many image sizes. Since they are stored resized this takes time to
generate when saving a new image, it's more rows on the attachment table, more
files on the disk, ...

64px is close enough to 128px that it can be removed without a big impact on
download size.

It will even reduce download and number of requests when both images are
displayed because now only one has to be downloaded and then benefit from cache.

The difference between the two is typically around 1.5kB which is negligible
these days, especially when the request overhead is around 0.5kB already, not
even taking into account other factors such as latency.

If a 64px image must absolutely be returned, it is still possible to pass the
size parameters to the image route. But the current guideline is to handle
resizing in the views when necessary.

Views
=====

- remove width and height attributes when existing CSS rules are overriding them
  (eg. `.oe_kanban_avatar` in the right context)
- add CSS rules instead of width and height attributes when possible
- use `object-fit: cover;` where width and height are forced to avoid distortion
  of non-square images
- for products, use `object-fit: contain;` instead, keep ratio but without crop
- add new CSS rules where the expected size was max 64px*64px before due to the
  image size itself
- remove `img-fluid` where using size classes to avoid conflicting rules

task-2060865

closes odoo/odoo#36147

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2019-09-19 10:23:39 +00:00