Commit Graph
103218 Commits
Author SHA1 Message Date
Nicolas Martinelli 2bf8a6541b Revert "[FIX] hr_recruitment: incorrect recruitment report"
So @sig-odoo is not the only one to revert his own fixes :-)
Anyway, we want to be able to get statistics about archived applications
as well.

This reverts commit 7e0e27ea79.
2016-07-07 12:39:59 +02:00
Christophe Simonis 45fc5f7a8f [I18N] web: change term after 3888301a2e 2016-07-07 12:38:05 +02:00
Denis Ledoux b329d6219e [FIX] hr_attendance: Attendance Error Report fail afer upgrade
After upgrading the `hr_attendance` module,
it was no longer possible to use the
`Attendance Error Report` link in the `More`
menu of employees.

This is because there were two binding actions
added in the code under the samename
(`Attendance Error Report`):
 - `hr_attendance_error_values`
 - `action_report_hrattendanceerror`

The first launch a wizard which will print the report
after filling the required data,
The second tries to directly print the report, but it
fails because required data (from the wizard) is missing.

Before update, it's the first binding action that was displayed.
After update, it was the second, which failed.

We solve this issue by changing the way the report is
created through the data, by not using a `<report/>` tag,
this one creating automatically the action binding.
Instead, we use a classic `<record/>` tag, which
doesn't create automatically the action binding.

opw-682720
2016-07-07 12:29:54 +02:00
Fabien Pinckaers 3888301a2e [IMP] web: Quantity is very misleading in reporting views --> e.g. SO Line Quantity is perceived as Quantity of products, whereas it's the count of SO Lines. Renaming to Count 2016-07-07 12:28:57 +02:00
Nicolas Martinelli 7e0e27ea79 [FIX] hr_recruitment: incorrect recruitment report
The recruitment report used in the pivot view does not filter out the
archived records.

opw-682119
2016-07-07 11:35:52 +02:00
Goffin Simon a082ec6aea [FIX] sale: Expenses in multi currency
Steps to reproduce:

-Set your company in USD
-Create a SaleOrder with a pricelist in EUR
-Create an expense in USD, with the analytic account of the SO
-Confirm the expense and post journal entries.

Bug:

The unit price of the new SO line was wrong: it was stil in USD as in
the expense.

Expected behavior:

The price unit must be converted in EUR

opw:682378
2016-07-07 11:31:54 +02:00
Nicolas Martinelli a1c3fe1291 [FIX] crm: opportunities list view
When the lead step is activated (`group_use_lead` is true), 2 dinstinct
tree views can be selected to display the opportunities.

Indeed, when the action "Your Pipeline" is selected, the tree view
`crm_case_tree_view_oppor` is displayed thanks to the method
`action_your_pipeline`. However, when the page is reloaded or the tree
view is saved in the custom dashboard, the tree view
`crm_case_tree_view_leads` is selected instead.

The fix is to specify explicitly in the action which view should be
chosen, accordingly to what is done in method `action_your_pipeline`.

opw-681488
opw-681734
2016-07-06 17:25:15 +02:00
Goffin Simon d98eb32272 Revert "[FIX] product, website_sale: order by sequence product.template"
This reverts commit 0a13e5cb8e.

Changing the order of the products in stable version is not accepted.
2016-07-06 17:03:18 +02:00
Martin Trigaux 0df7a1ca2f [FIX] base: decode params_store content
The parameter bin_size=True will display the size of the binary field.

Fixes #12681
2016-07-06 16:24:50 +02:00
Goffin Simon 0a13e5cb8e [FIX] product, website_sale: order by sequence product.template
The product.template must be ordered first by sequence if website_sale
is not installed.

opw:682395
2016-07-06 14:00:31 +02:00
Daniel-CA 5e466d3507 [FIX] stock_account: prevent division by zero
In case of a move where source location = destination location, the result of
SUM(quantity) would be 0 and ending up with a division by zero.

Closes #12247
Closes #12423
2016-07-06 11:18:20 +02:00
Lionel Sausin 5537c5a13c [FIX] stock_account: do not sum price unit
The view yields one line per stock move, with a price/unit on each line.
It doesn't make sense to sum price/units, the avg will be only meaningful when
grouping per product but it's correct in the default state.

Closes #11309
2016-07-06 11:16:07 +02:00
Martin Trigaux 70011137ff [I18N] mrp: export terms for the new report 2016-07-06 10:34:30 +02:00
Josse Colpaert f719d76fed [ADD] BoM price report
In v8, we had a BoM price report in xsl format which was removed in v9.

As it is still needed, we added a report in the new qweb format, but this
time it is on the BoM instead of the product variant.

It also makes sense to have a similar report for v10 as the cost structure report
on the mo is for the real cost and not the standard cost.
2016-07-06 10:34:29 +02:00
qdp-odoo 3f3c30887c [FIX] account: bank statement reconciliation speed improvement.
Removed assertion statement that was making a useless browse on account.move. This single patch is enough to divide by 4 the time of preprocessing a bank statement when opening its reconciliation widget.

That removed assertion is now a supposed prerequisite when calling the function and should be tested first (on batch of records).
2016-07-06 09:55:28 +02:00
Denis Ledoux 489ea42859 [FIX] web: parsing of date with abbreviated month/day
When using the abbreviated month in the language
date format (`%b`),
e.g. `%d %b %Y`
in some languages, the parsing of the date
from this format to the database format (YYYY-mm-dd)
failed because of a dot `.` added from time to time
to the end of the abbreviated name
e.g., in French, `5 juil. 2016`

This is a bug of `moment.js` < 2.13.0,
handling badly this dot.
This is solved from `moment.js` 2.13.0,
thanks to the below revision
moment/moment@41fdb58572
moment/moment#3078

Unfortunately, we cannot update this library to its latest
release in stable release of Odoo (e.g. 9.0),
as this is seen as an unstable change
(if some API changes occured in the given library)

Instead, if the parsing of the date fails with the
strict mode (meaning the date must respect the format
exactly), we perform a second pass without the strict mode,
so this dot will be ignored,
and the date can be correctly parsed.

The issue can be reproduced by loading the French language,
and setting `%d %b %Y` as date format, and then performing
an advanced search on a date field. The value of the date
in the advanced search will be empty without this revision
(for the months having more than 4 chars,
other than `mars`, `mai`, `juin`, `aout`).

Fixes #11854
opw-682534
2016-07-05 18:04:22 +02:00
Laetitia Gangloff 77de330c03 [IMP] stock: stock_change_product_qty : add hook to complete inventory line data
Improved by Denis Roussel (Acsone). Closes #10598
2016-07-05 17:55:26 +02:00
Alex Comba e3954a3457 [FIX] stock: fix AccessError on stock.quant while trying to resolve an inventory line linked to a package closes #12511 2016-07-05 17:36:45 +02:00
Josse Colpaert 3de53fa165 [FIX] stock: no rereservation needed in a lot of cases and make sure the moves passed to action_done are those from the recomputation
It is possible (in very rare cases) on rereservation that the new reservation will trigger other stock moves
than the first reservation.  In order to be sure to send the correct stock moves involved to done, it is better
to do the rereservation before the splitting of the moves on the total picking.

Also rereserve is optimized as it should only reserve for what is given by the pack operations,
as the backorder will be reserved later on anyways.
2016-07-05 17:26:06 +02:00
Joren Van Onder 75dbd545c8 [FIX] point_of_sale: mount /boot when building the POSBox image
We don't mount /boot in fstab to prevent systemd-udev looking for
corresponding kernel modules in /lib/modules. We need to do this
because the modified kernel-qemu image we use for emulation is usually
not 100% the same version as in the Raspbian image. Therefore
systemd-udev won't be able to find the 'correct' kernel modules in
/lib/modules.

This causes issues when the raspberrypi-kernel package is updated
however. apt will update /lib/modules and will write the new
kernel{7,}.img files to /boot. Before this patch /boot was just a
directory on /dev/sda2, not the 'real' /boot which is on /dev/sda1. So
you'd end up with old, not updated kernel images but new, updated
kernel modules in /lib/modules.

This mounts /boot after the system booted. /boot gets mapped to
/dev/sda1 by /etc/udev/rules.d/90-qemu.rules.

Fixes #12650
opw-682320
2016-07-05 16:18:25 +02:00
Damien Bouvy 60a7678b9d [FIX] sales_team: context-defined default should have priority
If you are in a view whose action defines a default team (for
example in a pipeline view), the default should take the context
into account instead of simply forcing the team of the current
user.

opw-682577
2016-07-05 15:22:34 +02:00
Goffin Simon 474d9dbf19 [FIX] l10n_es: Spanish Localization Module Error in Default COA
Tax Paid(Hacienda Pública. IVA soportado) and Tax Received(Hacienda Pública, deudora por IVA)
must be respectively under Current Asset and Current Liabilities in BS report.

opw:681998,681252
2016-07-05 15:21:21 +02:00
Nicolas Martinelli c4b82344d5 [FIX] account: traceback when getting counterparts
The compute method of the `counterpart` field only keeps a maximum of 2
account codes. However, it attempts to do [0:2] on a set, which is not
syntactically correct in Python.

opw-682373
2016-07-05 14:50:36 +02:00
Denis Ledoux da8c5d054e [FIX] web_settings_dashboard: email TLDs can be longer than 6 chars
This revision is similar to
7f29a23118

opw-682116
2016-07-05 14:27:11 +02:00
Nicolas Martinelli 11199d2cc2 [FIX] project_timesheet: task progress is no timesheet
If a project task with no linked timesheet is set to "Done", the working
time progress stays to zero.

opw-681622
2016-07-05 13:33:41 +02:00
Goffin Simon f7263dac30 [FIX] account: tax_line_move_line_get
The "else" has to be removed  because if a tax group named "X" is
the group of tax "A" and "B", the journal item corresponding to the invoice line
has the taxes "A", "B", and "X" set.

Introduced by 5a5ac1d7a5
2016-07-05 12:34:45 +02:00
qdp-odoo 549ea7a886 [FIX] account: cancelling a statement line that was reconciled with several already registered payment was crashing. Fixes opw 680128 2016-07-05 11:27:56 +02:00
Erwin van der Ploeg 06f75bf93d [FIX] l10n_nl: set sequences to have taxes not included in price by default.
Courtesy of Erwin van der Ploeg. Was PR #12273
2016-07-05 11:07:24 +02:00
Martin Trigaux 64b0e67a38 [FIX] hr_recruitment: wrong id on composer
When an applicant is moved from a stage to another, an email is sent to the
applicant(s) if an email template is specified on the stage.
The active_ids is correctly set in the compose context to be used by the
send_mail method to send a message to all the applicants in the new stage.

However, a potential active_id may be propagated from a previous action.
This is the case when a user goes from a Job Position record to the list of
applications and change the stage using the kanban view (active_id & active_ids
is the id of the hr.job).
The default_get method of mail.compose.message will use the active_id as the
default value for the field res_id which is wrong as it is the id of another
record).

Forcing the value at False instead of ids[0] as it would not work in batch mode.
The list of records is correctly used in send_mail anyway.

Closes #12494
2016-07-05 10:28:34 +02:00
qdp-odoo fb6a05d358 [FIX] account: fixed grouping of account.invoice.tax creation.
in details:
[FIX] added analytic account in grouping key of because we need to create different journal items for each of the lines having a different analytic account.
[REF] added a function on account.tax that returns the grouping key and that could be inherited in another (community) module
2016-07-05 10:22:35 +02:00
Goffin Simon 5a5ac1d7a5 [FIX] account: creation of an aml for an include base amount tax
When an account move line(aml) is created for an include base amount tax,
all the other taxes are impacted with this tax then the field tax_ids of
the created aml must contain the other taxes.

Example:
Considering an invoice line with:
 -A price=90
 -A fixed include base amount tax=10(incl_tax)
 -A 21% tax(called tax)

The base amount for the 21% tax is equal to:
100 = 90 + 10(incl_tax)

When the invoice is validated, three amls are created:

One for the product with:
 -Debit=90
 -Credit=0
 -Tax_ids=(incl_tax, tax)
 -Tax_line_id=()

One for the incl_tax with:
 -Debit=10
 -Credit=0
 -Tax_ids=(tax)
 -Tax_line_id=(incl_tax)

One for the tax with:
 -Debit=21
 -Credit=0
 -Tax_ids=()
 -Tax_line_id=(tax)

In this way, the base amount of 21% in the "Declaration periodique TVA"
report is the sum of all the amls balance(credit-debit) linked to tax with
the field Tax_ids.

opw:681102
2016-07-05 09:48:42 +02:00
Goffin Simon ffd30c5be2 [FIX] account: act_window to find Chart Templates
The act_window to search the chart templates must filter on category
"Localization" due to 692d41c686
2016-07-05 09:30:42 +02:00
Denis Ledoux 6c85d925c3 [FIX] web: dialog close with a reason
In the below revision:
c0db6aec56

The dialog close `reason` was introduced
to not reload the current form if the dialog
has been closed for a reason
(e.g. a window action was returned by the server).

This is to prevent the record reload, which:
 - Is useless, as another action has been launched
   and the user therefore redirected elsewhere
 - Can fail, in the case the initial action deleted
   the current record
   (e.g. when merging a lead in an opportunity, the
   lead is removed, and therefore this is not possible to reload
   it).

 opw-680180
2016-07-04 18:40:15 +02:00
Nicolas Martinelli faf3577896 [FIX] stock: receive product with lot
When a product is received in the lot reception view, a new lot is
created. If the user receives at least one lot, closes the lot selection
window, then reopens the window, he will not be able to create a lot
anymore, but only choose existing lot.

The fix is to make sure that the lot selection is available only in the
case of a returned product.

opw-681925
2016-07-04 17:53:05 +02:00
Anton Engelhardt 8914de8c53 [FIX] mrp: missing context
context was not passed to move objects in action_cancel

Closes #12598
2016-07-04 17:24:47 +02:00
Philipp Hug 84daaa1658 [FIX] base: use correct address format for CH/LI
Closes #10911
2016-07-04 17:12:14 +02:00
Nicolas Martinelli d1407f9a09 [FIX] stock: returned product with lot number
Before this commit, the return of a delivered product with a lot number
is problematic because the user cannot select the lot from the list of
delivered lot numbers. Therefore, the user needs to create a new lot
number for the returned product since the combination product/lot must
be unique.

opw-681925
2016-07-04 16:24:03 +02:00
Denis Ledoux f7e4241a91 [FIX] l10n_fr_fec: exclude initial balance at 0
The FEC control check does not like rows
with debit = credit = 0

```
º Structure fichier incorrecte, débit/crédit ...
renseignés sur une même ligne ... , ou débit=crédit=0
```

opw-682365
2016-07-04 14:53:00 +02:00
Odoo Translation Bot 1986980a51 [I18N] Update translation terms from Transifex 2016-07-03 02:59:06 +02:00
Odoo Translation Bot e349692ede [I18N] Update translation terms from Transifex 2016-07-03 00:32:09 +02:00
Simon Lejeune 7f2e748a22 [REV] base: allow 'render' override with new api
Using a frozendict as context breaks the `t-lang` mechanism, as
the `loader` is not aware of the changes of a copied frozendict
and thus is still using the values from the original context,
including the lang one.

This reverts commit e1deae7eab.
2016-07-01 15:41:39 +02:00
Nicolas Martinelli 9a7ed7cabd [FIX] sale_mrp: COGS in case of kit
When a kit is sold, the unit price of the COGS recorded is the sum of
the unit prices of each component multiplies by the quantity sold.
Obviously, this is not correct since the unit price should not take into
account the quantity sold.

opw-681403
2016-07-01 11:05:28 +02:00
Odoo Translation Bot ff31e0381a [I18N] Update translation terms from Transifex 2016-07-01 00:28:27 +02:00
Olivier Dony 61a9cdc3f8 [FIX] account: fix unclear wording for Net EOM payment terms
The previous wording was inaccurate and made users think it
was impossible to setup "Net EOM" payment terms.

Updated POT file accordingly, but not PO files because this
requires a proper new translation.
2016-06-30 18:11:51 +02:00
Goffin Simon 31fb5275fd [FIX] product_extended: bom_count appeared twice in a view
The field bom_count appeared twice in product.template form view and
then the smart button for "Bill of Materials" always displayed 0 as
number of BoMs.

opw:681830
2016-06-30 15:28:04 +02:00
Goffin Simon bdec480434 [FIX] account: _compute_base_amount
When computing the base amount of a tax, all the include base amount
taxes must be considered.

Closed #12481

opw:681102
2016-06-30 15:12:13 +02:00
Yannick Tivisse 692d41c686 [IMP] Classified each module in its category to display them correctly on odoo/apps
To be displayed correctly on odoo app (In a given category and not only in all or hidden)
the module category in the __openerp__.py file should be one of these:

    "Accounting",
    "Discuss",
    "Document Management",
    "eCommerce",
    "Human Resources",
    "Industries",
    "Localization",
    "Manufacturing",
    "Marketing",
    "Point of Sale",
    "Productivity",
    "Project",
    "Purchases",
    "Sales",
    "Warehouse",
    "Website",
    "Extra Tools",

'Accounting & Finance' will not work, as 'Project Management', ...
2016-06-30 13:27:46 +02:00
Yannick Tivisse 2f020dc8b9 [IMP] Remove 'author' field in __openerp__.py files to user default value 2016-06-30 13:27:46 +02:00
Denis Ledoux 7c9ab02c53 [FIX] website_event: make Attendee # translatable
On the website,
when registering for an event with ticket,
the placeholder `Attendee #` could not be translated,
as `t-att` attributes are not translated.

An alternative is to put the string to translate
in a `t-set` node, which can be translated, and
to use the variable assigned in this `t-set`
in the `t-att` attribute.

opw-678758
2016-06-30 13:01:27 +02:00
Nicolas Martinelli 830fc8922d [FIX] purchase: traceback when copy
If a PO has no product, a traceback is raised because
`onchange_product_id` returns no planned date.
2016-06-30 08:27:49 +02:00