The custom selection widget was only used in the form.
A small rework had to be done to make it work in list views because the
values were not pre loaded.
closesodoo/odoo#49604
X-original-commit: cf942e6df3bf065e299d8ad0dcfd8ed2cc66b29c
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Signed-off-by: wan <william-andre@users.noreply.github.com>
- Create journal entries as soon as bank/cash statement lines are created, temporary booked on a suspense account set on the journal.
- Simplify the management of "blue" lines in the reconciliation widget. A "blue" line is now a journal item using a temporary liquidity account (outstanding payment/receipt accounts, set on the journal).
- Adapt and simplify the bank reconciliation report.
- Remove the bank reconciliation threshold date. The reconciliation report will show the not already reconciled journal entries using a liquidity account and the not already reconciled journal entries using a temporary liquidity account. Without accounting, an account.payment will involve directly the liquidity account and then, will be considered as a statement line directly.
- Remove the post_at bank reconciliation feature. The "paid" state will be set on the invoices only if reconciled with a journal entry involving the journal's liquidity account.
With invoicing, the payment will do that so the "in_payment" state should never be shown up.
With accounting, only the statement lines have the power to move an invoice to the "paid" state.
- Fix various corner cases about the management of multi-currency in bank statement lines.
- Fix the conversion dates in multi-currency: Since the bank/cash is always used on the statement lines, it will use always the real "bank" date instead of the fictive payment one.
- Ensure the 'reconcile' method will raise an error if the involved moves are not posted.
related enterprise PR odoo/enterprise#7019closesodoo/odoo#41301
--task: 2092096
Related: odoo/upgrade#1018
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
* account
This commit adds a new field registry for component fields.
This field registry is used to only register the new field components
and the other one should register the legacy fields.
Those two registries will be used together while all legacy fields are
not converted to owl component.
As the legacy registry now throws an error when adding a component
field the existing component fields (account.ShowGroupedList and
account.ShowResequenceRenderer) are moved into the new registry.
This commit also refactors some field managers (form renderer, list
editable renderer, calendar popover) to use the new registry and thus
support the component fields.
task id: 2193996
Before this commit, layout of the widget 'tax-group-custom-field' was
broken on small devices.
This commit improves the layout for the widget to make it consistent in
both small and large devices.
Task ID: 2152164
Since ae6545ccd5 in 11.0, reconciliation
model buttons were wrapping and were scrolling vertically when more than
three lines were shown.
Since the change to bootstrap 4 in 12.0, however, the reconciliation
model buttons were not wrapping any more, and were scrolling
horizontally.
This commit restores the previous behavior, which can display more
buttons before any scrolling is necessary.
closesodoo/odoo#47828
X-original-commit: 0c4195f2c2eec7589ed79a21fbbe089a75c6209f
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: Paul Morelle <madprog@users.noreply.github.com>
Use of the new control panel helpers to increase consistency and change the assertions
according to the new DOM/behaviour (e.g. components removed instead of turning invisible).
Part of task 2196029
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
This commit moves some step utils in a dedicated file and add new ones.
These steps will be very useful for the Main Flow Tour to avoid
duplicated code.
To do this, we also had to transform it into functions to allow
utils to call each other. Existing one are converted for
standardization purpose.
Note that 'WEBSITE_NEW_PAGE' wasn't considered as an util.
This is a very simple step only used twice.
Before this commit, the amount currency could be wrapped on a
second line (on mobile).
To fix this, we had to find a way to have more space:
- Buttons are now displayed at the top (mobile only).
- Amounts can grow (col-auto) and the other column will take the
space left (col) and add "..." when there is not enough space.
(mobile + desktop)
We also had to remove a button from a div tag in order to display
the buttons next to each other on mobile (buttons are "inline-block"
but div is a "block").
The main flow tour has been adapted accordingly and the typo has
been fixed too...
closesodoo/odoo#46680
Task-id: 2184243
X-original-commit: 159e3d4cb8a301c908f7718a56138528033e75d4
Related: odoo/enterprise#8963
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Steps to reproduce:
- Go to Invoicing
- Select an invoice
- Add credit note
- Click on "Post"
- Invoice footer is overlapped on mobile
This bug occured because of "float: right".
Get rid of this is too much work (oe_subtotal_footer is already floating),
so we decided to keep it with a "clear: both".
In desktop, this element is on the right of the screen but
on mobile we take the whole horizontal space.
closesodoo/odoo#46007
Task-id: 2184243
X-original-commit: 986152405a0ba6038df7d93c9264a46ee4207dd8
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Steps to reproduce:
- install accounting
- go to accounting > accounting > reconciliation (you need at least
one unpaid invoice and one unreconciled payment for the proper screen
to show)
- manual operations > click the cog icon > create model
- create a model with a long name and duplicate it 5-10 times
- go back to the reconciliation tool > manual operations
Previous behavior:
the model buttons leak out of the right of the screen
Current behavior:
An horizontal scrollbar appears if necessary
opw-2185355
closesodoo/odoo#45431
X-original-commit: e24d971ad8d1bfdef8fc55710d99fc29c29a9c31
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Task 2146469
Rework the name computation:
* It doesn't use ir.sequence anymore
* It is an editable computed field
* Add a renaming tool
This allows the user to tweak the sequences more easily than having to
get through the ir.sequence settings.
The sequence depends on a parameter of the journal: continuous, montly
and yearly restart of the sequence. Everytime a new period is started,
try to make a pattern form another period.
The incrementing is done by taking the previous name, ordered
lexicographically, splitting it by taking the digits at the end, adding
1 and re contstruct with the prefix.
** This means there could be cases where the prefix has a big importance
on the next number. For instance, if you have
INVOICE/2019/0001
INVOICE/2019/0002
and then rename the last one to INV/2019/0002, don't expect the next
number to be INV/2019/0003. It will be INVOICE/2019/0002 (again) because
the highest number was INVOICE/2019/0001.
You will then end up with
INVOICE/2019/0001
INV/2019/0002
INVOICE/2019/0002
closesodoo/odoo#41485
Related: odoo/enterprise#7189
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
This is done by introducing a new threshold setting, allowing choosing a date before which all invoices and payments have to be ignored by the accounting. Once this is done, all the balances can be reimported directly, easing the migration to Odoo Accounting a lot.
account.move objects having to be ignored because of this are cancelled, and receive the new 'invoicing_legacy' payment state. account.payment objects are moved to the new 'invoicing_legacy' state and their related account.move is cancelled and marked as invoicing legacy as well.
closesodoo/odoo#41416
Task: 2092377
Related: odoo/enterprise#7071
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Since commit odoo/odoo@43db60d `<notebook>` elements
have also a wrapper element (with class `o_notebook_headers` around
their tabs.
Since account module reuse the markup and styling of the `<notebook>`
but without using the tag itself (cf. done by hand) the reconciliation
line's tabs style was broken.
This commit adds the missing wrapper element and set the
margin-{left,right} reset to the that element.
closesodoo/odoo#43959
X-original-commit: 8d45e3d52a7312addb05dd6cb39d68f9d61144da
Related: odoo/enterprise#7941
Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
Task 2092079
Accounting firms that want to give access to their customers avoiding
mistakes and risks will love this profile that can't do anything
wrong... Maybe as well as companies auditors..?
closesodoo/odoo#39860
Related: odoo/enterprise#6576
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
This wizard also reconciles automatically entries done on reconcilable accounts. It can hence for example be used to "move" the balance of a receivable account into a payable account (or the opposite), using the generated transfer entry to do as if the receivable and payable accounts were directly reconciled together.
[IMP] account: display 'P' as matching number when account.move.line objects are partially reconciled
For this, we introduce a new matching_number field, used in account.move.line's tree views instead of full_reconcile_id, which used to be shown directly.
Was task: 2037318
closesodoo/odoo#39415
Related: odoo/enterprise#6544
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Reproduce the issue
- Load Arabic language
- Install Accounting
- Create an invoice & add credit note
- Switch to arabic
- Click on the "(i)" icon near the total price
The popover is displayed at the other side of the screen
Cause
- RTLcss was reversing the "left: 0" css property to "right: 0"
- The popover configuration was not adapted for RTL
This commit ignore RTL for the popover css "left" property and
configure correctly the JS side
OPW-2146210
closesodoo/odoo#41200
X-original-commit: 88f03f0444a2533b1f6085369af431131da42b54
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>
— In a SO, create a section or a note;
— Add an invisible modifier (with studio for example).
Before this commit, the table-cells of the section/note were not aligned
any more, and the delete button (trash-can icon) wasn't available.
In a list, the invisible modifier uses a display: table-cell to keep
table cells aligned. But in this specific case, the display is already
none, because they are hidden cells. Therefore, the invisible modifier
it removes the display: none in the hidden cells, this has as outcome
that the table cells are not aligned any more.
Now, the hidden cells cannot have an invisible modifier.
opw-2117714
closesodoo/odoo#40584
X-original-commit: d040f02dd0140d9b7128e806e4a974fe1e8aa0d3
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Go on the accounting module, you'll find a kanban view with a few
cards including "Bank" and "Cash". Click on the Cash card.
The default import button doesn't appears because it is hidden.
The reason of this hiding is that the bank statements of type "Bank"
have a custom import method and the users where confuse. They
didn't know which is the right button for the special import so
we hid the default import button for the whole model.
But there is also a "Cash" type bank statement who doesn't have that
special import and his default import button is hidden too.
This commit checks the type of the bank statement and hide the default
import button only if the type is not "Cash".
OPW-2090477
closesodoo/odoo#39829
X-original-commit: ee45228a8532b676729bc2be686814d616e5cbb5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
The reason of this fix is that we reference some account accountant menu
in the invoicing menu and if you are not in enterprise version with
accounting installed, the tours don't work.
The tours are adapted for each versions.
closesodoo/odoo#39104
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Before this commit, lists having a section or a note would have a horizontal
scrollbar in readonly mode.
Now it has been removed and the list stretches properly according to its parent
size.
Task 2086594
closesodoo/odoo#39301
X-original-commit: cbe26b3a3ac5ef3d79695cf44874e01087a35ef9
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Task 2034073
The reconciliation widget is now entirely part of the enterprise version
as it is an advanced accounting feature
closesodoo/odoo#38424
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Before this commit, the account_render_report tour assumed that
account_accountant was installed on any enterprise database.
Now, the account_accountant steps are only inserted in the tour
when the module is installed.
closesodoo/odoo#38963
X-original-commit: a45a4b6cc3249320969c8ba3324aad9e7c1aab67
Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>
When a reconciliation proposition's amount is computed from a regex, we
cannnot be sure the regex captured something. If it didn't we don't want
to display a badly formatted line so we set the amount to 0.
closesodoo/odoo#38870
X-original-commit: 111495795b6cdc53312096078033804dbbfe57f2
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Have a reconciliation model that applies to some particular journals
And that will match some of those journals' lines
The field journal should be filled too
(this field is only the default journal that a proposition will be filled with)
Open the reconciliation widget on a given journal, within the list of
possible journal (from the account dashboard)
Before this commit there was a crashed. This was caused by the fact that
one of the lines that should be displayed had a reconcile model that was not fetched beforehand
After this commit, there is no crash as all relevant reconcile
models are fetched
Note that, on reconcile models, the field journal_id is just there to prefill
the propositions it will create
corrects commit e5c8071484
OPW 2084942
closesodoo/odoo#38836
X-original-commit: c285d578cc497044e819c62d42373c29f87b1e93
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
In the reconciliation widget, pressing enter validates the line
focussed. This should not happen when editing an input, like it was the
case for the partial amount input.
closesodoo/odoo#38037
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Renamed xml ids of the main accounts (in prepartion for a future multi l10n
demo system). Change account numbering to match quickbook and other US GAAP
convention and recommendations.
closesodoo/odoo#37606
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Suppose uploading an attachment with res_id = 0, res_model = 'existing.model'.
Suppose also there a one2many having 'ir.attachment' as co_model and res_id as co_field
in 'existing.model'.
This setup leads to an error since the record with id=0 doesn't exists.
This commit ensures the res_model is not set when uploading the attachment.
closesodoo/odoo#37414
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
*:
- account
- barcodes
- calenndar
- hr_timesheet
- mail
- mass_mailing
- partner_autocomplete
- web
- website_slides
This commit removes description of fields that should not be shown in
non-debug mode Studio. Only field widgets whose own description is
set are displayed in non-debug mode Studio in "Widget" of sidebar.
In other words, even if any ancestor has a description but not the
current widget, it won't be displayed in the sidebar in non-debug
mode.
Task-Id 2056992
closesodoo/odoo#35902
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
* Add an equity section inside the balance sheet
* Divide profit and loss into Expense and Income
* Reorder the Expense and Income types
closesodoo/odoo#36599
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Task 2072312
* Ensure that the css is from Odoo and not from the browser
* Only use up/down to navigate
* Use Enter to validate a line
* Remove the accesskeys
Before when creating a vendor bill with a tax 15% and a price unit less than 87, the widget to edit the tax amount was wrongly displayed, the pencil and amount was broken into two lines. This fixes this behavior by ensuring that the all block stays together using the css property white-space: nowrap
closesodoo/odoo#37049
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Previously when opening the manual reconciliation widget with several lines, trying to put the focus on another line by clicking on the grey line was not working due to a o_field_widget with the partner name taking all the line and there is an event on that o_field_widget that stop the propagation of the event.
Also changing the partner value was only changing the value in the grey zone and not in the other field.
Therefore as it was strange to have twice the name of the partner display one above another and that it was causing problem for the focus of the widget. We removed the name of the partner that was readonly (leaving the editable field where we can change it) and we replaced it with the name of the account which makes more sense.
closesodoo/odoo#36881
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
The function _blurProposition returned a promise that was causing
concurency in the function quickCreateProposition. The _computeLine from
_blurProposition was erasing the value of reconciliation_proposition
created in quickCreateProposition.
However, the _blurProposition was didn't need to call _computeLine as it
was called later.
closesodoo/odoo#36904
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
If a line was produced by a reconciliaion model, it shouldn't be put back
in the reconciliation propositions because a rpc request would not give
it back. Also, the line is not correctly formatted.
closesodoo/odoo#36826
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
When trying to edit the amount of a proposition of an inactive
statement, the focus of the line tried and the edition of the amount
were racing one against each other causeing flickering and making it
hard to edit the line.
We removed the focus as it was intended for the keyboard navigation but
it was not fully usable, so we also removed the accesskey needed for the
focus.
When there is a lot of data to be displayed in the searchpanel, the scrollbar appears. The with of the scrollbar takes too much space compared to the width of the custom searchpanel.
This commit reduces the size for Chrome and Firefox >= 64
closesodoo/odoo#36758
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
- show period along with 'Tax Report' activity of journals on accounting dashboard.
- added 'Upload Invoices' button on sales journals in Accounting Dashboard.
- added 'New Bill' button on purchase journals in Accounting Dashboard.
Task: 34740
Closes: #34740
Co-authored-by: Hardik Prajapati <hpr@odoo.com>
* When clicking on the partner m2o selection field before having clicked on the bank statement line, 2 events occured:
* the bank statement line expanded
* the partner selection showed
This could lead to unwanted behavior as the renderer could update
-> Stop the propagation of a click on .o_field_widget to prevent
flickering and possible update of the statement line widget
* Always recompute the create line as sometimes the value is not correct
when removing a proposition
closesodoo/odoo#36322
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Task 2008956
* Add the root of an account (first 2 digits/char) as a searchable model.
* Create a custom searchpanel for this account root on account.move.line
* Add the account_root searchpanel to the account.account view too.
