Commit Graph
151539 Commits
Author SHA1 Message Date
Julien Castiaux 1de40dd85e [FIX] website: wrong canonical URL after reroute
A reroute in an internal redirection, the URL on the current request is
changed. The actual changes occurs on the "WSGI environment", a
dictionnary that is populated with the request information by the WSGI
server (werkzeug in our case). Among all the properties there are
PATH_INFO, RAW_URI and REQUEST_URI.

* PATH_INFO is the standard value, it contains a RFC-3986 path.
  `request.httprequest.path` is based on that value.
* RAW_URI and REQUEST_PATH are two custom values set by werkzeug to
  mimic other popular wsgi servers (gunicorn, uwsgi, mod_wsgi), they
  also only contain a RFC-3986 path.

When rerouting only PATH_INFO and RAW_URI are updated. REQUEST_URI is
left as-is in order to keep the original path somewhere. When building
the cannonical path, one must use the original path instead of the
rerouted one.

X-original-commit: 779486c4dff23b946b4b14e3dca164ecca4f85a8
Part-of: odoo/odoo#91034
2022-05-12 13:42:57 +02:00
Paul Morelle ece83df99a [FIX] website,http: make EndPoint object reusable
It may happen than the routing map is cleared while rendering a qweb
view. For example, if an asset bundle is regenerated, the previous one
is unlinked, which causes a cache clearing.

Previously-generated EndPoint objects aren't found any more in the new
routing map, so `request.endpoint` cannot be used any more after a cache
clearing.

This commit adds hash and comparison magic methods on http.EndPoint so
that EndPoint objects created by a previous routing map generation can
still be used after a cache clearing.

Two tests were added: one to test the comparison and hash methods, and
the other to test them in a real-case rendering.

Commit 80a04f7ebed fixed this bug too, but introduced another issue
which caused many OPW, so it was quickly reverted by deb23450f18 along
with its performance improvement 33167b3928c. This commit replaces
80a04f7ebed with another way to fix the issue.
A third test has been added in order to avoid reintroducing this other
issue.

By the way, this commit also removes the EndPoint.arguments attribute,
as commit 17f1992698 removed all usages of this attribute in Odoo 9.0,
but left this initialization here.

OPW-2834546
OPW-2834549
OPW-2834625

X-original-commit: bdc45422f5c715782b147eecda2403386ba7eb4a
Part-of: odoo/odoo#91034
2022-05-12 13:42:57 +02:00
Kevin Baptiste 72886a6210 [IMP] hr_contract: automatically expire contract when past end date
Automatically closes contracts when the end date is set in the past.

closes odoo/odoo#90714

Taskid: 2845368
Related: odoo/enterprise#27037
Signed-off-by: Kevin Baptiste <kba@odoo.com>
2022-05-12 13:42:46 +02:00
Kevin Baptiste 7061bacf6a [IMP] fleet: count archived services on vehicle
When a vehicle is archived, its corresponding services/contracts are archived
as well. However, the corresponding records were no longer counted for
the stat buttons.

closes odoo/odoo#90406

Taskid: 2841384
Signed-off-by: Kevin Baptiste <kba@odoo.com>
2022-05-12 13:42:43 +02:00
anhe-odoo 2ea1d5233c [FIX] google_spreadsheet: fix parameters in spreadsheet pivot insertion
Observed Behaviour

When opening a pivot view (in any of Odoo module) and trying to import
it in a Google Spreadsheet, we get the following error:
UncaughtPromiseError > TypeError
Uncaught Promise > Cannot read properties of undefined (reading 'id')
TypeError: Cannot read properties of undefined (reading 'id')
at AddToGoogleSpreadsheet.addToGoogleSpreadsheet (...)
at HTMLSpanElement.eval (eval at _compile (...)

Expected Behaviour

When trying to import the pivot in a spreadsheet, everything should
work fine, openning a new tab with a Google spreadsheet.

Reproducibility

This issue can be reproduced following these steps:
1. Install the 'Google Spreadsheet" module
2. Go to 'Settings' > 'Google Drive' and set your credentials
3. Go to the Sales App
4. Select the pivot view
5. Click on 'Favorites' > 'Add To Google Spreadsheet'

Fix Description

The original issue was coming from the fact we try to access the ID
of a null view, giving us the reported error. Moreover, after fixing
this issue, we got another error coming from the fact the config
method was called with a domain passed as a list, while it need a
string. Both errors were corrected in the way it was already done in
https://github.com/odoo/odoo/blob/2e5acb4b15422c1ee38c5630e4fdb929d7a24d3c/addons/google_spreadsheet/static/src/legacy/js/add_to_google_spreadsheet_menu.js#L25

Related Issues/PR

opw-2794744
opw-2761065
opw-2752840

closes odoo/odoo#91127

X-original-commit: cd6a2c83a9c9dbc7efcecb69b542a237a30cc8a8
Signed-off-by: Hendrickx Anthony (anhe) <anhe@odoo.com>
2022-05-12 11:32:50 +02:00
David (dafr) ac586931bc [FIX] mrp: Allow multiple users to start the Work order
# Issue:
With User1, create a MO with work orders, and start one Work Order.
With User2, go to the MO, and start the same Work Order
=> Nothing happen, we currently prevent the workorders to have more than 1 open Time Tracking.

OPW-2845080

closes odoo/odoo#91123

X-original-commit: 8cb5aad6126e3f63ee4ef91115c8b4a6be571828
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: DavidFesquet <dafr@odoo.com>
2022-05-12 09:19:13 +02:00
Dossogne Bertrand a63a271768 [FIX] fleet: fix fuel types
There shouldn't be a distinction between full hybrids.
'hybrid' and 'full_hybrid_gasoline' are replaced in this commit by a unique 'full_hybrid'.
fixes task 2629318

taskID 2753096

closes odoo/odoo#90413

Related: odoo/enterprise#26886
Related: odoo/upgrade#3494
Signed-off-by: Kevin Baptiste <kba@odoo.com>
2022-05-12 09:19:04 +02:00
Romain Derie 156da50e63 [FIX] website: prevent btn on 404 page to be clicked before JS loaded
Before this commit, it was possible to click on the "Create page" button
before the JS was loaded, as that button is a simple link with a href.
But that link is supposed to be handled by the JS which transform the
GET href link to a fake form submit to send a POST request to the
`/website/add` controller.

If the user clicks before the JS had the chance to handle that click and
do the "transformation", the controller will reject the GET request and
a raw 405 error page will be shown.

Now, we wait for the JS to be fully loaded before allowing user to click
on this button.
The fix is made globally as it should be the case of every link related
to this behavior.

Note that the `/website/add` controller was changed from GET to POST
with commit [1]. It most likely forgot to adapt the button from the 404
page which was later done with [2] by using the `post_link` util class
introduced with [3] (for need of website_blog at the time).

[1]: https://github.com/odoo/odoo/commit/714f0aa07f25e8a88a778e8b21c79b48e9801231
[2]: https://github.com/odoo/odoo/commit/2c85c1cb6ee0f6000cd2db182d5b8cfd3d040876
[3]: https://github.com/odoo/odoo/commit/0f2cada32319b3910d6ace6d412cfa94a646c9c7

task-2847785

closes odoo/odoo#91151

X-original-commit: d4a8ec96900c0e0923901bc2672f18aa51b1a9fb
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2022-05-12 07:27:59 +02:00
Guillaume (guva) 8c89c1810c [FIX] account_check_printing: allow multiple payments
With this commit, we allow mutliple payments with manual
check printing.

Steps to reproduce:

- With manual check numbering
- Create +=3 vendor bills
- In bills list view, select all bills and register payment
- Select Checks as payment methos, and validate
-> Validation Error: The following numbers are already used ...

Setting the check_numbers before calling the super of
payment.action_post.

opw-2830586

closes odoo/odoo#91128

X-original-commit: c26cd9fa30ac9093f5c7500ca1dd9a9f9cfd06a5
Signed-off-by: Florian Gilbert <flg@odoo.com>
Signed-off-by: Guillaume Vanleynseele <guva@odoo.com>
2022-05-12 05:17:16 +02:00
Guillaume (guva) 25d2665582 [FIX] account: unbalanced entry with price_unit 0
Steps to reproduce:

- Create invoice for a prudict at price X > 0
- Change the price to 0 before saving
- Then save it
-> Error : Cannot create unbalanced journal entry

This bug was introduced in 14.0 with this commit fe7d56dc32c71e04b54de9dbd756a48942a832f4
With this commit, we use an ugly condition to catch the
specific case of a tax with price included and amount type division
to avoid changing the price unit if the line balance is zero.

opw-2822635

closes odoo/odoo#91059

X-original-commit: 2b9592cb0ecef235d708ed7810d0613ccd946124
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Guillaume Vanleynseele <guva@odoo.com>
2022-05-12 02:00:03 +02:00
Adrien Widart 56ea31a9ed [FIX] stock: auto-reserve after last step of multi-step receipt
The auto-reserve feature does not work if the products are received in
several steps

To reproduce the issue:
1. In Settings, enable "Multi-Step Routes"
2. Edit the existing warehouse:
    - Incoming Shipments: 2 steps
3. Create a storable product P
4. Create and confirm a SO with 1 x P
    - The delivery D is created and is waiting for one available P
5. Create and validate a receipt for 1 x P
    - An internal transfer T is generated (Input -> Stock)
6. Validate T
7. Open D

Error: The delivery is still waiting for the product while this product
should be reserved. This is correctly working in 1-step receipt

In 1-step receipt, when the user marks the receipt as done, the
destination of the associated SM is WH/Stock and its operation type code
is "incoming". Therefore, the module checks if some other moves (from
WH/Stock) can reserve the newly-available quantity.
However, in [2/3]-steps receipt, the operation type code of the
in-WH/Stock move is "internal". So, the conditions are not respected and
the module doesn't check the needs of reservation.

OPW-2806423

closes odoo/odoo#90715

Signed-off-by: Tiffany Chang <tic@odoo.com>
2022-05-11 22:14:40 +02:00
sofiagvaladze 0476f084a1 [IMP] fleet: add category_id to the vehicle from model
category_id field is populated from the model, but it can be edited.

task - 2828459

closes odoo/odoo#89282

Signed-off-by: Kevin Baptiste <kba@odoo.com>
2022-05-11 19:46:00 +02:00
Hiral Bhavsar cfa916379b [FIX] web_editor: traceback on strikethrough with a checklist
Before this commit:

When having a checked checklist and clicking on the `strikethrough` gives
traceback.

After this commit:

No traceback is being generated.

Task-2833325

closes odoo/odoo#91114

X-original-commit: 491a79f6f8f734990a2ece3fd1b3f90d09a55c85
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2022-05-11 18:50:14 +02:00
Brieuc-brd f8dc60add2 [IMP] mail: AutocompleteInput, add form-control by default
Part of the overall v16 SCSS optimization/restyle, task-2704984

This commit adds the Bootstrap `form-control` class by default to
improve the consistency of inputs in Mail.

task-2850961

closes odoo/odoo#91081

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 18:50:04 +02:00
bit-odoo a9c03b7b24 [FIX] im_livechat: few changes for livechat
Before this commit:

- When the operator edit or delete a message, but the livechat visitor does not
  receive the updated content.

- If the first message of a series of squashed messages is deleted, the avatar
  and the name of the author are lost on the visitor side.

After this commit:

- Livechat visitors will receive the updated content instantly and disable
  the reactions and replay buttons for the LiveChat channel.

- Displayed message with the avatar and the name of the author on visitor side.

Task-2678397

closes odoo/odoo#91084

X-original-commit: 3d6ff10055deaea1a2295740c5216efce0ef3ef5
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 16:00:51 +02:00
tsm-odoo 7cfde26a93 [FIX] mail: ensures getMessagingComponent is called after registration
Adds an import to wait for the required components to be added to the messaging
components registry before their parent use getMessagingComponent. Otherwise,
any slight delay could lead to missing components.

closes odoo/odoo#91083

X-original-commit: 45d04504b2b0427b666f16d1b450edb73e4c14e5
Related: odoo/enterprise#27193
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2022-05-11 16:00:47 +02:00
tsm-odoo bd02fcc8f6 [IMP] mail, *: remove useless widget destroy
*: calendar, hr, note, test_mail.

Since community#86338, widget destruction is registered in the start method. Thus,
explicit calls to widget.destroy during tests are useless. This PR prepares the ground
for the one introducing the new environment in the discuss app. Indeed, the former PR
will use createWebClient instead of createView/Widget constructor thus, we won't be able
to call destroy on the returned value anymore. In order to reduce the noise in the main PR,
all the calls to widget.destroy have been removed.

task-2582313

closes odoo/odoo#91082

Related: odoo/enterprise#27192
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2022-05-11 16:00:41 +02:00
William Braeckman df984fff4e [IMP] resource: improve performance of _attendance_intervals
This commit aims to improve the performance of
`_attendance_intervals_batch`.

The complexity in space has been reduced by a lot.
Prior to this commit an intervals object was generated for each resource
request.
However every resource of the same timezone will share the same ending result.
The number of calls to `localize` and `astimezone` has also been reduced
as they get quite expensive with such a high volume.

Overall we can see a 10x improvement during `test_performance_attendance_intervals_batch`

closes odoo/odoo#90933

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2022-05-11 16:00:34 +02:00
William Braeckman 9985fd0725 [FIX] hr_work_entry_contract: fix generation of work entries
This commit aims to fix an issue with work entries generation when the
requested period is completely outside of the contracts period.
In this case no work entries should be generated.

Part-of: odoo/odoo#90933
2022-05-11 16:00:34 +02:00
Abdelouahab (abla) a37d53b1d1 [FIX] calendar : remove conversion to plain text
To reproduce
============

- configure a default note on the "Meeting" type activity in html in the settings of crm
- create a meeting type activity from an opportunity: the activity created in the chat of this
opportunity is well formatted in html (the layout is preserved: bold line break, highlighting...)
- create the meeting corresponds to the activity in the calendar: the html format in the note is not kept

Purpose
=======

when creating the meeting we convert the html to plain text

Specification
=============

to solve the issue we removed the conversion to plain text.

opw-2825252

closes odoo/odoo#91079

X-original-commit: 7d19020b7ff15b8b9e14f38c96312e1c2d1cecb4
Signed-off-by: Arnaud Joset <arj@odoo.com>
Signed-off-by: abla001 <abla@odoo.com>
2022-05-11 14:54:44 +02:00
Andro Gvivradze 6df903ad96 [FIX] point_of_sale: use total_amount value when down payment tax is not specified
Currently, when customer does not specify taxes on down payment product in pos
and tries to use down payment for quotation, they get javascript error.
With this fix we will assign down payment tax 0 in case there is no tax
specified

fixes OPW-2843483

closes odoo/odoo#91077

X-original-commit: c6ec2ccf611fa099187f0547222a5fa3c09da9af
Signed-off-by: Masereel Pierre <pim@odoo.com>
2022-05-11 14:54:40 +02:00
Nicolas (vin) 3b86e2a864 [FIX] account_facturx: fix uom unece code fetch
The _get_unece_code method does not work in case where a specific uom
has multiple xml_ids.
Change it to handle such case and try to match every xml ids with a
unece code if possible.

closes odoo/odoo#91076

X-original-commit: d488b3cde3701b5eb69ac36cb6bbcc913956a0d4
Signed-off-by: Florian Gilbert <flg@odoo.com>
2022-05-11 14:54:36 +02:00
qsm-odoo b754a6f99d [FIX] website: ensure lazy loaded images are loaded on zoomed Chrome
Before this commit, some images were never appearing on Chrome,
especially when using the 90% zoom.

Steps to reproduce (on a 1920x1080 screen and using Chrome):
1. Edit the homepage
2. Add a "Cover" block and setup a 50% min-height on it
3. Add 2 "Columns" blocks below the "Cover" block
4. Set the width of the first "Columns" snippet's first image to the
   recommended size (690px)
5. Save
6. As a public user, set the browser zoom to 90% and go to the page
   (you may need to reload the page again so images are in cache)

=> The first image of the second "Columns" block never appears.

opw-2731507

closes odoo/odoo#91075

X-original-commit: e9ef21b6cd5ae58322fa9102f9f34f06835f0485
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-05-11 14:54:32 +02:00
Nicolas Bayet 7dfd2e071e [FIX] web_editor: prevent class to create history steps
There is some classes that are technical and should not create steps.
Otherwise it compromise the ability to undo/redo or compromise the
ability to detect the dirty elements properly.

This commit prevent thoses classes additions and removals to create
history steps.

task-2836351

closes odoo/odoo#91074

Forward-port-of: #90064
X-original-commit: 41d8a0f246a134e2b5292da4db11e67aa9cfb4ed
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2022-05-11 14:54:28 +02:00
Nicolas Bayet 57d3211c99 [FIX] web_editor: disable observer only when necessary
Before this commit, the linktool was disabling the editor observer
until it was destroyed. This messed up with the undo/redo and the
isDirty.

This commit only disable the observer when necessary.

task-2836351

Forward-port-of: #90064
X-original-commit: 57c98f314332bbb4c3225942e1d3748eb131d8b0
Part-of: odoo/odoo#91074
2022-05-11 14:54:28 +02:00
Guillaume (gdi) 8d6c4e421e [FIX] web_editor: fix form not saved
Before this commit, the modifications of the form were not saved if the
user had only clicked on the submit button of the form. Only elements
with the class o_dirty are saved, but since this commit [1], the
observer that adds this class was disabled. The resolution of the bug is
just to remove the fact that the link tool disables the observer that
adds the o_dirty class. This commit also adds a test to make sure that
this bug does not happen again.

Here are the steps to see the bug:
- Go to /contactus page
- Click on edit
- Click on the Submit button
- Change a Form option (eg: Recipient Email, Labels Width, URL, ...)
- Save

Edit again the see that the changes are not saved

[1]: https://github.com/odoo/odoo/commit/c29fe9fa8fc8ff4a5e6f042607ef9b3070d1d339

task-2812722

Forward-port-of: #90064
X-original-commit: 3b45ef633adbeebee4819c30808680644b85c5fc
Part-of: odoo/odoo#91074
2022-05-11 14:54:28 +02:00
Alexandre Kühn fab501aec4 [IMP] mail: introduce view models (step 8)
This commit introduces models that define records being 1:1 map with components,
as a step to move further to having essentially all business code in models.

Having code in models is desirable to have very maintainable code, thanks to
robust and declarative code with an ORM-like architecture.

Task-2831082

closes odoo/odoo#91000

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 14:54:22 +02:00
Odoo's Mergebot a2eb586785 [MERGE] hr_work_entry: Add a link with planning/attendance
Creates a link between the work entries and the attendance app.

Currently work entries are generated by looking at the working schedule
on the contract, however this does not allow for employers to pay their
employees based on prestated hours.

This modules extends the base work entries generation routine to allow
for attendances to represent work entries.

The goal is also to keep the exact same behaviour as the regularly
generated work entries for attendance.
Meaning contract changes should affect work entries the same way when
using either schedule types.

Task ID: 2466871

closes odoo/odoo#72552

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2022-05-11 14:54:17 +02:00
alt-odoo 5fdeac05ca [FIX] hr_recruitment: disable activities for Interviewer access rights
Since commit [1], an interviewer can only access applications they are
assigned to, and the chatter is disabled as it might contain sensitive
information. However, they currently can still schedule activities on
these applications, which is triggering an access rights error at
message creation. We should prevent the use of activities alongside with
log notes and messages.

[1]:https://github.com/odoo/odoo/commit/63c4a9b951d374bec5796c525c99a3fbd4689e53

closes odoo/odoo#91061

X-original-commit: e615397f46652800681abd2c624c2dd8259e8dac
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Alex Thuyls (alt) <alt@odoo.com>
2022-05-11 13:48:06 +02:00
Brieuc-brd a27bd6ff36 [REF] mail: ThreadView, review and simplify scss
Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2849973

closes odoo/odoo#91024

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 12:44:47 +02:00
Sébastien Theys dc178821ba [FIX] mail: check existence of component records
- remove useless check (record should now always exist on update hooks)
- adapt check to use exists() when necessary (async code)

task-2849688

closes odoo/odoo#90973

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 12:44:41 +02:00
Romain Derie a3904dc603 [FIX] web: remove the fa-lg on the fa-bug icon from the debug menu
That icon is not meant to have a `fa-lg` class. It is a leftover of a
wrong revert. It looks way too big.

Indeed, it didn't have the `fa-lg` class initially.
When the new homemade icons were merged, the new bug icon needed to be
enlarged for some reason, it was done with [1].
It was later reverted with [2] to keep the FA icons when we can,
bringing back the `fa-bug` icon, but replacing the new `oi-large` by
`fa-lg` while the old FA icon didn't need to be enlarged.

[1]: https://github.com/odoo/odoo/commit/4e53953756b26e103efd479148e831b111c093d3
[2]: https://github.com/odoo/odoo/commit/28f910f5bef256ebb17700dea72fed4552e16357

closes odoo/odoo#91036

X-original-commit: 503401a3d575fb1c613a7c5230c67fb134f47418
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2022-05-11 11:29:07 +02:00
Xavier BOL (xbo) 5582af3958 [FIX] sale_project: exclude the Section and note SOLs
Before this commit, when a SO linked to the project contained a section
or a note in its Sales Order Items, the `Sales` section displayed in the
project update view displays those Sales Order Items even if there is no
product set and so the UoM will be False for those Sales Order Items.

This commit adds a condition in the domain to exclude the `Section` and
`Note` Sales Order Items in the `Sales` section displayed in the project
update view.

task-2849122

closes odoo/odoo#91035

X-original-commit: 0eaafbe4e56fd9728ce17a58e2dd3b91abd44359
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Signed-off-by: Xavier <xbo@odoo.com>
2022-05-11 11:29:03 +02:00
Brieuc-brd d5243c0128 [REF] mail: ThreadTypingIcon, review and simplify scss
Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2849864

closes odoo/odoo#91004

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 11:28:58 +02:00
Pouya Malekinejad 4cc4037726 [FIX] account: Tax grids stay when removing a tax from invoice line
Currently, when the user removes a tax from an invoice line (tax_ids), the tax grid stays on the account move lines,
after this commit, when the tax is deleted in invoice line, the related tax_tags are removed from `aml.tax_tag_ids` which is the correct behavior

task ID:2843666

closes odoo/odoo#90950

Pr: #90836
X-original-commit: 27b3d3412b347ef7fb62626d5087eaf34621395a
Signed-off-by: Laurent Smet <las@odoo.com>
2022-05-11 11:28:55 +02:00
William Braeckman f51afa1ed4 [IMP] hr_work_entry_contract: prep work for multiple sources
Prep work to allow work entries to be created from multiple sources when
using contracts.
The end goal is to be able to generate work entries from attendance as
well as the planning app.
After that the plan is to make sure the implementation works well with
payroll for hourly wages.

This commit contains the necessary changes for the next work_entry
modules to work.

TaskId-2466871
2022-05-11 11:23:04 +02:00
nni-odoo adccedb3dc [IMP] l10n_id_efaktur
Improved e-faktur document to adapt to the most recent requirements from partners and end users.
Changes include:
- Remove writing the row for "FAPR"
- Remove unused section (components that make up the "FAPR" line)

2783987

closes odoo/odoo#91013

X-original-commit: ee7a8ce740d1ec1ce6bdc0e992b8fee4fa975bdb
Signed-off-by: Florian Gilbert <flg@odoo.com>
2022-05-11 09:22:04 +02:00
nni-odoo 7b1e2014d6 [IMP] l10n_id
Improvement on Indonesian Localization. Changes include:
- Reducing the amount of Chart of Account to only essential and popular ones amongst end users.
- Updating the taxes to refer to the newly updated Chart of Accounts.

2783987

X-original-commit: 5af469755e2669483ab8d81564627da58218ec6b
Part-of: odoo/odoo#91013
2022-05-11 09:22:04 +02:00
Stanislas Gueniffey ac175c98e1 [IMP] define xml_utils.cleanup_xml_node
Intended to cleanup qweb xmls:
- remove blank (empty) nodes and/or nodes with whitespace text
- fix indentation
- remove indentation (needed for some xml signatures)

closes odoo/odoo#91006

X-original-commit: b7d7adb4f5a9873350511c227d5fbf54c8f38ce8
Signed-off-by: William André (wan) <wan@odoo.com>
2022-05-11 09:21:59 +02:00
Krzysztof Magusiak 2490982fce [FIX] sale_project: Expecting an ID in write for Many2One
When we are writing on a Many2One field, we are supposed to pass the id
of the object, in this case we are passing directly the object which is
working with the ORM, but is not expected in overrides as the
documentation suppose that an int is passed.

community PR refused in stable:https://github.com/odoo/odoo/pull/88736

closes odoo/odoo#90992

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
2022-05-11 09:21:55 +02:00
Alexandre Kühn 7394650865 [FIX] mail: fix typo onMobileAddItemHeaderInputSource
The method was moved in models but we forgot to remove the prefix
`_`, as it's now a public method. As a result, the feature was
not working.

closes odoo/odoo#90991

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 09:21:51 +02:00
Brieuc-brd 6606f8fc1f [REF] mail: MessageSeenIndicator, review and simplify scss
Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2835895

closes odoo/odoo#90002

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2022-05-11 09:21:39 +02:00
Camille Spiritus e720cfe901 [IMP][l10n_ch] account: allow for QR bills to be printed in batch
The only option to print a QR Invoice was to go on the invoice page and to click on the Print QR Button.

This PR allows for a user to print multiple QR codes, selected from the Invoices view.
The download occurs normally if all invoices are valid and QR-printable.
A wizard opens when the whole invoice selection isn't valid. It allows to download the invoices as a single pdf or to see a list of the ones that could not be printed in the QR format.
The wizard's text depends on the number of QR-valid, ISR-valid and classic (non QR, non ISR) invoices that the user tried to print.

All invoices for which a print is asked will be printed with a QR bill if it is possible. If not, this will check if printing in the ISR format is possible. Lastly, if none is possible, the classic invoice will be printed.
The behaviour allowed for the removal of the QR PRINT and ISR PRINT buttons on the single invoice view, for a behaviour closer to the original guidelines.

Bills can't be QR printed.

Corrected QR-Bill CSS.

task-2726507

closes odoo/odoo#82341

Signed-off-by: Laurent Smet <las@odoo.com>
2022-05-10 16:23:44 +02:00
Yannick Tivisse 1a71354b41 [FIX] rating: Avoid searching ratings in for loop
From 40 ms to 0.3 ms
From 1440 to 1341 request when crating 100 SO

Before this commit, the res_id field of the rating mixin was a simple integer.
It worked but the cache of the rated record was not be updated when new rating
were created.

This commit change it to a Many2oneReference to improve this behavior.

closes odoo/odoo#90968

X-original-commit: 1a6dd617a3c3be106e6fc7f1924243bca368edf7
Related: odoo/enterprise#27143
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Arnaud Joset <arj@odoo.com>
2022-05-10 15:16:51 +02:00
Arnaud Joset ffd0e24a95 [IMP] test_mail_rating: Add performance tests
X-original-commit: 2b3b679a843f516cc8e767e46cb48fea3088682a
Part-of: odoo/odoo#90968
2022-05-10 15:16:50 +02:00
Yannick Tivisse 27e17cad1a [FIX] sale: Use orm-cached _xmlid_to_res_id instead of ref
X-original-commit: 1a9133dcdd6a25e29b00eae3e4478801b3d9efca
Part-of: odoo/odoo#90968
2022-05-10 15:16:50 +02:00
xO-Tx f0fe283c76 [FIX] web_editor, *: fix image options visibility
*: website

Issue: from 15.0 onwards all image options are available on "/shop".

Details:

On 14.0, images options were removed for unsupported images (we had
a message "Quality Options Unavailable" - see [1]) and images related
options on old editor toolbar were hidden too.

On 14.4 and after [2], images options from the toolbar (crop, width,...)
were moved to a separate 'ImageTools' option and as a consequence, they
don't respect the same visibility rules as 'ImageOptimize'. Other
options were added in XML and they have the same issue, they are visible
as long as the target is an 'img'.

This is a list of options that should be available for unsupported or
partly supported images:

[A] For "t-field" images (shape & quality options are available only if
the image is supported for processing):

- Shape
- Filter
- Width (image width)
- Quality
- Transform (crop)

[B] For external images or images unsupported for processing:

- Description
- Tooltip
- Transform (crop, transform)
- width (CSS width)
- Alignment
- Style
- Padding
- Animate

[C] For illustrations:

- Same as [B]
- Dynamic colors

The goal of this commit is to fix this visibility issue on the JS code
of image options.

[1]: https://github.com/odoo/odoo/commit/84417a174bc2bb76730cc89783d3426a3a3b07d9
[2]: https://github.com/odoo/odoo/commit/d934b81aaae8d68b5579d1489b1fbe8ea347b4ed

task-2724946

closes odoo/odoo#90224

closes odoo/odoo#90832

X-original-commit: 8e6ca51ed3ebf121acfc7cb1ab992984d0764c90
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-05-10 15:16:44 +02:00
qsm-odooandxO-Tx b17a30f2d9 [FIX] website: hide the "animation launch" option for imgs in dropdowns
Since [1], that feature was lost because a `_computeWidgetVisibility`
was duplicated inside of the same class. The feature is now restored,
indeed the option does not make sense as animations will always launch
on every dropdown openings no matter the configuration.

[1]: https://github.com/odoo/odoo/commit/187acb938f70a2130d25fa76079221339c742f1e

X-original-commit: bde55751608b1679bd6599238a4da6279b8f74fa
Part-of: odoo/odoo#90832
Co-authored-by: xO-Tx <mou@odoo.com>
2022-05-10 15:16:44 +02:00
William Braeckman 3b1e37ce67 [FIX] hr_work_entry_contract: fix first batching
While investigating an error that occured on production it was noticed
that work entry batching did not happen correctly on the first batch for
contracts that started on the same date, this is due to the microseconds
being different in the `date_generated_from` and `date_generated_to`
fields.

TaskId-2466871
2022-05-10 14:56:10 +02:00
Merlin (megu) 339cdffb68 [FIX] account: use company name or id as suffix for journal alias name
Loading the demo data of Accounting app when only Japanese language is
installed will raise an error because there is a non-unique alias_name

Steps to reproduce:
1. - Run odoo with parameters `-d [db_name] --without-demo all
--load-language ja_JP -i l10n_jp,account_accountant` (you can also
install those apps using the UI but only Japanese should be installed
so it will be in Japanese)
   - Or create a trial database on odoo.com with Accounting installed,
using Japan as country and Japanese as language
2. Activate debug mode and go to Settings, scroll to the bottom and load
the demo data (`デモデータをロード`, last link in 'Developer Tools')
3. A validation error is thrown

Solution:
When building the alias name, if the name of the journal is not in
ascii, use the journal's code or type followed by the company's name. If
the company's name is not ascii, use the company id as suffix

Problem:
When a journal with non-ascii characters in its name is created, its
alias name fallbacks to the journal's code. In the demo data, two
journals have the same code. It will try to create the second journal
with the same alias name, violating the unicity check in
`_clean_and_check_unique`.

opw-2831638

closes odoo/odoo#90969

X-original-commit: 91d26b32250a74684dacad8350ac4452fa082384
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>
2022-05-10 14:16:59 +02:00