This commit replaces some odoo classes by native ones. They are simple
classes with no big extensions or not at all.
task 3439226
closesodoo/odoo#137116
Related: odoo/enterprise#48154
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
This commit removes the event `do-action` listened on `core.bus`
and adpats the place where it was triggered.
task 3439226
closesodoo/odoo#137088
Related: odoo/enterprise#48144
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Previous fixodoo/odoo#135784 added a test to repair that references
a sale_order_line field that only exists when the sale_margin module is
installed. Unfortunately there isn't already a common module that
requires both repair + sale_margin and runbot doesn't do single module
app tests so this test slipped through the cracks.
To avoid the error when the nightly single module tests occur, we avoid
running the test when sale_margin is installed since it will still run
during standard runbot tests and ensure that the bug doesn't return.
closesodoo/odoo#137490
X-original-commit: 6343e2f3125bb48b01bf5b1ef7be36d86ae35f86
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Before this commit, in a Email Marketing form sheet, there was a
margin-left spacing on alerts and unnecessary old CSS rules.
This commit addresses and corrects that spacing issue.
task-3488229
closesodoo/odoo#137469
X-original-commit: 390fbed6b4c978de076887f755427d0f7c538c64
Signed-off-by: Xavier Luyckx (xlu) <xlu@odoo.com>
As with fields, dynamicProps will be accessible to widgets from extractProps.
This commit will make readonly accessible as the first dynamicProps.
We'll be able to add more when we need them.
DynamicInfo.readonly is true iff the expression given as readonly
attrs in the arch is evaluated to true with the current record.
closesodoo/odoo#137414
Related: odoo/enterprise#48309
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This PR adds the verification for user input fields related to Six
terminals on the IoT box homepage.
Since we are moving Six to IoT it can be dangerous to call C functions
with wrong arguments (this can lead to leaks, errors and crashes)
task-3031744
closesodoo/odoo#137319
X-original-commit: 733a95fc3ef7ae244e3eecb6a880c7034b452cc7
Related: odoo/enterprise#48256
Signed-off-by: Yaroslav Soroko (yaso) <yaso@odoo.com>
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
*board,mail,project
This commit aims to simplify the XMLParser logic and the way archs
are manipulated in views, motivated by [1] where we had to
modify the arch in View to insert access right information.
First, the xml utils have been reworked. The XMLParser class has
been removed. The xml utils module already exported a parseXML and
a serializeXML functions, this commit adds visitXML, s.t. the whole
XMLParser feature is fully replaced by the 3 functions.
Second, concrete views now receive the arch in props as an
XMLDocument, as the arch is parsed once for all in View. With this,
we were able to remove serializing/parsing back and forth at several
places, where we needed to extract information for sub-parts of an
arch individually (e.g. View, x2many subviews, list view groupby).
Third, even though this change has been driven by the one above and
wasn't initally wanted, the view compiler cache and API have been
simplified. The cache is now flat, there's an entry in the cache for
each template that has been compiled. Moreover, the useViewCompiler
hook no longer takes the cache key in params, as it can directly
compute it itself (the key being the outerHTML of the template).
[1] odoo/odoo#135145closesodoo/odoo#136376
Related: odoo/enterprise#47808
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Prior to this commit, when closing the pos, if an order
contained a product with a tax present in the parent company, the tax
would not be found.
Steps to reproduce:
- create a tax in pos of company
- create a branch company
- set a product in pos of branch company with tax from parent company
- sell that product in pos
- close pos, error close popup will show up
Since a company is allowed to access the taxes of its parent, the filter
has been changed to check the taxes of the parent companies of the company.
Task-3502993
closesodoo/odoo#137380
X-original-commit: 7f0216e1b33885bc5c3787121911b632f4737abb
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Loukas Wets (lowe) <lowe@odoo.com>
Before this commit:
When pasting text from outside odoo, it often includes additional tags
such as <b> and <P>, along with unwanted styles.
After this commit:
When pasting text from outside odoo, those extra tags and styles are now
removed.
task-3378093
closesodoo/odoo#137236
X-original-commit: 5485824654179981cc7562e643123a6decbb02a2
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Before this commit, it was not possible to display a link to the linked
document in the calendar popover.
closesodoo/odoo#135061
Taskid: 3380101
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
Description of the issue/feature this commit addresses:
As of the first October 2023, some Japanese companies will start using "T" as
country code in their Tax ID. The current vat check only allows the country
code to be used in the Tax ID which means that "T" is refused.
Desired behavior after the commit is merged :
This commit makes it possible for Japanese companies to use "T" as a
country code in their Tax ID.
task-3515786
closesodoo/odoo#137455
X-original-commit: 114e31521beb1d00f85f8a19959006dfe62708a0
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Thomas Becquevort (thbe) <thbe@odoo.com>
Reproduction:
1. Go to any record with a chatter
2. Open full composer
3. Enter a special case for the text using shortcuts (CTRL+I for italic,
CTRL+B for bold, etc)
4. exit the special case with the same shortcut
5. JS error
Reason:
A selection is not null check is missing in the condition
Related PR: https://github.com/odoo/odoo/pull/136777closesodoo/odoo#137499
X-original-commit: db0325503576d06521ab65a64d3c9cce837e66bc
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Jinjiu Liu (jili) <jili@odoo.com>
This is not the way to retry, so we can avoid duplicate sending etc.
Task-3535981
closesodoo/odoo#137503
X-original-commit: c94c8f7f5c52e31b99a6a5717a4d93d0cdeca3b0
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Follow-up PR of https://github.com/odoo/odoo/pull/136308
Commit above simplified code in discuss models so code applies
on records than properties on records. For example, instead of
juggling between persona local id and persona, some code can simply
keep logic on persona without leaking local id.
However the improvements are iterative, and more improvements are
needed to stop using local id. Some code still need local ids.
Commit above mistakenly converts a local id to persona on some code
that still work in terms of local id. As a result, message reactions
were not working properly, notably when adding a new reaction using
click on an existing message reaction of someone else.
There was also a bug in implementation in mock server which made the
test not working. This commit fixes this issue too.
Task-3523101
closesodoo/odoo#136940
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
There is a double list encoding, probably not required. Coming from mail
enterprise code move.
closesodoo/odoo#137451
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit:
When we inserted a new row or column into a table, a <p> tag was not
inserted within it, resulting in the placeholder not being displayed.
After this commit:
When a new row or column is inserted into the table, a <p> tag is inserted
within the <td>.
task-3344668
closesodoo/odoo#137429
X-original-commit: a3e09ed84451f8a7c5cbc82648a02565ef63072f
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Purpose of this commit:
Added a button to the sidebar and the column dropdown menu
for resizing the table's height and width, so that if we
want to reset the modified size of the table, we will be
able to do so
Taskid: 3344668
X-original-commit: 8740310ec845b020db0d31d3be5dfc2969665994
Part-of: odoo/odoo#137429
Before this commit, a test in the "objects" test suite failed because
it used native dates without patching them, resulting in a low chance of
the generated dates to vary by 1 millisecond and failing the assertions.
This commit patches dates in that test to avoid this issue.
RunBot task 23058
closesodoo/odoo#137426
X-original-commit: aebbbaf942b85cb4d141975a617d8bcadfe9a719
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Add the `@` on the compute decorator of
`_compute_days_sales_outstanding`, it was probably due to a typo.
closesodoo/odoo#137425
X-original-commit: cb9bdd717f1ceacaecc29eaf8e7a1898405f2c1d
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Piryns Victor (pivi) <pivi@odoo.com>
Steps:
- Publish Standard method and Mondial relay shipping methods.
- Empty rules and countries on mondial relay shipping method.
- Go to shop, add a product and checkout.
- On the final checkout page, click on mondial relay and cancel the popup without choosing the location.
- Refresh the page.
- Click on Standard delivery then click on Mondial relay.
Issue:
We get an error(Null value of a variable) or the popup doesn't pop.
Reason:
When selecting the mondial relay method without location info, the ``SaleOrder.carrier_id`` of the order is set
but ``SaleOrder.delivery_rating_sucess`` is set to False(we didn't enter the location information). Because of that
when refreshing and calling ``_get_shop_payment_values()``, delivery line is removed from the order. Here we just
add the default delivery method.
opw-3468202
closesodoo/odoo#137418
X-original-commit: 686244ded63748196bbbea5773e55585015782f2
Signed-off-by: Eteil Junior Djoumatchoua (etdj) <etdj@odoo.com>
Steps to reproduce:
- Create a component C (automated/FIFO)
- Create and confirm two PO for C
qty: 1, price: 10
qty: 1, price: 20
- Make an MO with C as a component
- Unbuild that MO
Bug:
The valuation of the new component C is wrong, the new move in is valued
at the current product cost instead of its original value.
Fix:
create moves as a return to get the correct value
opw-3379457
closesodoo/odoo#137353
X-original-commit: d42238cc75fe6621c1eb893395856870c8bfbafb
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
Step to reproduce:
- Install `digest` module and configure mail setup
- Sent the digest mail
- Go to inbox and open mail
- Click on the link of `Choose the metrics you care about`
Issue:
Redirected to main menu on Odoo.
Cause:
The link is broken because we escape `&` twice: escaped directly in
the URL string, then with `Markup`.
Solution:
Use only Markup to escape `&`.
opw-3470958
closesodoo/odoo#137352
X-original-commit: e3e6d1970df192e6629b9a9caf2d6cf36c64723b
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
This significantly eases processing command data on relational field
received from server.
closesodoo/odoo#137341
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
This field contained 2 sets with partner and channel ids.
It's easier and safer to reason in terms of records rather
than properties on records.
Part-of: odoo/odoo#137341
Prior to this commit, the online payment portal was using the default
Odoo checkout layout when a user tried to pay for their order on the POS
self-order.
This commit enhances the UI and layout of the payment page (excluding
the o_payment_checkout form) as well as the confirmation page.
task-3433949
closesodoo/odoo#137090
X-original-commit: 046295b4a1651ba9ad3bfd8a9184154bde0ae1e2
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
We align how the date is computed on exchange differences on
how it already works when unreconciling. See _get_accounting_date().
closesodoo/odoo#136911
Task-id: 3516687
Related: odoo/enterprise#48058
Signed-off-by: Laurent Smet (las) <las@odoo.com>
This commit adds a popup to show product information when clicking on an
info button in the product card in the self order app. The popup shows
the ecommerce description and the name of the product.
The ecommerce description field has thus been moved from website_sale to
the product module so that the pos_self_order module can use it.
closesodoo/odoo#136906
Task-id: 3524272
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
The cookie service was replaced by a utils file in core. This was done
to be able to use the cookies without the need of environment.
"Om Nom Nom Nom" - Cookie Monster
part-of task-id 3439226
closesodoo/odoo#136782
Related: odoo/enterprise#48005
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Previously, when creating the public root, we would patch the rpc
service and the browser.fetch function so that they would rewrite the
relative URLs that they fetched to target the Odoo server. This is
useful when the public root is mounted on pages that are hosted on a
different server than the Odoo server, in particular, this was
historically useful for embeding the livechat widget in a website not
hosted by Odoo.
In odoo/odoo#122834 the livechat was refactored and got its own boot
code that does the same thing, making this code no longer useful. In
addition, in odoo/odoo#133153 the baseUrl we use no longer refers to the
session prefix which was configured by the livechat previously, but
simply refers to the origin of the page where the code is hosted, making
it a no-op.
These factors mean that the code removed by this commit is now
completely useless, which is why this commit removes it.
closesodoo/odoo#136672
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This PR makes several actions available for the embed livechat
such as:
- calls
- message edition
- message reactions
- link previews
task-3523930
closesodoo/odoo#136618
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit there were two regexes for matching http(s) URLs,
being the only difference between them the presence of a capturing group
for the protocol/scheme. The need for a nearly duplicated version of the
same regex was its use in `_onPaste` as delimiter for String.split(), in
which capturing groups are returned in the resulting array, and the
protocol/scheme was not desired.
This commmit removes the need for two different regexes to match http(s)
URLs, adapting `_onPaste`'s code to work with the presence of the
referred capturing group.
task-3520513
closesodoo/odoo#136497
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
pos*: point_of_sale, pos_sale_product_configurator, pos_self_order
This commit removes the product info button and put a button on each
product card to open the product info popup.
The commit also adds a new field on the product template model to
track the availability of a product to the self ordering mode. This
field can be changed from the product form view or from the product
info popup directly in the POS. If the field is set to false,
the product will not be shown in the self ordering mode.
The commit also adds new filter and search fields on the product
list view in the backend.
closesodoo/odoo#136467
Task-id: 3515881
Signed-off-by: David Monnom (moda) <moda@odoo.com>
With this commit we added the ability to use the real height of the
element as the height of the placeholder when we move an item when use
the DnD like jQuery NestedSortable did.
task-3439226
Part-of: odoo/odoo#136375
Like the jQuery NestedSortable, we implement the function `isAllowed`.
When you use the NestedSortable hooks, you can now specify a custom
function to verify if a drop location is allowed. By default, this
function is always true
task-3439226
Part-of: odoo/odoo#136375
Add a maxLevels param like the jQuery.nestedSortable has. The goal of
this param is to set the maximum depth of nested items the list can
accept. If set to '0' the levels are unlimited, it's the default value.
task-3439226
Part-of: odoo/odoo#136375
Update the description of the Brazilian localization to reflect the
most recent changes that happened here. Also fix some wrong formatting
that made some parts render as quoted text.
closesodoo/odoo#135959
Signed-off-by: Josse Colpaert <jco@odoo.com>
Co-authored-by: Rubi Navarro (ren) <ren@odoo.com>
This implements common Brazilian document types and adds a
government-assigned Series field used to identify each journal.
Sequence names in the same journal must have their own, independent
numbering. Because of this _get_last_sequence_domain() was extended.
A non-stored related l10n_br_invoice_serial field was added to
account.move to allow a user in the Bookkeeper access
group (group_account_user) without access to journals to see the
number.
task-3507518
Part-of: odoo/odoo#135959
For BR the same document type can be used for credit notes, debit
notes and regular invoices. There was no way to indicate that in the
internal_type field of the document type, so we wanted to add it in
the main module for simplicity.
Part-of: odoo/odoo#135959
Before this commit, in the form view of todo the title was light grey and there
was a small flicker when hovering the title.
In this commit, the color of the title is changed to dark grey and flicker is
eliminated.
Task-347920
closesodoo/odoo#135247
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Problem
---------
In master, XML attributes have been modifed from attrs={'invisible':...}
to invisible=. During the conversion, the condition where not properly
cleaned up.
Objective
---------
Clean up the XML attributes.
Solution
---------
Reduce conditions by removing unecessary elements:
- `fiscal_country_codes` always returns at least an empty string.
- All country codes are in capital letters, no need to `lower` them.
task-3493124
closesodoo/odoo#134329
Related: odoo/enterprise#46920
Signed-off-by: Josse Colpaert <jco@odoo.com>
When enable, this new feature adds the possibility to set a PDF header, footer and some product
documents to the quotation report.
These PDF can contains forms that'll then be filled using Odoo database.
This replace the previous sale quotation builder feature.
task-3249142
closesodoo/odoo#133773
Related: odoo/upgrade#5168
Related: odoo/documentation#5863
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Victor Feyens <vfe@odoo.com>
Co-authored-by: Morgane Demesmaeker <edm@odoo.com>
The value provided by the sale quotation builder feature is small due to many problems, and the
technical debt behind is high. For instance:
- The feature is nice but hidden: not visible on quotation, the most visible part is the button
"Design Template" on the quotation template (if you did activate the feature), it requires to have
eCommerce installed...
- The feature relies on fields that are shared with eCommerce which leads to unwanted behavior:
e.g. updating the bottom of the product page in eCommerce will impact quotation html description on
the portal
- The feature works as template but it is unclear for users: updating the HTML description on a
specific quotation will only impact that quotation. Updating the HTML page of a quotation only
update this quotation
- The feature is technically complex
As we want to keep most of the value of the feature but reduce its complexity, we remove the
quotation builder feature that'll get replace with the PDF quote builder feature.
task-3249142
Part-of: odoo/odoo#133773
Co-authored-by: Victor Feyens <vfe@odoo.com>
Co-authored-by: Morgane Demesmaeker <edm@odoo.com>
*: board, website
This commit simplifies the UX of the 'Custom Group by' menu. Before this
commit, many clicks were needed to apply another filter, from an accordion
menu.
Now, a select element is used instead, allowing a better user experience, by
enabling such group by directly, when an option is selected.
Some tests have been adapted to the new selectors and behaviors, and the
applyGroup and toggleAddCustomGroup has been removed, since groups are applied
when selected, and the value can be modified directly with selectGroup.
task-3458519
closesodoo/odoo#132006
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
PURPOSE
Slightly modify various apps to improve the user experience. Changes include
notably labels and views fine tuning, roundings, and small css fixes.
SPECIFICATIONS
- Remove the decorator from the event list view as it's a bit confusing
- Ensure mailing KPIs are now shown with 2 decimal places
- Re-order the mailing stat buttons
- Improve the background / font colors of the cover block
- Improve the labels of:
- Title and confirm button of the /button and /link modals
- Confirm button when archiving a record
Task-3204554
closesodoo/odoo#128108
Related: odoo/enterprise#43937
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Michael (mcm)