Commit Graph
17 Commits
Author SHA1 Message Date
wan 5125748616 [REF] account: remove chart template
Rewrite the whole chart template mechanism, removing the templates
stored in the database. The new format will mainly use CSV.

Speed up install time
---------------------

* About half of the time of installing a localization for the first time is
  taken by creating the template records. This new in code format gets
  completely rid of this.
* Creating the template records could often not be done in batch because
  of parent/children relations.
* The instanciation of the accounts on the company has been entirely
  reworked too, by
  - optimizing the order of creation of records to avoid UPDATE queries
  - using precomputed fields to avoid UPDATE queries
  - updating the translation in batch
  - deactivating logging in the chatter
  - avoiding access rights checks by checking the rights at the start

Overall, when installing a chart template for the first time, it is 4
times faster because half of the time spent on saving the template in
the database is not done at all anymore, and the instanciation on the
company is more than twice as fast.

Reduce technical debt
---------------------

There is no need to synchronize the templates with the real records
anymore. No need to use hooks to copy the data from one to the other.

It is easier to change a template in a stable version, which can often
be necessary due to legal reasons (i.e. a change of tax rates, reporting
tags,...)

Two modules have been removed:
* `l10n_generic_coa`: since there is nothing left datawise in this
  module, it can be integrated in `account` for free. It is just code
  and CSV.
* `l10n_multilang`: the fields that this module modified to be
  translatable are now always translatable:
  - there was an issue when updating modules that deleted all the
    translations because the fields were not translatable at some point
    during the loading of the registry, then they because translatable
    again but lost all translations because of the column type change.
  - most devs are not able to understand all the languages needed for
    all the localization available. Therefore, english has been added in
    the sources in most localization to understand better issues while
    debugging.
  - no need to call post init hooks anymore, doing the sync with the
    templates.
  - more: see "Translations" section

Because most of the data is now in CSV, it is also easier for product
owners to edit, audit, modify files themselves, removing one layer
during trivial development processes when only data should be changed.

More flexibility for declaration
--------------------------------

The data declaration can now be done easily in python or CSV.
A nice feature is that you can declare everything at once, even for some
more complex chart of accounts:
* if you have to set default taxes on accounts, would need to
  - declare the accounts because accounts are required on the taxes
  - declare the taxes
  - declare the taxes to put on the accounts
  This would lead to scatter information in multiple files. Now,
  everything can be declared in the same place and the loading of the
  chart of accounts will do the 3 steps automatically.
* if you have a relation of child/parent, you would first need to
  declare the parents then the children, and the loading would not be
  efficient because done one by one. Now, everything is done in batch
  automatically without having to think about it.

It is also easier to update fields on records where there was no field
for that on the templates, like
* setting a restriction for journals on accounts
* setting specific values on the company
* modifying journals and linking them easily by using the xml_id instead
  of having to compute it manually

Translations
------------

Some countries have multiple languages (i.e. Belgium uses officially
French, Dutch and German, and the CoA also has an official English
version) and we must support the languages in all these countries.
All these translations are known, and hard coded without using out
translation platform (Transifex). We also like to have the English
version (even if an official one doesn't exist) so that support can be
done more easily in databases using chart templates in other languages
(especially using a non roman alphabet).

Because the translations were not on Transifex for these records, it was
really hard to maintain: the translation templates (`.pot` files) were
not easy to extract as the automatic export would give values mixing
both the CoA and the menuitmes, the fields' strings,... But we don't
want to translate the CoA as we already know the value.
Managing the translations in the `.po` files was also annoying:
- it is easy to forget that the translations need an update too
- it requires a special editor, special terminal commands that everyone
  is not familiar with
- it is easy to make mistakes in the source string

The new format is the following: `field@en_US` where `field` is the
translatable field (usually `name`) and `en_US` is the locale code.
This allows to have the whole declaration on one line, everything in one
file. It also makes the process easier when debugging: instead of
searching for the translation in the `.po` files, it directly appears
next to the configuration of the account/tax/... .

Update of the code
------------------

The code can be updated using this script
https://github.com/william-andre/transform_coa
Forward ports can be managed too by stashing/resetting/checkout the new
modules or the changes in the modules updated in the same PR.

task-2687567

Part-of: odoo/odoo#110016
2023-02-17 19:30:40 +01:00
Denis Ledoux b4a7996e96 [IMP] base, *: change the API of init hooks to pass env
This is mostly a cleaning/refactoring change.

The current API for init hooks (pre, post, uninstall) is to pass
`cr, registry`.
But the first thing which was done by most
post init and uninstall hooks was to create an env using
the cr passed
e.g.
`env = api.Environment(cr, SUPERUSER_ID, {})`
and the `registry` argument was unused in all these hooks,
completely.

By changing the API of hooks to pass `env` instead
of `cr, registry`, we gain in average two lines in every
hooks:
- the line creating the env `env = api.Environment(cr, SUPERUSER_ID, {})`
- the line importing `api` and `SUPERUSER_ID`

Therefore removing ~250 lines of repeated code lines accross odoo/odoo and
odoo/enterprise.
In addition to these lines removed,
it also ease the API of init hooks for Odoo developers,
who are used to that `env` and not so much how to create an `env`
from a cursor.

Part-of: odoo/odoo#108254
2023-02-01 10:25:01 +01:00
Julien Alardot (jual) 81941965ae [ADD] l10n_ro: Add COA & tax & tax report data
[ADD] l10n_ro: Add COA & tax & tax report data

Add the Coa and tax data for the peruvian
localisation (in english with translations)

task-2697901

closes odoo/odoo#104065

Related: odoo/enterprise#33176
Signed-off-by: William André (wan) <wan@odoo.com>
2022-12-01 18:30:46 +01:00
xmo-odoo b4429c2a91 [FIX] Various P3-related import changes
* LDAP import: python-ldap is not python3-compatible, pyldap is

  Warning: only supported from debian Stretch (current testing)?
  https://packages.debian.org/search?searchon=names&keywords=pyldap

* implicitly relative imports
* imports of moved or removed stdlib modules

issue #8530
2017-04-28 09:06:53 +02:00
Rohan Patel ad7ca14d1b [MIG] l10n_* : Migrated to new API
[MIG] l10n_ae : Migrated to new API.

[MIG] l10n_ar : Migrated to new API.

[MIG] l10n_at : Migrated to new API.

[MIG] l10n_au : Migrated to new API.

[MIG] l10n_be : Migrated to new API.

[MIG] l10n_bo : Migrated to new API.

[MIG] l10n_br : Migrated to new API.

[MIG] l10n_ca : Migrated to new API.

[MIG] l10n_ch : Migrated to new API.

[MIG] l10n_cl : Migrated to new API.

[MIG] l10n_cn : Migrated to new API.

[MIG] l10n_co : Migrated to new API.

[MIG] l10n_cr : Migrated to new API.

[MIG] l10n_de : Migrated to new API.

[MIG] l10n_de_skr03 : Migrated to new API.

[MIG] l10n_de_skr04 : Migrated to new API.

[MIG] l10n_cn_small_business : Migrated to new API.

[MIG] l10n_cn_standard : Migrated to new API.

[MIG] l10n_do : Migrated to new API.

[MIG] l10n_ec : Migrated to new API.

[MIG] l10n_es : Migrated to new API.

[MIG] l10n_et : Migrated to new API.

[MIG] l10n_fr : Migrated to new API.

[MIG] l10n_generic_coa : Migrated to new API.

[MIG] l10n_gr : Migrated to new API.

[MIG] l10n_gt : Migrated to new API.

[MIG] l10n_hn : Migrated to new API.

[MIG] l10n_hr : Migrated to new API.

[MIG] l10n_hu : Migrated to new API.

[MIG] l10n_in : Migrated to new API.

[MIG] l10n_it : Migrated to new API.

[MIG] l10n_jp : Migrated to new API.

[MIG] l10n_lu : Migrated to new API.

[MIG] l10n_ma : Migrated to new API.

[MIG] l10n_mx : Migrated to new API.

[MIG] l10n_nl : Migrated to new API.

[MIG] l10n_no : Migrated to new API.

[MIG] l10n_nz : Migrated to new API.

[MIG] l10n_pa : Migrated to new API.

[MIG] l10n_pe : Migrated to new API.

[MIG] l10n_pl : Migrated to new API.

[MIG] l10n_ro : Migrated to new API.

[MIG] l10n_sa : Migrated to new API.

[MIG] l10n_sg : Migrated to new API.

[MIG] l10n_si : Migrated to new API.

[MIG] l10n_syscohada : Migrated to new API.

[MIG] l10n_th : Migrated to new API.

[MIG] l10n_tr : Migrated to new API.

[MIG] l10n_uk : Migrated to new API.

[MIG] l10n_us : Migrated to new API.

[MIG] l10n_uy : Migrated to new API.

[MIG] l10n_ve : Migrated to new API.

[MIG] l10n_vn : Migrated to new API.
2016-07-06 11:01:26 +02:00
Rohan Patel 180126755e [MOV] l10n_* : Re-organized directory structure
[MOV] l10n_ae : Re-organized directory structure.

[MOV] l10n_ar : Re-organized directory structure.

[MOV] l10n_at : Re-organized directory structure.

[MOV] l10n_au : Re-organized directory structure.

[MOV] l10n_be : Re-organized directory structure.

[MOV] l10n_bo : Re-organized directory structure.

[MOV] l10n_br : Re-organized directory structure.

[MOV] l10n_ca : Re-organized directory structure.

[MOV] l10n_ch : Re-organized directory structure.

[MOV] l10n_cl : Re-organized directory structure.

[MOV] l10n_cn : Re-organized directory structure.

[MOV] l10n_co : Re-organized directory structure.

[MOV] l10n_cr : Re-organized directory structure.

[MOV] l10n_de : Re-organized directory structure.

[MOV] l10n_de_skr03 : Re-organized directory structure.

[MOV] l10n_de_skr04 : Re-organized directory structure.

[MOV] l10n_cn_small_business : Re-organized directory structure.

[MOV] l10n_cn_standard : Re-organized directory structure.

[MOV] l10n_do : Re-organized directory structure.

[MOV] l10n_ec : Re-organized directory structure.

[MOV] l10n_es : Re-organized directory structure.

[MOV] l10n_et : Re-organized directory structure.

[MOV] l10n_fr : Re-organized directory structure.

[MOV] l10n_generic_coa : Re-organized directory structure.

[MOV] l10n_gr : Re-organized directory structure.

[MOV] l10n_gt : Re-organized directory structure.

[MOV] l10n_hn : Re-organized directory structure.

[MOV] l10n_hr : Re-organized directory structure.

[MOV] l10n_hu : Re-organized directory structure.

[MOV] l10n_in : Re-organized directory structure.

[MOV] l10n_it : Re-organized directory structure.

[MOV] l10n_jp : Re-organized directory structure.

[MOV] l10n_lu : Re-organized directory structure.

[MOV] l10n_ma : Re-organized directory structure.

[MOV] l10n_mx : Re-organized directory structure.

[MOV] l10n_nl : Re-organized directory structure.

[MOV] l10n_no : Re-organized directory structure.

[MOV] l10n_nz : Re-organized directory structure.

[MOV] l10n_pa : Re-organized directory structure.

[MOV] l10n_pe : Re-organized directory structure.

[MOV] l10n_pl : Re-organized directory structure.

[MOV] l10n_ro : Re-organized directory structure.

[MOV] l10n_sa : Re-organized directory structure.

[MOV] l10n_sg : Re-organized directory structure.

[MOV] l10n_si : Re-organized directory structure.

[MOV] l10n_syscohada : Re-organized directory structure.

[MOV] l10n_th : Re-organized directory structure.

[MOV] l10n_tr : Re-organized directory structure.

[MOV] l10n_uk : Re-organized directory structure.

[MOV] l10n_us : Re-organized directory structure.

[MOV] l10n_uy : Re-organized directory structure.

[MOV] l10n_ve : Re-organized directory structure.

[MOV] l10n_vn : Re-organized directory structure.
2016-07-06 11:01:26 +02:00
Christophe Simonis 2cf91d16a5 [MERGE] forward port of branch saas-6 up to 63e92cb 2015-07-22 16:17:54 +02:00
Fekete Mihai 6113b6364c [FIX] l10n_ro: update Romainian chart of accounts
To integrate latest chart of accounts changes from 01.01.2015
Closes #7603

Port of 433351f5 to master
2015-07-17 14:57:05 +02:00
Christophe Simonis d215a08db1 [MERGE] forward port of branch 8.0 up to 86d7f52 2015-07-14 15:57:39 +02:00
Fekete Mihai 433351f566 [FIX] l10n_ro: update Romainian chart of accounts
To integrate latest chart of accounts changes from 01.01.2015
Closes #6720
2015-07-13 16:11:47 +02:00
Olivier Dony 0bd4545348 [LEGAL] Use global LICENSE/COPYRIGHT files, remove boilerplate text
- Preserved explicit 3rd-party copyright notices
- Explicit boilerplate should not be necessary - copyright law applies
  automatically in all countries thanks to Berne Convention + WTO rules,
  and a reference to the applicable license is clear enough.
2015-06-02 03:16:04 +02:00
Christophe Simonis 4eb385fc0b [MERGE] forward port of branch 8.0 up to 0ec3c75 2015-01-23 14:57:07 +01:00
Aaron Bohy 2a39214d2e [FIX] File permission: remove unnecessary executable perm on files
Some .xml,.csv,.po,.woff,.ttf,.png,.eot,.svg had perm 755, provocating
'executable-not-elf-or-script' lintian warning for Debian packaging.
Set permission to 644 for those files.
Also remove unnecessary executable permissions on some .py:
	-addons/l10n_fr_hr_payroll/report/fiche_paye.py
	-addons/l10n_ro/res_partner.py
	-addons/l10n_ro/__openerp__.py
	-addons/l10n_ro/__init__.py
	-addons/l10n_do/__openerp__.py
	-addons/l10n_do/__init__.py
2015-01-23 11:11:27 +01:00
Leonardo Donelli 4a0b13ed92 [REF] remove vim modelines and resulting trailing blank lines
Let 2015 be a year without modelines!
cf #4174
2014-12-31 15:52:13 +01:00
Fekete Mihai aa768850c9 [IMP] l10n_ro: Update Romanian Localization
(Manual rebase+cleanup of PR #720 at 7e9faa6)
2014-07-01 00:45:43 +02:00
Fekete Mihai 6ee638f8fd Update the l10n_ro module providing the last chart of account and tax template.
bzr revid: office@erpsystems.ro-20121213073744-g0dh73t3q3q1rn2a
2012-12-13 09:37:44 +02:00
nvi-openerp afa0eb0100 [ADD] Added romanian accounting
bzr revid: nicolas.vanhoren@openerp.com-20101026075225-thzbib96q6nk96jk
2010-10-26 09:52:25 +02:00