Commit Graph
117156 Commits
Author SHA1 Message Date
Aaron Bohy 68332a0177 [FIX] web: fix evaluation context of the domain selector
The domain was instantiated without being given any evaluation context.
As a result, the uid variable was not defined,
crashing the js if present in a user-defined filter.

opw 1866852
2018-08-30 14:55:06 +02:00
Florent de Labarre 1ece9412be [FIX] stock: avoid useless processing
Define variables `product_id` and `rounding` to avoid useless Python
processing when accessing the corresponding values.

Closes #23111
opw-1868447
2018-08-30 14:01:54 +02:00
Moises Lopez e68350fcb5 [FIX] project: iterate on a single task
Do not retrieve the attachment of all records
Performance impromevement when iterating on a large number of records

From #26446
2018-08-30 13:33:52 +02:00
Nicolas Martinelli 052a5702c5 [FIX] purchase: keep vendor reference
Create a PO and assign any string to the Vendor Reference field. Confirm
and create an invoice.

The Vendor Reference field on the invoice is empty, while it is expected
to be filled in.

opw-1879379
2018-08-30 10:07:35 +02:00
Lucas Perais (lpe) b8fe404eae [FIX] project: portal should see projects only when he has tasks
before this commit, on /my/tasks, in the filter dropdown, every project that had visibility = portal was displayed
regardless of whether the portal user was a follower or not

After this commit, we search project in a more clever manner

OPW 1878187
closes #26615
2018-08-30 09:17:23 +02:00
Goffin Simon 1962d17c4b [FIX] hr_attendance: White screen if employee is not set
When the user was not linked to an employee, the first screen of the Attendance app
(the check-in/out screen) stayed white.

opw:1880582
2018-08-30 09:12:34 +02:00
Nicolas Martinelli 93a586be7c [FIX] calendar: recurring events
Do not parse the rule with `rrulestr`, because converting back to string
will change the original rule.
2018-08-30 09:04:23 +02:00
Joren Van Onder a1802fa327 [FIX] point_of_sale: iface_print_auto doesn't require a POSBox
Auto-printing works with and without a POSBox. Skipping the print
screen only works with a POSBox.

Was possible in v10, small oversight of
80e89c7a11.

opw-1874390
2018-08-29 14:39:01 -07:00
Christophe Simonis 0b8ef693a0 [MERGE] forward port branch saas-15 up to 0dc8588c5b 2018-08-29 16:45:36 +02:00
Lucas Perais (lpe) 4ba87e073d [FIX] mail: right user_ids when calling /mail/follow
On a SO, write a note to a user
The mail the user receives contains a follow button
Click on it

Before this commit, the link did not add the user as follower of the SO
this was because the wrong uid was passed to the function

After this commit, user is added as follower

OPW 1869849
closes #26634
2018-08-29 15:58:10 +02:00
Toufik Benjaa b367625248 [FIX] sale_payment: create payment.token when needed
- Before this commit, a sale order that generate a subscription and paid
  by the form method do not create a payment.token.

  After this commit, we check if the sale order need a payment.token to
  be created, if so we set the correct transaction type.
2018-08-29 13:55:03 +02:00
Nicolas Martinelli b53b637745 [FIX] mrp: 'To Consume' in workorder
Hide the field since it is always set to zero.

opw-1869511
2018-08-29 13:38:51 +02:00
len-odoo 683ecab8dd [FIX] web: use an unused variable in mock server
Fine-tuning of commit:
https://github.com/odoo/odoo/commit/818c18e55d0718286ff5bf332186a10f4d7a58ef
which introduced a variable that it didn't use.

opw 1867049
2018-08-29 11:04:46 +02:00
Goffin Simon 6bc2be09f5 [FIX] stock: Description for receptions are not being shown in Delivery Slip
Steps to reproduce

- Create a product with a custom description for receptions

- Create a purchase order

- Open the resulting picking

Shown behavior

- Product name is shown, description for receptions isn't shown in the delivery slip report

PS: Same scenario with a sale order

opw:1879069
2018-08-29 10:07:53 +02:00
Martin Trigaux a8469c4590 [FIX] tools: handle code in po
The previous code, as explained at b505ba9e0a, was to avoid creating duplicated
code entries for the same source (as only one is considered).

In case of a po comment like
 #. openerp-web
 #: model:ir.ui.view,arch_db:base.ir_access_view_search
 #: code:addons/web/static/src/js/chrome/search_inputs.js:716
 #: code:addons/web/static/src/xml/base.xml:1125
 #, python-format

the condition was not triggered (trans_type is model), creating two code entries

Necessary in #26614 to fix #26553
2018-08-28 18:10:03 +02:00
Martin Trigaux fe9cd11ab5 [FIX] base: generate translations in po format
Instead of csv, it allows to benefit from some features of POFile class like
handeling the duplicated terms correctly

In #26553, generating the missing terms was creating a new translation for
base.xml with no translation (value=src), making a previously translated term
no longer translated.

Closes #26614
Fixes #26553
2018-08-28 18:09:36 +02:00
Martin Trigaux 9e6e0da06f [FIX] web: accept false value in comparison
momentjs `isSame` method considers undefined values but not false
our method _isSameValue does consider false

Correct the error when running web tests
    Deprecation warning: value provided is not in a recognized ISO format
2018-08-28 16:10:40 +02:00
Goffin Simon 4a8d0b3484 [FIX] account: Rounding error with multi-currency payment
Fine tuning of this commit: a10ea93dbe

opw:1870351
2018-08-28 10:16:41 +02:00
Goffin Simon 3efc853f5f [FIX] stock_account: Display variant name in INVENTORY VALUATION report
When clicking on "Inventory valuation" in Stock module, the display name
of the variants didn't appear. So with a product template with several
variants, all the variants had the same name in the inventory valuation.

opw:1879572
2018-08-28 09:35:16 +02:00
LP Papillon b8e4374a4e [FIX] account_payment: use correct field
state_message instead of state_mesage

Closes #26444
2018-08-28 08:53:30 +02:00
LP Papillon 722b7e3867 [CLA] d2go Signs Odoo's CCLA
Done at #26444
2018-08-28 08:53:01 +02:00
Sylvain LE GAL 3c0a0261be [FIX] doc: js mixin inheritance
Hamster extends Animal, not itself

Closes #26595
2018-08-27 15:26:40 +02:00
Devendra Kavthekar 6ab7f8d095 [CLA] signature for dek-odoo
Closes #26593
2018-08-27 14:20:13 +02:00
Josse Colpaert 12ceef0c12 [IMP] point_of_sale: posbox unbeta version 17 2018-08-27 13:26:20 +02:00
Lucas Perais (lpe) 7768abd40b [FIX] tools:image: reset stream on crop
When cropping the image with a size, we crop it first and then we make a thumbnail out of it

Before this commit, the same byte stream was used, meaning that the thumbnail was
appended to the original

After this commit, we reset the stream

OPW 1876496
closes #26575
2018-08-27 10:31:43 +02:00
Dipalee Bhalodia 3c9aa50449 [FIX] web: Graph: group by two fields on line chart
Before this commit, when we applied two or more groupbys in line
graph, the groups displayed on the X axis where shifted to the left,
and the first one wasn't displayed at all.

related task: #1848289
Closes: #25037
2018-08-27 08:21:40 +02:00
Moises Lopez - https://www.vauxoo.com/ 8bda4744b5 [FIX] requirements: improve python3.7 compatibility
Continuation from https://github.com/odoo/odoo/commit/27c017ad98b4c9ac5fdcd28c9fd84d3690993118
PyYAML was missed in the list
Closes #26587
2018-08-27 08:19:53 +02:00
Odoo Translation Bot 7526b64e8a [I18N] Update translation terms from Transifex 2018-08-26 04:10:40 +02:00
Christophe Simonis 302ad0632c [FIX] base: set filename of javascript files of assets
A side effect of this bug was that other bugs like [1] wasn't caught by
the test suite.

[1] 2ed13c583e
2018-08-24 21:07:09 +02:00
Christophe Simonis 33981790de [MERGE] forward port branch saas-15 up to 4703d649dc 2018-08-24 18:03:00 +02:00
len-odoo 818c18e55d [FIX] web: fix js data during consecutive sequence of resequence moves
Let x_1, ..., x_a, x_{a+1}, ..., x_{a+k}, x_{a+k+1}, ..., x_{n} be a record
sequence ordered by its 'sequence' field.
Suppose the reordering occurs between elements x_{a+k} and x_{a+1}.
If the subsequence x_1, ..., x_a is ordered, then it does not change.
This is also true of the subsequence x_{a+k+1}, ..., x_{n}.
The resquence function makes exactly this assumption, and only sends the server
the subsequence x_{a+1}, ..., x_{a+k} to update its 'sequence' field.
The update of x is done as follows: it is index + offset, where index is the
position of x in the subsequence, and offset is the 'sequence' of the first
element of the sequence (i.e. x_{a+1}.sequence).

It is easy to see that we need another hypothesis: that the sequence numbers are
unique. To show it, suppose that the sequence of x_1, ..., x_a is 0, then all
x_{a+1}, ..., x_{a+k} have sequence 1, and lastly all x_{a+k}, x_{a+k+1}, ...,
x_{n} have sequence 2. Then after the call to the server resequence, the
subsequence x_{a+1}, ..., x_{a+k} would have sequence numbers 1, 2,..., k.
Since the x_{a+k+1}, ..., x_{n} subsequence have 'sequence' value 1, this would
obviously be incorrect.

We fix the reordering of the data in the js frontend to be consistent with
what is done by the server.
Note that this is only pertinent for sequences of reordering moves, since
otherwise the data comes directly from the server.

opw 1867049
2018-08-24 17:25:54 +02:00
Invitu a19d2c98f4 [FIX] point_of_sale: consider timezone in return orders
Similar to 21575407 for returns
payment_date is a date field, make sure the day is the one of the user

Closes #25342
2018-08-23 15:52:55 +02:00
Nicolas Lempereur 01b1830219 [FIX] mail: access token in received cid images
Following 50ab18176 an access token is added in the URL, but there may
not be an existing access token. If so this commit generate one.

opw-1877347
closes #26526
2018-08-23 15:38:34 +02:00
Olivier Colson 12fbbacc6d [IMP] account: reconciliation widget: format dates depending on user's language preferences. 2018-08-23 14:53:25 +02:00
Swapnesh Shah d6ee2abb98 [FIX] point_of_sale: force invoice journal if enabled
When the option "iface_invoicing" is enabled, an account journal must be set.

Closes #24380
2018-08-23 14:10:14 +02:00
Hiral Bhavsar 5830fcf506 [FIX] account: reconciliation: Pass context properly when making RPC call
This way, language formatting is always performed (123.30 becomes 123,30 in French for example).
2018-08-23 13:29:41 +02:00
Lucas Perais (lpe) 7ea67cea2e [FIX] crm: make sure there is a create date when computing date_open
Display the field date_open in the crm.lead form view
Create a new record

Before this commit, there was a crash because since the record is a virtual one
there is no create_date, hence the crash

After this commit, we make sure we select records that have a create_date, and there is no crash

OPW 1877080
closes #26499
2018-08-23 11:27:26 +02:00
David Monjoie a66650a7fa [FIX] web: esc cancels kanban column quick create
The feature was already declared in AbstractQuickCreate, but the
ColumnQuickCreate object did not define a _cancel function.
2018-08-22 15:54:21 +02:00
Arnold Moyaux be4651cda3 [FIX] stock: compare quantities with different uom
Usecase to reproduce:
- Create a receipt for 1 dozen.
- Mark as todo
- Unlock and update initial demand to 3 dozen.
The reserved quantity on move line is 36 dozen.

It happens because reserved_availability and product_qty are
compare. However reserved_availability is in move UoM and product_qty
is in move's product UoM.

This commit clean the code in order to compare field that use the same
UoM.

Close #26504
2018-08-22 15:44:54 +02:00
Christophe Simonis fbfb91799e [MERGE] forward port branch saas-15 up to 9cf0dbe226 2018-08-21 16:00:40 +02:00
Nicolas Martinelli 65c2a9b70c [FIX] sales_team: default team is active
Check the default team is active. Moreover, make the return object type
consistent.

opw-1876966
2018-08-21 14:46:11 +02:00
Nicolas Martinelli f46761caa8 [FIX] membership: change partner on invoice
- Go to a contact C1 > Membership tab > Buy membership
- Create an invoice with the membership
  => It creates a membership line on C1
- Change the partner on the invoice to C2

The membership line and the membership status is not transfered to C2.

We first need to recompute on C1, and we also need to explicitly write
the new partner C2 on the membership lines.

opw-1875673
2018-08-21 13:39:16 +02:00
Nicolas Martinelli b8161ec806 [FIX] membership: cancel invoice
- Go to a contact > Membership tab > Buy membership
- Create an invoice with the membership
  => The status of the member goes to 'Waiting membership'
- Validate the invoice
  => The status of the member goes to 'Invoiced membership'
- Create a credit note to cancel the membership
  => The status of the member goes to 'Paid members'.

It shouldn't be the case because the client has canceled his membership.

We look on `payment_move_line_ids` instead of `payment_ids`. Indeed, the
latter doesn't list credit notes, while the first one lists all move
lines used for payment.

opw-1875673
2018-08-21 13:39:16 +02:00
Pedro M. Baeza 87a6b879a2 [FIX] account: Fix tax summary on invoice report
We want to show the base amount for the tax when there are multiple taxes or the
amount is not the invoice total, not the contrary.
2018-08-21 10:36:53 +02:00
Pieter Paulussen 00eb2e3e6d [CLA] update Dynapps N.V. CLA agreement
Closes #25336
2018-08-20 15:48:28 +02:00
Habib Ayob 13252a7daf [CLA] Paradigm Digital signs Odoo's CCLA
Closes #26468
2018-08-20 15:40:26 +02:00
Alexandre Moens 429f785426 [REV] Revert "[FIX] Stock : deliveryslip report - prioritize partner_id (#25709)" (#26458)
This reverts commit 6e8f1fcc63.

Reverted commit broke more than it fixed.

What it fixed : Show partner info when partner is changed after the
movelines are created (very specific used case, could be considered to
be the wrong way to do things)

What it broke : dropshipping
2018-08-20 15:29:29 +02:00
Lucas Perais (lpe) b2be451c7c [FIX] point_of_sale: fix rounding logic
Use case specifically for round globally, but the justifications hold anyway
Have a session with one tax, multiple partners, and returns of freight (negative amounts)

When validating a pos.session, the computation of amls was a bit out of logic,
Namely, we grouped tax lines by :
1. their tax id (correct)
2. their partner_id (not wrong but limited)
3. their balance > 0 (wrong)

The justification for point 2 and 3 is two fold:
- Ultimately, the order is level of granularity that really makes sense
It's the order that is paid and therefore that has both legal and business meaning
and on which the amounts are retrieved anyway
- On the order, we litterally make the sum of tax amounts of each line, aggregating
credit and debit under the same variable
It is only logic to do the same for grouping the taxes at validation time

This commit only corrects the behavior for the rounding method 'globally'

OPW 1865700
closes #26203
2018-08-20 10:23:27 +02:00
Tommy Tran 89bea8ef43 [FIX] hr_maintenance: fix singleton error in _compute_owner
avoid singleton error when accessing on multiple records

Iontroduced at 9a20c6556f

Closes #25379
2018-08-20 09:04:00 +02:00
Nicolas Martinelli a456161680 [FIX] sales_team: AccessError on default team
- Create 2 companies C1 and C2
- Assign User U1 in C1
- Assign the default Sales Team (`sales_team.team_sales_department`) to
  C2
- Create an invoice with U1

An `AccessError` is raised because the user is not allowed to access the
default Sales Team.

We fall back on `sales_team.team_sales_department` only if the user has
read access.

opw-1876966
2018-08-20 08:41:10 +02:00