Commit Graph
117156 Commits
Author SHA1 Message Date
Christophe Simonis 8d0942380b [MERGE] forward port branch saas-14 up to fbdda5437a 2017-10-17 13:22:25 +02:00
qsm-odoo b85bd35823 [FIX] web_editor: fixed issue of chrome triple click
Partial backport of 11.0 commit (https://github.com/odoo/odoo/commit/6ad2ae30354a77c0f898cb9cb5a859713061d71a)
to solve issue 774152. Note: it has to be forward-ported as
implementation has been improved to handle mass mailing cases.

When an user triple-clicked on a paragraph and then typed text, the
paragraph was removed instead of its content (so the new text was
added at the beginning of the next paragraph).

See: http://stackoverflow.com/questions/38467334/why-does-google-chrome-always-add-space-after-selected-text
2017-10-17 12:45:52 +02:00
Christophe Simonis fbdda5437a [MERGE] forward port branch 10.0 up to cbca27d005 2017-10-17 12:09:58 +02:00
Yannick Tivisse 55af66dcda [FIX] mass_mailing: redefine the usable models in mass mailing
Displaying all the model is not readable for a common user. We should only display models that are fit to be used in a mass mailing campaign.
2017-10-17 11:58:51 +02:00
Christophe Simonis cbca27d005 [MERGE] forward port branch 9.0 up to d5c0cae60b 2017-10-17 11:42:05 +02:00
Laurent Smet c2f59f08c7 [IMP] base_vat_autocomplete: don't block the user with VIES service
- When the VIES service is unreachable/unavailable, don't raise an error.
- Set the timeout to 5 seconds instead of default 120 seconds.

-task: 35043
2017-10-17 11:21:58 +02:00
Lucas Perais d5c0cae60b [FIX] mass_mailing: background snippet option outlook compatible (#20137)
Origin of the fix: the snippet background image did not change the background image.
This was due to commit a14f89c which wraps the snippet's content into a table for outlook display compliance

This issue is fixed here, with the modificaion of the background snippet option.

OPW 772442
2017-10-17 09:37:08 +02:00
fwi-odoo 48c17fd360 [FIX] web: polyfill to make the list editable work in IE11
Internet Explorer doesn't implement 'contains' for document so we make a
polyfill for this method in order to be compatible.
2017-10-17 09:31:55 +02:00
fwi-odoo 3993528bac [FIX] web: polyfill to make the list editable work in IE11
Internet Explorer doesn't implement 'contains' for document so we make a
polyfill for this method in order to be compatible.
2017-10-17 09:29:14 +02:00
Jérome Maes 81218a833c [FIX] sale_timesheet: access right when validate invoice
When validate an invoice, if you are timesheet
user and billing user, it is forbidden for you
to create an analytic line without a project set.
This commit allow billing user to create AAL.

opw-776391
2017-10-17 09:18:51 +02:00
Jérome Maes a9fd3f0f2f [FIX] sale_timesheet: rounding display on project overview 2017-10-17 09:04:49 +02:00
Jérome Maes a222afb7d4 [FIX] sale_timesheet: add onchange to set default value
When changing the type of a product to 'service' the
new service policy is empty by default, and should not
be !
2017-10-17 09:04:49 +02:00
Cedric Snauwaert 757e9e586c [FIX] account: fix balance = 0 in dashboard
In some case, user set a currency on the journal which is the same as the company currency. In that case, the field taken was amount_currency which should not be the case.

OPW 775123
2017-10-16 17:55:26 +02:00
Jérome Maes 25725eae57 [FIX] hr_timesheet_sheet: set domain on action to see timesheet only
Analytic lines should not be included when
showing the timesheet line of a given
sheet. A domain is thus needed on the action.

opw-772517
2017-10-16 17:27:16 +02:00
Jérome Maes 3d5298aff9 [FIX] hr_timesheet_attendance: only include timesheet in attendance/timesheet report
Report mixed analytic line and timesheet, but
only timesheet should be included.
Since a timesheet is an analytic line with
a project, this fix do the job.

opw-772517
2017-10-16 17:27:16 +02:00
Denis Vermylen c477f0764e [FIX] sale: pricelist price base
When setting a pricelist to show the public price discount, it ignored
the pricelist item's base field (if not 'Other Pricelist') and set it
by default on the lst_price instead.

This did not work when you based your discount on the standard_price
(= cost price) with public price discount.

Now it does.

opw: 775275
2017-10-16 17:26:11 +02:00
Pierre Masereel d301d6391d [FIX] point_of_sale: rounding error when create picking
When a return picking is created from a POS order, the methods check
that the value rounded to the unit of measure is not null.

The problem is that a rounding is passed to the function 'float_is_zero'
in the parameter precision_digits instead of precision rounding.

This bug has been introduced in rev: https://github.com/odoo/odoo/commit/61304087e7f48c677837dabdc8f1f8aeb18fb52e

opw-771282
2017-10-16 17:07:43 +02:00
Raphael Collet 9882c93874 [FIX] website_slides: avoid NULL characters in text field
OPW 772560
2017-10-16 16:38:30 +02:00
Fabien Meghazi c822eb4809 [FIX] crm: mark(lost|won) routes calls removed crm.lead functions (opw: 773907)
crm.lead#case_mark_won and case_mark_lost have been removed in 1414b3e56e
merged in saas-12 but later commit 0b87f76628
reference those function and was merged in saas-11

This fix also improved logging in the controllers in order to log
unexpected exception.
2017-10-16 16:32:24 +02:00
alexkuhn 44b3491450 [FIX][P3] base, tools: prevent crash when importing translation .po file (#20191)
With Odoo v11 running on Python3:

1. Go to Settings -> Translation -> Import Translation
2. Choose a valid .po file (e.g. generated with the menu Export Translation)
3. Click Import
There is a server error.

There are two bugs behind this error:
1. we open a temporary file that cannot insert bytes ('w+')
2. the name of the temporary file is an integer (its file descriptor)

Python2 processed some implicit conversion between str and bytes, so that the 1st error doesn't occur. The name of a temporary file in Python2 is '<fopen>'.

We made the following corrections to the code:
1. open the temporary file with w+b access (write bytes)
2. enhanced a conditional statement so that we skip instructions in case where the field name of the tempfile is a string

Related Ticket:
opw-775445
2017-10-16 16:30:54 +02:00
qsm-odoo df8590e562 [FIX] web_editor: properly save multi-edited elements
When an element is placed multiple times in a page, it is saved only
once. Unfortunately, when a view was divided in multiple editable
parts (XML branding), only one of those parts were saved.
2017-10-16 16:02:00 +02:00
qsm-odoo eda976e63d [FIX] web_editor: do not break labels' texts into <p/>
When editing the content of a <label/> which has XML branding (first
DOM element which is editable in its hierarchy), a <p/> element was
added inside. This behavior is there to automatically add <p/> elements
in empty editable <div/> / <section/> elements on edition. This should
however not apply on <label/> elements.
2017-10-16 16:02:00 +02:00
Christophe Matthieu c06aa12777 [FIX] account: reconciliation: small fixes
* reset pager when change filter
* display 10 lines in manual reconciliation (add limitMoveLines in action's
'params' options to choose the number)
2017-10-16 15:37:40 +02:00
Christophe Matthieu 2d0c3abd5c [FIX] account: reconciliation: loose the current view when reload
Todo in master: change action and add information in params
2017-10-16 15:37:40 +02:00
Géry Debongnie a18a3fd31a [FIX] web,report: display warning when report download is blocked
iOS devices need to open a window to allow downloading files.  This is
fine, unless the browser is setup to block the popups, which is quite
probably the default settings.  In that case, it just fails silently,
and the user has no idea of what just happened.

So, with this commit, we simply display a warning to let the user know
of what is actually going on.
2017-10-16 14:47:29 +02:00
qsm-odoo 296498fb58 [FIX] web_editor: do not break <p/> when pasting a <p/> element
This fixes a bug when pasting text in a paragraph, it was always
creating a new paragraph for no reason.
2017-10-16 14:14:47 +02:00
Khoi Nguyen 3315c7c727 [REV] mrp: reallow quantity/lot/SN changes from work orders 'manager view'"
This reverts commit
https://github.com/odoo/odoo/commit/44f06a66467cb39780fa65d0cefb44704b072e94.

The reverted changes will be applied in enterprise/quality_mrp instead.
2017-10-16 13:54:31 +02:00
Martin Trigaux 912a7318d9 [FIX] mrp: clarify uncomplete message
When selecting the BoM type 'kit' the explanations were unclear
Courtesy of Erwin van der Ploeg, Odoo Experts

opw-776612
2017-10-16 13:44:11 +02:00
amoyaux 671c20555e [FIX] mrp: Unbuild multi serial number components
Use case to reproduce:
- Create a product with a BOM that use at least
twice the same component tracked by SN
- Build this product with SN 'A' and SN 'B'
- Unbuild it
-> Constraint error on duplicate SN

It happens because the unbuild order will create only
one stock.move.lots for SN A with a quantity of 2.

This commit create a stock.move.lots by quant used,
for example if the MO used 2 quants with a qty of 1
and one with lot 'A' and the other with lot 'B'. It will
create 2 stock.move.lots with lots 'A' and 'B'.

Still a know issue: If the user try to unbuild twice
the same MO it will reuse the same unbuilded componenets
than the first unbuild order.
2017-10-16 13:14:46 +02:00
amoyaux 0aefcdbad7 [FIX] stock: procurement generated by scheduler truncate datetime
When purchase order are created from a scheduler they always
have the same hours even if they were created at different
time. Also the procurement order that generate the purchase
order line have the same problem.

It happens because the transformation from datetime to string
use a date format and thus truncate the DEFAULT_SERVER_TIME_FORMAT

This commit use a datetime format instead the dateformat.

opw-775833
2017-10-16 13:14:21 +02:00
amoyaux fea667a243 [FIX] account_invoice: Wrong default uom
The UOM by default should be the purchase UOM

opw-775105
2017-10-16 13:14:02 +02:00
Khoi Nguyen 0958eee295 [FIX] web: Remove debugger
Introduced by
https://github.com/odoo/odoo/commit/9f7af9f9b742d08ca69a4d4d0b963f625c4b4bba

Sorry!
2017-10-16 13:10:25 +02:00
Khoi Nguyen 8191d6d72e [FIX] web: tab navigation with phone widgets in form view
This commit ensures that tab navigation works properly when editing a
form view that contains input fields with phone widgets. Previously,
pressing TAB would skip those fields.
2017-10-16 13:05:19 +02:00
Khoi Nguyen b6c3ee4e24 [FIX] web: discarding a new record in a modal closes the modal
Discarding a new record triggers the 'history_back' action.  This makes
sense if the record was discarded from a normal form view, but not so
much when in a modal, where the expected behaviour is to close the
dialog.

This commit overrides the function in the action manager which handles
the switch to the previous view. It checks whether a dialog window is
open, in which case it simply closes it.
2017-10-16 12:20:11 +02:00
Laurent Smet 5afb5ecd04 [FIX] account: fix complex tax computations (multiple price included taxes, etc.)
Suppose the correct computation:

        seq | amount | incl | incl_base |  base  |  amount
        ----------------------------------------------------
          1 |    10% |    t |         t |  100.0 |     10.0
          2 |    10% |      |           |  110.0 |     11.0
          3 |    10% |    t |           |  110.0 |     11.0
          4 |    10% |      |           |  110.0 |     11.0
          5 |    10% |    t |           |  110.0 |     11.0
        ----------------------------------------------------

with an initial amount of 132. Without this commit, the base amount was computed by:

132 / 1.1 / 1.1 = 109.09

instead of:

132 / 1.2 = 110.0

see task: https://www.odoo.com/web#id=34471&view_type=form&model=project.task&action=333&active_id=967&menu_id=4720

Was PR #18275
2017-10-16 11:35:08 +02:00
Khoi Nguyen 9f7af9f9b7 [FIX] web: ticking a checkbox in an x2many after onchange
This commits fixes a traceback that appears when ticking a checkbox in
an x2many which triggers an onchange. The root cause of the issue is
twofold:

- confirmUpdate requires currentFieldIndex to be defined, but might be
  needed when setting currentFieldIndex;
- confirmUpdate attempts to restore the selection range even if we are
  not dealing with a char field (e.g. checkbox).

We solve the issue by ensuring that _selectCell gives a temporary value
to currentFieldIndex. This value is chosen so that confirmUpdate calls
_selectCell with the right parameters. Moreover, we only restore the
selection range when the range is defined.
2017-10-16 11:34:39 +02:00
Khoi Nguyen bb692c76d4 [FIX] web: tab navigation with phone widgets in form view
This commit ensures that tab navigation works properly when editing a
form view that contains input fields with phone widgets. Previously,
pressing TAB would skip those fields.
2017-10-16 11:34:39 +02:00
Goffin Simon ef671e7952 [FIX] base: Wrong default value for number_next_actual in ir.sequence.date_range
The default value for number_next_actual in ir.sequence.date_range must be at least one
otherwise it will raise error because the next value cannot be equal to the date_from.

opw:776205
2017-10-16 11:30:03 +02:00
Goffin Simon cd77219cbd [FIX] account: Duplicating journal entries
When duplictating a Journal Entry  that has been created from
a new payment (accounting/purchases/payments/create), the new copy
of the Journal Entry also duplicated the already existent relationship (link)
to the payment, causing possible future conflicts in functionalities
like reports, payments, reconciliations, among others.

opw:775151
2017-10-16 10:21:44 +02:00
Goffin Simon c9e36d3d15 [FIX] point_of_sale: Variant description doesn't show on POS invoice
The display_name of the product  must be shown as the name of the invoice line
to have the same behavior as in Sale app.

opw:771302
2017-10-16 10:07:51 +02:00
Goffin Simon cd21942ab8 [FIX] website_forum: 404 error message for empty question
When a empty question was posted in the forum, a 404 error was raised.

opw:76940
2017-10-16 09:53:11 +02:00
Yenthe V.G 4f0d6f5ae1 [Requirements] FIX: Upgrade ebaysdk to 2.1.5 due to bug
Upgrade the dependency for ebaysdk from 2.1.4 to 2.1.5.
There was a bug in in 2.1.4 that prevented installing (see https://github.com/timotheus/ebaysdk-python/issues/223).
Closes #20148
2017-10-16 09:06:38 +02:00
Yenthe V.G 2e6f25580e [FIX] sms: add missing import for translations
This commit closes #20141
2017-10-13 19:07:02 +02:00
Simon Lejeune 57f03f40b9 [FIX] purchase: fix rev 7392e476b8
Force the company currency before playing with the rates.
2017-10-13 18:47:20 +02:00
Simon Lejeune 7392e476b8 [FIX] stock_account: always call _get_price_unit in _action_done of a move
It is possible that the price unit the move was created with is no
longer valid (for instance, one could change the price unit on the
purchase before validating the receipt, or the currency rate has changed
in the meantime).

Fixes #20035
2017-10-13 17:56:50 +02:00
Nicolas Lempereur f4332118d3 [FIX] mass_mailing: unsubscribe error if contacts
If the mass mailing was to mail contacts, this could cause an error if
the recipient unsubscribed. If the mass mailing was to mailing list,
unsubscribe would not work.

This change update unsubscribe to take into account changes in 765e752
and e15372c07 that allowed mailing list / mailing list contacts to be
used separately.

opw-770473
closes #20145
2017-10-13 17:16:13 +02:00
Richard Mathot 9866322a3d [FIX] base: bad translation 2017-10-13 16:22:37 +02:00
Christophe Simonis 8c2c954785 Revert "[FIX] hr_expense: avoid crash when submitting"
Commit 46c1091f36 was only a workaround.
Inability to submit expenses was actually a js bug that hass beed fixed
by 7d448d57e3.

Close #19877
2017-10-13 15:53:34 +02:00
Yannick Tivisse 2651717251 [IMP] base_import: Defer parent computation after record creation/update
Currently when importing files, the parent left and right are recomputed on each record creation/update, which could lead to a lot a request.

This commit will defer the parent field recomputation to the end on the `load` function by recomputing the values from the MPTT and inserting directly the new values on the records.

Tested on a customer instance, this will reduce the execution time when importing a thousand stock.location from 15 minutes to several seconds.
2017-10-13 15:24:05 +02:00
Martin Trigaux 25ac56eaf6 [FIX] doc: undefined variable toctree 2017-10-13 15:21:16 +02:00