Commit Graph
117156 Commits
Author SHA1 Message Date
Christophe Simonis ee846fbff8 [FIX] core: exception are made to be raised 2016-08-19 15:59:10 +02:00
Thibault Delavallée 274e94d715 [REF] event: remove group_mail_scheduling as email scheduling is part of event management
In the interface using the email scheduler of events is limited to a group
that is not activated by default. However by default emails are sent and
therefore cannot be configured by the event maanger.

As managers should always be able to configure sent emails we decided to
remove the group and always give access to the email scheduling tab of the
event form view.
2016-08-19 15:49:37 +02:00
Christophe Simonis ef1386a7d2 [FIX] core: correctly load sql file when updating modules
Do not dumbly parse sql queries by splitting on `;`. PostgreSQL will do
a better job than us...
2016-08-19 15:48:36 +02:00
Thibault Delavallée df216b6bfe [IMP] base: limitate access to config settings to superuser or group_system members
Currently members of group_erp_manager (Access Rights) and group_system
(Settings) have theoritically access to config settings. However only
group_system members have access to the settings through the interface
as all menus are restricted to them. Moreover after changing a config settings
a check on ir.actions.todo is performed. This model is limited to group_system.

It is therefore not possible for group_erp_manager members to execute config
settings. This commit therefore change the check performed in config settings
to ensure user is superuser or a member of group_system to avoid unwanted
access rights errors further in the process.

[IMP] sale_stock: remove now unnecessary check
2016-08-19 15:47:54 +02:00
Aristobulo Meneses 5e7d23f1be [FIX] website_slides: Set file size limit to 25MB to match web module limits
This commit closes #13223
This commit closes #13225
2016-08-19 15:34:58 +02:00
Jeremy Kersten 0d491775c5 [FIX] web: don't duplicate alert while backup
When you backup 3 dbs with the database manager, you had 3 times the warning.

Underscore is not loaded, so _.once not available.
This commit closes #13173
2016-08-19 15:34:58 +02:00
Martin Trigaux 0122c05eff [FIX] web: avoid report with invalid sheet name
This commit does not fix any bug in odoo/odoo but helps fixing #12788
Needed for odoo/enterprise#433
2016-08-19 15:28:27 +02:00
Martin Trigaux 99215a02c6 [I18N] update saas-11 translations by merging 9.0 and master
1. export saas-11 sources terms into .pot files
2. msgcat odoo-9 .po & odoo-master .po into saas-11 .po files
3. msgmerge saas-11 .po with saas-11 .pot files to keep relevant terms
2016-08-19 13:54:31 +02:00
Christophe Simonis f571ba373a [MERGE] forward port branch saas-6 up to 826472d 2016-08-19 12:56:08 +02:00
Christophe Simonis 826472dc48 [FIX] account_asset: correct typo in function name 2016-08-19 12:45:11 +02:00
Christophe Simonis e5371329f7 [MERGE] forward port branch 8.0 up to 08ed48e 2016-08-19 12:07:14 +02:00
Srushti Patel 986b152f16 [IMP] product: ensure variant price is managed on the template
* variant prices should be read only on the variant
* added an help to explain how it works
* because variant prices are managed on the template via the Variant
  Prices button
2016-08-19 09:55:18 +02:00
Srushti Patel 9e84bf8217 [IMP] sale: remove payment term taken from partner on sale report
Normally payment term of the partner is set on the OS. However if you change
this behavior by manually removing it you probably don't want to have it
reappear in your report.
2016-08-19 09:55:01 +02:00
qsm-odoo 7a77209149 [FIX] web_editor,website: stop closing web_editor dialog two times
This commit fixes two problems:

* Clicking on the save button of a web_editor dialog closed the dialog
two times because the button was created with the flag "close: true"
and binded to a handler which closes the dialog. This also prevented
to extend this handler by placing the this._super call in a deferred.

* Some web_editor dialog extended the save callback but forgot to use
the this._super, which prevents the "saved" event to be triggered
(currently not used anywhere but useful for custo and master).
2016-08-19 09:07:40 +02:00
dut-odoo 8972bbd226 [FIX] gamification: goal definition: traceback when changing model
* self.model_id is already a recordset, no need to re-browse it
* id are expected in domain, not recordset

oversight from rev 0c649644db
2016-08-18 21:31:48 +02:00
Yannick Tivisse 8c91d690f0 [FIX] mail: Don't display follower settings (fa-cog) if not follower on the record
Y
2016-08-18 17:53:22 +02:00
Martin Trigaux 2331bbf4b0 [I18N] update saas-10 translations by merging 9.0 and master
1. export saas-10 sources terms into .pot files
2. msgcat odoo-9 .po & odoo-master .po into saas-10 .po files
3. msgmerge saas-10 .po with saas-10 .pot files to keep relevant terms
2016-08-18 16:47:23 +02:00
Jainik Patel a4d7540ed9 [ADD] various: add missing icons for website apps 2016-08-18 16:45:38 +02:00
Pierre Masereel 36359f8d3e [FIX] stock: stock_warehouse resupply warehouse
* bad creation of a dictionnary with the dictionary comprehension syntax.
  correction of the syntax.
2016-08-18 15:49:52 +02:00
Haresh Shyara 0633bde576 [FIX] stock_account: stock_history report
* shadowing of "fields" import in the read_group function as it receives
  a "fields" arg. As we have to use fields.Datetime in this method,
  whe choosed to reimport it as "fieldsDatetime" to use it.
* cast not_real_cost_method_products.ids list to tuple, because
  psycopg2 only accept tuple for "IN" condition.
2016-08-18 15:48:49 +02:00
Thibault Delavallée 07a63ca22d [MERGE] event: improve emails sent by events and fix access rights issues 2016-08-18 15:33:23 +02:00
Jigar Patel 9f7d7c6809 [IMP] event: improve emails sent by event
* improve layout of confirmation and reminder emails
 * add default mails configuration on events: 2 reminders are added
   J-2 and J_15
2016-08-18 15:12:08 +02:00
Goffin Simon acc7449df1 [FIX] stock: action_done with moves with pack operation
When action_done is called with moves without pack operation, the pickings
linked to the computed moves must be in state done and the date_done must
be set on each picking.

opw:685145
2016-08-18 15:10:42 +02:00
Thibault Delavallée 6b87c731fb [FIX] event: fix access right issues
* Limitate rights of event user to reading an event

Event user should not be able to create events. Its rights should be limited
to reading events, creating and updating registrations. Only event managers
are allowed to create and modify events.

* Sudo access on ir.values in event config settings

Configuring events imply modifying auto confirmation parameter which is stored
into an ir.values. As this model is limited to values with user_id = uid we
have to sudo the access here as it is not a user-defined value.

* Add some tests for the various fixed issues
2016-08-18 15:09:40 +02:00
Thibault Delavallée 5916583885 [FIX] event: take contact data when changing contact
registration.onchange_partner_id() method updates registration contact data
(phone, email, name) based on the partner_id field. However the onchange
currently works only when no existing contact data is stored on the
registration. A second change of partner_id does not update the contact
data.

The condition is now inversed. This way when changing the partner, if it
has valid contact data, it will replace existing information.
2016-08-18 14:52:04 +02:00
Thibault Delavallée 450aa05cc6 [FIX] event: go to 1.0 (he deserves it) and fix typos in manifest 2016-08-18 14:41:36 +02:00
Damien Bouvy 08ed48e24c [FIX] stock,purchase: stop shortening picking type names
In purchase, a special key is set in the context to simplify the name
of the picking type: instead of the normal name, only the name of the
warehouse is used. This is problematic if more than one incoming picking
type exists for a given warehouse, as it prevents you from being able to
differentiate them. Asking users to modify the view to remove the
context key seem a bit too much to ask for something that should be
simple.

It is my understanding that this was implemented only for cosmetic
reasons, but I am willing to assume that having to select
"YourCompany: Delivery Orders" instead of simply
"YourCompany" for people who only have one picking type should not
be too disruptive or obscure.

opw-685751
2016-08-18 13:59:42 +02:00
Goffin Simon c0bb312a26 [FIX] warning: Products with Blocking Warnings can still be added to Sales Orders
Like in 8.0 when adding a product with a blocking message in a SO line, a warning
message must be raised and the product is not added.

opw:685928
2016-08-18 13:22:34 +02:00
Goffin Simon 0bfcf65200 [FIX] base: Individual contact gets Company icon
Steps to reproduce:
- Create a contact (Company).
- Create a "child" in this company.
- Select "Contact" as type of address.
- Create an individual child of the company.

Bug: instead of having the Individual icon (Human being), it gets the
Company icon (Building).

Fix: the behavior must be the same as in 8.0, the avatar must be used
for a contact which is not a company.

opw:683105
2016-08-18 11:19:07 +02:00
Goffin Simon c844534f8a [FIX] account_asset: asset depreciation with refund
When an asset is created from a refund invoice, the negative amount
must be taken into account to create the depreciation moves.

opw:685630
2016-08-18 11:11:49 +02:00
Martin Trigaux c73b2bd079 [I18N] export master source terms 2016-08-18 11:01:50 +02:00
Martin Trigaux a1a84834f9 [FIX] tools: correct typo in migration to new API
Avoid error during export of translation terms
2016-08-18 10:36:35 +02:00
Raphael Collet 16dece86b1 [MIG] openerp.report: convert to the new API 2016-08-18 09:32:45 +02:00
Raphael Collet d85bf78976 [MIG] openerp.tools.translate: convert code to the new API 2016-08-18 09:32:45 +02:00
Raphael Collet 1b59643d4b [MIG] openerp.service: convert code to the new API 2016-08-18 09:32:45 +02:00
Raphael Collet 41dbbe802c [FIX] add missing access rights on models 2016-08-18 09:32:45 +02:00
Raphael Collet 58cde6c2fb [MIG] openerp.modules: convert code to the new API
Also, convert function `init_models` to a registry method.
2016-08-18 09:32:45 +02:00
qsm-odoo baef529cbd [FIX] web_editor: keep all debug values for FieldTextHtml
Commit 89a4774c21 changed the kwargs
debug value of the FieldTextHtml controller to let it be equal to
"assets" instead of True or False. The problem is that an empty string
was considered True before the commit and False afterwards.

In fact, the original code was wrong and the debug value should equal
the already processed kwargs debug value in the HttpRequest object.
Indeed, the kwargs.debug value is equal to the URL value while the
request.debug value is already processed and is only one of the 3
values: None, True or "assets".
2016-08-18 09:27:05 +02:00
Nicolas Lempereur 06fdc2a6de [FIX] mass_mailing: body editor with translation
Since a324b22d, the mass mailing body editor would:

- save english body in language Y if user had language Y,
- not allow to edit translations in another language

This is due to how html_translate is set as translation function of html
only if the field is set as sanitize==True.

closes #13196
opw-685629
2016-08-18 08:31:24 +02:00
Fabien Pinckaers ecd9189684 [IMP] Allows to unlock a PO 2016-08-17 21:07:29 -07:00
Damien Bouvy 037a152db6 [FIX] project_issue_sheet: hide timesheets tab on issues w/o project
Since it is not possible to create a timesheet entry on a issue without a
project_id, the timesheets page in the form view should be hidden if no
project is set.

This prevents the user from trying to create a timesheet entry on the
issue and receive a not so transparent message like:
mandatory field is not set: [object with reference: account_id - account.id]
2016-08-17 16:37:44 +02:00
Nicolas Martinelli 354017b805 [FIX] mrp: duplicate product code
The BOM Structure report shows the product code twice.

opw-684520
2016-08-17 16:16:29 +02:00
Raphael Collet d32871570a [FIX] base: extrapolate table name on uninstall for ir_model_constraints
When uninstalling a module, the model *may* be removed from the registry
before the removal of the model constraints; to prevent crashing in
those cases, a simple replace('.','_') on the model name should allow to
obtain the table name in these cases.
2016-08-17 15:21:26 +02:00
Nicolas Martinelli 19e556b34f [FIX] website_form: traceback when sending an attachment
The form builder offers the possibility to add a "Custom File Upload"
field. When the user clicks on "Send", an error occurs ("An error has
occured, the form has not been sent.").

This is because we try to send a mail linked to "mail.mail", which
doesn't make sense.

The case was actually taken into account in the code, there was just an
oversight in the code.

opw-684040
2016-08-17 14:52:10 +02:00
Cédric Snauwaert 5b4404f628 [FIX] account: optimize the bank reconciliation widget + add of a button to auto-reconcile instead of auto-reconciling directly when opening the widget.
* This new button is a behavior change, but this is needed for big databases with a lot of statement lines to process. Indeed, in that case we prefer to load the widget as soon as possible and thus let the user process the lines manually or click on that button (but at that time he knows why it takes time).
* Opimization of various method in order to speed reconciliation and view opening : added indexes, direct use of sql queries...and also removed the code that was looping on open debit/credit to propose a sum of entries to match the statement line's amount, because it was a little greedy and wouldn't give accurate results most of the time.
2016-08-17 14:23:08 +02:00
Denis Ledoux 8787476b50 [FIX] web: fix DataSetSearch to avoid race conditions
This is a following of revision
ab8a93c852

This revision solves a new case:
when quickly performing a second search
after one which has not been resolved yet in a kanban view, and the second
search is resolved before the first, it was not possible to load the form
by clicking the card of the kanban, it leaded to a
`Could not find id in dataset` web client error

This was because the ids of the dataset were altered with
the ids of the first search (the one that lasted longer), while
the records displayed were the ones of the second search
(the one that finished first)

opw-682362
2016-08-17 12:26:16 +02:00
Cédric Snauwaert cda132bba5 [FIX] account: fix several problem related to exchange rate entries. Was PR #13162
When an exchange rate entries was created, fields `exchange_move_id` and `exchange_partial_rec_id` were not set on account_full_reconcile. which implies that when unreconciling entries we had the exchange rate entry that was not reconciled with its reversal move.

Another problem fixed is an infinite recursion loop that occured when trying to unreconcile entries with a `full_reconcile_id` and an exchange rate entry that is reconciled with more than one journal item. In that case, the unlink() of account.partial.reconcile has to be done before trying to reconcile the exchange rate entry with the reverse move otherwise as the exchange rate entry is still reconciled with another aml, `amount_residual_currency` is not correct and hence the program tries to create another exchange rate entry and loops.
2016-08-17 11:55:20 +02:00
Martin Geubelle 5fce7847e1 [FIX] purchase: fiscal position in multi-company environments
Properties depends on with which companies the records
are browsed.

When retrieving the fiscal position as sudo (from a cron), we should force
the company from the context.

After https://github.com/odoo/odoo/commit/4162b8f as the context is force in get_fiscal_position,
we should call this method with a company (and not pass the company in the context).
This has been forgot in https://github.com/odoo/odoo/commit/fe92dea

opw-684802
2016-08-17 11:51:50 +02:00
Nicolas Martinelli 717ca3390f [FIX] base_import: error message
During the import of a file, if the connection is closed (timeout,
server shutdown...), a traceback appears.

This is because `error.data.arguments` is not defined in this case.

opw-682104
2016-08-17 11:43:17 +02:00
Jeremy Kersten a4d8cf9ead [IMP] website_blog: allow to use publish date in future
Now, you can set the published date in the future.
There will be not visible by visitor until this date.

When a user publish a post, if the published date is in the
past, we update the publish date to now, else we keep the old
published date which one is in the future.
2016-08-17 10:32:57 +02:00