Commit Graph
881 Commits
Author SHA1 Message Date
kthe-odoo 40abf404c3 [FIX] project: fixed stat button in project.project form
Steps to Reproduce:

- Install Project App
- Go inside any  project and set the state of task as done
- Click on project burger menu and click on settings

Issue:

- The count on the stat button refers to count of all tasks

Causes:

- Reference of wrong field in the XML i.e ., 'task_count' instead of
 'open_task_count'.

Solution:

- Changing the field to reference it to open tasks count i.e., 'open_task_count'

task-3741260

closes odoo/odoo#153984

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-04-11 16:43:18 +00:00
lakhichand borse dccca8fe8d [FIX] project: fixes 'view task' is display once the task is saved in portal
Steps to reproduce:
- Open project share any project which has task.
- My account > project > open that project you can see task .
- Open any task and add new sub-task you can see once the sub-task is saved
  'task view' button is displayed.

Issue:
- Sub-tasks notebook > add a line > 'view task' is displayed at the creation but
  is then hidden once the task is saved.

Solution:
- Correct the attrs and change the condition in able to invisible 'view task'
  once the sub-task is saved

task-3602610

closes odoo/odoo#160117

X-original-commit: cd6ed7f9fd2e0654cfb0672d7a9536dca21035cf
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-04-05 14:01:07 +00:00
kcv-odoo b4985308b4 [FIX] project: fix milestone options issues in sub-task page
Steps:
- Install project app.
- Share a project which contains a task and
sub-task and project should have allow milestone
- Go to task form in project sharing.
- Go to milestone field of sub-task page.

Issue:
- Milestone field has can create and can open options
enable and because of that portal user able to create
edit or open milestone and which leads to tracebacks

Cause:
- There was no options added to prevent those attribute
from that field for project sharing views.

Fix:
- Added option to prevent those operation for project
sharing view.

Note: Add this options in blockby page in FW port.

task-3764782

closes odoo/odoo#160514

X-original-commit: 9b5da888af627e0d7efc8cdd49f41c023c79bb25
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-04-05 12:18:17 +00:00
lakhichand borse 9e0e04eeaf [FIX] project: fix name alignment when grouping by task stages
Steps to reproduce:
- Open the project in mobile view
- go to the kanban view enable task stages
- add one new staged with large name you can see name is
  misaligned

Issue:
- In mobile view task stage name is misaligned

Solution:
- Adding class in able to not overflow name in kanban view

task-3602610

closes odoo/odoo#160540

X-original-commit: 7403bd65fd50c51d3a114a50f812a6f3740faa87
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-04-05 06:03:46 +00:00
Dheeraj Pandey d845954fb9 [FIX] project: fix width field of the project sharing sub-tasks
Steps to Reproduce
- open project
- open project settings and mark task dependencies
- open task

Issue
 - The title is super far from the left.

Cause
 - Every field have the same width.
Fix
 - We fix the width of priority and state.

task-3761269

closes odoo/odoo#159949

X-original-commit: 96f225fee0e9b7b0213a5e63f261d3e8b8ace2bd
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-04-02 13:55:43 +00:00
padh-odoo 1e69238331 [FIX] project: fix allocated time label in portal
Steps to Reproduce
- open project
- create a project and allow timesheet
- open timesheet and change encoding method to days/half days
- create a task in the project and set allocated time
- open portal view of the task

Issue
- There is no label for allocated time.

Cause
- Condition was added in this commit 82a85d42c86cffcd6e96b0712c8ff9a221f25d87
  to show the label if encoding method is not in days.
Fix
- We apply the label for both encoding method of timesheet.

task-3761269

closes odoo/odoo#159939

X-original-commit: d7140c14d29d7e667a11dd0f92fe07117044feed
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Dheeraj Pandey (padh) <padh@odoo.com>
2024-04-02 06:01:51 +00:00
lase@odoo.com e108e5854c [FIX] project: show only active users as possible task assignees
Steps to reproduce:

- Go to the project application and click on any project with a task
- Hover over the task and click on the "assign button"

> inactive users can be assigned to the task

Cause of the issue:

Clicking on the "assign button" will call of the `name_search` method on
`res.users` to determine which user can be added as a task assignee.
Since the domain of the `user_ids` field of the `project.task` model:
https://github.com/odoo/odoo/blob/331d8451d9011aff6a8290c473a52fa77b30b358/addons/project/models/project_task.py#L169-L170
is override in the view:
https://github.com/odoo/odoo/blob/fcd66ee3321649405cf21bc1d625d71abf3d5819/addons/project/views/project_task_views.xml#L649
inactive users will not be filtered out due to the domain.
On the other hand, they could still be filtered out during this call
because inactive records should automatically be filtered out, during
the call of the `_where_calc` method, unless explicitely asked for:
https://github.com/odoo/odoo/blob/9134358b579361ef5d7e4da43d4778027564adc9/odoo/models.py#L5389
https://github.com/odoo/odoo/blob/9134358b579361ef5d7e4da43d4778027564adc9/odoo/models.py#L5091-L5093
However, since the `'active_test'` is set to `False` in the
context of the the `user_ids` field:
https://github.com/odoo/odoo/blob/331d8451d9011aff6a8290c473a52fa77b30b358/addons/project/models/project_task.py#L169-L170
the inactive records will also not be filtered out by the call of this
`_where_calc` method.

Note:

Prior to version 17.0, the flow worked "as expected" since the
context set in the `user_ids` was not properly taken into account
and inactive records were therefore filtered out by the call of this
`_where_calc` method. Thanks to commit c3e497f this context is now
relevant.

opw-3796425

closes odoo/odoo#158824

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-03-29 16:19:49 +00:00
mjvi-odoo 3dda5576ac [FIX] project: add domain in parent_id in convert task/sub-task form
- Instead of raising an error, we simply exclude sub-tasks of the current
  task from the domain of the 'parent task' field

task-3584963

closes odoo/odoo#143282

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-03-28 14:16:43 +00:00
mjvi-odoo 3219a17292 [FIX] project: resolve traceback task creation in project sharing
Steps to reproduce:
- In 'project sharing' create a task T in project A.
- Add 2 subtasks to task T in project A.
- Share project A in edit mode.
- Access the view form of task T as a portal user.
- Click on the subtask button to navigate to the tree/kanban view of subtasks.
- Select the kanban view.
- Create a new task on the fly, resulting in a traceback.

Issue:
- When a portal user creates a new task on the fly from the subtask kanban view,
  a traceback occurs, and the expected behavior of creating a new task Y in
  project A is not met. Additionally, task Y should not be a subtask of task T.

Solution:
- Resolve the traceback issue when creating a new task from the subtask kanban
  view as a portal user in project sharing.
- Ensure that the new task Y is correctly created in project A and is not
  set as a subtask of task T.

task-3584963

Part-of: odoo/odoo#143282
2024-03-28 14:16:43 +00:00
mjvi-odoo 210e93a8e2 [FIX] project: inability to save subtasks when project is added
Steps to reproduce:
- Access the 'project.task' module.
- Create a subtask.
- Attempt to save the subtask after adding a project to it.

Issue:
- Saving a subtask becomes impossible when a project is added, causing an
  obstruction in the process.

Solution:
- Rectify the functionality to enable successful saving of a subtask even after
  adding a project, ensuring a seamless process for subtask creation and
  association with projects.

task-3584963

Part-of: odoo/odoo#143282
2024-03-28 14:16:43 +00:00
Thomas Lefebvre (thle) 31cb1a5260 [FIX] project: remove partner_autocomplete assets
Issue:
------
The `partner_autocomplete` module is an automatically installed module.
This module is not included in the dependencies
and can therefore be uninstalled.

If `partner_autocomplete` is uninstalled and we go to a shared project
with a portal user for example, we get an internal server error,
as we don't have access to the `partner_autocomplete` files.

Solution:
---------
Remove the `partner_autocomplete` files from the manifest file
of the `project` module.

Note:
If the widget is not found (in the very rare case of uninstalling
the `partner_autocomplete` module), we will use the
default widget (and create a log).

opw-3774575

closes odoo/odoo#157965

X-original-commit: 65331aee3b7c74752aed23e136f08ff1fb5d282d
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
2024-03-21 13:10:29 +00:00
duongnguyen-viindoo fc34baedfa [FIX] project: project update description should be collaborative
we forgot to enable the feature in the description of project.update
model.

closes odoo/odoo#158257

X-original-commit: fedb0c6f4f79e762602185dee86ce8a558000783
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-03-20 23:15:37 +00:00
luve-odoo a568411cc8 [FIX] project : project stage column portal
When creating a sub-task from a task form view in portal, the domain of
the stage should exclude personal stages and include only the one of the
project.

taskid:3551354

closes odoo/odoo#156776

X-original-commit: 3be073e73b5866d7b5da8cc549146be5efb5d7d0
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-03-08 21:21:58 +00:00
Bastien (bvdn) bc430fdd6b [FIX] project(_todo): for todo only internal and active users should be selectable as assignees
decided to add the domain condition in the project.task user_ids field definition,
which means we can remove identical domains in views

Task-3698867

closes odoo/odoo#155044

X-original-commit: c6978c3fc4f828d970d45ebdaa4a35b44f3d09ce
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-02-23 13:10:05 +00:00
Jinjiu Liu 868d4f839a [FIX] web_editor: unneed size set when adding a row above a table
Reproduction:

1. In project -> task, create a new task
2. In the description, make a table of 1 row 2 columns, type two line
long string in the second cell
3. Create a row above, type anything short, save
4. Add the portal user as follower, e.g. search user joel
5. In an incognito tab log in with portal portal, check the task and the
table is out of the field

Fix: we should not fix the columns' width when create a new head row in
the table, for extra long table, it should be scrollable

task-3559104

closes odoo/odoo#154715

X-original-commit: 997b2f2817efe06ea37e5aca278507e0ef878635
Signed-off-by: Jinjiu Liu (jili) <jili@odoo.com>
Signed-off-by: Antoine Guenet (age) <age@odoo.com>
2024-02-20 14:57:31 +00:00
ilru-odoo 882c852603 [FIX] project: prevent auto-assignment of projects to sub-tasks
**Issue Description**:
From versions 16.3 to the master branch, a sub-task should never be assigned to a project automatically. However, when accessing `Sub-tasks` through the smart button and creating a new one, the context pass variable such as `'default_project_id': 4`. This leads to the sub-task being created with an assigned project immediately.

**Steps to Reproduce**:
1. Open `Project` app.
2. Enter any project, then navigate to any task.
3. Within the task, go to `sub-task` tab.
4. At the top center of the page, click on 'Sub-task' smart button.
5. Then, create a new sub-task using the 'New' button.
6. You will observe that the sub-task is immediately assigned to a project, which should not happen.

**Proposed Solution**:
By removing the passing of the default_project_id variable from the context when open a sub-task action, we ensure that sub-tasks are not automatically assigned to a project, as intended.

opw-3708537

closes odoo/odoo#154101

X-original-commit: c45ac4c9584f961ea0cdedffdf2b4bbe9058e8d9
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Ilya Rudy (ilru) <ilru@odoo.com>
2024-02-14 22:00:02 +00:00
Shubham Patel 17d7109bd8 [FIX] project: remove space between email alias and project title
Steps:
- Install project.
- Go to settings and select Custom Email Servers.
- Add alias domain.
- Then go to the project.
- Create a new project.
- The gap between the email alias and project title is too much.

Issue:
-When we create a new project the gap between the email alias and project name is too
 much when only the project is installed and there are no options to display. 

Cause:
-The "margin-top-4" taking much space.

Fix:
-After this commit the space between email alias and project name is decreased
 by changing the space.

task-3550638

closes odoo/odoo#153277

X-original-commit: b01b2f2f4d2e31648e3c98b8991eaafc886ca542
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-02-09 18:33:18 +00:00
suresh badikala 2af2d816f3 [FIX] project: fix project form view in mobile
Steps:
- In mobile install project
- Project.project form view
- Go to the project settings
- In Alias Domain(Custom Email Servers)
- The input alignment is not good

Issue:
- The input should go under the alias domain in project.project
  form view in mobile

Cause:
- Here they adding extra bootstrap class so that's why it will be
  showing in correctly

Fix:
- By removing the bootstrap class of 'oe_inline' the problem will be solved

task-3550702

closes odoo/odoo#151829

X-original-commit: 2819d6e076404140f5c26e76829a8f5bb171cf14
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-02-01 16:25:39 +00:00
Raja Prasad fbfeeba29f [FIX] project: fix space between progress bar and date
Steps to reproduce:
- open project updates of any project by clicking three dots
- add some update of project
- switch to mobile view

Issues:
- in kanban cards of project update, no spaces between progress bar and date

Solution:
- add some space between progress bar and date to  have  better experience

Task:3633405

closes odoo/odoo#145774

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-01-25 11:50:06 +00:00
Chrysanthe (chgo) 1c79cbe778 [FIX] portal: fix layout and spacing issues
This commit fixes some layout issues from the portal redesign.

The aims of this commit is to :

1) fix some issues with the column layout, mainly in the quotation section.

2) fix some spacing issues by using the right classes and better units.

3) fix the typescale and the information architecture with the right
heading tag.

4) fix some layout issues within the column layout and fixing unconsistent
layouts shared between different items.

5) fix an issue about the first information of the sidebar often
being hidden when scrolling, due to the sticky position of the sidebar

task-3651084

Part-of: odoo/odoo#147496
2024-01-24 10:44:35 +00:00
lakhichand borse b134cb60ae [FIX] project: make personal stages not clickable in task calendar
Steps to reproduce:
- Open the 'project.task.calendar' view.
- click on the date to open private task
- Observe that personal stages are clickable.

Issue:
- The personal stage should not be clickable in the 'project.task calendar' view

Solution:
- Disabled the clickable behavior for personal stages in the 'project.task
  calender' view

task-3637218

closes odoo/odoo#150133

X-original-commit: 48c5d2b7bc036fb530ab7f665894c30174cb2518
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-01-22 09:08:50 +00:00
Xavier Bol (xbo) 58b8b5c56f [FIX] project: use new field open_task_count to display open tasks in project
Before this commit, when the task_count is too huge, the number of
open tasks displayed in each kanban card of project returns `NaN` value
the reason is because, for instance, the number is 1026 and using `value`
will format the value and return `NaN` when the soustraction is made
between 2 numbers formatted (task_count - closed_task_count).

This commit introduces a new field called `open_task_count` to get
the number of open tasks and use it in the kanban instead of doing
the soustraction between `task_count` and `closed_task_count` fields
since we cannot really format the result.

closes odoo/odoo#149637

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-01-20 02:42:55 +00:00
Shubham Patel 5b284d4176 [FIX] project: project name is overflowing on the project kanban card
Steps:
- Install project.
- Go to the project.
- Create or edit the project name to excessively long.
- Then go to Kanban view.
- The project name would overflow.

Issue:
-Before this commit, in the project's kanban view, if the project's name was
 excessively long, it would overflow.

Cause:
-When the name is excessively long it would overflow out of the div element.

Fix:
-After this commit the name is now shortened by applying the 'me-5' Bootstrap
 class.

task-3676094

closes odoo/odoo#149007

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-01-16 20:17:52 +00:00
shiyam kumar ec75467cae [FIX] project: prevent editing status field in kanban view
Step:
- Navigate to the project module.
- Select any project.
- Click the status button on the Kanban view's top left.
- This action redirects to the project update Kanban view.
- Notice that the status field is unexpectedly editable.

Issue:
- In the project module, accessing the project update Kanban view allows
unintended editing of the status field.

Cause:
- Due to the new modifications made in the kanban view where the user is allowed
to perform selection from the view itself, the status field also resonates the
similar behavior.

Fix:
- By adding the 'read-only' attribute in the Kanban view specifically for the
status field, we can restrict the unintended modifications to this field.
This implementation ensures that users cannot edit the status field directly
from the Kanban view.

Task-3610481

closes odoo/odoo#144336

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-01-15 16:07:44 +00:00
Xavier Bol (xbo) b05c6df09a [FIX] project: unable to save the project for subtask
Before this commit when the user creates a task with a subtask and
save the form view and then go to the form view of the subtask and
set as project the same than the one set on the parent task, he cannot
save the form view. The reason is because the framework JS considers
there is nothing to save since in fact , the project set is the same
than the parent by default, it is just not displayed in the interface
thanks to the value of `display_in_project` field. The reason is
to be able to let the user choose if he wants to see the subtask in
the main views (list/kanban) of tasks linked to the project or just
below the parent task.

This commit fixes the issue by forcing to update the `display_in_project`
field even if it is not in the active fields since it is invisible
in the interface and only the widget set on the project field will
read and update it.

Steps to reproduce:
==================
- Install Project app
- Go to the project app
- Create project A
- Create a task inside that Project A
- Go to the form view of that task
- Create a subtask
- Save the form view
- Go to the form view of the subtask
- Set the project A as project for that subtask
- Save the form view

Current Behavior:
================
The form view cannot be saved because the framework JS considered
there is in fact, nothing to save since `display_in_project` is
not in the active fields and there is no force_save="1" set on the
field in the view definition.

Expected behavior:
=================
The form view should be saved.

closes odoo/odoo#149035

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-01-11 17:00:53 +00:00
padh-odoo 1263127f0f [FIX] project: fix project task count in kanban view
issue:
Currently, the project task count in kanban view calculates all closed and
opened task.

cause:
In this commit 03235ae  in task count both closed and open task considered.

fix:
In project kanban view we only show task count for open task.

closes odoo/odoo#148641

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2024-01-10 08:50:56 +00:00
Levi Siuzdak (sile) e5f1c3dc71 [FIX] project: display project on task card in calendar view
Versions:
---------
- 16.4
- 17.0
- master

Steps:
------
1. Have a project with tasks with deadlines;
2. go to My Tasks;
3. open calendar view;
4. select a task.

Issue:
------
The task's project field is empty.

Cause:
------
Commit fb88a7448c added the
`display_in_project` field for tasks. The `project` widget uses this to
decide whether to display the project. As this field hadn't been added
to the calendar view yet, it defaulted to `false`, so projects don't
get displayed.

Solution:
---------
Add `display_in_project` to `view_task_calendar`.

opw-3672339

closes odoo/odoo#148582

X-original-commit: 0139cbeb03c6f36ccb6bddda716e3d43b9fb541c
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Levi Siuzdak <sile@odoo.com>
2024-01-10 07:27:03 +00:00
qsm-odoo c96760a76b [FIX] *: avoid translating CSS classes values
*: project, survey, test_website, website_event, website_sale

This commit fixes all found occurrences of such a case:
```
<t t-set="classes">some_classes</t>
```
=> CSS classes being marked for translation by mistake.

A breaking case was found via task-3636009, where the arabic language
has a translated class on some element which makes some JS crash
because of it.
Steps to reproduce (only for 17.0):
- Create a website with the "Arabic" language as the default language
- Go to the shop page in Arabic
- If you are in grid view, click on the "switch to list view" button and
  if you are in list view, click on the "switch to grid view" button
=> Crash

Note that commit [1] already did something similar a while ago (but
more generically than this commit). In this commit here, broken
occurrences were found using this regex:
```
<t\s+t-set=["']\w+lass(es)?["']\s*>
```

[1]: https://github.com/odoo/odoo/commit/98678199a32b3ba9af999f76980a6110546ec0fc

task-3636009

closes odoo/odoo#147688

X-original-commit: 01b223e3043a3d847fd7dbf8997edcee62c3254a
Related: odoo/enterprise#53463
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2024-01-04 22:03:50 +00:00
Hugo Carlier (Huca) e9127a9fdf [FIX] project: remove onchange on date/date_end for projects
Steps
=====
- Install module project
- Open the form view of a project
- Set a planned date
- Click anywhere on the page to remove the focus from the date picker

Issue
=====
The chosen date disappeared without any explanation to the user

Cause
=====
odoo#123268 introduced some changes related
to the planned dates of projects.
1. the write method is modified to avoid the write of only a start/end
date (both date should be set or none of them)
2. a required is added on the start date field in the form view of
project
3. an onchange is added to avoid to have one of both field set and not
the other

This last change is problematic as it overrides the required behavior of
the date fields.

On top of that, https://github.com/odoo/odoo/pull/143509 changed the
behavior of the datepicker widget that only display the full range by
default if both fields are required (which is not the case here if they
are empty).

The combination of those changes have the consequence that the planned
date field is unusable in the form view of projects.

Fix
===
The onchange being only useful in form view, it is deprecated as the
required attribute is sufficient for this usecase and provide the user
warnings if he forget a field. On top of that a required attribute is
also set on the end date field.

task-3628069

closes odoo/odoo#145167

Related: odoo/enterprise#52280
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
2024-01-03 10:58:02 +00:00
Nasreddin Boulif (bon) 26314ddf4f [FIX] project: display avatar in 'my tasks' page
Steps to reproduce:

 - Install Project module
 - Login as admin
 - Create a task an assign it to admin
 - Go to 'My Tasks' page (`example.com/my/tasks`)

Issue:

  The avatar of assignee is not displayed.

Cause:

  Using a row over two elements that are already in a table.

Solution:

  Add `px-0` bootstrap CSS class to the avatar.

opw-3592972

closes odoo/odoo#147369

X-original-commit: fc94a19c3ae66765a2f814533c17d6ec0f9533fb
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
2023-12-26 20:37:09 +00:00
Victor Piryns (pivi) 170f09c118 [PERF] project: invert domain on task closed states to hit index
Description:
Indexes on a Selection field are never used in a `NOT IN` where clause,
as PostgreSQL doesn't have the complementary values (in DB a Selection
field is just a VarChar) to make use of an index on the field.
The ORM currently doesn't invert
`not in <selection>` -> `in <complement of selection>`.

Benchmark:
Positive impact in the project modules all around, specially for long running
projects where the proportion of "done" tasks are >90% of the
project's task. On a populated project with 10k tasks, 200 of those are
open, there were around 10x improvement on the requests linked to
rendering the kanban view of the project. More elaborate benchmarks are
available in the referenced task.

Reference:
task-3576802

closes odoo/odoo#146168

X-original-commit: 403a7c78f06f6b99233e6fc045bde67f0c670702
Related: odoo/enterprise#52708
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Piryns Victor (pivi) <pivi@odoo.com>
2023-12-13 17:12:00 +00:00
Adrien Widart (awt) 448f36ec4d [REV] project: cancel view changes
Revert [1]

Changing `t` into `span` is not allowed in stable, in case some
customization already exist and have xpath that target `t`. The
change OE side [2] is problematic too: if a DB has the old XML version
(`t`) and the user tries to install `industry_fsm`, an error will be
raised:
`Element '<xpath expr="//span[@t-if=&#39;record.partner_id.value&#39;]">'`
`cannot be located in parent view`

[1] b3e3c92b52
[2] odoo/enterprise@094009669b

OPW-3629163
sentry-4700256130

closes odoo/odoo#146094

Related: odoo/enterprise#52682
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-12-13 11:57:10 +00:00
Gurupreet Singh 5b51757c59 [FIX] project: duplication remove
The issue of the start date appearing before the task name in the project task
list view is caused by a duplication of the company_id in the list view
definition. Consequently, this problem is linked to the task with ID 3213526.

task-3468392

closes odoo/odoo#145856

X-original-commit: ff384b259808f3106daea7de685f5501c13ebf2d
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-12-12 23:08:51 +00:00
Manushi Shah (mash) 74c80cee6c [FIX] project: resolving validation error in quick create
Steps:
- Open Project
- Go to Tasks > My Tasks or All Tasks
- Create New Task
- Create Project from Quick Create
- Clicking on Save,  will give a Validation Error

Issue:
- Validation Error is raised and thus, we aren't able to add the project and
thus creating a task.

Cause:
- Due to the addition of context, the default_type_ids isn't obtained, and thus
the SQL error occurs as the name of the task stage isn't set which is a mandatory
field.

Fix:
- removing the context from the form view of Quick Create and set the stage

closes odoo/odoo#145599

Task: 3378510
X-original-commit: 83119d5de49ae69d08a0f798453d9c5c56b2276a
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-12-11 08:29:21 +00:00
Prakash Prajapati 37e1e18284 [IMP] web, project, (_todo): add hide_label options in the state_selection in all view
If someone wants to show the label of the state_selection field then
it can be shown

like-
 <field name="xxx" widget="state_selection" options="{'hide_label': False}"/>

task-3475416

closes odoo/odoo#136901

Related: odoo/enterprise#48060
Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
2023-12-08 15:57:43 +00:00
Manushi Shah (mash) b3e3c92b52 [FIX] project: prevent name overflow in kanban view
Steps:
- Open Settings > Users
- Change the name of the user by typing it multiple times
- Open Project > Choose a Project
- Create a task with the assignee as our user
- Now open the Kanban view of the Project, where we have the task stages.

Issue:
- In the Kanban view, we can see the name of the assignee overflowing.
(This same issue is also present in Project Sharing)

Cause:
- The text is not truncated due to which the name overflows.

Fix:
- adding the class text-truncate and d-block to correct it

closes odoo/odoo#144492

Task: 3383519
X-original-commit: 93d0b7bb81cf9c682a46626323f4baee9b808cfb
Related: odoo/enterprise#52012
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-12-04 13:23:32 +00:00
Victor Piryns (pivi) 36cd3ec68c [PERF] project,*: download smaller avatars in portal view
Description:
Portal routes `/my/tickets` or `/my/tasks` were reported slow to
load with many items.

Analysis:
The avatars that are loaded are of too large sizes (encoded in base64)
compared to their rendering size. `img.o_avatar` limits the
dimensions to `1.7145em` (roughly `27px` on desktop), so it's
useless to load `avatar_1024` for those image sources. This has a
significant impact when the user has a slow connection, the server
is hosted far away from the user, or the images used are of badly
compressed (so each images takes a quite a few MiB).

Fix:
Scan for all instances of the usage of `avatar_1024` on an `<img>`
with the class `o_avatar` and reduce it to `avatar_128`.

Reference:
opw-3470171

closes odoo/odoo#142103

Related: odoo/enterprise#50678
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-11-16 11:44:55 +00:00
Ritika Rathore b34c04a7c1 [FIX] project: fix hover on the assignees of a task portal
Steps:
- Install Project & Website
- Go to Website Module
- Click on Tasks
- Now on hover multiple assignees

Issue:
- On the hover of the mouse, this problem appears when we are viewing multiple assignees .

Cause:
- There is list in which we mapped assignees & reading from the 1st index.

Fix:
- List execute from 0th index in assignees list.

Task-3495253

closes odoo/odoo#141430

X-original-commit: 61ac7a392eca48b978c9aeb8575c3509607366b1
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-11-10 10:18:10 +00:00
Xavier Bol (xbo) 349915dfc3 [FIX] project: hide name field in project list view
The name field has been to be able to order on it but it is added
and just invisible instead of completely hide the column.

This commit changes `invisible` attribute to `column_invisible` to
completely hide that field in the project list view.

closes odoo/odoo#141455

X-original-commit: 62f49331ba
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-11-08 04:09:50 +00:00
Ritika Rathore d5b40f0007 [FIX] hr_timesheet,project: fix visibility of fields in portal
Steps:
- Install project, timesheet & website
- Open project module
- Select any task
- Set Allocated Hours
- Go to the task corresponding project & disable the timesheet
- Then appear in portal form view

Issue:
- In portal form view of project's task the 'allocated time' and the 'progress' fields shouldn't be visible if the 'timesheets' feature is disabled on the project.

Cause:
- There is no any condition for allocated time  and progress field.

Fix:
- Added condition for both field in hr_timesheet & project respectively.

Task-3495253

closes odoo/odoo#141357

X-original-commit: 58040fed8b075b40cf6d2be73de53b600bf9f94d
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-11-07 08:01:01 +00:00
Pierre-Yves Dufays 9ce9d69788 [IMP] project: allow to create project plan directly from project module
The new plan form view in project module now allows to choose between project
and task as target model.

Task-3558929

Part-of: odoo/odoo#138998
2023-11-06 15:36:45 +00:00
MerlinGuillaume 62f49331ba [FIX] project: add name field in project list view for order
When we add a many2many field related to Project, an error is thrown
when we add 2 or more projects

Steps to reproduce:
1. Install CRM, Project and Studio
2. Go to CRM and open any quotation
3. Trigger Studio
4. Add a many2many field related to the Project model
5. Close Studio
6. On the CRM form, click on Add a line and select 2 projects, the 2
   projects must have the same sequence (new projects will have a
   sequence of 10)
7. An error is thrown

Problem:
The "name" field used in the order of the list view for project was not
present in the view so there was an error when trying to sort the list
by this field

opw-3526101

closes odoo/odoo#140950

X-original-commit: 334e6fc41725fe0bd7e6bae8e2153c6abedc71cf
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>
2023-11-04 06:43:14 +00:00
Elisabeth Dickinson 89082fbd56 [IMP] web, *: fix favorite alignment
*: account, hr_recruitment, project, lunch, mrp

By removing the absolute positioning on ".o_favorite" inside kanban
views, we allow it to align naturally with the rest of the elements,
thus removing the custom code that was needed for padding.

By doing so however the icon - which is now only visible on hovering the
card in the Project's kanban view - should remain visible at all times.
The behaviour would be the same as in other kanban views: an outlined
star when not active and a full yellow star when it is.

The margin on the kanban heading in the Manufacturing orders has been
removed to realign the top elements.

task-3462098

closes odoo/odoo#131559

Signed-off-by: Pierre Paridans (app) <app@odoo.com>
2023-11-02 12:03:40 +00:00
Hugo Carlier (Huca) 2236e5c97c [REF] project, project_todo: refactor personal stages
Personal stages of project.stage records are based on two main field:
- personal_stage_type_ids: the list of all personal stages linked to a
  task (M2M)
- personal_stage_type_id: a computed field (not stored) indicating the
  personal stage of a task for the current user.

When reading a set of project.task records grouped by personal stages,
two options are possible:
- Group the records by personal_stage_type_id (approach used in former
app Notes): in which case the read_group method has to ne rewritten as
it can be used on a non-stored field.
- Group the records by personal_stage_type_ids (approach used in app
Project) in which case, the kanban view has to be overriden to be able
to drag and drop a task between personal stages (which is not possible
by default, when grouping according to a M2M field).

The main evolution proposed by this refactor is to use an hybrid
approach that would:
1. Group the project.task records by personal_stage_type_id
2. Use the read_group with groupby set to 'personal_stage_type_ids' as
this should give the same result.

This would allow to:
- Avoid a complex and costly (performance wise) read_group override
- Avoid an override of the kanban view that is costly to maintain
- Simplify the implementation (and thus readability) of personal stage
management (among which, removal of the model
project.task.stage.personal).

task-3345132

Part-of: odoo/odoo#140050
2023-10-27 14:22:12 +00:00
Maryam Kia 9c8d39d1a8 [IMP] account, helpdesk,...: same title for all portal chatters
By this commit, all portal chatters have a same title as `Communication history`

closes odoo/odoo#139735

Related: odoo/enterprise#49566
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2023-10-27 13:02:10 +00:00
williamandh4818 dc696c8ed4 [IMP] analytic: allow cross analytics
Purpose
=======

Make it possible to compare analytic values between plans by inputting
up to one account per plan on each line.
For instance, if we have 2 plans: "Country" and "Product Type", with the
following accounts

| Country | Product Type |
| ------- | ------------ |
| BE      | Drinks       |
| LU      | Food         |

And the following invoices:
* 1000€ of drinks in Belgium
* 2000€ of food in Belgium
* 3000€ of food in Luxemburg

We want to be able to display the following pivot tables:

|     | Drinks | Food | Total |
| --- | ------ | ---- | ----- |
| BE  |   1000 | 2000 |  3000 |
| LU  |      0 | 3000 |  3000 |
| Tot |   1000 | 5000 |  6000 |

|        | Total |
| ------ | ----- |
| Food   |  5000 |
| * BE   |  2000 |
| * LU   |  3000 |
| Drinks |  1000 |
| * BE   |  1000 |
| Total  |  6000 |

Implementation
==============

* `ir.fields` are added/removed dynamically on `account.analytic.line`
* Each analytic plan corresponds to one field on `account.analytic.line`
* The fields are added dynamically in the views.
* `account.analytic.plan` doesn't have a `company_id` field anymore,
  meaning that all the companies have access to all the plans. This
  means that the applicability fields and lines are now company
  dependent, and those can be used to know which fields/plans to display
  for which company.
* There can no longer be one "Project" plan per company, even if the
  accounts of that project can still be owned by only one company.
* There is now only one method to get the default (or "Project" plan),
  which is `_get_plan_columns`

task-3497653

closes odoo/odoo#139225

Related: odoo/upgrade#5306
Related: odoo/enterprise#49226
Signed-off-by: William André (wan) <wan@odoo.com>
Co-authored-by: william <wan@odoo.com>
Co-authored-by: h4818 <ayh@odoo.com>
2023-10-25 18:10:57 +00:00
Chrysanthe (chgo) df8535fbd4 [REF] portal, *: portal redesign
*: base, account, account_payment, auth_top_portal, hr_timesheet, loyalty,
   mrp_subcontracting, payment, project, purchase, sale, sale_stock,
   sale_timesheet, website_crm_partner_assign, website_sale,
   website_slides

Portal general redesign. Increase visual consistencies with the backend
[1] and adapt to the new default website design [2].

[1] https://github.com/odoo/odoo/pull/116641
[2] https://github.com/odoo/odoo/pull/120302

task-3046004

Part-of: odoo/odoo#138077
2023-10-25 15:50:36 +00:00
Thibault Delavallée c68ddce1b9 [IMP] various: update alias management in views
PURPOSE

Allow alias domains to be multiple, notably to be used in a multi company
environment where each company has its own alias domain.

SPECIFICATIONS

Update fields used in form views. Use 'alias_domain_id' instead of domain
that is now simply a related on 'alias_domain_id.name'. To ease UI we add
a placeholder on this field as it is now writable e.g. in multi domains
environment. Avoid unwanted configuration change by making it generally
no_open / no_create_edit.

In project, remove an unnecessary field adding complexity for few real use
case now that aliases are more open to configuration.

Task-36879 (Mail: Support Multi Domains Aliases)

Part-of: odoo/odoo#76734
2023-10-24 19:24:50 +00:00
Adrien Dieudonne a2016359d0 [REF] web, *: avoid extend on h5 for kanban card title
´extends´ generates a lot of css rules.

So in this commit, we remove it by replacing it by the ´h5´ html tag.

closes odoo/odoo#139484

Related: odoo/enterprise#49408
Signed-off-by: Romeo Fragomeli (rfr) <rfr@odoo.com>
2023-10-24 13:55:30 +00:00
Adrien Schoffeniels 31af631607 [IMP] *: add properties fields to various models
Purpose:
--------
This commit adds properties (and related properties definitions) on the
following models:
- hr.employee (hr.department)
- hr_recruitment.hr_applicant (hr_recruitment.hr_job)
- product.product (product.category)
- stock.picking (stock.picking_type)

These have been added to the related form, kanban and calendar views when
applicable.

Properties have also been added to kanban and calendar views of
- crm.lead
- event.event
- project.task
(Properties had already been added on these models and form views)

Task-3458627

Part-of: odoo/odoo#132578
2023-10-20 11:21:56 +00:00