Purpose
=======
Properly compute portal_readonly_mode to also take into account portal
users, so the template is properly rendered for them.
closesodoo/odoo#92850
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
When the cron is fetching the xml from the database, an empty invoice
with the xml as an attachment is created. The reason for this is so
that, if the import fails, there is at least a file accessible on the
invoice for the purposes of debugging.
When the cron's fetching function loops through the proxy users for each
company, fetching the results from the proxy server for each company in
turn. However when the empty invoice is created, the company is not
provided, and thus the context company is used (that of the cron), which
is not necessarily correct. This commit uses the company of the proxy to
create the empty invoice (which in turn selects the correct journal etc.
for the empty invoice).
closesodoo/odoo#92830
Ticket-id: 2854284
X-original-commit: a19cdf82f3276f84fba2961fbd82a5a1a2f7844e
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Daniel Kosky (dako) <dako@odoo.com>
Steps to reproduce the bug:
- Enable “Product Packagings” in the settings
- Create a storable product
- Set the company field
- Go to the inventory tab:
- Click on add packaging
Problem
The company field is not set automatically
opw-2864554
closesodoo/odoo#92826
X-original-commit: 79223022e79a95c9c1f7d6307c48866a0f9a13ef
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
Current behavior:
In the PoS if you add a tracked product that uses "kg" as uom
and change the quantity to any float value. After that if you try
to modify the lot number you get an error.
Steps to reproduce:
- Have PoS installed
- Create a tracked product that use kg as uom
- Open PoS session
- Add the product to the order and modify the quantity to any float
value
- Click on the green lines to edit the lot number
- You get an error
opw-2861426
[FIX] point_of_sale: float_serial
Current behavior:
Steps to reproduce:
opw-2861426
closesodoo/odoo#92722
X-original-commit: 0aff8bb9484a23c0d875d3b12259dd4e0d51e716
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Engels Robin (roen) <roen@odoo.com>
In the sale_signature tour, there was a step for entering auto mode when
signing for a payment. Since now the auto mode is selected by default,
it's not necessary to set it anymore.
task-2862209
closesodoo/odoo#92340
Related: odoo/enterprise#27793
Signed-off-by: Arnaud Joset <arj@odoo.com>
In order to make the process of signing faster, automatic mode should be the
default one. This commit implements this behavior and adds tests for it.
task-2862209
Part-of: odoo/odoo#92340
Applies various small changes:
- [IMP] stock, stock_account: add dates to stock move name (inventory adjustments)
- [IMP] delivery,stock: add pack type weight
- [IMP] {purchase, sale}_stock: add Incoterm Location field
- [IMP] stock_picking_batch: default show Batch Transfer
- [IMP] purchase: add supplier info with sudo qty 1
- [IMP] sale_purchase: add related PO warning
- [FIX] product: order product labels by product
- [IMP] product: default filter vendor pricelist w/ active products
- [IMP] stock: relax picking locations readonly states
- [IMP] stock: add consumables replenish button
- [IMP] stock_picking_batch: pick type auto batch not active by default
- [IMP] stock: add stock quant import template
- [FIX] sale,stock,mrp,purchase: add uom precision
Task Id: 2764771
COM PR: odoo/odoo#91640
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Signed-off-by: Tiffany Chang <tic@odoo.com>
This commit contains the following:
1) Added sudo to product record when adding supplier info during PO confirm, so that
supplier info is created regardless of who is confirming the PO.
2) the test test_multicompany_partner_bank was removed since it was creating two
res partner banks with the same partner and setting company_id to two seperate companies
while currently the company_id is related to the company partner thus this can no longer
happen.
3) test_message_qty_already_received was changed to not set the company_id explicitly as
it caused unexpected cache miss in the runbot.
task : 2764771
Part-of: odoo/odoo#91640
Steps to reproduce:
just be sure you activate "packages" from the Inventory settings and you can find that button on a picking. Inventory dash > Operations > Transfers > Form view
Solution:
Add the hotkey
The choice has been made as following:
- not used in stock.picking
- used in other models
https://docs.google.com/spreadsheets/d/1QIPwUiEDv37H1P_FjN-WctzPey2Niu6K5dCL157Z8BY/edit#gid=0
opw-2858629
closesodoo/odoo#92838
X-original-commit: 73ab94402878a16c34c0e131818ffc0d2e8da3da
Signed-off-by: Adrien Widart <awt@odoo.com>
Signed-off-by: yosa-odoo <yosa@odoo.com>
Currently, the currency conversion rate used is based on the accounting date on invoices and bills.
According to partner feedback and the official documentation we should use the exchange rate on the invoice/bill date.
Moves that are not invoices or bills should still use the accounting date.
closesodoo/odoo#87984
Task: 2807136
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Problem: open any (multi record) view, open the "favorites" menu and
select the import action. The import client action now opens, but no
button is visible in the control panel.
Since a recent owl update, the import client action did not display its
control panel buttons (upload file, cancel, ...). This is caused by an
unfortunate situation: the control panel buttons are rendered, but after
the control panel was rendered, so owl does not add them in the DOM. It
worked by chance before: the props were completely reactive, and the
code actually modifies in place some object received in props. So, a
render was forced on the controlpanel, which means that it properly
picked up the buttons.
Now, this render was accidental, so the new owl code is actually
correct. This commit fixes the issue by simply rendering the buttons
before the controlpanel is even rendered, so it now works as expected.
closesodoo/odoo#92810
X-original-commit: f185f543452abf65b9948e907aeb45e918cf3bed
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Géry Debongnie <ged@odoo.com>
Steps to repdroduce:
- In Reconciliation Models create a new rule
- Add two new lines with a "From Label" type and respectively set the "Amount" field to:
Koerperschaftst.{5,10}\s([\d\,\.]+)
Solid.Zuschl.KSt.{5,10}\s([\d\,\.]+)
- Change the "Decimal Separator" to a comma ","
- In Bank statement, create a new one with the following label:
Stnr 330/5707/3700 Koerperschaftst. 1.Vj.22 1.250,00 Solid.Zuschl.KSt 1.Vj.22 50,00 - FOLGELASTSCHRIFT
- Reoncile by using the button corresponding to the new rule
Issue:
-> "1.250,00" won't extracted contrarily to the "50,00"
Cause:
In: https://github.com/odoo/odoo/blob/affdd8d6276cb3c3aea9b994fa2427a6e97de691/addons/account/models/account_reconcile_model.py#L353
Our scenario: float("1.250.00") -> will throw an error
Solution:
Clean the match group to only keep the numebers and the decimal_separator
opw-2794209
closesodoo/odoo#92827
X-original-commit: d4da8be3669fbfdfdcad752af1f0311accaf34a3
Signed-off-by: William André (wan) <wan@odoo.com>
Could not actually reproduce problem locally.
Looking at the logs, the randomly failing tests seem to be related to
the effects of some previous steps not having been applied even though
the test did proceed further.
This commit introduces intermediary checks to make sure that the effect
of each step is fully applied before proceeding to the next one.
runbot-3171
runbot-3172
runbot-3629
runbot-3630
runbot-3778
runbot-3779
runbot-3859
runbot-3860
closesodoo/odoo#92816
X-original-commit: 2d47b78e677f5046214cb2c8613eeb510753076d
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This will reduce memory leak size in tests. But the proper fix should be lower
level in the code (probably in Owl according to the stack) to ensure unnecessary
references aren't kept anymore.
Part of task-2850875
closesodoo/odoo#90934
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This will reduce memory leaks in tests.
Indeed `destroy` is not a standard service method, it must be called manually.
And references to messaging service were unnecessarily kept in env.
Note: ideally everything should be cleaned this way, not just messaging code.
In other words, env itself should have no retainers at the end of each test, but
completely removing all of them is a much bigger work that is outside of the
scope of this PR.
Part of task-2850875
Part-of: odoo/odoo#90934
This will reduce memory leaks.
Side-effect of this PR:
Accessing a field after the record is deleting is no longer supported. It was
never meant to be, but some async code relied on this behavior to check the
(non-)existence of relation fields, with an implicit check on the current record
existence.
-> After this PR, the existence check of current record needs to be explicit,
before accessing any field.
Part of task-2850875
Part-of: odoo/odoo#90934
Before this committ:
- Stats buttons were hidden when records are zero
- Some wordings were insignificant
- Existing filters don't allow us to check blocked, blocking and tasks soon in overtime and some other information
- Product form fields need some changes in their order
After this commit:
- All stats button are displayed when records are zero
- Wordings fixed
- New filters added to check blocked, blocking tasks and tasks in overtime soon
- Fields were rearanged
task-2726465
closesodoo/odoo#82253
Related: odoo/enterprise#23257
Related: odoo/upgrade#3185
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
In this commit, we improve the load-in-the-background
feature of partners/products.
If there are items that are not loaded yet, (either because the
background loading is still running or because the user did not
want to load any prodcts at all at the start of the session)
the option to fetch items from the database is enabled: every
time the user interacts with the search bar (pressing "Enter",
"Search database" or the "Search" icon at the search bar) the
backend is queried and new items (products/partners) are fetched
and added to the frontend. Before the fetching of products from
the backend was done using the "database" icon / "Load Customers"
button which are now dropped.
In this commit, the feature of querrying the database
is automatically disabled once all the partners or
products (available_in_pos) have been loaded in PoS.
Then, the querying of the backend stops.
task-2755384
closesodoo/odoo#81226
Related: odoo/enterprise#23544
Signed-off-by: Masereel Pierre <pim@odoo.com>
Before this commit, the toast Notification would apprear
center aligned only for some screen sizes. In this commit
we adjust it so that is displays properly for any screen
size.
task-2669747
Part-of: odoo/odoo#81226
In this commit we enlarge the info button
on the top left corner of a product item
so that we make it more usable for small
screens.
task-2669747
Part-of: odoo/odoo#81226
In this commit we make the search bars of the
PartnerListScreen and the ProductScreen more
usable, taking into account their external
layout in desktop & mobile version alike.
In detail, we find a way to better expose the functionality
of fetching from the backend using the "Search" icon of the
search bar. This was previously exposed by the "db" icon at the
product search bar and "Load Customer" button at the
PartnerListScreen which are both dropped in the current
commit. The new way of interacting with the search bars includes:
A) click "Search" icon (previously idle): "deep" search,
query the backend db and fetch results (if not all products
/partners are already loaded).
B) click "Cross" icon: clear the search input/text.
To facilitate the user interaction with the search bars,
we implement proper messaging that is displayed to the
user: Product <prodcutName> was not found .etc.
Also, we add a highlighed button "Search database"
that is conditionally displayed and prompts the user
to search the database for more results (if applicable).
Previously the automatic selection of a partner/product
when it was the only search result happened when the user
pressed "Enter" and was considered to be a "hidden" feature.
Now, insted of selecting automatically we diplay a toast notification
to notify the user about the newly fetched results from the database.
With these changes we improve the intuitivity. We also drop the error
message when the search result is empty. That was very nerve-racking
feature for the user.
task-2755384
Part-of: odoo/odoo#81226
Before, the cash move popup was overlapping with
the virtual keyboard in some devices. In this
commit we address the above issue by displaying it
higher at the screen.
Added to this, we make the popup more usable by changing
the order of the confirm and cancel buttons. Confirm
button goes to the left (to comply with Odoo standards)
and is marked as primary (green). We also make the
"Cash out" button red, just to make it more distinctive
for the user.
In addition, we add 2 features to make the use of the
popup more intuitive:
1) when the user selects the "Cash out" option,
the input is prefixed with a '-' sign. When the user
selects the "Cash in" option the '-' sign disappears.
2) when the user presses '-' from the keyboard we
toggle the state of the popup from "Cash in" to
"Cash out" and vice versa.
Finally, we make it simpler for the user by
making it not draggable.
task-2669747
Part-of: odoo/odoo#81226
Before, when the amount due of a customer changed, the user
had to press the "rotating arrows" icon at the client list
screen in order for the the updated quantity to be displayed
properly.
This icon was confusing for the user and was burdening the UI
with not frequently used behaviour. Instead, in this commit,
we incorporate the `refreshTotalDue` logic in the payment
workflow so that it is updated automatically when the total
due of a client changes.
task-2669747
Part-of: odoo/odoo#81226
In this commit we follow a set of changes to
simplify the view of PartnerListScreen.This includes:
- directly select a parnter by clicking on them
- rename "EDIT" to "DETAILS" and display always
- use short address
- add company name below the partner name (if any)
- searching by company name is possible
- merge phone and e-mail in one column
- merge loyalty points and total due in one column
- save automatically selects the partner
- header buttons are reordered
- selected partner is displayed first
- selecter partner has an "unselect" tag
- visual imporovements (lowlighting etc.)
- move "settle due" button and "more info" link
into details edit
These changes expose less info to the user and
take some burden off the UI. Also, by selecting
a partner directly when clicking on them we follow
the "make the common case fast" design principle.
This way, the main action of the screen is accomplished
in 1 click instead of 2.
task-2669747
Part-of: odoo/odoo#81226
Because of the change in order of operations, for the main company
when we install e.g. l10n_ec, the CoA installed is the Ecuadorian
one, which makes the fiscal country EC, but the country_id still US.
We suspect https://github.com/odoo/odoo/blob/7cb109e7b0ee2e46cef79ec7d3076d16715567f9/addons/account/models/chart_template.py#L278
for the change in behaviour as the generic coa does not have US as
company anymore and that somehow led for the sales journal to
require to use document types. (there we use the fiscal country which
is set to Ecuador)
The solution anyhow here, is that for the demo data, we should
use the fiscal country as well to see if we need to add the
document type to the demo invoices or not.
closesodoo/odoo#92772
X-original-commit: 40dab08559d5b4c837589ce96d6d7ce23f14fd98
Signed-off-by: William André (wan) <wan@odoo.com>
Added debugTestId url searchParam that executes that test in debug mode.
While in debug mode, one can fully interact with it, and the console logs
the test's internal state.
closesodoo/odoo#92770
Signed-off-by: Géry Debongnie <ged@odoo.com>
Steps to follow
- Use chrome
- Connect to a runbot with the demo account
- After a couple refreshes, the mail.MessagingMenu isn't displayed
Cause of the issue
The navbar should be updated when there is a new item added to the systray registry.
For that, the navbar listen to the update event with the `useBus` function.
`useBus` itself uses `useEffect` which only starts listening after a component has been mounted/patched.
-> The update callback is never called in this case because new items are added before the callback is registered.
opw-2801467
closesodoo/odoo#92768
X-original-commit: c2fd26881ceae95417e2a0afc71fdf8567e3b8c0
Signed-off-by: Samuel Degueldre <sad@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
Purpose: Before it was hard to view expense attachments from sheet record.
To do so, the user should have gone through clicking on each expense first and
checking attachments, or could have clicked on a attachments smart button on embedded
expense table, which is redirecting to another view that only displays attachments for the one expense only.
Thus, checking all the attachments from sheet was an tedious task.
After this commit, the user can see in the sheet attachment preview all the associated expenses' attachments.
To make it possible, we ovveride 'mail.thread' method that is called to
fetch the data for the chatter. In the override, we fetch extra, associated expenses' attachments.
task - 2320177
closesodoo/odoo#92724
Signed-off-by: Kevin Baptiste <kba@odoo.com>
A new method `triggerEvent` has been introduced in order to simplify
event creation. This commit adapt the tests to use that method.
closesodoo/odoo#92653
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Fabio Barbero