Commit Graph
152817 Commits
Author SHA1 Message Date
Carlos Dauden fdc20d13bb [FIX] sale_purchase: Take into account minimal quantity supplierinfo
closes odoo/odoo#53548

X-original-commit: d872cbf11f05cd10aa9b36b3c0aded895e0e68f3
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2020-06-24 08:44:59 +00:00
Xavier Morel 6bd8e89766 [IMP] sale: avoid using _write to schedule an activity from the invoice status
Task 2186312

closes odoo/odoo#53427

Related: odoo/enterprise#11335
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-06-24 10:27:26 +00:00
Xavier Morel 1dab0fac85 [IMP] website_slides_survey: remove _write override
odoo/odoo@020e2a5e85 added a way to hook
into recomputation of stored fields, so messing about with _write
should be unnecessary.

Task 2186312
2020-06-24 10:27:26 +00:00
Barad Mahendra 7e8dee1ecc [IMP] hr_timesheet: add name on task kanban to inherit easily.
Purpose of the commit is to add the name on condition so it will
be inherited easily from the fsm view and  able to change the condition
easily by inehritance.

closes odoo/odoo#51979

Taskid: 2253536
Related: https://github.com/odoo/enterprise/pull/10796
Related: odoo/enterprise#10796
Closes: #51979
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-05-27 12:32:54 +00:00
Pratima Gupta 6ed99c032a [IMP] stock: propagate_date on 1st receipt move
1) Before this commit, propagate date on 1st receipt move was always False
   if PO was created manually.

   After this commit, move will be assigned with propagte_date of buy
   route of warehouse only if there is not move_dest_ids.

2) Default settings on routes as -
	1) If receipts in 3 steps > the alert on the receipt
	   (+ propagate) and the propagate rescheduling on the followings
	2) If receipt in 1 step > the alert on the buy rule
	   (no propagate rescheduling)

Task-2209541

closes odoo/odoo#51853

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2020-06-24 11:05:33 +00:00
Sébastien Theys 652d835f77 [FIX] mail: restore close of other menus on click of messaging menu
task-2278830

closes odoo/odoo#53566

X-original-commit: 0407151b34da16ca54066bb15e578dc1db85f365
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-06-24 10:22:58 +00:00
Xavier Dubuc ba744be937 [FIX] mail: fix folded new message chat window style
task-2272492

closes odoo/odoo#53565

X-original-commit: dcaa91ffb84a7d9ca433fff1913df47513bb365a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-06-24 10:22:35 +00:00
Xavier Morel ff669b68cb [IMP] test_lint: disable deprecated-method
It's not super useful as we've re-enabled DeprecationWarnings though
logging, and it turns out to be a *very* expensive lint, as it more
than doubles the runtime of pylint locally:

Before:

    odoo.addons.test_lint.tests.test_pylint ran 1 tests in 376.27s, 2 queries

after:

    odoo.addons.test_lint.tests.test_pylint ran 1 tests in 114.05s, 2 queries

It also seems to significantly increase peak memory consumption (by
~60% though that's not a precise measurement), which can lead to
non-deterministic memory errors.

Also disable mixed-indentation since it doesn't do anything (mixed
indentation is illegal in Python 3).

closes odoo/odoo#53562

X-original-commit: 8062098d0586048a9e91543290c6ab1c8d8d7009
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-06-24 09:52:28 +00:00
Victor Feyens c250bec9ff [FIX] hr_timesheet: timesheet encoding unit of measure.
Potentially wrong in multi-company environment.

closes odoo/odoo#53513

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-06-23 14:15:39 +00:00
Victor Feyens 117c391ac7 [IMP] hr_timesheet: project CRUD cleanup
* remove name_create override: allow_timesheet default is True anyway
* create projects in batch
* write improvement
2020-06-23 14:01:47 +00:00
Victor Feyens 9d2e60aa86 [FIX] hr_timesheet: wrongly raised UserError
Do not say that the task has timesheets linked when there are none 
linked...
2020-06-23 13:47:32 +00:00
shs-odoo 770494fade [IMP] fleet: Change long description of fleet.vehicle.log.contract model
Purpose of the task is the current name(_description) of model
fleet.vehicle.log.contract is too long and confusion.

So in this commmit, Rename model fleet.vehicle.log.contract
name(_description) to 'Vehicle Contract'.

closes odoo/odoo#52176

Taskid: 2267547
Closes: #52176
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-06-02 04:16:25 +00:00
Swapnesh Shah 99c02a83a5 [IMP] stock: display validation properly
Before this commit, This validation message was not displayed properly. (See https://nimb.ws/zYBLvh )

Now we are displaying validation error Properly.

closes odoo/odoo#51209

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2020-05-13 18:23:51 +00:00
qsm-odooandThanh Dodeur a777da6cd3 [IMP] website: make GMap on contact us page a customize show option
Part of https://github.com/odoo/odoo/pull/49101
task-2091396

closes odoo/odoo#49101

Related: odoo/upgrade#1524
Related: odoo/design-themes#231
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: Thanh Dodeur <39259739+ThanhDodeurOdoo@users.noreply.github.com>
2020-07-28 07:45:40 +00:00
Thanh Dodeur d98ee926d6 [IMP] website: allow to change GMap API key from left panel
Part of https://github.com/odoo/odoo/pull/49101
task-2091396
2020-07-28 07:45:40 +00:00
qsm-odoo 430b5b669f [IMP] website, *: move all google map options to left panel
*: web_editor

-> Introduce the we-gpspicker widget and improve the way the gmap lib
    is loaded (for Odoo / multiple snippets / ...).

Part of https://github.com/odoo/odoo/pull/49101
task-2091396
2020-07-28 07:45:40 +00:00
Thanh Dodeurandqsm-odoo 59d46b51b1 [MOV] website: move google map snippet from themes to community
Improve the base code and adapt to new website features as well.

Part of https://github.com/odoo/odoo/pull/49101
task-2091396

Co-authored-by: qsm-odoo <qsm@odoo.com>
2020-07-28 07:45:40 +00:00
Xavier Morel 37a7aed189 [IMP] core: allow both action & children on root node
Reported by VFE, odoo/odoo#54564 missed one of the use cases in menus:
normally a menu can have *either* sub-menus or an action (aka only
"leaf" menu items can have actions), however there's an exception for
root (application) menus: those can have an action, which is used as
the application's action, that is, what gets executed when opening the
application itself.

* root menus were already special cased (to allow a ``web_icon``),
  expand this to allow both action and submenus
* modify the alternatives -- submenu-items and menuitems with a parent
  -- so they keep the behavior of allowing *either* an action or
  children

closes odoo/odoo#55144

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-07-30 05:37:05 +00:00
Alexandre Kühn a647497b51 [FIX] im_livechat: missing env/owl dependencies in external lib
closes odoo/odoo#55173

X-original-commit: b24b0e29fe537baed6919f26a4b63e7f3ad37e66
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-07-29 16:42:27 +00:00
Alexandre Kühn 9ba879fc61 [FIX] im_livechat: hide 'add attachment' button in livechat
Message attachments are not yet supported in livechat for livechat
visitors, so the "Add file" button should not be visible.

closes #54927

Forward-port-of: #54972
Forward-port-of: #54957
X-original-commit: 91a548a6a7456dfd50833671a3938fcf55ed18c6
2020-07-29 16:42:26 +00:00
Christophe Simonis 92c2a54505 [FIX] timer: remove leftover file
Oversight of d6a23144d5

closes odoo/odoo#55165

X-original-commit: a8d450f2339d1e788d50455e3c5ad009155b99ee
Signed-off-by: Christophe Simonis <chs@odoo.com>
2020-07-29 15:40:21 +00:00
Dhruv Patel 246a9de7b6 [FIX] web_tour: tooltip bubble info glitch and moves to the left
When you hover on the bubble tooltip infobox then sometimes its glitch,
and moves left. once you leave the mouse over from the tooltip info then
it will be repositioned as before.

So with this commit, we have resolved this issue by giving the condition
on the repositioning of every time the _updatePosition methods execute.
If the tooltip infobox is open then we are not repositioning the box's position.
otherwise, it will be repositioned.

closes odoo/odoo#55162

Task: 2263600
X-original-commit: 1d62b9d5fbe17cb1cc33dd335cff129ce9b13570
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-29 15:39:03 +00:00
Sébastien Theys 6b06ada2c2 [FIX] mail: fix messaging locale update on translation bundle change
closes odoo/odoo#55167

X-original-commit: c3eb3f04e06cea84dd98323b6d10867dead5b953
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-07-29 15:41:10 +00:00
Xavier Dubuc a28f24ca3f [FIX] mail: prevent attachment delete from not authored message
task-2299330

closes odoo/odoo#55164

X-original-commit: c331b6761fbc1e8dd4d554109acab142ab02702d
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-07-29 15:39:56 +00:00
Xavier Dubuc 69d89218f9 [FIX] mail: fix read more/less span insertion
task-2248307

closes odoo/odoo#55163

X-original-commit: a8ea9bc98d114eef056babc0d2639eaddbcf3778
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-07-29 15:39:31 +00:00
Victor Feyens 42fc0f4910 [FIX] product_matrix: matrix edition on a new record.
Probably since recent js framework changes, when trying
to modify the matrix of a product on a new SO (not saved),
a js error was raised (wrong qweb template rendering).

This is due to a wrong check when loading the matrix data,
in the case of a new record, the data wasn't correctly updated
on all widgets, resulting in an opening of the matrix with the results
of the last matrix changes (since the information is transferred in the same field).

This commit:

* Ensures that the correct data is taken to open the matrix (solving the main
problem of matrix update on new records)
* Improves test coverage to cover untested buggy situation
* Fixes another error found while improving test coverage:
The edition of existing quantities was wrongly creating new lines, instead of updating
existing ones.  Simplify lines comparison to ensure the matrix won't generate two lines
for the same variant combination.

closes odoo/odoo#54917

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2020-07-29 13:46:46 +00:00
Julien Mougenot d3f0632f49 [FIX] web: datepicker get correct database format
Before this commit, the format used by both date and datetime picker
components depended on default props which are evaluated on module
loading. This was an issue because the "time" module did not have time
to load and fetch the correct database value, hence using the default
ones.

Now, the format is evaluated on component instantiation, giving enough
time to the "time" module to load.

Task 2307258

closes odoo/odoo#55113

X-original-commit: 792b565a65a8c9f65bf13e94f30b88913f2bfa7f
Signed-off-by: Paul Morelle <madprog@users.noreply.github.com>
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
2020-07-29 11:20:16 +00:00
Robin Heinz dbbf6a8731 [IMP] point_of_sale: customer flow improvement.
Improve the flow of the customer list and edit to fit better with odoo.

closes odoo/odoo#54571

Task-id: 2294251
Related: odoo/enterprise#11891
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2020-07-29 08:39:40 +00:00
Thibault Francois fb396a954d [FIX] hr_timesheet: Timesheet in multi company
Allow user that have a employee in a company A
and that is allowed on company A and B to timesheet
on company B

Problem:
A user have access on company A and B but is link to
an employee that belong to company A. He want to timesheet on a
project from the company B. He gets an error
"Incompatible companies on records".

Since most users are linked to only one employee that belongs
to one company. It's impossible to have consistent companies.

Solution:

The employee shouldn't be checked on the timesheet

closes odoo/odoo#55074

X-original-commit: 7eada96b8fc1c370801ff42231167885cc8e46bc
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2020-07-29 09:02:49 +00:00
Lucas Perais (lpe) 559a9cf018 [IMP] *: adapt some list views to the action button in controlPanel
task-2246383

closes odoo/odoo#54593

Related: odoo/enterprise#11992
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2020-07-29 09:11:52 +00:00
Lucas Perais (lpe) 49d9771c56 [IMP] web, base: action buttons in list's controlPanel
This commit introduces a new semantics to define action and method buttons
in the list view.
The aim of this feature is to be able to do some actions on selected records, or on the entire
records' domain with the help of buttons located in the controlPanel, much like the form view header buttons.

To define such buttons, one must add a `header` node in the list view's xml definition
```
<tree>
  <header>
    <button type="action|object" name="actionId|methodName" string="button's text" context="{}"/>
  </header>
  <field name="fieldName" />
</tree>
```

task-2246383
2020-07-29 08:59:42 +00:00
Andrea Grazioso (agr-odoo) 97cdcc05f1 [FIX] stock,sale_mrp: Inventory adjustment not possible
1) Create a stockable product > Add some quantities on hand
2) Edit this product > set it as a consumable or service
3) Create an inventory adjustment on all products

Error will raise "Something went wrong! You can only adjust storable products.

This occur because when switching product type the available quantity
was not cleared, so it will get in the next inventory, but only storable
products can have inventory. So the product should to have no
quantity left before switching type

opw-2300478

closes odoo/odoo#55062

X-original-commit: be17e31307070498ba9ac7dc594443730caa7404
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
2020-07-28 14:40:25 +00:00
Paul Morelle 544e22f4f2 [FIX] mass_mailing: respect mail_server_id for test emails
When sending a test email for a mass mailing, it was using the default
server, ignoring the one that could have been set on the mailing object.

This commit fixes this issue, so that the way the test emails are sent
is even closer to the real process.

closes odoo/odoo#55072

X-original-commit: 6af6e4714f2ccc703e9a3189b12a2317bd6af49c
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Paul Morelle <madprog@users.noreply.github.com>
2020-07-28 15:43:36 +00:00
Nicolas Lempereur fff793f7d7 [FIX] web_editor: carriage return in source mode
Enter keypress browser event were removed in 3c372d1da8.

It was reintroduced in text fields with d2f024d254 and this PR do the
same and reintroduce it for source mode of FieldHtml (`html` widget).

opw-2302605
closes #55066

closes odoo/odoo#55081

X-original-commit: b10ca1f6094b7c8e6e222aa0ea3d1f891e79379a
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2020-07-28 18:16:22 +00:00
Nasreddin (bon) d432b34728 [FIX] website_slides: Traceback when no link provided for video
Issue

	Traceback raised in case no link provided when content type
	is a video.

Solution

	Format url only if provided.

Note: also fix issue with scheme (embedCode src could start with //)

Related fix : https://github.com/odoo/odoo/pull/54536
opw-2294344

closes odoo/odoo#55079

X-original-commit: 49a18eec21bad3d193804a3aa630e453b85318e9
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2020-07-28 17:45:09 +00:00
6aa6c321a6 [IMP] web: remove min date limitation of year 1900
Before this commit, user could not selecta a date before year 1900.
This was an historical limitation due to python < 3.2 that didn't
support dates before 1900.

After this commit, user can select any date, user can select any
date from 01/01/0001.

taskID: 2166761
Fixes #41788
Closes #43055

closes odoo/odoo#51406

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
2020-07-28 14:02:10 +00:00
Nicolas Martinelli 684b628c5a [FIX] purchase_mrp: receive kits with multiple UOM
- Create 3 products A, B & C
  A is in Units
  B is in kg
  C is in m
- Create a BOM kit for A using 1 kg of B and 1 m of C
- Create a PO for A, validate
- Receive the picking

An error is raised: "Conversion from Product UoM ... to Default UoM ...
is not possible as they both belong to different Category!."

It happens because `_compute_qty_received` incorrectly converts
quantities.

The computation of the quantity received for kits is done in 2 steps:
first we compute the quantity the same way we do it for a regular
product, then we overwrite the quantity with the value computed for
kits.

We can compute the quantity correctly at once by calling `super` only on
lines which are not kits.

opw-2302807

closes odoo/odoo#55047

X-original-commit: b82f71dac9452de9c1e16cde552fe260fec3c262
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-28 12:38:33 +00:00
Xavier Morel c8063af7a0 [IMP] core, account, lunch: make <menuitem> recursive
For clarity, some data files are formatted as pseudo-tree
structure. This is somewhat confusing and dangerous when the structure
has no meaning... so add meaning:

* allow nesting menuitems, nested items are set as children to the
  parent they're nested in
* update schema to allow an icon *or* a parent on regular menu items,
  and neither on nested (they have an implicit parent meaning can't
  have an icon)
* remove attributes which don't actually exist from the menuitem
  schema
* also type sequence as an integer while at it

Convert two large-ish menuitem data files to recursive form.

closes odoo/odoo#54564

Related: odoo/enterprise#11887
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2020-07-28 13:03:13 +00:00
Xavier Morel 6835aeb0de [REM] core, *: deprecate <act_window> and <report>
Convert deprecated tags through the codebase.
2020-07-28 13:03:13 +00:00
Xavier Morel 96a3265118 [FIX] doc: remove <act_window> and <report>
* remove <report> and <act_window> form the backend tutorial
* remove documentation for <report> in the report doc

Also various fixes and improvements:

* add ACL to the wizard in the tutorial, as transients now require ACLs
* fix indentation & spacing in rST
* reword a few bits
* improve styling of footnote references (and recompile stylesheet
  with recent lessc which apparently changes its output formatting
  quite a bit)
2020-07-28 13:03:13 +00:00
Xavier Morel 48335c04bf [IMP] core: orm doc
* fix link from backend tutorial to log_access section
* flesh out log access documentation
* add documentation for log_access itself & improve doc for a few
  other model-level attributes
2020-07-28 13:03:12 +00:00
Nicolas (vin) c09c6a92e1 [IMP] account: Make analytic fields read-only
Analytics fields are currently updatable when the move has been posted,
even though editing them as no effect.

This change make them read-only when the move has been posted.

Task ID: #2299319

closes odoo/odoo#54521

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2020-07-27 05:04:39 +00:00
Benjamin Vray 501487c9d7 [FIX] website: fix header effects issues with hamburger menu
Do not update to main padding-top when opening an hamburger menu with
a fixed header. Close the menu hamburger if the page is scrolled.

Part of https://github.com/odoo/odoo/pull/51446
task-2229127

closes odoo/odoo#55045

X-original-commit: c06218408df4c8ec2fa3902e0cc03468c32dd36d
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-07-28 12:20:17 +00:00
Benjamin Vray 4848c3aed7 [FIX] web_editor: fix overlay when scrolling
Since the new effects on the header, the overlays do not overlap
correctly after the page has been scrolled. Now we hide the overlays
during the scrolling and show/recompute it after the scrolling.

Part of https://github.com/odoo/odoo/pull/51446
task-2229127

X-original-commit: 209a94d8c4fcdc2e74860c9392fc14a35aec52ed
2020-07-28 12:20:16 +00:00
Benjamin Vray 2ebbdef089 [FIX] website: fix standard effect with Logo on top/below
Fix the standard effect with template logo on top/below to avoid
an hopping when scrolling.

Part of https://github.com/odoo/odoo/pull/51446
task-2229127

X-original-commit: 444b8b8a8d2014d0465a6ff00ce23b2ca1fca66a
2020-07-28 12:20:15 +00:00
yhu-odoo 7b8035563f [IMP] (purchase_)stock: reserve and replenish automatically
1. When reservation can't be done for some products, we automatically
evaluate their reordering rules and create the corresponding
replenishment document.
2. When receiving products in stock, automatically check if some stock
moves are available and assign them.

Task 2244230
PR #52433

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2020-07-28 09:47:04 +00:00
jerome hanke (jhk) d6d540a8d5 [FIX] sale: portal generates pdf for the chatter in a separate request
Steps to reproduce:
- install studio, website and sales
- go to sales > open studio > go to 'reports' > Quotation/Order
- add a field anywhere on the report with the field expression set to
"doc.signature" > save
- go to sles > create a quotation > send by email > send > go to the customer portal
- sign and send the quotation > go back to the edit mode > open the pdf attached
to the latest message in the chatter

Previous behavior:
the custom field added was not rendered properly,
the attachment is not available during the request and the generated
pdf shows the placeholder image instead

Current behavior:
the message posted in the chatter is generated in another request,
this makes the attachment available

opw-2260989

closes odoo/odoo#54955

X-original-commit: a15cbb0a7be666d3ad438f6470d29cda75c24027
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-07-27 09:39:25 +00:00
Siddarth Gajjar 7146ee0231 [IMP] *: clean leftovers 'col_group_by' and 'measures'
* hr_recruitment, point_of_sale

Context keys 'col_group_by' and 'measures' are ignored since v8 or
v9. They have been respectively replaced by 'pivot_column_groupby'
and 'pivot_measures'/'graph_measures'. This commit cleans the few
filters that were still using it.

Task 33834

closes odoo/odoo#23234

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2020-07-28 07:22:22 +00:00
Jason Van Malder 974bc0d2df [FIX] sale: fix safari excluded variant indistinguishable in select
Issue

	- Safari
	- Sales with product configurator
	- Have a product with color black & white
			      size M, XL
	- Exclude M size when color is white
	- Create a SO with that product
	- Select white color

	The size's M option is not grayed in the select

Cause

	We do not disable the option when it's not available.
	We are just adding a css class which grays the option.

	Safari ignores the style

Solution

	Since the flow can't be completed if you select a
	grayed item, disable the option

OPW-2289666

closes odoo/odoo#54993

X-original-commit: 6150311b72089e3fbae6bc27551bc7f4792e68dd
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
2020-07-27 14:49:18 +00:00
Jeremy Kersten cc6000abfa [FIX] website_sale: align abandoned cart period
Using same domain
Using similar filter by week/month/year

closes odoo/odoo#55020

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2020-07-27 15:23:08 +00:00