Commit Graph
943 Commits
Author SHA1 Message Date
Goffin Simon 0fd773a486 [IMP] Cleanup and refactoring of exception handling
Unify and refactor exception handling in framework and addons.

The generic `except_osv` is now deprecated, and replaced by more specialized exception subtypes:
 - `UserError` (renamed from Warning, as it conflicts with the built-in `Warning`) raised when a non-technical error occurs during a business operation. It could be a missing information in the data provided by the user, or a misconfiguration.
 - `AccessError`: raised when any operation is denied because the user conducting it does not have the required access rights.
 - `AccessDenied`: raised when an operation that requires authenticated access is attempted via an unauthenticated request.
 - `MissingError`: raised when an operation is attempted on a record that does not exist.
 - `ValidationError`: raised when an operation violates a SQL or Python constraint.
 - All other exceptions are internal errors due to a system problem or bug, and raised untouched to the client-side, which should display a traceback.

All exceptions take a single message argument.

The `test_exceptions` module has been updated to showcase both new and old (deprecated) exceptions.

A great many old `except_osv` had a useless title with "Error!" or "Warning", those have been removed, as this is handled by the client-side widget that displays the messages.

This commit introduces a more consistent policy for logging errors and warnings:
 - All messages that do not require administrator attention should be logged at INFO level or lower. This includes all errors that are notified to the user in a friendly manner, even for access right problems or validation errors during business operations.
 - All messages that indicate a likely misconfiguration or malicious use by the users should be logged at WARNING level, as they typically require administrator attention.
 - All other unhandled internal errors cannot typically be handled by the user and should be logged at ERROR or higher level, as they require immediate administrator attention.
2015-01-16 17:15:18 +01:00
Fabien Pinckaers 03920283be [IMP] removing bad label 2015-01-09 06:00:09 +01:00
Christophe Simonis fab4d6d442 [MERGE] forward port of branch 8.0 up to ea54d4a 2015-01-06 11:49:04 +01:00
Leonardo Donelli 4a0b13ed92 [REF] remove vim modelines and resulting trailing blank lines
Let 2015 be a year without modelines!
cf #4174
2014-12-31 15:52:13 +01:00
Josse Colpaert 723f532e57 [IMP] Changing product qty on product form should work with serial numbers like in 7.0, but we should explain it
Closes #3984
2014-12-12 10:48:00 +01:00
Denis Ledoux bdd5ec8216 [FIX] stock: reload after stock picking scrap
If a wizard is launched from an embedded view list, only the record of the line from which the wizard was launched is reloaded after closing the wizard.

In this specific case, as new lines are added to the picking, we need to fully reload the stock picking
2014-12-11 15:59:13 +01:00
Josse Colpaert 7bee5918eb [IMP] No lot in qty update as it is only confusing #3984 2014-12-09 09:56:31 +01:00
Christophe Simonis e17222a38d [MERGE] forward port of branch 8.0 up to 2e092ac 2014-12-03 15:18:36 +01:00
Josse Colpaert 536d00d2ba [FIX] Avoid endless loop when doing a return picking 2014-12-02 18:54:25 +01:00
Jitendra Prajapati 52c3b52bf0 [IMP] stock: onboarding (display improvements) 2014-11-25 15:49:23 +01:00
Christophe Simonis d64fe8279b [MERGE] forward port of branch 8.0 up to c92e70b 2014-11-17 17:31:12 +01:00
Josse Colpaert 86f785ae1b [FIX] #3153 Digits in wizard should be those of moves,... / Recreate delivery order from sale / Delivery method on delivery order
[IMP] Provide better purchase order picking type

[IMP] Possibly a better product uos handling in the sale order line

[FIX] Recreate of delivery order when sales order in shipping exception

[FIX] Delivery method should be passed to delivery order
2014-11-13 11:50:01 +01:00
Christophe Simonis 709c9868de [MERGE] forward port of branch 8.0 up to e883193 2014-10-01 19:18:14 +02:00
Josse Colpaert 21aaec282d [FIX] Theoretical quantity for created inventory adjustment should take into account location in context of stock 2014-09-17 21:41:41 +02:00
Yannick Tivisse bfc98d8ca2 [IMP] Generic: configuration menus reorganization 2014-09-10 16:28:49 +02:00
Josse Colpaert 138011c69b [IMP] Changing the standard cost price should do the real-time valuation for all variants of the template 2014-09-03 19:19:18 +02:00
Josse Colpaert 5242cfceea [FIX] Make sure packages are not shown when the setting is not checked 2014-08-25 09:23:05 +02:00
Josse Colpaert f4e7105eb6 [IMP] Usability improvements by clarifying texts 2014-08-21 11:37:40 +02:00
Josse Colpaert 3891892d9f Merge from nse back-end partial picking wizard 2014-08-20 18:28:57 +02:00
Josse Colpaert 28ad04a4de [IMP] Only show number of variants when more than one + bug cursor Compute Minimum Stock Rules 2014-07-16 13:50:56 +02:00
Josse Colpaert 32dd003d60 [MERGE] Resolve conflicts 8.0 2014-07-13 09:27:20 +02:00
Christophe Matthieu e26623da01 merge from 8.0 2014-07-09 09:43:02 +02:00
Josse Colpaert beb12f71f1 Merge branch 'odoo/8.0' into master-wmsstaging4-jco 2014-07-07 23:34:42 +02:00
Christophe Matthieu e3d9db2bab [FIX] stock: update and request procurment button use active_id to se the product. Fix to use this buttons on product template. 2014-07-07 16:58:47 +02:00
Raphael Collet 33eb3dffb2 [REM] models: remove the magic methods signal_XXX() 2014-07-07 11:50:30 +02:00
Josse Colpaert 12211437f1 [IMP] Corrections in views + calendar fields isinstance + inventory theoretical qty 2014-06-25 15:03:11 +02:00
Josse Colpaert 6b63d40145 [MERGE] Merge from master and resolve conflict 2014-06-17 16:23:44 +02:00
Fabien Meghazi faa09da325 Removed version="7.0" from form views 2014-06-12 09:09:59 +02:00
Josse Colpaert f30cf0cf1b [IMP] Run schedulers and minimum stock rules done by company + purchase order should change date when adding (to) lines 2014-06-11 14:05:13 +02:00
Quentin (OpenERP) 0170fe87bc [REF] removal of stock/wizard/mrp_procurement.py which was unused + refactoring of procurement.do_view_procurements() in order to use new API of ir.model.data
bzr revid: qdp-launchpad@openerp.com-20140507091818-hp6fgipxi1arpv4u
2014-05-07 11:18:18 +02:00
Quentin (OpenERP) c41941d978 [FIX] a lot a fixes or usability improvements. Includes a branch of jco as well with other fixes
bzr revid: qdp-launchpad@openerp.com-20140416145313-eiadz94h9wolhb9b
2014-04-16 16:53:13 +02:00
Quentin (OpenERP) 398d96f273 [MERGE] merged trunk up to revision 9327
bzr revid: qdp-launchpad@openerp.com-20140414094743-hv0u7qhigv1to2uc
2014-04-14 11:47:43 +02:00
Josse Colpaert af1d4acba3 [MERGE] Merge from trunk-wms
bzr revid: jco@openerp.com-20140326155150-4y47ny5gyvjezlm9
2014-03-26 16:51:50 +01:00
Quentin (OpenERP) e0b27b4ee8 [MERGE] merged trunk up to revision 9251
bzr revid: qdp-launchpad@openerp.com-20140326152751-b6bo0fawrzmd71f0
2014-03-26 16:27:51 +01:00
Denis Ledoux 0e4cfe0add [MERGE] Forward-port of latest saas-2 bugfixes, up to rev. 9157 revid:dle@openerp.com-20140320181252-4gqcog22p1ex0pz7
bzr revid: chs@openerp.com-20140320134212-9nbuc7uqla4uiyf7
bzr revid: dle@openerp.com-20140320112958-slajf0ho0jtl7u60
bzr revid: dle@openerp.com-20140320161349-olyte7xt35nfj3dg
bzr revid: dle@openerp.com-20140320181737-68q9xh9jhfjynjip
2014-03-20 19:17:37 +01:00
Denis Ledoux 02459f8d4a [MERGE] Forward-port of latest 7.0 bugfixes, up to rev. 9929 revid:dle@openerp.com-20140325104921-x8zjx5p71l1o3uif
bzr revid: dle@openerp.com-20140310133913-465x5t3n1bo7fu98
bzr revid: dle@openerp.com-20140311164146-2s599kogbqj8e94l
bzr revid: dle@openerp.com-20140312111149-u6y036aej3ywq7et
bzr revid: dle@openerp.com-20140312121145-06s1jvct9v4m7l6s
bzr revid: mat@openerp.com-20140313084409-c0kckxemy3in0mlo
bzr revid: chs@openerp.com-20140313163420-ifa4hyixj722d6jo
bzr revid: chs@openerp.com-20140314102034-g0nzryvwhrpzdas9
bzr revid: chs@openerp.com-20140314104803-19c5snl2fcuih91o
bzr revid: odo@openerp.com-20140314143519-x6rzcfkkqxwc0e1g
bzr revid: chs@openerp.com-20140318110229-y8098w3shdpmoig2
bzr revid: dle@openerp.com-20140318151824-sscl4m8p87emjl8s
bzr revid: dle@openerp.com-20140320112618-yfyihlwz66ryeqf5
bzr revid: dle@openerp.com-20140320161003-j01cc6sqves2wnp2
bzr revid: dle@openerp.com-20140320181252-4gqcog22p1ex0pz7
bzr revid: dle@openerp.com-20140321140450-8ulnhr76qybiadks
bzr revid: dle@openerp.com-20140324104743-ubvu8st7emq9pg1q
bzr revid: dle@openerp.com-20140325112413-xs5z7y81rhyjt0rd
2014-03-25 12:24:13 +01:00
Kersten Jeremy 9bf6f0310e [FIX] Move default value in the _defaults of model and not in default_get.
Don't override the location_id if the super get_default don't retrun a value. 

Else it is impossible to set a default value, because the ir_values is always overrided with stock_location_stock as location_id

bzr revid: jke@openerp.com-20140320180240-un42lptu3pjnsmxq
2014-03-20 19:02:40 +01:00
Denis Ledoux 287aae3942 [FIX] stock: force form_view_ref to False in context of actions track_line and scrap_move to avoid context propagation of stock picking views
bzr revid: dle@openerp.com-20140320110741-pg8se5c02p87yi1y
2014-03-20 12:07:41 +01:00
Josse Colpaert b01a61e396 [WIP] Remove unnecessary reports
bzr revid: jco@openerp.com-20140317150409-wusdimhx4hx001to
2014-03-17 16:04:09 +01:00
Denis Ledoux c11db79d57 [MERGE] Forward-port of latest saas-2 bugfixes, up to rev. 9141 revid:dle@openerp.com-20140306123937-sn61atwvbcjwbyup
bzr revid: dle@openerp.com-20140306124247-29dgpb0ap5j0vsk0
2014-03-06 13:42:47 +01:00
Denis Ledoux 5db57a21a2 [FIX]stock: in fill inventory wizard, set raise-exception to False in context to avoid having error saying that the product uom category is different: this button is just a tool to help filling the inventory. Anyway, If it should pop the error, it should be on the validation, not in the button to auto-fill the inventory.
bzr revid: dle@openerp.com-20140304113407-b2kku1xolvkceqcg
2014-03-04 12:34:07 +01:00
Denis Ledoux 257df67d32 [FIX]stock: in fill inventory wizard, set raise-exception to False in context to avoid having error saying that the product uom category is different: this button is just a tool to help filling the inventory. Anyway, If it should pop the error, it should be on the validation, not in the button to auto-fill the inventory.
bzr revid: dle@openerp.com-20140304104603-5y9rz8onsxdr43dp
2014-03-04 11:46:03 +01:00
Josse Colpaert d5cdec9e16 [MERGE] Merge from trunk-wms
bzr revid: jco@openerp.com-20140219145719-snazgq9oe9q0idrs
2014-02-19 15:57:19 +01:00
Quentin (OpenERP) 9550c32409 [MERGE] usability improvements among several modules/screens
bzr revid: qdp-launchpad@openerp.com-20140214145712-j8dmf06wy49x9l50
2014-02-14 15:57:12 +01:00
Cedric Snauwaert 9502276166 [FIX]work on view for better usability
bzr revid: csn@openerp.com-20140210100727-1q2q61t3c3nxfd10
2014-02-10 11:07:27 +01:00
Quentin (OpenERP) 7796000e3d [MERGE] branch fixing the return picking wizard
lp bug: https://launchpad.net/bugs/1269421 fixed

bzr revid: qdp-launchpad@openerp.com-20140206131638-tlwdnhzdtkfkb727
2014-02-06 14:16:38 +01:00
Quentin (OpenERP) 3753eb2524 [MERGE] fix of stock_change_product_qty wizard
lp bug: https://launchpad.net/bugs/1271991 fixed

bzr revid: qdp-launchpad@openerp.com-20140206124937-dx4j3vraziu5wmp6
2014-02-06 13:49:37 +01:00
Quentin (OpenERP) 06d41e195a [FIX] stock, return picking wizard: several bugs fixed (see details bellow) and removal of feature to recreate or cancel chained operations (because it was totally bugged, not easily achievable and it's a new feature).
bugs fixed:
1) do_unreserve() on stock.move was setting back to 'confirmed' state also moves in 'done' or 'cancel' state
2) in return picking wizard, unreservation of quants was made only on the chained operation regardless if it had been split before or not
3) lot management in return picking wizard
4) new implementation or return picking wizard in order to only allow a manual fixing
5) uom support in return picking wizard

bzr revid: qdp-launchpad@openerp.com-20140206123852-g22nkgcxud0c9tzr
2014-02-06 13:38:52 +01:00
Quentin (OpenERP) 369d222965 [REF] some refactoring made during code review
bzr revid: qdp-launchpad@openerp.com-20140205172444-4v7msetkkp7ypb7y
2014-02-05 18:24:44 +01:00
Quentin (OpenERP) abb8f9c929 [MERGE] trunk-wms
bzr revid: qdp-launchpad@openerp.com-20140205143652-v0d0ug0afldyd2em
2014-02-05 15:36:52 +01:00