Commit Graph
11 Commits
Author SHA1 Message Date
Goffin Simon 0fd773a486 [IMP] Cleanup and refactoring of exception handling
Unify and refactor exception handling in framework and addons.

The generic `except_osv` is now deprecated, and replaced by more specialized exception subtypes:
 - `UserError` (renamed from Warning, as it conflicts with the built-in `Warning`) raised when a non-technical error occurs during a business operation. It could be a missing information in the data provided by the user, or a misconfiguration.
 - `AccessError`: raised when any operation is denied because the user conducting it does not have the required access rights.
 - `AccessDenied`: raised when an operation that requires authenticated access is attempted via an unauthenticated request.
 - `MissingError`: raised when an operation is attempted on a record that does not exist.
 - `ValidationError`: raised when an operation violates a SQL or Python constraint.
 - All other exceptions are internal errors due to a system problem or bug, and raised untouched to the client-side, which should display a traceback.

All exceptions take a single message argument.

The `test_exceptions` module has been updated to showcase both new and old (deprecated) exceptions.

A great many old `except_osv` had a useless title with "Error!" or "Warning", those have been removed, as this is handled by the client-side widget that displays the messages.

This commit introduces a more consistent policy for logging errors and warnings:
 - All messages that do not require administrator attention should be logged at INFO level or lower. This includes all errors that are notified to the user in a friendly manner, even for access right problems or validation errors during business operations.
 - All messages that indicate a likely misconfiguration or malicious use by the users should be logged at WARNING level, as they typically require administrator attention.
 - All other unhandled internal errors cannot typically be handled by the user and should be logged at ERROR or higher level, as they require immediate administrator attention.
2015-01-16 17:15:18 +01:00
hiekmann ed21177044 [FIX] payment_ogone: typos in comments
closes #4166
2014-12-11 10:55:55 +01:00
Martin Trigaux 932eccc7a7 [FIX] payment_ogone: last commit 2014-09-25 15:07:07 +02:00
Wolfgang Taferner 29fefafcd6 [FIX] paymnet_ogon: add missing SHA OUT keys
The SHA OUT list was incomplete and therefore SHASIGN was not matching anymore
List of keys from https://viveum.v-psp.com/Ncol/Viveum_e-Com-BAS_EN.pdf
2014-09-25 15:01:16 +02:00
Thibault Delavallée ade618a63e [IMP] payment: renamed env field to environment, to avoid conflicts
with the incoming new API.

bzr revid: tde@openerp.com-20140416121055-01ygh1zer7cfv98a
2014-04-16 14:10:55 +02:00
Thibault Delavallée 38ae695d00 [IMP] payment modules: added provider selection field that is different
from the name. This allows to distinguish name and provider. Provider is a more
technical field, used to call some specific methods (<provider>_method_name). The
name field is used for display on the website.

Code and views udpated accordingly.

bzr revid: tde@openerp.com-20140319144608-0i4rv520l0bh53f0
2014-03-19 15:46:08 +01:00
Christophe Simonis 783a8e22a9 [FIX] payment_ogone: ogone is so bad with encoding that they need to duplicate their code to handle utf8 correctly ಠ_ಠ
bzr revid: chs@openerp.com-20140228092535-1tfy5832rgq79ob9
2014-02-28 10:25:35 +01:00
Christophe Simonis 91c278ad75 [FIX] payment_ogone: use utf8 version of orderstandard page
bzr revid: chs@openerp.com-20140227214423-k0dz4769kibfgld4
2014-02-27 22:44:23 +01:00
Christophe Matthieu 9aa278b3ee [FIX] payment_ogone: sale order view crash when payment_ogone is installed
bzr revid: chm@openerp.com-20140128154135-p2gq6t1z0a2n15qn
2014-01-28 16:41:35 +01:00
Thibault Delavallée 4cfdab77b2 [CLEAN] payment_ogone, payment_paypal: added tags in docstrings for s2s methods. Those methods are now identified as experimental as not finished and/or not tested.
bzr revid: tde@openerp.com-20140123154735-o5z6j4fh1ysll356
2014-01-23 16:47:35 +01:00
Thibault Delavallée 0b69bad996 [RENAME] payment_acquirer_* -> payment_ *
bzr revid: tde@openerp.com-20140122175702-1h1e51z4njt4s70w
2014-01-22 18:57:02 +01:00