Commit Graph
115219 Commits
Author SHA1 Message Date
William Henrotin e9b09d4778 [FIX] account, crm, website_sale: wrong link to sale settings
After sepration of CRM and Sales, The xml_id of sales settings action
changed. This patch update old links in web_planner to the new settings.

opw-804426
2018-01-12 13:18:47 +01:00
tbe-odoo d5e97eab8b [FIX] web: Kanban image not showing in some languages
- In some languages the kanban images are not displayed because of a bug in human_size method in JS.

This method translates the Unit Size for data and strip with the string with a comma as separator.
When the translatation contains spaces after the commas (like in the French translation), there is extra spaces in the final result.
This then cause an issue with the method is_bin_size that expects a unique space between the value and its unit.
Resulting in a bug in the method 'kanban_image'.

opw #804973 #804970 #804648
2018-01-12 12:05:56 +01:00
qsm-odoo 4357783a58 [FIX] mass_mailing: width of main layout in editor
Commit https://github.com/odoo/odoo/commit/bee3253b44850c0d563ee8973556ece33376781b
changed the main layout width computation so that it is compatible with
mail clients but broke the preview in the editor.
2018-01-12 11:48:35 +01:00
Martin Trigaux ea8cf1b7a2 [FIX] doc: escape code 2018-01-12 11:31:26 +01:00
Christophe Simonis 4eaef03df3 [MERGE] forward port branch 9.0 up to 330f84f211 2018-01-12 11:25:58 +01:00
Romain Derie bd00fa8dd1 [FIX] web_editor: dbclick a video open MediaDialog with wrong media
Before this commit:
In the web editor, if you double clicked on a video iframe to edit it, it would
open the MediaDialog(media) with the wrong media element.
Media would be ' ' instead of '.media_iframe_video' (which is its grand
parent):

  div.media_iframe_video
    div.css_editable_mode_display
      '& nbsp;'

Then, if you changed the media by another one (Image or Video), the media would
be wrongly inserted into the DOM, in the already existing iframe, eg:

  (1) div.media_iframe_video
    (2) div.css_editable_mode_display
      (3) div.media_iframe_video
        (4) div.css_editable_mode_display
          (5) '  '

Since the new media (3) is wrongly instered into (2) instead of replacing (1),
the bug it would not be visible on normal mode (you would still see the
old media) because (2) is not displayed on normal mode.
Then on edit mode you would see both media one over the other.

Note: This only happened when you opened MediaDialog thought double click
directly (not 'Edit 'in navbar) and without clicking somewhere else after you
entered edit mode.

Now, if the media has an iframe parent, we use that parent as the correct media

This closes #22109, closes #22179

Courtesy of QSM for the help
2018-01-12 10:48:42 +01:00
Jerther 270b2ebf81 [FIX] service, web: memory error on large DB
Fixes MemoryError when restoring large database archive.

Closes #17663
opw-788273
2018-01-12 10:17:42 +01:00
fda-odoo a4d0b0b44d [IMP] hr_recruitment: onboarding ux fixs
- rename module to Recruitment instead of Recruitment process.
    - add a tour on the "create" button of hr_job
    - change wizard for the creation of a job position (change text + remove "create & edit" button)
    - change the design of job positions cards and applicant cards
    - prefill the db with 5 states for applicants (Initial qualification, First interview, Second interview, Recruited and Contract signed)
    - add an activity widget on the kanban view for jobs applicants.
    - change hr_recruitment survey module (xpaths) according to changes in hr_recruitment
    - delete tooltips on kanban cards of applicants
    - show recruitment stage in green or red on kanban cards of job positions.
2018-01-12 10:04:58 +01:00
Nicolas Martinelli b3088532f2 [FIX] account: save due date
Complement of e832fbfd7a

opw-803939
2018-01-12 09:55:40 +01:00
Fabien Meghazi d080f8c047 [IMP] ir_cron: use 'info' loglevel instead of 'debug' when starting job
This information is important for `ir.cron` troubleshooting hence
deserves a little more love.
2018-01-12 09:34:37 +01:00
Fabien Meghazi 65b41eb291 [IMP] ir_cron: use 'info' loglevel instead of 'debug' when starting job
This information is important for `ir.cron` troubleshooting hence
deserves a little more love.
2018-01-12 09:34:08 +01:00
Nicolas Martinelli 6d5c2d0bea [FIX] stock: unset warehouses
When 'Applicable on Warehouse' is set to `False`, the list of warehouses
should be emptied.

opw-803678
2018-01-12 08:39:07 +01:00
Nicolas Martinelli 8ab2b099fb [FIX] sale_stock: unecessary dependency 2018-01-12 08:39:07 +01:00
Aaron Bohy 90279c70eb [FIX] web: quick create in empty grouped kanban views
For kanban views with attribute 'on_create="quick_create' set on
their root node, clicking on 'Create' in the control panel should
open the quick create widget in the first column if the view is
grouped and if there is at least one column displayed.

It was working as expected, except when there were no record yet.

This was because the kanban controller used the 'state.count'
attribute of the state (which indicates the total number of records
in the group), whereas it should have used 'state.data.length'
(which is the number of columns).
2018-01-12 08:13:15 +01:00
Aaron Bohy 25b101f15b [FIX] web: Kanban: quick create several records in a row
Before this rev., when quick creating a record in a grouped kanban
view, the quick create widget wasn't automatically re-opened, which
didn't allow the user to quickly create several records in a row
(without clicking each time on the '+').

This desired behavior had been broken by rev. 1d34e26, which aimed
to properly reload the kanban column when a record was created
(e.g. column counter, progress bar...).
2018-01-12 08:13:15 +01:00
Simon Lejeune b7b38ed141 [FIX] stock: remove superfluous track visibility messages
`_run_move` creates the move, calls `_assign_picking` and then confirms it. The
result is that a draft move is added to a picking and then its state is changed to
confirmed. As the state of the picking is computed across its moves and a manual
call to `message_track` is done when any of its move changes its state, there was
a lot of tracking messages in the picking chatter, especially when you confirm a sale
order (a lot of calls to _run_move).

The thing is that this is unnecessary as stock.move’s `_action_confirm` will call
`_assign_picking` later on AND after having changed its state to “confirmed”. Now
a confirmed move is added to a confirmed picking and no message are posted. This
improves considerably the validation of a massive SO.
2018-01-11 16:33:14 +01:00
Géry Debongnie 27dd19c0b9 [FIX] web: prevent crash in some rare cases
When we have a form view with a one2many with an onchange, and with
lines which contains a x2many, and more lines that the limit (so more
than one page), and the read is not in the same order as what is
displayed because we have a widget=handle, then we might have a problem
when we delete one of the lines, if the onchanges tries to change the
x2many.

This is due to the fact that the order of the basicmodel datapoint is
not preserved by the various operations going around.  I think that we
may still have a few other issues of this type, but it is actually quite
difficult to establish.

In any case, this situation is now properly handled.

opw 804530
2018-01-11 16:30:34 +01:00
Nicolas Martinelli 8dcee7f17e [FIX] product: price digits
Complement of cf32a23b92

Closes #21686
opw-800279
2018-01-11 16:10:09 +01:00
Denis Ledoux 78d0a32470 [FIX] web: force a determinist installed modules order for the assets
The backend assets includes a list of the installed modules with:
```
odoo._modules = <t t-raw="get_modules_order()"/>;
```

Because of the randomization of Python 3.5 in the dict keys,
the order of the installed modules could change from time to
time, therefore making the assets being regenerated unnecessarily

This revision is a bit linked to the below one:
f3bb9ae679

In addition to have the dict keys always in the same
order, it's important for the values to always be
the same, and it was not the case for this list
which was in the content of the backend assets,
in various order.

opw-804747
2018-01-11 15:48:08 +01:00
Nicolas Martinelli bc1c72f9af [FIX] sale_stock: test error
`sale_stock.tour` requires `sale.tour` which is defined in
`sale_management`.

Aside from the test failing, this is more logical to add the 'Sales'
menu once the set-up is past a simple 'eCommerce' configuration. Note
that it was intended in the original commit 5dfd342d08, but was
later changed back to avoid issues.

We need to depend both on `sale` and `sale_management` explicitly, to
make sure installing `sale` and `stock` separately will also install
`sale_stock`.

opw-804621
2018-01-11 15:34:06 +01:00
Romain Derie 3ec98ae6b0 [FIX] website_sale: can't send coupon code after an ajax request
Before this commit, an user could only use the coupon form if he didn't perform
any ajax request (eg: change quantity, already sent a code..).
Since the cart html would be reinjected with theses ajax requests, the click
event would not work afterward until the page got fully reload.

Now, we changed the jquery click binding to work with dynamically injected DOM
2018-01-11 15:28:31 +01:00
Nicolas Martinelli 411a9fa326 [FIX] web: autofocus
Support autofocus on notebook pages:
```
<page autofocus="autofocus">
```

This was supported before the web client refactoring.

opw-801259
2018-01-11 15:19:52 +01:00
Christophe Simonis dde619a9ac [REL] master is back as 12.0 alpha 2018-01-11 15:18:03 +01:00
Raphael Collet 309b6b8e5a [FIX] api: optimize odoo.api.Cache.get_records()
Assuming that `field.cache_key(record)` is independent from `record.id`,
compute the cache key once for all records, and avoid using `browse` on all
record ids.  This makes `get_records` about 20 times faster.

This has a good performance impact on `field.modified_draft()`, which is used
during onchanges for invalidating fields.
2018-01-11 13:52:16 +01:00
Romain Derie 0474de44c0 [FIX] website: unpublished homepage read error + first menu fallback
Before this commit:
1. If the website's homepage is unpublished and a public user naviguate on it,
it will log an access read error in the server. The user won't see the error
though.

2. If the user can't access '/', we serve the first menu's page instead.
This first menu's page can be an unpublished page, resulting in a 403, which is
not convenient.

3. Menus are sorted by sequence, then the ORM sort them by write_date.
Menu with same sequence will be sorted differently every time you edit one of
them. (This issue get hidden/solved if user edit and save the menus with
"Edit Menu" since it will recompute every sequence.)
  - Create 3 pages 'A', 'B', 'C', with 'Add page in menu' enabled
  - Menu is now 'A B C'
  - Edit website.page B (in property dialog), it will write on the page's menu
    aswell
  - Menu is now 'A C B'

Now:
1. We prevent this error by ensuring the page is published and so can be read
by anyone before accessing its properties.

2. We serve the first menu's page that is published

3. We sort menu by id after sequence to keep original order

This closes #21259
2018-01-11 13:33:30 +01:00
Romain Derie bf8519853f [FIX] website: hide menu if related to an unpublished page
Before this commit, if there was a menu entry linked to an unpublished
website.page, the menu would be shown. For restricted users, they would land on
a 403 forbidden.

Now, we dont show website.page's menu if user can't access it.

This closes #21328
2018-01-11 13:30:12 +01:00
Nicolas Lempereur 491404f053 [FIX] website_event_track: day separation and tz
An agenda for an event separates tracks by days and display them taking
into account the event timezone.

But when separating by day the timezone is not taken into account and a
track could be displayed on the wrong day.

opw-803610
closes #22170
2018-01-11 12:51:54 +01:00
Romain Derie 32701aa512 [FIX] website: menus with null URL would throw an error on display
Before this commit, if a website.menu had a URL set to null, it would throw an
error when displaying that menu.
It is normally not possible to do so in v11 but after a migration, menus can be
empty. (eg: Using an empty menu to display a divider in a dropdown menu)

Now we return an empty url instead of an error
2018-01-11 12:49:18 +01:00
Thibault Delavallée d139e92c62 [REF] mail: move message notify and author subscription in after_post hook method
Purpose
 * move notify in message_post instead of always doing it at message
   creation

Specifications
 * message create should only create a message
 * message post should be in charge of calling the notification process
2018-01-11 11:53:58 +01:00
Thibault Delavallée cdfe479e2e [MOV] mail: reorder a bit mail thread methods by category
As this class has grown a lot some methods have been put a bit anywhere
in the file. To prepare future improvements it is easier to regroup
them a bit.

remove_accent from mail_alias is also moved to tools in order to separate
tools from business or class specific code.
2018-01-11 11:52:37 +01:00
Romain Derie cca12fbb08 [FIX] payment_stripe: route receive wrong currency parameter
This commit b335ae0348 previously sent currency instead of currency_id on
/website_payment/transaction route resulting in a cast error.

Now, we send the currency_id as the route expect

This closes #19468, closes #22165
2018-01-11 11:01:35 +01:00
qdp-odoo 330f84f211 [FIX] l10n_fr_fec: fix format of Debit/Credit columns
Numeric columns of fixed length should be left padded with '0' instead of ' ' (Article A47 A-1 Section III 2°)
2018-01-11 10:46:31 +01:00
tbe-odoo ea90491789 [FIX] mail: m2m tag email test fixed
- The test for m2m tag email was not expecting an array as the result.
2018-01-11 10:12:06 +01:00
Jeremy Kersten 8fb203f7c6 [FIX] base: ir_ui_view unescape %% in dev mode
In dev mode with xml feature, we read the xml from file directly.
%% should be unescape to get % instead.
2018-01-10 21:01:33 +01:00
Christophe Simonis 782154da11 [MERGE] forward port branch saas-11.1 up to f6ef0c7760 2018-01-10 20:35:53 +01:00
Christophe Simonis f6ef0c7760 [FIX] sale_mrp: correct test when delivery is installed 2018-01-10 18:04:38 +01:00
qsm-odoo 61bb46c82b [FIX] website, *: auto-fold menu review
* portal

Review https://github.com/odoo/odoo/commit/392c91cda3133b921e9aca9a7b1c511231027438

- Some elements should not be folded in the "+" dropdown, like the login
  button and related stuff
- Using pull-right instead of navbar-right (https://github.com/odoo/odoo/blob/392c91cda3133b921e9aca9a7b1c511231027438/addons/portal/views/portal_templates.xml#L37)
  broke the mobile version of the menu
- Folded menu <li/> seemed too small (but it was only an illusion)
- On Chrome, the menu was sometimes not folded when it should have been.
  This was because of rounded width calculations.

For the first point, the code has been made so that everything that
follows a divider is considered unfoldable.
2018-01-10 17:59:38 +01:00
qsm-odoo 4fc0079f5f [REF] web_editor, website: LESS simplification and correction
The variables.less file was producing CSS which was then multiplicated
by the number of bundles (see less_helpers).

Also simplify some LESS.
2018-01-10 17:54:22 +01:00
qsm-odoo 5da89f6152 [REF] portal, website, web, *: improve LESS split
* website_sale
2018-01-10 17:54:22 +01:00
qsm-odoo a5e9acfb69 [REF] portal, website, web: rename/regroup LESS files 2018-01-10 17:54:22 +01:00
qsm-odoo 27311c2b3d [REF] portal, website: portal LESS files cleaning
- website.ui.less was moved to portal for no reason
- rename portal_frontend.less to portal.less
2018-01-10 17:54:22 +01:00
Géry Debongnie cb72f172d0 [FIX] website_(event_)sale: fix tours in enterprise
Recently, a few tours started failing in enterprise.  The reason is that
there is some code in the e-commerce which folds the navigation bar
(with the page names), including the shopping cart counter.  Some tours
depended on the presence of that counter, and fails in enterprise, when
more modules are installed and the folding code is more likely to
actually run.

In this commit, we do not fix the core issue (not hiding the cart
counter), but we work around the issue by slightly changing the tours to
make them pass.  I believe that the website team will make that properly
work soon.
2018-01-10 16:19:42 +01:00
Goffin Simon 88fe132a27 [FIX] mail: Wrong title for the image's activity
An activity is always created with sudo, so it's useless to set the
image and the name of the "Administrator" all the time.

Now the image and the title of the assigned person is displayed.

opw:802759
2018-01-10 16:10:03 +01:00
tbe-odoo d9f1e6789a [FIX] mail: Fix crash when adding recipient on mails
When adding more than one recipients on mails a traceback appears.
This was caused because instead of doing a name_get by providing the partners ids as a list, we send them as arguments.
Which wasn't valid because name_get except a single argument.

opw #804691
2018-01-10 15:40:16 +01:00
Rémi Rahir 13baea56b9 [FIX] phone_valdation: fix default behaviour for numbers formatting
before this commit, the selection on res.company was by default hiding the country prefix. THe option was not available on res.company view.

We fix the default behaviour and add the option in the res.company view in debug mode.
2018-01-10 15:39:28 +01:00
Simon Lejeune c16c46a00d [MERGE] mrp_repair: rename module to repair
This module does not depend on mrp
Was PR #18760
2018-01-10 15:33:09 +01:00
Haresh Shyara 232f474b62 [IMP] Update .tx/config for renamed module 'mrp_repair' to 'repair' 2018-01-10 15:30:50 +01:00
Haresh Shyara 5f6b0a7bc5 [IMP] repair: renamed model names xmlid
- Also rename file references with new one.
- model renamed
	mrp.repair to repair.order
	mrp.repair.line -> repair.line
	mrp.repair.fee -> repair.fee
	mrp.repair.cancel -> repair.cancel
	mrp.repair.make_invoice -> repair.order.make_invoice
2018-01-10 15:30:50 +01:00
Haresh Shyara d20e1d30a1 [IMP] mrp_repair: rename to repair 2018-01-10 15:30:50 +01:00
Martin Trigaux 932ac72c7e [FIX] hr: correct action source model
Should be from hr.employee
At a8326cc6 source model inconsistence was introduced but the bug was revealed
only after 55549f1e where it kept the wrong one

Fixes #20203

PS: this action should be removed in master in favor of hr_org_chart module
2018-01-10 14:18:31 +01:00