Commit Graph
88927 Commits
Author SHA1 Message Date
Antoine Huvelle 0df22ebb60 [FIX] maintenance: show real time taken for a maintenance
Previously, the calendar view only shown a 1h item whatever the duration of the
maintenance, which was wrong every time the maintenance took more or less than
exactly one hour.
Adding this parameter allows showing a calendar view reflecting the real time
taken by the maintenance operation.

Closes #18072
2017-07-14 15:03:31 +02:00
Darko Nikolovski 6d1314367c [FIX] mrp_repair: group multiple repairs into one invoice
While `action_repair_invoice_create` is called on active_ids, it was working
only on one record at a time

Closes #18158
2017-07-14 14:58:31 +02:00
Christophe Simonis 9150d4c552 [MERGE] forward port branch saas-11 up to 8d1ad402a4 2017-07-14 12:13:33 +02:00
Christophe Simonis 8d1ad402a4 [MERGE] forward port branch 9.0 up to 3e8ba4905c 2017-07-14 12:10:25 +02:00
Nicolas Martinelli ba5608a5af [FIX] resource: efficiency factor
Backport of 45e7389a1e

opw-752226
2017-07-14 11:14:47 +02:00
Nicolas Martinelli 2d155a35e1 [FIX] website_crm_partner_assign: # of Cases
The measure '# of Cases' gives a traceback when selected.

opw-752165
2017-07-14 09:01:28 +02:00
Nicolas Martinelli 69fa111e95 [FIX] stock_account: negative quant cost
- Set up a product with 'Real Price' costing method, in real time
  valuation
- Receive 1000 units at $0.10 each
- Create a landed cost of $456.70, validate => it creates a quants of
  999 units at cost $0.56 and 1 unit at cost $-2.74.
- Perform an inventory adjustment, and set the quantity to 0 instead of
  1000, post inventory.

An error arises due to the constrain debit + credit >= 0.

This is caused by the method `_prepare_account_move_line` from
`stock.move`, which cannot handle negative cost for quants.

opw-752063
Fixes #17707
2017-07-13 13:20:24 +02:00
Goffin Simon 37ff69d45e [FIX] mrp: Post inventory button without finished product"
This fix 2332df6bc7  has been done in stable and some customers
wants to keep the button "Post Inventory" available all the time.
Now the button is just visible in developper mode.

opw:748347
2017-07-13 11:23:42 +02:00
Nicolas Martinelli 3e8ba4905c [FIX] crm: expected closing
The "exp. closing" dashboard button takes into account the won
opportunities. It shouldn't.

Backport of 9d2f48dc7f

opw-751165
opw-744940
2017-07-13 08:35:40 +02:00
Nicolas Martinelli b1b8392591 [FIX] sales_team, crm: expected closing
On the CRM dashboard, the shortcut 'exp. closing' is the same than the
'overdue' shortcut. However, the number of opportunities in these
categories is computed differently (see method
`retrieve_sales_dashboard`).

We introduce a new filter "Overdue Opportunities" which reflects this
difference.

Backport of 9d2f48dc7f

opw-704173
opw-751165
2017-07-13 08:34:20 +02:00
Nicolas Martinelli 68934c6b87 [FIX] mass_mailing: access error when 'Retry'
A user without 'Administration/Settings' access rights cannot use the
'Retry' button on a mass-mailing.

This is because only this level of power is allowed to unlink
`mail.mail` records. However, this button is supposed to be used by
regular mass mailing users.

opw-744616
2017-07-12 15:33:38 +02:00
Cedric Snauwaert 999dc80e7c [FIX] base_import: when parsing date field, strip extra spaces 2017-07-12 13:48:22 +02:00
Christophe Matthieu e6e17cc5d6 [FIX] product: Error message when adding an item to a quote
When a user tries to add a product on an opportunity, the date_order of the
order is added into the context. This value can be False.

When "_compute_price_rule" is called without "date" arguments
(some onchange, compute...) the method method use the context date (in this
case the value is False) or the today date.
The date value is used in an sql request and raise a value exception.

opw-751700
2017-07-12 13:39:29 +02:00
Nicolas Martinelli 058cc22d2c [FIX] website_form: send email with subject
- Use the form builder to send an email
- Customize the snippet to include the subject and the body
- Send a mail

=> The subject is not included in the email

This is because the subject is filtered out and considered as a
blacklisted field.

It happens because `mail.mail` inherits from `mail.message`. The field
property `website_form_blacklisted` is set to:
- `True` for `mail.mail`
- `False` for `mail.message`

Since we go through all inherited models, the property on `mail.mail` is
overriden by the property on `mail.message`.

It is actually not necessary to go through all inherited models, since
in the case of `inherits`, we copy the fields of the inherited model to
the target model. The check is simplified by only checking the fields of
the current model.

Based on work of @nla-odoo

opw-748926
2017-07-12 11:56:23 +02:00
Sylvain LE GAL 4001aaf2c4 [FIX] l10n_fr_certification : fix string_to_hash computation
- use datas of all lines, and not only the last lines.
- removed useless 'move_id' field from account.move.line

Was PR #18175. Courtesy of Sylvain Legal
2017-07-12 09:58:34 +02:00
Christophe Matthieu a6f2dc07e5 [FIX] sale: traceback when choosing a product with warning as order.line
If a user chooses a product that has a blocking error message, the product
is set to False. This is good, but we do not want the following to happen:

The other onchange triggers are called and "product_uom_change"
generates an error because there is no product. (In fact it is
"_compute_price_rule" on "product.pricelist" who raise)
The onchange update the values of the other fields related to the
product (eg for the "name" field where the name of the product that
is canceled by the warning is assigned).
2017-07-12 09:50:45 +02:00
Christophe Simonis 0ac49ee1e4 [MERGE] forward port branch saas-11 up to d52f0a29b4 2017-07-11 10:45:36 +02:00
Christophe Simonis d52f0a29b4 [MERGE] forward port branch 9.0 up to 479facb783 2017-07-11 10:34:07 +02:00
Goffin Simon e43b54cf3c [FIX] sale: Wrong taxes amount printed in SO
Steps to reproduce the bug:

-Create a tax group TX with two taxes: 15% and 5%
-Create a SO with one line and set TX on it
-Print the SO

Bug:

Only the first tax of TX was taking into account

opw:748923
2017-07-10 15:14:35 +02:00
Christophe Simonis 479facb783 [MERGE] forward port branch saas-6 up to e26d85e836 2017-07-10 15:07:43 +02:00
Christophe Simonis e26d85e836 [MERGE] forward port branch 8.0 up to 49407e46cb 2017-07-10 14:58:37 +02:00
Lucas Perais (lpe) 8bd56bb466 [FIX] website_sale, website_sale_options: fixing prices of product vs options in the modal
Before this commit, having an option on a product, the modal had every prices set to the one of the option
This was brought about by commit c8a434306f which was designed for the pricelists and striked prices

After this commit, we keep the intended behavior for pricelists while controlling that options would not mess up the modal
The prices that are displayed are the right ones.

OPW 744943
GH-17342

[FIX] website_sale, website_sale_options:fix the modal of options

Before this commit, the add quantity button were not working at all

This commit corrects the behavior by browsing the dom for anything that looks like a product section

Closes #17353
2017-07-10 10:44:43 +02:00
Richard Mathot 7522e29927 [FIX] event: a user may not have set its timezone 2017-07-10 08:21:16 +02:00
Joren Van Onder 2c605ab08f [FIX] point_of_sale: allow easier template extension of PosTicket
Fixes #17704
2017-07-07 17:57:28 -07:00
Joren Van Onder 49407e46cb [FIX] sale_margin: convert standard_price to SO currency before using 2017-07-07 16:01:36 -07:00
Invitu 7102fcfc4f [FIX] point_of_sale: also clone orderline price
Otherwise during e.g. bill splitting of an orderline which had it's
price overridden you end up with the original price again.

Fixes #17810
Closes #17811
2017-07-07 16:00:38 -07:00
Olivier Dony e8271ffcc7 [FIX] mail: avoid attaching auto-notifications to foreign parents
`parent_id` fields are common in many models, and thus default values
for those fields are sometimes passed in the context.

Because mail.message also has `parent_id` field, it would automatically
use the default when an automatic message was being posted. While of
course, the parent_id value comes from a different model.
This "adoption" by a random "parent message" is unexpected,
not desired, and it can even cause a very surprising AccessError if the
parent message is not readable by the user.

Forcing the `parent_id` value during the creation of an automatic message
avoids this confusion.

One way to trigger the bug was to use the "subtask" stat button to create a
child subtask for a project task (it relies on the parent task ID
passed in the context)
2017-07-07 18:34:54 +02:00
Martin Trigaux 326ff3699a [FIX] point_of_sale: use local variable in labmda
NameError: free variable 'order' referenced before assignment in enclosing scope

opw-751576
2017-07-07 15:39:47 +02:00
Martin Trigaux 3418c91f13 [FIX] product: fallback in category_all does not exists
self.enf.ref returns None if the record is not found.
Introduced at af11e74c
opw-751602
2017-07-07 14:42:31 +02:00
Christophe Simonis 96fa86779b [MERGE] forward port branch 9.0 up to 9cc799f511 2017-07-07 14:00:39 +02:00
qdp-odoo 1fda216887 [FIX] l10n_fr_certification: set auto_install to False
Due to recent decision by the French government this might not be mandatory for french companies
2017-07-06 17:01:33 +02:00
Yannick Tivisse afefa1b771 [FIX] account: Display the correct records on 'Invoice' button
Currently it shows all the invoices, not the sales invoices that are paid or validated
2017-07-06 16:47:40 +02:00
Christophe Simonis 1206cc3f7d [MERGE] forward port branch saas-11 up to 5f7f3209e0 2017-07-06 12:30:51 +02:00
Christophe Simonis 5f7f3209e0 [MERGE] forward port branch 9.0 up to 2b06da6ed0 2017-07-06 12:10:12 +02:00
Christophe Simonis 2b06da6ed0 [MERGE] forward port branch saas-6 up to 63944d30ba 2017-07-06 12:09:30 +02:00
Christophe Simonis 63944d30ba [MERGE] forward port branch 8.0 up to fe73fc442c 2017-07-06 11:44:26 +02:00
Christophe Simonis fe73fc442c [FIX] google_drive: avoid AccessError when reading filters
If a config use a private filter, others users can't read it due to
record rules on filters.
2017-07-06 11:37:19 +02:00
Nicolas Lempereur 52f268d042 [FIX] website: load momentjs locale in frontend
It is for example useful in the form builder with date-kind form field,
the translation of momentjs is done in french.

opw-707986
opw-749544
closes #17103
2017-07-06 11:28:57 +02:00
Frédéric Gilson d7334930a6 [IMP] payment_authorize: change setup link as old one is deprecated. 2017-07-06 10:44:49 +02:00
Sylvain GARANCHER b587ae48e4 [FIX] mrp: set default quantity
The wizard to change the produced quantity of a manufacturing order was not
using the current produced quantity as the default value.
This was because the field mo_id was not present in the view (and not in
`fields` in default_get).

Adding the field as invisible to compute the default value for mo_id.

Correct typo in dictory lookup (using `[` instead of `(`)

Closes #17937
opw-749725
2017-07-06 10:41:26 +02:00
Goffin Simon 6d6c24cfb2 [FIX] stock: Not allowed to change product on stock.production.lot
Steps to reproduce the bug:
-Create a product tracked by LN
-Create an inventory adjustment to add 10 products with LN A
-Validate it
-Then go in inventory > inventory control > lots/serial numbers > open LN A
-Change the product

Bug:
The LN A tells you you have 10 products X
While in your inventory you see you have 10 products Y

opw:750735
2017-07-05 16:54:12 +02:00
Goffin Simon 4f88f4dd18 [FIX] website_sale: Sort by catalog price in the shop
When sorting by price (increasing or decreasing) in the shop,
the products were sorted according to the catalog price(list_price)
and not according to the price(which takes the pricelist into account).
So a better name is given in this patch.

Reason: The field "price" is a computed and not stored field.
Then it's not possible to order the products with it in the orm.

opw:750997
2017-07-05 15:53:00 +02:00
Nicolas Lempereur 4fe4c228f3 [FIX] web_editor: style if website not installed
web_editor can be installed without website, thus missing needed CSS
causing e.g the widget sidebar to overlay and hide the mass mailing
content if website is not installed.

This fix implement a simple middle ugly solutions, but doing something
more in stable would be an hassle (for example in 88c2b684 the #wrapwrap
CSS is included in report module).

opw-748975
closes #18005
2017-07-05 11:49:59 +02:00
Yannick Tivisse 317ed37aee [FIX] account: Avoid to rewrite all the account codes on res_config creation
opw-750892

Avoid to rewrite the `accounts_code_digits` on the company if the value is the same. As all the values are
passed on the res.config creation, the related fields are rewriten on each res_config creation. Rewriting
the `account_code_digits` on the company will trigger a write on all the account.account to complete the
code the missing characters to complete the desired number of digit, leading to a sql_constraint.
2017-07-05 11:37:30 +02:00
Martin Trigaux d8083b4270 [FIX] website_sale: use the same price for all routes
The route /shop and /shop/product did not used the same context.
The partner is set in the shop but not in the product page which may lead to a
different pricelist to be applied.

opw-746729
2017-07-04 14:39:25 +02:00
Christophe Simonis 657e328903 [MERGE] forward port branch saas-11 up to 7b0a1e4031 2017-07-04 12:28:38 +02:00
Christophe Simonis 7b0a1e4031 [MERGE] forward port branch 9.0 up to b9131adb48 2017-07-04 11:51:23 +02:00
Cédric Snauwaert b1082348e7 [FIX] account: reconciliation, fix query that fetch perfect line match (#17969)
When opening the reconciliation widget, there are two queries that are done,
The first one is to find a move line that perfectly match the statement line
and is done in SQL for performance issue.
The second one is a search with a domain to find all the lines that could be used
in that reconciliation.

1) There was a mismatch between the two. The domain fetches lines that have a payment_id
while the SQL query does not. Which is inconsistent

2) In some case, we did not find a perfect match on the amount using the SQL query because
of a rounding error. Example is for amount 3,3. In python: 3,3 is represented like this
3,3000000000003 and doing a float_round of that value still returns 3,3000000000003
Since we want to match on an exact amount, using float_repr is needed to fix that error
2017-07-03 11:22:32 +02:00
Jeremy Kersten 15da3356a0 [FIX] web: /web/image fix resize if only one limit (height or width)
The old code don't resize correctly if you use params in request.
because if '200' > 500 => return True

Now we force the casting to int to be sure to compare apple to apple.

before: /web/image/<id>?height=100 => don't return an image with height=100px
after: /web/image/<id>?height=100 => return now an image with height=100px
2017-07-03 10:56:31 +02:00
Jeremy Kersten 4322d96a0c [FIX] website_portal_sale: be sure that form post a vat before to compare
Typo in previous condition. 'vat' in partner is always True.
2017-07-03 10:03:26 +02:00