Commit Graph
127612 Commits
Author SHA1 Message Date
Yannick Tivisse 0984b2aadb [FIX] l10n_be_hr_payroll: Compute correcty employer cost for warrants 2018-05-16 15:13:46 +02:00
Alexandre Kühn 93f9131450 [REVERT] "[IMP] mail : display mentions in green color in edit mode"
This reverts commit c778de44c7.
2018-05-16 15:06:39 +02:00
Alexandre Kühn c52243794d [REVERT] "[FIX] mail: fix composer style for chat windows"
This reverts commit 0275c70f78.
2018-05-16 15:05:35 +02:00
Toufik Benjaa 1c6aa878cb [FIX] project: Access rights issue on /my/tasks
- Portal users do not have the rights to read on project.project.
  This causes issues on the page "/my/tasks" as it is trying to read the label_tasks and the name of the tasks' project.

  To address this issue we read those two fields using sudo
2018-05-16 14:51:42 +02:00
Nicolas Martinelli 491243d1ca [FIX] stock_account: partial reception with avg cost
- Create a product where the associated product category has Costing
  Method "Average Cost (AVCO)"
- Create a PO. Order 1 unit at $1000.
- Receive that unit. (System now has 1 unit at $1000).
- Create another PO. Order 3 units at $500 each.
- Receive only 1 unit and don’t create any back order.

System has 2 units @ $625, instead of $750.

The quantity computed should take into account the quantity actually
done.

opw-1843998
2018-05-16 14:21:15 +02:00
Xavier ALT c22d3f6732 [FIX] web: widget char_domain should pass context to selection dialog
In case we define a field like,

<field name="my_domain" widget="char_domain" context="{'active_test': False}"/>

when selecting records the dialog should display all records (as asked by the
context), but it's not the case.

This commit ensure the field context is passed to the selection dialog.

opw-1831902
2018-05-16 14:18:17 +02:00
Raphael Collet 6a601fe6dc [IMP] test-pylint: check for undefined variables 2018-05-16 13:58:39 +02:00
Olivier Dony cdabb9d74c [FIX] auth_signup: remove password from welcome message
Revision 054c68689b added by mistake the
password of the new user in the welcome message that is sent to users
who signed up with an invitation token.

There is no need for this, the user has just chosen their password, and
we should not send them a copy which could be compromised on the way to
their inbox or later in their inbox.
It may also give users the impression that their passwords is stored in
cleartext in the database, even when that is not the case.

This patch minimalizes changes to the template and its translations.
For existing databases where the code is updated without re-syncing the
template, the password will simply be missing in the message (until a
resync of auth_signup module is done)
2018-05-16 12:17:14 +02:00
Jeremy Kersten b8f5f17aed [FIX] event: don't block scheduler at first exception
Before this commit, when a scheduler fail for one event (eg: error in send_mail),
the cron stop and don't continue to process all others event's scheduler.

Now we try to warn (~ randomly once by hour) the responsible/organizer/write_uid
that an error occurs with this scheduler, and we continue to process the others.

opw-1840497
closes #24741
2018-05-16 11:58:11 +02:00
Nicolas Martinelli 6fce298d70 [FIX] account: tax computation at reconciliation
- Create a tax included of 7.7%
- Set the company rounding to 'Round Globally'
- Create a bank statement of 10.70, reconcile
- Add a manual line with the 7.7% tax

An extra line of 0.01 remains.

The remaining amount after subtracting the tax is `0.00499...`, which
is rounded to `0.005` by `Math.round(total*1000)/1000`, and finally
displayed as `0.01`.

The 'Round Globally' setting makes sense for objects containing multiple
lines, such as SO, PO or invoice. In the case of a reconciliation, we
can switch to the 'Round per line' config.

opw-1837986
2018-05-16 11:10:58 +02:00
Christophe Simonis 9db6dfa25d [FIX] event_sale: update registrations as sudo.
Consequence of 19878d011f

Backport of fb17edd0b0
2018-05-16 11:05:16 +02:00
Olivier Colson 75e965f4b0 [FIX] purchase: valuation tests: use reconcilable accounts for in and out accounts in anglosaxon accounting 2018-05-16 10:27:08 +02:00
len-odoo 47cc4fbbab [FIX] auth_signup: add missing dependency on the computation of the signup validity
The field signup_valid is a non stored computed field based on signup_token.
The cache is filled with prefetched values, so in a loop the field is read from
the cache and not recomputed due to the missing dependency.

opw 1843442
2018-05-16 09:01:14 +02:00
len-odoo 25548eb7e9 [FIX] web: sort relational fields by their names
When sorting records according to a many2one field in a list view
embedded in a form view, the js would sort according to their ids,
in a seemingly arbitrary order.
Thus sorting records according to a field with values in ("a", "b", "c")
could be sorted as "a", "a", "c", "b" instead of "a", "a", "b", "c".
We make the comparison on the name of the field instead.

opw 1838860
2018-05-16 08:04:53 +02:00
Christophe Simonis fa8a67ee5f [MERGE] forward port branch 11.0 up to 5a943390f2 2018-05-15 20:18:14 +02:00
Christophe Simonis 5a943390f2 [MERGE] forward port branch saas-15 up to fb17edd0b0 2018-05-15 20:03:18 +02:00
Christophe Simonis fb17edd0b0 [FIX] event_sale: update registrations as sudo.
Consequence of 19878d011f
2018-05-15 19:19:51 +02:00
Christophe Simonis df3b75a127 [MERGE] forward port branch saas-15 up to f1ae96e389 2018-05-15 18:58:20 +02:00
Christophe Simonis f1ae96e389 [MERGE] forward port branch saas-14 up to a50e7aa366 2018-05-15 18:36:16 +02:00
Toufik Benjaa 05ef2f24e0 [FIX] mail: Missing parenthesis to call "remove" on chatter spinner
- The code to remove the loading spinner from the chatter was missing parenthesis to actually do the function call.
2018-05-15 17:53:22 +02:00
Christophe Simonis a50e7aa366 [MERGE] forward port branch 10.0 up to 13fc77daf4 2018-05-15 17:44:34 +02:00
Jeremy Kersten 04ce6e84c2 [IMP] website_event: show physical event before online if country specific.
If a country is specified, we show also all our online events to promote it since
they can be followed from anywhere. But we show in priority the physical event.

opw-1845012
2018-05-15 17:24:50 +02:00
Olivier Colson 0f39ee9370 [FIX] purchase: anglosaxon: use currency rates to determine whether or not to post price difference amount
Before that, we compared the amounts naïvely, leading to possible errors in case the PO and invoices were made in different currencies.
2018-05-15 17:22:56 +02:00
Denis Ledoux e5fb990db1 [FIX] project: prevent to create recursive hierarchy of tasks
Until this revision,
this was possible to set as parent task the current task.

From then, it was impossible to compute the field
`subtask_count` because of an infinite loop.

This resulted to the inability to open the task
form, which contains this field.

opw-1847982
2018-05-15 17:10:30 +02:00
Goffin Simon 35c2a74480 [FIX] delivery: Delivery method name not translated
When adding a SO line with a delivery method (e.g. The Post) for a customer
with a different language that the one set on the current language, the description
of the SO line was not translated. Inspired from function 'product_id_change' in
model 'sale.order.line'

opw:1843934
2018-05-15 17:07:44 +02:00
Christophe Simonis 13fc77daf4 [MERGE] forward port branch 9.0 up to 19878d011f 2018-05-15 16:51:34 +02:00
Toufik Benjaa 84f0b4d934 [FIX] mail: Avoid crashing when removing link from chatter
- The code to remove mentionned users on the chatter isn't robust enough.
  It crashes when trying to remove a link added from a copy/paste as if it was a mention.
  Mentions have an id defined on their "a" html node, linked copied and pasted don't.
  Which crashes the javascript code because it is trying to use the id.

  This fix, make sure to delete the node without using its id (we already have the node) and make sure to remove it only if it starts with a '@' (meaning it is a mention).
2018-05-15 16:48:54 +02:00
qdp-odoo 6558d52e9b [FIX] account: adjustment wizard usability
This commits removes a disambiguation on the choices of the 'Adjustment Type' selection as 'in your favor' could be achieved by debitting the 'Collected Tax' account or creditting the 'Paid Tax' accounts (respectively for 'in favor of the Estate'). The choices now refers directly to the journal item where the tax is gonna be copied

Related to https://github.com/odoo/odoo/commit/c58ef14a01f600d75391f2a9c38bb2b30e0e2528
Related to OPW 1826242
2018-05-15 16:47:38 +02:00
Tejas Shahu 15a99338fb [FIX] note: correctly display chatter in note form view
Before this commit there was an unexpected behavior of chatter in Note module
on Zoomin/Zoomout. Putting the html field memo in the sheet solves it and
chatter now properly behaves.

Related to task ID 1837177. Closes #24295.
2018-05-15 15:49:54 +02:00
Thibault Delavallée 96a223a5f0 [IMP] mail: prevent creation of activities to users that have no access to document
This commit is related to task ID 58968 . Closes #24176.
2018-05-15 15:42:54 +02:00
Vincent Schippefilt 9148960174 [IMP] account_budget: complete review of the module
* budgetary position nor analytic account aren't required anymore (although one of the 2 have to be given)
* by extension, the computation of practical amount is not either based on the analytic lines or the account.move.line
* usability improved (for eaxmple: there's a button to open the list of items on which the practical amount computation is done)
* addition of a pivot and graph views of the budget lines

Was PR: #22342
Was task: 31995
2018-05-15 15:19:28 +02:00
qdp-odoo f53d9c369d [IMP] analytic: slightly improves demo data
by adding an analytic group to analytic accounts
2018-05-15 15:06:39 +02:00
qdp-odoo d5cf6be26e [IMP] account: make currency_exchange_journal_id field visible in settings 2018-05-15 15:04:17 +02:00
Thibault Delavallée 7e90349cb9 [IMP] various: clean references to removed content_subtype post parameter
content_subtype was a parameter to message_post allowing to give plaintext
content instead of html content. It has been removed at 74d4b3902d. This
commit cleans some leftover bits referencing this now removed parameter.
2018-05-15 15:04:13 +02:00
Vincent Schippefilt 09125f78c3 [IMP] web: allow usage of computed unstored fields in pivot views 2018-05-15 14:55:00 +02:00
Vincent Schippefilt 32c6d129ca [IMP] web: add the Percentage widget in the registry as a basic field 2018-05-15 14:13:38 +02:00
Christophe Simonis 96e5455079 [FIX] hr_attendance: compute attendance state as sudo()
Since `last_attendance_id` is stored, `sudo` is needed as employees
doesn't have access to their collegues attendances.
2018-05-15 13:51:02 +02:00
Raphael ColletandThibault Delavallee 4412cb0bf4 [IMP] tests: do not warn about margins and improve logging
* margin have been recently added on some query count tests as currently query
   count is not completely deterministic. Setting a warning is not really
   interesting as it is the current behavior. Being in margin is now green
   and solely provide a different logging message;
 * logged messages are improved to ease grep;

This also reverts aae54ecc15 .

Co-authored-by: Thibault Delavallee <tde@odoo.com>
Co-authored-by: Raphael Collet <rco@odoo.com>
2018-05-15 13:29:30 +02:00
RomainLibert 6de803645e [FIX] hr_holidays: remove duplicate onchange
There were two onchange methods on employee_id in hr.holiday.
2018-05-15 12:27:19 +02:00
Lucas Perais (lpe) eb6714f59b [FIX] website_slides: slide in fullscreen needs to have the navbar
Display a slide, enter fullscreen mode
Make the navigation bar appear.

Now, try to push on any button of the nav bar

Before this commit, none of the button work
This is because the fullscreen mode is handled by the browser, and won't let any non-fullscreen
elements be interactive

After this commit, the nav bar is part of the element that are in fullscreen
And the button work

OPW 1839503
closes #24522
2018-05-15 09:46:55 +02:00
RomainLibert 19878d011f [FIX] event: fix bug with users
We need to fix a problem with the users where someone might get
informations on registrations.
2018-05-15 09:41:25 +02:00
Goffin Simon e806151882 [FIX] point_of_sale: product not available in POS if not salable
When the box "Can be sold" on product.template is unticked, the
product must be unavailable in the point of sale.

Closes #22061
opw:1844188
2018-05-15 09:33:31 +02:00
Raphael Collet 7925abe3ce [FIX] hr_holiday: default date must be callable 2018-05-15 09:29:56 +02:00
Nicolas Lempereur c39d40f98d [FIX] hr_recruitment: job stages choosen manually
In 9.0, stages of a job position in recruitment are not share by
default, there is a "New" stage and existing stages can be added in the
form view (since 780f46ae).

When creating a job position, the "New" is not working with the given
widget type.

This commit doesn't show stages in the form view until the record is
created.

opw-1839217
closes #24706
2018-05-15 09:20:59 +02:00
Goffin Simon 871387ca9e [FIX] web: Impossible to add an attachment on Safari
Fine tuning of cd6150fe9e

opw:1840373
2018-05-15 09:20:02 +02:00
Nicolas Martinelli d9fc5bca7e [FIX] purchase: move with zero qty
- Create a product FIFO / Real-Time valuation
- Create a PO with 1 unit, validate, receive the picking
- Create the corresponding vendor bill, but do not validate
- Unlock the picking and change the received quantity to 0.0
- Validate the invoice

A traceback because of a zero division occurs.

When searching for the stock moves linked to the PO, we should filter
out the ones with a zero quantity.

opw-1843543
2018-05-15 08:51:40 +02:00
Nicolas Martinelli 1dbeda0157 [FIX] project: sub-tasks
- Activate sub-tasks in projects
- Enter a project's tasks, click on the stat button 'Sub-tasks'
- Reload the page (F5)

A traceback occurs since `project_id` is undefined.

The fields `project_id` and `partner_id` are only defined in the context
of the stat button.

opw-1844334
2018-05-15 08:47:20 +02:00
Nicolas Martinelli 429bcd9464 [FIX] payment_sips: special characters
The field `transactionReference` of Sips must contain only
alphanumerical characters. Previous commit 31dc6b888e solved
the special case of several attempts to pay, but a much simpler case may
appear in v11. Paying an invoice is likely to fail since the reference
contains by default `/`.

In the previous commit, we could simply modify the common `payment`
module code. In this specific case, however, we only change the
reference if the acquirer is Sips.

opw-1841483
2018-05-15 08:33:06 +02:00
Christophe Simonis 7767d2cba3 [MERGE] forward port branch 11.0 up to 45b4a4a4dd 2018-05-14 20:26:51 +02:00
Christophe Simonis 45b4a4a4dd [MERGE] forward port branch saas-15 up to 62d93dad02 2018-05-14 20:25:16 +02:00