Commit Graph
127612 Commits
Author SHA1 Message Date
Nicolas Lempereur c4ddf55880 [FIX] web_editor: link don't duplicate child text
If we applied a link eg. on:

```
<span>hello <b>world</b></span>
```

The system actually gets the "label": hello worldworld because there is
3 nodes:

 text node: hello
 element node: `<b>world</b>`
 text node: world

Also since "hello worldworld" is different than "hello world",
instead of just keeping existing nodes and adding the link, the system
would replace the selected range by:

 `<span><a>hello worldworld</a></span>'

instead of:

 `<span><a>hello </a><b><a>world</a></b></span>`

This commit ignores element nodes when creating a new link, since when
getting the label of the link from the selection, only the text nodes
insides the element nodes have any interest.

There was a second issue because if we had:

```
<i><a href="hello">world</a></i>!
```

and tried to put a link over "world!", the code would decide: "world" is
inside a link so we will just update that link.

Thus we would get:

```
<i><a href="hello">world!</a></i>!
```

instead of:

```
<i><a href="hello">world</a></i><a href="hello">!</a>
```

opw-1848351
closes #25187
2018-06-13 16:20:40 +02:00
Aaron Bohy f03f2f7c8a [FIX] account: print move lines with no label
Field 'name' (Label) on account_move_line isn't required. When
following the usual flows, it is automatically set by the system.
However, one can manually create move lines without specifying it.

When this occurs, the Sale/Purchase Journal can't be printed
anymore because it causes a crash.

OPW~1857663
2018-06-13 15:51:35 +02:00
Dinar b3aeb3b2e7 [IMP] pos_discount: possibility to redefine the discount button
Was not able to make inheritance of  POS Discount objects via "extend" or
"include" functions

Closes #25227
2018-06-13 15:47:09 +02:00
Dinar 08b297289d [IMP] pos_restaurant: possibility to redefine new buttons and screens
Was not able to make inheritance "action_button" and "screens" POS Restaurant
objects via "extend" or "include" functions.

Closes #25150
2018-06-13 15:44:27 +02:00
Miku Laitinen fd2b130428 [FIX] sale: Add missing import to 'account_config_settings_views.xml' in manifest
Coming from the migration of sale https://github.com/odoo/odoo/commit/f3d715ca94f24f86ce39a4bc6873fe7576ef1860#diff-7ca766af4bd53a0bc808dd3a4ead8317
2018-06-13 15:36:48 +02:00
Antonio Espinosa a8dd1de5c4 [IMP] doc: add i18n section to command line reference
Closes #14042
2018-06-13 15:13:52 +02:00
Josse Colpaert 232d5ca64b [FIX] stock: onchange like pr 25223 2018-06-13 15:07:34 +02:00
Xavier Brochard b10e34ed1a [FIX] web_editor: add <em> as inline tag and remove duplicate strong
This commit closes #24818
2018-06-13 14:56:16 +02:00
Jairo Llopis 71334b13bd [IMP] web: Expose datepicker configuration to view declarations
The lower-level widget itself supports passing options to the underlying
datepicker library. However this is not exposed to higher-level view
declaration. With this patch, one can declare a field in a view such as:

```xml
<field name="datefield" options='{"daysOfWeekDisabled": [0, 6]}'/>
```

That option would land in the widget and disable those weekdays.

Documentation has been updated accordingly.

Closes #25044.
2018-06-13 14:53:11 +02:00
David Arnold 9447bedf85 [IMP] pos: add vat number to search options of customer in pos
Closes #23248.

Signed-off-by: "David Arnold" <"dar@xoe.solutions">
2018-06-13 14:48:13 +02:00
Prakash Prajapati 8bc74a09ba [REF] stock: picking report: show lot name below the barcode
PR:24832
Task:1849829
2018-06-13 14:47:09 +02:00
Christophe Simonis bdd051bf78 [MERGE] forward port branch saas-14 up to c43c540172 2018-06-13 14:12:12 +02:00
Akim Juillerat 25d63b97a0 [IMP] maintenance: restrict deletion of equipment if requests exists
Loosing data about existing requests is not good idea when managing
maintenance. It is better to ensure there are no ongoing requests
and prevent deletion if it is the case.

Closes #18794 .
2018-06-13 12:54:48 +02:00
Thomas Binsfeld 4d3debe2c3 [FIX] purchase: do not show all pickings from PO if there are no picking
Closes #19961.
2018-06-13 12:05:17 +02:00
Aaron Bohy c7b1faa458 [FIX] web_calendar: color of sidebar filter
Before this rev., if you went to Sales > Sales order, switched to
calendar view, edited the arch such that 'color="state"' is
replaced by 'color="invoice_status"' on the root node, it crashed.

The reason of the crash is that a possible value of the
'invoice_status' selection field is 'to invoice' (it contains a
whitespace), and the JQuery selector didn't wrap the value by
quotes.

OPW~1856305
2018-06-13 11:32:36 +02:00
Jeremy Kersten 4fe0981c33 [FIX] web_editor: remove website dependence introduced by 4f9d9d169f
Now we use the get_view_id method that already do the job to filter the views
based on the current website.

Related to #24429
2018-06-13 11:14:02 +02:00
jlzhou 68cde40515 [FIX] mail: fix translation issue in client notification
Closes #19095.
2018-06-13 11:03:46 +02:00
Christophe Simonis c43c540172 [MERGE] forward port branch 10.0 up to 788750ea51 2018-06-13 10:55:58 +02:00
Christophe Simonis 788750ea51 [MERGE] forward port branch 9.0 up to 444f0b6a7f 2018-06-13 10:50:43 +02:00
jem-odoo a3d81597d7 [FIX] sale_timesheet: cosmetic changes in table plan
This commit
- make the 'sold' and 'remaining' total invisible
for employee lines
- displays zero hours line in light grey
2018-06-13 10:34:25 +02:00
jem-odoo bcd34e83b7 [FIX] sale_timesheet: fix view mode
Actions returned by the plan project are directly
executed by the webclient. But their are not post
processed like other actions by /web/action, so the
'fix_view_mode' method is not call, and this causes
a mismatch between 'list' and 'tree' mode and type
on action.
This 'hack' is a bad legacy of the past ...
2018-06-13 10:34:14 +02:00
jeffery chen fan f0e8965d2a [IMP] l10n_cn: Rewrite description for l10n_cn
rewrite description for l10n_cn to avoid confusion, as this module is the base for the another two modules which is the actully addons for chart of account
2018-06-13 10:24:14 +02:00
Toufik Benjaa 444f0b6a7f [IMP] payment_ogone: Avoid requesting already owned data from Ogone
- When receiving a S2S payment feedback from Ogone server, we call the method '_ogone_form_get_tx_from_data' which does a "pre-process" of the data to retrieve the payment.transaction linked to this payment.
  It also checks the hash signature of the data to be sure it comes from Ogone.
  Right after, we call "_ogone_s2s_validate" which make a HTTP call to ogone, to retrieve the data related to the transaction which were already sent by Ogone (maybe to be sure the data comes from Ogone?).

  So instead of calling "_ogone_s2s_validate" we now call "_ogone_s2s_validate_tree" which processes the data from Ogone.
  We are sure they come from Ogone, since they passed the hash signature when calling "_ogone_form_get_tx_from_data".
2018-06-12 18:27:24 +02:00
Andreas Perhab bb8ded772a [FIX] db: close connection of incompatible DB only
Close connections of incompatible databases instead of closing all
connections.

Introduced in 610036756a

Closes #24479
opw-1852793
2018-06-12 18:26:35 +02:00
Toufik Benjaa c8243e71c6 [FIX] http: Consume less cursors for session checks
- Each time we check if a session is valid we create a new cursor.
  This could lead to issues with db_maxconn that limits the number of
connections to the postgresql server.
  In a perfect world, a worker should use a single connection to
postgres to process the request.
  The only known side effect is that the cursor is created earlier in
the execution of the code.

- This commit fixes issues with the longpolling raising
Psycopg2.PoolError exceptions on databases with a lot of clients.
2018-06-12 18:10:37 +02:00
Toufik Benjaa 8354b34a4a [FIX] project: Keep your search filter on the tasks' portal
- Searches made on tickets using the portal aren't kept when changing page.
This commit makes sure the search is kept.

OPW-1857033
2018-06-12 18:05:36 +02:00
Miquel Raïch df05c81396 [IMP] account: set create=False on account.move.line form
The tree form has it already
To be consistent

Closes #22854
2018-06-12 18:03:23 +02:00
Jairo Llopis 8357e7395e [FIX] link_tracker: do not give a date to a datetime
Creation date is a datetime field. However code is giving a date value.
as create date is a magic field with a default value there is actually
no need to override it.

Closes #22447.
2018-06-12 17:48:56 +02:00
Jairo Llopis 228df6a29f [FIX] link_tracker: do not die if statistic was unlinked when the user clicks on a tracked link
[There's a chance mail statistics disappear](https://github.com/odoo/odoo/blob/b3b8a471cc3e02488dcc0da991fd1d828978220d/addons/mass_mailing/models/mass_mailing.py#L519), which is probably not a very good decision, but there it is. Then, `add_click()` produces a 500 error when a user clicks on the mass mailing if the email comes from an old attempt.

Fix is to check the statistic record effectively exists before linking it.

Closes #22447.
2018-06-12 17:48:56 +02:00
Subodh Dahal c2f20f12b9 [FIX] doc: recommand to xpath on snippet_structure
Fixed the xpath expression for inserting snippet into Structure tab

Closes #22971
2018-06-12 17:45:36 +02:00
Subodh Dahal 3fc6624631 [CLA] SubodhDahal signs Odoo's CLA
Done at #22971
2018-06-12 17:45:36 +02:00
Yannick Tivisse ce1f1b69e7 [IMP] purchase: Extract code from _compute_amount to allow inheritance
Purpose
=======

Currently the discount mechanism is not implemented in the purchase module.
This limitation is could be avoided if the _compute_amount arguments could
be overwritten.

While waiting the feature to be implemented in master, we simply introduce
a hook method to allow an easy inheritance of the argument values.

Closes #11235

PS: Also move compute methods under the fields definition to follow
    the coding guidelines
2018-06-12 17:26:30 +02:00
Pierre Masereel 4f04af5bab [TEST] stock: add tests to pick a pack 2018-06-12 17:22:00 +02:00
Pierre Masereel 76bb1c60df [FIX] stock: pick a pack
The package level was not set on move lines when a pack was pick. this
was caused by the _check_entire_package method on picking that anly
werked when there was no package_level (pick-pack-ship) and didn't
handle when the pack is picked.
2018-06-12 17:22:00 +02:00
Christophe Simonis 4479aac52f [FIX] product: correctly set partner_ref
Oversight of previous forward-port
2018-06-12 16:53:44 +02:00
Christophe Simonis af1853775f [MERGE] forward port branch 11.0 up to e3658d6f56 2018-06-12 16:49:11 +02:00
Christophe Simonis e3658d6f56 [MERGE] forward port branch saas-15 up to d44cd77884 2018-06-12 16:31:54 +02:00
Ankit Joshi b730a6190f [FIX] stock: location on picking form view
In picking receipts show the destinaion(https://goo.gl/TPNgqZ),
and picking delivery show the source location(https://goo.gl/HnBfNw)

task-1853350
2018-06-12 16:26:31 +02:00
Yannick Tivisse 92052386f7 [FIX] mass_mailing_event_track: Correctly set recipients on mail wizard
Since https://github.com/odoo/odoo/commit/f93c4f4262e0a7102e34c6ed8f2b8f51eef45062 the
feature is not setting the recipients correctly when trying to send a mass mailing
to all the event tracks speakers.
2018-06-12 16:16:57 +02:00
Stephane Le Cornec 05f8bbd635 [FIX] product: use given argument in name_search override
Do not force to use the comptued one. Make an AND between both.

Closes #22396
2018-06-12 16:09:08 +02:00
Nicolas Martinelli 9a3fc2a06f [FIX] base: P3.5 - P3.6 compatibility
In P3.6, the error message has changed.
2018-06-12 15:48:43 +02:00
Jeremy Kersten 51acdeba4f [ADD] qweb: add tests for widget=date with datetime
This commit is related to #24761
2018-06-12 15:48:21 +02:00
Carlos Dauden ac68eb5b3d [FIX] base: ir_qweb fix timezone for datetime with widget=date
Before this commit, display a datetime field with the widget="date" was ignoring
the timezone.

This commit closes #24761
2018-06-12 15:48:21 +02:00
Jairo Llopis ce6b6e6458 [FIX] event: do not suggest public user email in registration chatter
Chatter suggests to include recipients on several objects, notably on
registrations. When a registration is done through a public interface
like website in website_event associated partner is the public user.
In that case proposing to mail the public user does not make sense.
It should propose the real email stored on the registration record.
To fix that we filter the partner if it is linked to the pubic groups.

The fix includes a sudo + context switch in a loop. As this method is
called only on a recordset of one element this has no impact on real use
case. Purpose is to keep the diff minimal.

Closes #23187 .
2018-06-12 15:42:40 +02:00
Adrien Dieudonne 25955f6d94 [FIX] web: prevent web client from blocking some view
Before this commit some rpc was blocked and we didn't see
lost connection notifications.

Steps to reproduce:
1) Go to any form view
2) Force disconnected from the network
-> The "Connection lost" notification appears
3) Get connection back
-> The "Connection restored" notification appears
3) Close the connection again
-> No notification appears and the user aren't notify
that the internet connection is lost.

Related commit: @47cf31b53

Note: It's now important to notify the user about connection loss
because a recent improvement in mobile app replaces the 'retry screen'
and let the webclient handle connection issues by itself.
The single odoo mobile app is supposed to work with all databases
from 10.0.
2018-06-12 15:41:24 +02:00
Yannick Vaucher da8d4b5b99 [IMP] account_bank_statement_import: Update module description
When using Community Edition you don't have access to any of the formats you
will thus rely on odoo community to create types of import based on this
generic module.
2018-06-12 15:01:48 +02:00
Andrea Stirpe 375bff6619 [FIX] l10n_nl: use tax tag 5b
There was a difference in the tax codes Import Buiten EU (2), some had the tag
'5B Voorbelasting' and other had the tag 'Voorbelasting BTW Bis'.

Link all the codes to '5B Voorbelasting' instead.
This is more consistent with the rest.

Closes #23119
2018-06-12 14:50:17 +02:00
Nicolas LempereurandRaphael Collet e60a8762fb [FIX] base: depends if no depends is ()
With saas-11.2's 3fbd86b some trigger towards other fields are improved
but this caused an issue when a inherited field towards a custom
computed field had no depends.

When we created a computed field x_custo on res.partner, we have a
inherited x_custo on res.users automatically created.

Both these fields have a depends computed to `('',)`, this caused an
error for the one on res.partner: but this was ignored with dd048ae7.

Since saas-11.2's 3fbd86b this also caused an error on the inherited
field but since an inherited field is not "manual" the error was not
ignored. Thus it was not possible to create custom field on a model
inheriting of another model if the fields had no depends.

opw-1854786
closes #25146

Co-authored-by: Raphael Collet <rco@odoo.com>
2018-06-12 13:12:39 +02:00
Christophe Simonis d44cd77884 [MERGE] forward port branch saas-14 up to 284ed9216c 2018-06-12 12:19:14 +02:00
mpanarin 4178684fa3 [IMP] mrp: make mrp_bom_structure_report more extensible
by moving child values to a separate method. This way, other modules can
properly add or remove fields to the report without overriding it
completely and breaking the inheritance
2018-06-12 11:56:50 +02:00